[PATCH v2 1/1] fix apt-retry spec used by apt running in rootfs

[PATCH v2 1/1] fix apt-retry spec used by apt running in rootfs

[Felix Moessbauer]

This patch fixes a bug introduced in d349b7 when moving
the apt options from the apt cli to a config file:
The configuration to let apt retry failed downloads belongs to the
'Acquire' group but not to the 'APT' group of apt.conf.
Previously this had been placed in the invalid group and hence did
not have any effect.

According to the manpage of apt.conf, the new location is at least
valid from debian stretch on and from ubuntu bionic on. By that,
all distros supported by ISAR are covered. The same configuration
entry can also be seen in the debrebuild script in /usr/bin.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index bbb5ac0a..d19ac037 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -107,7 +107,7 @@ rootfs_configure_apt() {
 
     mkdir -p '${ROOTFSDIR}/etc/apt/apt.conf.d'
     {
-        echo 'APT::Acquire::Retries "3";'
+        echo 'Acquire::Retries "3";'
         echo 'APT::Install-Recommends "0";'
         echo 'APT::Install-Suggests "0";'
     } > '${ROOTFSDIR}/etc/apt/apt.conf.d/50isar'
-- 
2.30.2

Re: [PATCH v2 1/1] fix apt-retry spec used by apt running in rootfs

[Anton Mikanovich]

19.11.2022 16:09, Felix Moessbauer wrote:
> This patch fixes a bug introduced in d349b7 when moving
> the apt options from the apt cli to a config file:
> The configuration to let apt retry failed downloads belongs to the
> 'Acquire' group but not to the 'APT' group of apt.conf.
> Previously this had been placed in the invalid group and hence did
> not have any effect.
>
> According to the manpage of apt.conf, the new location is at least
> valid from debian stretch on and from ubuntu bionic on. By that,
> all distros supported by ISAR are covered. The same configuration
> entry can also be seen in the debrebuild script in /usr/bin.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>

Applied to next, thanks.