From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7175185077837496320 X-Received: by 2002:a17:906:160a:b0:7c0:688a:6251 with SMTP id m10-20020a170906160a00b007c0688a6251mr40180000ejd.274.1670603427219; Fri, 09 Dec 2022 08:30:27 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:190a:b0:45c:bfd9:fb45 with SMTP id e10-20020a056402190a00b0045cbfd9fb45ls1355925edz.3.-pod-prod-gmail; Fri, 09 Dec 2022 08:30:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf5FQTR+bdXuH8VgrSf87uc5YHPecXxjP0zbv+XzANWSuHC7Q5h27ja65XH7mE+mZOBP2Qnw X-Received: by 2002:a05:6402:524b:b0:46b:8d4f:1699 with SMTP id t11-20020a056402524b00b0046b8d4f1699mr10153524edd.14.1670603426106; Fri, 09 Dec 2022 08:30:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670603426; cv=pass; d=google.com; s=arc-20160816; b=kqET2pjfEBiqjZKVVSv/PmvpSkfL83fIHuZJCHXJeM6ija2ogsPj9D/ayrvmVo43jc oDI6Gx292WMZuQM9eTRrbzIB3NYPpq1paoJvnQEshQgtdEyATmB4uTIifuzUXMCv0U9n fbUjxmiXBSl91+H6JrKZhMFmqzwUVyyQHgXmZBr7FpDcLdXDkDlR4Q6SAxMkPvWJ9Cox nvnu9raQsgEKZMT/CGpBIVc71L6kkTYw9x8mXEugL6WPrXsnN4xwZf4Rx6wyytswOrK1 gKO64fWMdtk9YeSLlRRlUl1HYjqdcPg9SZziBLVb4Nf+c9p3h43uA5zm3UANnJAQC3ka wBlw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=p3IdligEV+8wMIXFTBzWNj1DJQ5P4NUoifQXxBEdMgE=; b=KKiqUsiBD0yrOVXOrMoEzENM8oE8GZjmyJdQjcaGUlh8QB8CE3R6EUslzhEuJfORUs z8i6O5U0VMqZyO838lumtb5m53psACqpDQtXWaAWv4F7Pn8RvrF/vSwlE7kfvsbb7yAB GNePYeORjtOJAkVABpK7isGjvliMSAfk44ivMYOwtSDDgWFAOByTpfAJNgGxmzEJXEqd HSagd+1xB8J/2Lc7HPuLcd0pQKlmK6sof+fx6AJmoUspikM9MiM+pEOrXUu6oe2lEj1o 1sRkl4sRYVCsJJ7/G+cFtdL8toPz87s5IFmgUqdq7iCaf4Xt9wzYKrWYKZUh1AuG0jbP agOw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=KI5XpcRp; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::60a as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060a.outbound.protection.outlook.com. [2a01:111:f400:7e1b::60a]) by gmr-mx.google.com with ESMTPS id bc15-20020a056402204f00b0046c3ce626bdsi98792edb.2.2022.12.09.08.30.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2022 08:30:26 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::60a as permitted sender) client-ip=2a01:111:f400:7e1b::60a; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=KI5XpcRp; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1b::60a as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TxjTENkcw7wWurjL5jbktqCENLD+S6W+3JGjknrWJFE3nKw0XK7BYFctpJSjCIBTF//3QYX91SwaYHCbh51WRxYELIEANG1C4UYijU4gbuNM/QG7JEG5L229jnxlcTqyWHPF1eOA+g+VuSDTG0Ya2tAGKMQAufjJ4zWDZnQ0erkcOGdR/TE5PtnSLr6RoF+3ndJqQoQuN8mvIR8Cpwe77pTFPVKoa02WGSP3oEb71VGC5S3SgcrR4ygSxvjx+Ox+l9gYU7INm5bfcMz5oxcbs+0d/0F8woSklG5Oe65z7Joywk72VFFqPR3Pbpt34cdZI3hFR7OjNvfTFrZuOJ3Xfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p3IdligEV+8wMIXFTBzWNj1DJQ5P4NUoifQXxBEdMgE=; b=mrLfBskmS1GGjzdIcARWgr5eMbK2tif5b1S4IfuzwEX7ClO3RZBoSr/O7C4yJ08G6qOC56hU+V+iN74Wl645grJiy8Tl6gl+y/ser+8IsVMdcVkw8/A41EX5BWRCie2syz8vCZaaBPoMk8hlpHLheWFju61oThdOagafU57KRsHYpBjiZ893H68jH5Ve5prz31UC+KaoPj3Q0DuQxU/qaRv3eLUv12Ry/otwppe+dzAr5J8Ok5yuun3WX4btyqYbIOhglMR5C/+J8hJyUgJALt6KwYOrSe3Pb+ocTGNDsPD+AEtiMWCezM83mpz71iCJ+2CiRHvRiqZw0ERuAErNNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3IdligEV+8wMIXFTBzWNj1DJQ5P4NUoifQXxBEdMgE=; b=KI5XpcRpXGCdy3oSFmtEfg1zZBBTmBPtzp+GLrylNMntXZFCk5yYXuIUmPEN87Y3j65Y8mveGOKP3lsn1bfCerCEOo6Pe8DEWm/ozSm3+O+VwohHKRzLQDECZSY1yGuukU+f1KW5GX29X3u+sn8/riWCA8OhyqKJ/z5Yj/XurBUioteKcDa3e5vf/6UNDvGvaY0ObVrWO2SP0AJWbHII//2fpt5DuJzP0uGFre8khd5Zkoe5CKnBTO+XrsMf4krpRlIuh1C00ve1FotA/jEHBgPoLqBSofo/nhaLtUizzk/pR8IDkNsaJxEyRmWit0MPBBQnWMUOj+7uHMDY1GG0Yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM7PR10MB3589.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:136::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.16; Fri, 9 Dec 2022 16:30:25 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5880.014; Fri, 9 Dec 2022 16:30:25 +0000 Date: Fri, 9 Dec 2022 17:30:19 +0100 From: Henning Schild To: isar-users@googlegroups.com Cc: Tobias Schaffner , felix.moessbauer@siemens.com, jan.kiszka@siemens.com Subject: Re: [PATCH] expand-on-first-boot: switch back away from systemd-growfs Message-ID: <20221209173019.68c28b90@md1za8fc.ad001.siemens.net> In-Reply-To: <20221209162237.13420-1-henning.schild@siemens.com> References: <20221209162237.13420-1-henning.schild@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::11) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AM7PR10MB3589:EE_ X-MS-Office365-Filtering-Correlation-Id: 37a9a26e-0875-459c-61fc-08dada02aba9 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: haVKdz9WPG3CaR+/8HI0ImYlgnsFYk01JHQmu0LTNpTkTZNU8Pz6nbVR5zLey9FTh1QTk990F6sRcaAL7v9HUSyz7keFnPGS7qYcluRV4vogsVEM8Y6SCilxWC5t4l5Tq2bWSTqsMbN7MUMXQD7Lm3GkThnwOkq4r9NjlDyKuxaE3NzFTcFqRu9bNl2V+aHggF5z8h6sUJKsIStgKZMkKdNgcjG86BZYbgEG8UU/ITkm3JSiX7jC346zrTJZf55i7Ij9+KValDRbYwZFELFSYh1BqDzgYRdxyfrlZpbvXwmjfaD1j1TvZBX0C6SA0ix24+5bS2RSVlnJiNz6wLThq68HUofdQqhcHlTK2JDEwLfzVrvzhmchk35NbgqRfFcgcKTPNv4xbTPQlsjAkJPoP5ervoiDzsMcSrSA2NthbCyXTtEsCTZlucvD2bVP+RIgRd3/I+U/fA/NSg2oumuQMc5B8qf4zvzwL/jg4wSbaby5Z90CeIH2v8GkIvBqF2g7gQI5ipJZrG0GQX3zOPFXyjy4alkOojVnLanUufIhrOu2GlqYZJAGXssReWzkHGFL2ve1jjiXeSxhuZUAHzKejOd4XuWuFkg9ZqUj0y88oWWYCKcXsXUaHXiZNUZuCTfsn6jedsbUpNIC/JmsVetCdg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(366004)(39860400002)(451199015)(86362001)(41300700001)(66476007)(66946007)(66556008)(8676002)(4326008)(186003)(1076003)(44832011)(5660300002)(6486002)(6506007)(6666004)(478600001)(107886003)(82960400001)(6512007)(6916009)(9686003)(8936002)(316002)(26005)(83380400001)(2906002)(38100700002)(66899015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4is/jJ+idNCiTFH/pkKEwjv/+YSuFMGiT1h5Nz8UbLLmlvsNfRXpQo4DGSMQ?= =?us-ascii?Q?Lrnno/OKfWzwc0wc57i1HIh1S1bmdTBMO6nhhYxgd3dveizYsTe17wFzV13r?= =?us-ascii?Q?piPveKP16V2d7oMuZ3c0nC3iXH6G8GwUEG86rGCbI7QJcs6en/ucdEsa0J0z?= =?us-ascii?Q?yaPFcO4/pCTb5LC6uimAUlM8eARkY5C9B4OwoBv4NGc5oyqL1zqEK6RyjcSE?= =?us-ascii?Q?qpF0UiP4qNy7NM+vtkbuIdXFIlkzVVhQzquBwvE9EjuJCSicZDAafdvXFJ8Y?= =?us-ascii?Q?0fdpA7RsgtEkGXno2KotSOrjZScQG0QuhzQQ1PISWkmx60Sz2q0fQ/AK8xK0?= =?us-ascii?Q?KUCnX++ANJKC7dKQBXM4fOHWpYJS5BEagc2kwhNPGdw1B9zhMVc8j/Nh98ql?= =?us-ascii?Q?c97Mv55vmv1P7tD09qe31lr5VhZIRH+710NQlgwzcMevmJxtUn6ULpxtDArN?= =?us-ascii?Q?CuMfjs69fzLLPvCTVwFudTYsggDdWBb01DxGk51TjczLJKNcEKaa++3knGsa?= =?us-ascii?Q?u4EPlXmsp7LVBVyKaCwvNKSmq70919/ctGDkN+wjq5Pj3sdWBysRHZVONYg4?= =?us-ascii?Q?EsBPmr3/NlkMKLKgw0RazbpLzwCvIIynUhIO6uhWN5W5JJt2rbb3oLUSOv5+?= =?us-ascii?Q?bG5sNXRZAXmgyyXfACjZodApv5hb3u9Z3LDG85qjFbNp3bwLom1w1fKY3D64?= =?us-ascii?Q?shCEwYUi6NLV5De9F3uQ6PuDVwgr+eBH9f7FcQN57KUs+uw61SwSKTA6BdyH?= =?us-ascii?Q?3k25f34zJbWT3uIiyfUKkKSbGGaRcyfqBX2d/WmXUd42Zvn0egtJ7bfv3g1n?= =?us-ascii?Q?ycqRNn9En0cdmPM0ILQliPiztPyl8WRD/T+IK0V0CXS3znnbI2k1cPsKEamV?= =?us-ascii?Q?Gugjdiwh7Wk6k1jNQoVoJ47pssIdJeBW3du6daQ9jwgeEOSNm5XKkHAU5lpZ?= =?us-ascii?Q?GeBk8bT5Bx2Vhvh6Ovaonkcjp+wbMEWcUnvnOzKV6sRP1Vo3zNfO1l9o8kf5?= =?us-ascii?Q?/keJFiFcXfzT94tdMBA+jt55Wf4soXFHU7H2pIRzYXfbrtqmY3akxaTAt0Ys?= =?us-ascii?Q?zqIv8ixUPrR6flCUOQwCSp39I1wnJajtL/RmuNEb8dXlSyZBs8r1PteCGxTk?= =?us-ascii?Q?1+uYrJNIce7cp7ZYq4CiRizjxNlzbsDk3+E27HgXx4Q79BcPqScGxZ7eHfCW?= =?us-ascii?Q?dZpbaFGU7cc91/poJ8y9kVvOVKnpMKTu3w/3O47RxVH0loe474WWcJNR0MVX?= =?us-ascii?Q?VJSJa/1DlbnyZPW933s1QNt1nW10Nc7eHN6BNW73HG9xl/RMhD7JKtb760YT?= =?us-ascii?Q?ZFD+suBf9Zz3RKAHcWeBEkFAxQA7TTMq+kO2puIwxkkkdedEGQzSHEc6QvjG?= =?us-ascii?Q?yuTKO+PuCUWEsdOPjCArgd9X+PJ3T5bdhbyKG4GRj3wF+nd0y1/l7tZf4UON?= =?us-ascii?Q?TejfiCcdQhxe770N1aaJGWryfeA33QK6UispQiqEz5LcMT3lZyesgacV+dtt?= =?us-ascii?Q?3cQLrgS0NCj86X7jot5xOQGevwzXYNI5sJCNMW94ykIghj5yiasb/8j/lYpO?= =?us-ascii?Q?BNkxv25hv/yWmPqy+dJXeCQIKNQuA7VdyizANZnr98S/gsA1UG5G3cY8nZCU?= =?us-ascii?Q?pw=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37a9a26e-0875-459c-61fc-08dada02aba9 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 16:30:25.0211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C8JyGsOSNg8fJSpAg0kTkCN7jRDUlMPG2Tl01yisY6Ydp30MKEQWeVnY2cajpPBznJmWV2YjeTflJEJCFcUWMokE+EADh0xAuW8YtKxepTc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3589 X-TUID: Z3HnR3vIfCvS This is almost a full revert of some recently applied patches. We only keep the bail-out in case "x-systemd.growfs" is somewhere in fstab. Tested on an rpi that was affected and now is not any more. We are kind of removing btrfs or other filesystem support for the last partition. I would suggest to take them in as they are actually requested. And i will at some point start with btrfs support and a target actually using that. Henning Am Fri, 9 Dec 2022 17:22:37 +0100 schrieb henning.schild@siemens.com: > From: Henning Schild > > systemd-growfs in some versions has runtime deps on symlinks created > by udev and we have a race there that shows especially on > smaller/slower devices. > We had patches dealing with that but they ended up looking rather > complex. > The gain of systemd-growfs is potentially a bunch more filesystems. > But we can add them as well in sort of a switch-case. We never used > it the way it is intended because it did not really fit, so better > not use it. > > Signed-off-by: Henning Schild > --- > ...oot_1.2.bb => expand-on-first-boot_1.3.bb} | 0 > .../files/expand-last-partition.sh | 26 > ++++--------------- 2 files changed, 5 insertions(+), 21 deletions(-) > rename > meta/recipes-support/expand-on-first-boot/{expand-on-first-boot_1.2.bb > => expand-on-first-boot_1.3.bb} (100%) > > diff --git > a/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb > b/meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.3.bb > similarity index 100% rename from > meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.2.bb > rename to > meta/recipes-support/expand-on-first-boot/expand-on-first-boot_1.3.bb > diff --git > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > index 57055ccdcbd8..93eddda2a3b7 100755 --- > a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > +++ > b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh > @@ -57,29 +57,13 @@ sfdisk -d "${BOOT_DEV}" 2>/dev/null | \ # Inform > the kernel about the partitioning change partx -u "${LAST_PART}" -# > this is for debian stretch or systemd < 236 -if [ ! -x > /lib/systemd/systemd-growfs ]; then > - # Do not fail resize2fs if no mtab entry is found, e.g., > - # when using systemd mount units. > - export EXT2FS_NO_MTAB_OK=1 > - > - resize2fs "${LAST_PART}" > - exit 0 > -fi > - > if grep -q x-systemd.growfs /etc/fstab; then > - echo "Found x-systemd.growfs option in /etc/fstab, won't > call it explicitly." >&2 > + echo "Found x-systemd.growfs option in /etc/fstab, won't > grow." >&2 exit 0 > fi > > -# mount $LAST_PART out of tree, so we won't conflict with other > mounts -MOUNT_POINT=$(mktemp -d -p /mnt "$(basename "$0").XXXXXXXXXX") > -if [ ! -d "${MOUNT_POINT}" ]; then > - echo "Cannot create temporary mount point ${MOUNT_POINT}." > >&2 > - exit 1 > -fi > +# Do not fail resize2fs if no mtab entry is found, e.g., > +# when using systemd mount units. > +export EXT2FS_NO_MTAB_OK=1 > > -mount "${LAST_PART}" "${MOUNT_POINT}" > -/lib/systemd/systemd-growfs "${MOUNT_POINT}" > -umount "${MOUNT_POINT}" > -rmdir "${MOUNT_POINT}" > +resize2fs "${LAST_PART}"