public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
Cc: Joe MacDonald <joe_macdonald@mentor.com>,
	isar-users@googlegroups.com, joe.macdonald@siemens.com
Subject: Re: [PATCH v2] expand-on-first-boot: support resizing a btrfs root
Date: Sat, 10 Dec 2022 17:29:53 +0100	[thread overview]
Message-ID: <20221210172953.30abdf41@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <CAJGKYO63BfCYSVvzC9j_20SWhhOcTbE=rpwQwHg4FmxqySWtFw@mail.gmail.com>

Am Sat, 10 Dec 2022 04:28:48 +0100
schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:

> On Fri, 9 Dec 2022 at 16:40, Henning Schild
> <henning.schild@siemens.com> wrote:
> >
> > It all looks like we want to revert the systemd-growfs patch and go
> > back to using plain tools for each partition type. So i looked at
> > this again and will likely propose another round, keeping the
> > author but changing it quite a bit.
> >
> > Am Fri, 22 Oct 2021 15:50:47 -0400
> > schrieb Joe MacDonald <joe_macdonald@mentor.com>:
> >  
> > > resize2fs fails if the build sets the root filesystem for an
> > > image to btrfs though the partition is expanded properly. Since
> > > the rest of the script works as intended, simply checking the
> > > last partition type with lsblk and adding `btrfs resize` instead
> > > of `resize2fs` in the appropriate circumstance allows everything
> > > to function as expected.  
> >
> > It it not about "rootfs" it is about the last partition.  
> 
> This is the code you need to integrate btrfs filesystem
> 
> case $(lsblk -fno FSTYPE "${LAST_PART}") in
>         ext4)   resize2fs "${LAST_PART}"
>                 ;;
>         btrfs)  mkdir -p /tmp/btrfs
>                 mount "${LAST_PART}" /tmp/btrfs
>                 btrfs filesystem resize max /tmp/btrfs
>                 umount /tmp/btrfs && rmdir /tmp/btrfs
>                 ;;
> esac

I have an updated version of Joes patch looking very similar but still
needing some more testing. Feel free to review that once it comes.

As for this one, it is a clumsy duplicate and i will not even review.

Henning

> In attachment the patch against the current next branch.
> It has been sent by elastic mail but went in moderation, as usual.
> 
> Best regards, R-


  reply	other threads:[~2022-12-10 16:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 18:01 [PATCH] " Joe MacDonald
2021-10-22 18:19 ` Jan Kiszka
2021-10-22 19:50   ` Joe MacDonald
2021-10-22 19:50   ` [PATCH v2] " Joe MacDonald
2021-10-25  8:10     ` Henning Schild
2021-10-25  8:22       ` Henning Schild
2022-04-22  7:57     ` Henning Schild
2022-04-22  9:06       ` Jan Kiszka
2022-12-09 15:40     ` Henning Schild
2022-12-10  3:28       ` Roberto A. Foglietta
2022-12-10 16:29         ` Henning Schild [this message]
2022-12-10 20:37           ` Roberto A. Foglietta
2022-12-12 15:24     ` Henning Schild
2022-12-12 17:48       ` Roberto A. Foglietta
2022-12-13  2:10       ` Moessbauer, Felix
2022-12-13  6:02         ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221210172953.30abdf41@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=joe.macdonald@siemens.com \
    --cc=joe_macdonald@mentor.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox