public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: henning.schild@siemens.com
To: isar-users@googlegroups.com
Cc: felix.moessbauer@siemens.com,
	"Roberto A . Foglietta" <roberto.foglietta@gmail.com>,
	Joe MacDonald <Joe_MacDonald@mentor.com>,
	Henning Schild <henning.schild@siemens.com>,
	Joe MacDonald <joe_macdonald@mentor.com>
Subject: [PATCH v4 1/5] expand-on-first-boot: support resizing a btrfs
Date: Tue, 13 Dec 2022 11:15:05 +0100	[thread overview]
Message-ID: <20221213101509.535-2-henning.schild@siemens.com> (raw)
In-Reply-To: <20221213101509.535-1-henning.schild@siemens.com>

From: Henning Schild <henning.schild@siemens.com>

This adds support for resizing btrfs filesystems if they are in that
last partition. It also prepares for potentially other filesystems to
come in the future by introducing a switch-case.

The mounting logic is taken from the systemd-growfs patches we had to
revert again. Some filesystems need to online for resizing, but in order
to find the filesystem of a partition (without udev) mounting it and
letting the kernel detect seems a good idea.

Suggested-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
Suggested-by: Joe MacDonald <joe_macdonald@mentor.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 .../files/expand-last-partition.sh            | 35 ++++++++++++++++---
 1 file changed, 31 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
index 93eddda2a3b7..0bc686059718 100755
--- a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
+++ b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh
@@ -62,8 +62,35 @@ if grep -q x-systemd.growfs /etc/fstab; then
 	exit 0
 fi
 
-# Do not fail resize2fs if no mtab entry is found, e.g.,
-# when using systemd mount units.
-export EXT2FS_NO_MTAB_OK=1
+# some filesystems need to be mounted i.e. btrfs, but mounting also helps
+# detect the filesystem type without having to wait for udev
+# mount $LAST_PART out of tree, so we won't conflict with other mounts
+MOUNT_POINT=$(mktemp -d -p "" "$(basename "$0").XXXXXXXXXX")
+if [ ! -d "${MOUNT_POINT}" ]; then
+	echo "Cannot create temporary mount point ${MOUNT_POINT}." >&2
+	exit 1
+fi
+mount "${LAST_PART}" "${MOUNT_POINT}"
+
+ret=0
+# Determine the filesystem type and perform the appropriate resize function
+FS_TYPE=$(findmnt -fno FSTYPE "${MOUNT_POINT}" )
+case ${FS_TYPE} in
+ext*)
+	# Do not fail resize2fs if no mtab entry is found, e.g.,
+	# when using systemd mount units.
+	export EXT2FS_NO_MTAB_OK=1
+	resize2fs "${LAST_PART}"
+	;;
+btrfs)
+	btrfs filesystem resize max "${MOUNT_POINT}"
+	;;
+*)
+	echo "Unrecognized filesystem type ${FS_TYPE} - no resize performed"
+	ret=1
+	;;
+esac
 
-resize2fs "${LAST_PART}"
+umount "${MOUNT_POINT}"
+rmdir "${MOUNT_POINT}"
+exit $ret
-- 
2.37.4


  reply	other threads:[~2022-12-13 10:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 10:15 [PATCH v4 0/5] expand-on-first-boot btrfs and CI testing henning.schild
2022-12-13 10:15 ` henning.schild [this message]
2022-12-13 16:45   ` [PATCH v4 1/5] expand-on-first-boot: support resizing a btrfs Roberto A. Foglietta
2022-12-13 17:18     ` Henning Schild
2022-12-13 20:44       ` Roberto A. Foglietta
2022-12-13 21:05         ` Henning Schild
2022-12-13 21:20           ` Roberto A. Foglietta
2022-12-14  3:33             ` Moessbauer, Felix
2022-12-14  6:50               ` Roberto A. Foglietta
2022-12-14  7:10                 ` Roberto A. Foglietta
2022-12-13 17:01   ` Roberto A. Foglietta
2022-12-13 21:22     ` Henning Schild
2022-12-13 22:15       ` Roberto A. Foglietta
2022-12-13 10:15 ` [PATCH v4 2/5] meta-isar: introduce an example to use btrfs henning.schild
2022-12-13 10:15 ` [PATCH v4 3/5] CI: improve cibuilder readability henning.schild
2022-12-13 10:15 ` [PATCH v4 4/5] meta-isar: install expand-on-first-boot in most images and add space henning.schild
2022-12-13 10:15 ` [PATCH v4 5/5] CI: expect a message about filesystem resize vom expand script henning.schild
2022-12-13 10:25 ` [PATCH v4 0/5] expand-on-first-boot btrfs and CI testing Henning Schild
2022-12-20  9:37   ` Uladzimir Bely
2022-12-20 15:08     ` Henning Schild
2022-12-21 10:25       ` Uladzimir Bely
2022-12-21 12:13         ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221213101509.535-2-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=Joe_MacDonald@mentor.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox