From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7176574724112121856 X-Received: by 2002:adf:ea84:0:b0:242:1572:bd68 with SMTP id s4-20020adfea84000000b002421572bd68mr30100482wrm.487.1670966533566; Tue, 13 Dec 2022 13:22:13 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:3b17:b0:3d1:be63:3b63 with SMTP id m23-20020a05600c3b1700b003d1be633b63ls12756133wms.1.-pod-canary-gmail; Tue, 13 Dec 2022 13:22:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf5O0wXg7zkENehfC0vFKzrOhsS4lYUStYmD8Vs1Wd6XqfYWYmKAtsdd4G3L2ieZuD63fQ7i X-Received: by 2002:a05:600c:3b0c:b0:3d2:7ef:ac5 with SMTP id m12-20020a05600c3b0c00b003d207ef0ac5mr14239372wms.15.1670966532391; Tue, 13 Dec 2022 13:22:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1670966532; cv=pass; d=google.com; s=arc-20160816; b=tZfgl+6ggwrVYOrBEqPE7tV7rLvRSbSF9q+SkiBHBtH812Y2sFOzq0CYpUYwVLNsFu TXg6SAV8ylVTPH2usS0Fx8ZzREAF6khRvZRuWFdYfUYzB6n1OWh7DcDhSTb13fgOfaNt lPC4DtudkFKeTMh1k/YEp5+zJk8EIM82iKb3gRk0VqfgBKuk7yULZV0pQaHsX2VU19yr ld88FRDEbVq7iwlMny/spvd9WVMjf8MOH5DDnYmOGI+BThDu8y52dpCskgIrhamVD1YD GP7kViQzVh9Wvm9V+L9ccOd6Su0q0swDelZwd9Ap7xPvQ2Pr/6XUYUlF3Nn5KaSLuH/A Ihig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=skJaV+35C4GKfDQ5/Hwpli82IKLGM+f3yFZ88wMIeyA=; b=ziXAYrvTg10TAL6xkW8O1uWmnXSLE//kbr3bQmBP9XIUy2IR6gW5CiEGmMIxQSjBEP UVrAN2lxFpXUSv9Fr+oa8xgZjhn39/p5e+yJ6pQWKVHdQfAd6vl5JCvHDkoUFL06hisq qQu/HGmCMjJEwrkWvxGP8M6uzOE7yvgqr82mQRCXKeHZISFRJxahGxsF7v7f6PO9cxHG mZGSnzTYYEXf5JcIiy7Xgtr7WJBZJpDln5uIyHDUV3+4NrJi682xra6oacL5HiEHU9ly ZRt7Hv+pSBg6gXZ5T5oNn5zI+wsZvN3DL8iV9Ul4CFBVEFIieUbfjpBX/S2RuGOJ1trO 64AQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=y+1G27J2; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2079.outbound.protection.outlook.com. [40.107.21.79]) by gmr-mx.google.com with ESMTPS id 65-20020a1c1944000000b003d090dbdab3si165502wmz.1.2022.12.13.13.22.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Dec 2022 13:22:12 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.79 as permitted sender) client-ip=40.107.21.79; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=y+1G27J2; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.79 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMIWyjKPwTQAZIlBJqrD1iEv2edP1Alsy0PLHt6sXcLJy+2op6nDETSJkvhDb2e3P7bZffWOExrHl/xMyztNWvZj7d43arreUe68Vf9vmjG/Wm2Nxsa6epSRDV55PaqwqNJhhlceCEq2JllEZenC+Wz5KQe6vSeKWJ3VNsrv0favCrwqdcFvQCpPrHuX2fO3H8IYK4PBST0iLycRjycqDGmlRskNaBcmxixuYGyfwd2xB5eWks84YrNqH8LXd1tDdFD8tgeCsnIvkLVE+2452lWWXov57vYO/kgEKEjknv0yrWyr1XsEgXaUkrYiPWUf1vhT98qediCStueqYW40DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=skJaV+35C4GKfDQ5/Hwpli82IKLGM+f3yFZ88wMIeyA=; b=O4fbZXfcQm7q2uPswd1eZjIQD7yFNWlqD48ehlR0TQik4GORNjcWw19eNMTMyBbvOh0B5MC1T61ihV23YQZNQ/GHFvPhZuq+vdjWOr7a0JnAGb6hL/JN6TBsT3us1FFYfxOsS0nzL+azS5612WzkjhPMrh1al/UQ3fazmvYc2bJEr1TXDT6LcZZ8eSHjTQ+0WbAJtXtYZ+whE3htEd6VqWzsvc2L74rNNb4tbItKxP5Zdfa815BCV0SNxTaDkhcmtahbCX0gXkxiULvEsfqoYg1ghbFMXLYfeVJxKcf/ejauJZGpKlxYl/y2xYzdJSGl8e304MU2tk0GymYNfmCZrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=skJaV+35C4GKfDQ5/Hwpli82IKLGM+f3yFZ88wMIeyA=; b=y+1G27J2NuoGcI0O+jdaveZFatYM1+2DDAqeboiom3yj9wbtnm07U2qeT8fgwcYHfcpdrKA2mJHnuuLFVs3U2ckUyDy8b0GIPXbjbVYVxpuYBga8PsFrk9TngeV0OUmD/LFv9qxsFEYDeslpyccQqiejxJqJcd9sx76lBzIvWlMilXast15ejNPHnZw+2oLMJObAhg5InOHYrmmTkS11zkapb9O7MMuYhTmREL4leII2P99XqbH3eFryHzyqRU+blhjyTCCW5d1S3kr8921IIyszd7qB0tdkqk1MGSkviQ7hVuuQpuWGeG8q23D1qW4cqGZO/o3Bx/rSdky7IAmBIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DU2PR10MB7766.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:49c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 13 Dec 2022 21:22:10 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 21:22:10 +0000 Date: Tue, 13 Dec 2022 22:22:00 +0100 From: Henning Schild To: "Roberto A. Foglietta" Cc: isar-users@googlegroups.com, felix.moessbauer@siemens.com, Joe MacDonald Subject: Re: [PATCH v4 1/5] expand-on-first-boot: support resizing a btrfs Message-ID: <20221213222200.199bc0e6@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20221213101509.535-1-henning.schild@siemens.com> <20221213101509.535-2-henning.schild@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR19CA0010.namprd19.prod.outlook.com (2603:10b6:610:4d::20) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DU2PR10MB7766:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fe0e939-cd70-46d8-024f-08dadd50182f X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b4mIOdW5uPDofnCZgguNemWamhNqLa4ZgVOmZwpieRIVtgK1RvEUIw2u4E8IDHjAqBc0SqFJyRKItNd4LmpznVolbeDBdpoGKkcz5wqyZpqxQanTp/l+YjvTVhuxBYq96srfKjcv9bvdfhkK8I544EaPYsQNzOnyjcsAgndGsXb3PlGVXNCAJiYHegJJMxWGpdRdbA4AjrbwlCpRdW6z6NyYUzipj6fbvea/dYjHbVD7ZOSBa9zTZar+K1OwZ12w98kMd8p6vhnqTLdxte2bZIkheuYxT7NZDYiG9xaPYA0ge/4C6oZYlrKuJPDOKmNQXcepxwu1NmTIRs4kRPvb/P0dzLPQkjjOohaQxerKAXEbtjYag4CtA3A8MRmMBQKzKuAkf2DPF0XtMb8hPXuadFTWxKktaJeCwfT0GV0Ycz7FzWv/eTixZN3ddVaTpbUm4UVtXcJ33KCel4exyt30AAVoVr2OZismrw8J807IODZAMRwLIItzkwBkBEQ0V1IvBdNQWcQzJ9aB0fpwuOR+Q25Rd/Sqas7I9yrr81+lG8P1A41C+XJfEjP4Ax3SLoFMI9KmjkPCl/OAl27yqbb6boRCSjvybBtqHLpbXYc4Wy6FaQRTIOBecc4Wd/JhvKOv2zDbKy3q1o+bgxFBezEiRxtIvRbpe8vctZSwpLPr8SPQYF8KZSRDZR+9QAFnOEiM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(451199015)(38100700002)(8676002)(66556008)(316002)(86362001)(9686003)(1076003)(66946007)(66476007)(82960400001)(4326008)(6512007)(6486002)(186003)(478600001)(6666004)(6916009)(6506007)(2906002)(83380400001)(44832011)(5660300002)(41300700001)(8936002)(17423001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qVHHCdzm53k0qZMtNLOiHsmQGyF4+vjsBISti44bG73406w1q552ElFN6sRS?= =?us-ascii?Q?Hln7g1ZgkaEZ4a0jLzgCwcXqcodbE1rjBZaoyHGjhnDNYQ7affLg4EVRhzPa?= =?us-ascii?Q?yt0PnnLoONWHNJbFs2yJxNC6nYCSNnXT7fFkooFF8HGbscjlILhRJggz4mzs?= =?us-ascii?Q?P7XYYSyf0C8FAomG/0h8+usYh4J6iBrV22mBnfL6SCsrbcSy8W5GFEWXDXD2?= =?us-ascii?Q?zASABj3fglQBSwNGF9i57wmpb0Ea0o24vdxIPo7iZXQgD3lJJBCCmDyZFdlC?= =?us-ascii?Q?8dnwbsdfqBihjp/ZDOJu47ZDeJFjOQHfIv6J5qYcmrsh/iCk9mXM1WerLD2N?= =?us-ascii?Q?xiPMbwneT5/Q8+veoRa+nkMYbByeWXzBsv5oI0lV/Y/2zjuaFmhqoqCh0SQ1?= =?us-ascii?Q?4bEH0DHuJ1q9H9do1+RGAQ7Bc3F0/3IOe6qv5fYNjAg4VdhcaF7p4z/6cRzU?= =?us-ascii?Q?PwsJ2dsGWR5+Y1/xIroBa+fXrzK1o12S0uSmhQhZg2WVl/ah98pHHq6x85tv?= =?us-ascii?Q?vnSAfoxBuaKhqt89pFvfZHTak5KnsTVJoSDS/QsvJc9qpsoyYOM84D2QXT1F?= =?us-ascii?Q?xPomWXWiMUVsxMA+SU5aAMLwTFEZn/3wD3rsvDRVIPHlXDunudtZUEz3qoge?= =?us-ascii?Q?eANDgSZTND4Dmi/asm1Lk19P/2xBzRhgTwBWkMcajsaP2M7ifdZM4hp5YQf7?= =?us-ascii?Q?5RslXBXJrEINGyAoUcGjYE8YdpX78ixpRrPRLbbtv6/juR1XoHalNoosOWDW?= =?us-ascii?Q?9UGar8U/CxKQyFMWjEW1zzJO0ypvArEiy5X5ikFSS7By2cSRXirQFGBhFjzf?= =?us-ascii?Q?FVIYxVpRJqAuAPunSRfI8aYIadxZ9MYAHJdbxzYS4QAV2+8zpix9fIG96c51?= =?us-ascii?Q?MF4r7KUjQov5q+Czfu8iac+09gQy4dp6DjERDJr85/YUylH8N5cWD3vSigMr?= =?us-ascii?Q?xTgOVE2Uh/AFw93s+Ez3T4cW4L0Wrf3fTE0CnzbF61sCsuSjSwmwa37fMJXb?= =?us-ascii?Q?xFsKk49FCPNGNbr2O9xTRV4yRZN8xPQOVBcDSwwqvFRmIt4RFAXnlkXYaB8y?= =?us-ascii?Q?aRS7y1koo55l4sBRbZhP4dfwkZBNiTtVVQMY1iRfyU1zbUvbF7KVH9y2zDjv?= =?us-ascii?Q?Gs4ka4NjHZ9/xkRgmKyehBDUltUpFlCXHzNfNGVnBfm9pkigFsExdXnyf2A6?= =?us-ascii?Q?Uyfk7c+rPCkhukjcmokZHAfxvRhwa7mc1zza7zybW7s6MZ0H46v2VDtVE1w1?= =?us-ascii?Q?vsPJyLdhkWM2eHNrLSch4yazcF52bUphujtSnXoTpKABSdYwdW8C5ijOMStr?= =?us-ascii?Q?zLNDDBdqoGr/2/TTGGMZkGII641sann2+/oSJ/1zrEQPoA6ehXc4NuKGgnV4?= =?us-ascii?Q?EbPTeyLlSmErX1Sf7O+yNLQNwjXGeMNArHW8M3SlfZi7bEPkdUr7mCwlYqBg?= =?us-ascii?Q?OxJycHswwI7F/2PUS5viQCtr2b8yOtFvEXojboRgAj9HTXY+6XiAKvw7HJbS?= =?us-ascii?Q?bko1L9gVvQmxAmJ1ewEFgfl1n4FRJOwFQwUVWfaXu6l7Unbdl+1eD4c04ewk?= =?us-ascii?Q?eLZdIplXWqZEOpb8XqjfHcmyxmQ/5KHOHAHq1w1MOlMqrCuxJ8l8zknLMSDb?= =?us-ascii?Q?1SxqDT4503roLv6HjinVlxY6E5/l0rKcW9EgEFEnVobfnNzRaIJXTbUWjfGY?= =?us-ascii?Q?Ohf6QA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fe0e939-cd70-46d8-024f-08dadd50182f X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 21:22:10.2327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gvUSACmhqLMsGUNNTE2oOEAefioxY3PzJUCuAvtS7njDNgVcguuB+Eayt0FmTvi4AbvQaeM3/SMEgYIVI3Bi/FOWkPiv5hRX3+TP4OmZypQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR10MB7766 X-TUID: 8xGodEOiWc0y Am Tue, 13 Dec 2022 18:01:49 +0100 schrieb "Roberto A. Foglietta" : > On Tue, 13 Dec 2022 at 11:15, wrote: > > > > From: Henning Schild > > > > This adds support for resizing btrfs filesystems if they are in that > > last partition. It also prepares for potentially other filesystems > > to come in the future by introducing a switch-case. > > > > The mounting logic is taken from the systemd-growfs patches we had > > to revert again. Some filesystems need to online for resizing, but > > in order to find the filesystem of a partition (without udev) > > mounting it and letting the kernel detect seems a good idea. > > > > It is possible to avoid the udevadm settle constraints only because > the boot device [1] is the same as the rootfs device. The boot device > should be mapped by the kernel at boot time, so it would be available > but not necessarily present in /dev partition if this has no static > links or devfs mounted at the time of mount. If udevd is the demon > that we choose to populate the /dev then it would be better to wait > until it settles down. The stats about boot time on different > platforms will show that only hardware slow to detect has a larger > boot time. > > [1] in some embedded devices the boot device is an internal and small > device dedicated to the boot while the rootfs is on a separate > plug-able device. > > I have no clue how this would matter in the case of ISAR. The whole thing is about only one device and its last partition, not more! And we clearly expect boot and root to reside on the same mass-storage. Or any other last partition (my series was also manually tested against another /data partition to be grown). Thanks for approving that we do not need to "udevadm settle" in that case! For any more advanced scenario people can always run whatever they want, possibly systemd-repart. Isar is all about a single image for one mass storage device, it can be used for more but such code will have to live in layers. With btrfs we could have one filesystem with multiple devices/partitions and the code i (and you and Joe) proposed here will likely not work. Let us keep things simple in the core while allowing layers to do whatever they please. expand-on-first-boot is for the "normal rpi case" where a stand-alone image gets flashed to one device of which we only know the final size when we boot it up. Not just rpi ... it could also be your qemuamd64 image flashed to an ssd/hdd in any PC. ciao, Henning > Best regards, R- >