From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7176514492887465984 X-Received: by 2002:a2e:992:0:b0:27a:1822:c65a with SMTP id 140-20020a2e0992000000b0027a1822c65amr3786298ljj.487.1671007639469; Wed, 14 Dec 2022 00:47:19 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b5b5:0:b0:277:a9d:9351 with SMTP id f21-20020a2eb5b5000000b002770a9d9351ls3057933ljn.7.-pod-prod-gmail; Wed, 14 Dec 2022 00:47:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf6zEMMwsco/I1ugySza4bBTutsxSbf4GlSA8qczsWToICA0u/3qTeQccPn2HnCo998j6bG2 X-Received: by 2002:a2e:9918:0:b0:279:d2b0:7945 with SMTP id v24-20020a2e9918000000b00279d2b07945mr5789205lji.26.1671007638208; Wed, 14 Dec 2022 00:47:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671007638; cv=pass; d=google.com; s=arc-20160816; b=II3MmT+kMTv6KKNMLmpeRJOQ1cgHz1d+z2IsKBkBaloAN3YNO2jZNxkjvqOP8Lrz1O rbM/GJSWxC+cwrhtlYFzk4PDgtpZcpNYCyCbih+DJovqtbX6lRgVh5G7N2PjK+wUKL66 kjutVEv11UOiDxEHOdVTV6HO8y8B2FCLoxTBELo6G1Uik2Npqh3G8r2honDBIW+mh3VN aGI6LAYWqxpxvyYccgKgm9ZnL1MKc80p8tBS/vVQSrGHR8y8xnONAH8dqMU6fi8o1hnw lEzYwKqLU6ehdIM8PQKRysfFvw+klYo9UXsnKY2iflEmO0mKZpbTDfdc0LSnh9GgZ2sP 7nUQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=F53byjIcXKJlNOkrDS9vhfOFcttu06XBqdNYmzZb9h0=; b=sFqXTmdwVjXvMuA757wpCHLbCu/MjyFEW/f1/siCcIXjwCRhyDpshXS0nuTKnzmkRb 8sMw4TojAGA1GxOZSEYO6RggotYUmdpdoSwZ9D8Z3WqVjERBjPH3fGovtzvl33fa6lyD TqCy4Ah+ikTjRmCAS9dCOzQwwUITIQ81dfHjhZAFvQN7JX7QZQGm63DxSyMs23LTJQG/ ts+aYbRupJvxW3Jf6Img+i4Qe1LG9Wm3tD2sSHsCLMvn6QcKi0FCwVEDXOl639FAjK0t JxA/2BQ7hUl5cNx5Idv3EgQ/gzpTai36H1cDEDFclnAbS34rUo/i/dLI9v8ElSSolftc j3lA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Vv0QYoXj; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.15.70 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2070.outbound.protection.outlook.com. [40.107.15.70]) by gmr-mx.google.com with ESMTPS id q14-20020a2eb4ae000000b0027a2a767052si246001ljm.3.2022.12.14.00.47.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 00:47:18 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.15.70 as permitted sender) client-ip=40.107.15.70; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=Vv0QYoXj; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.15.70 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBFdQH+0+CaEXR4PU9aORX2Xm0cRyEjStfFg/sRqzAR9TxFwxI8gZjgn0s7oSilTS0puD0wtHvJrl1nx7kEeleJcix+aqfTtJEYP4zVLIlwng60pMQ0oH80QwQN8S9mI8EfjvE3s451l9V+FwDBoDLCUZl/PC+SxbMJ5gT3JXyMFIbqp/dCA9TkBCkH/A8V4j3CVls3VJ9IlozCw/DkeqOJfhkXK7W+EO9W1i2NT5I7rKEKP+u/VtGTexCNxGm/rXqxXQlgKUNvGrcnc+GGaPefEm+7Cq4mIyan8932VncFVVL3JV9/49TNkGSq52PH4dZtddPpvc5NepaoSNuzSyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F53byjIcXKJlNOkrDS9vhfOFcttu06XBqdNYmzZb9h0=; b=YKXxLHaUKW/v+6BJDW7sqj14Sr4vWqOaxVuigiF3wyEXRuJrNkzK2sc48dEqguJrJWgS5QDNDT/lj6TdhwXhJgKVV2T2RExzMEt26kGl3ZxeU8nXlhqbUu4BFcz5HO2Ix8xByF+v1ZW1IFC2gyOUDik4ddSWrImOw7CPTyt/YotCZcfSqyF9qSawp209YZQT8OyhkWad85S0n0SfiE7JH9pccK0TegbNetRQFKp41Q5WWN7NpgInNiVh+0k6hNsU9rBa+fDdUkJGcN3zqVkfxDg4a09ELGzDbTUBaqLFAecf32X8zPHznU5Bqof0K7KWLImQizP5mMHSGAGjcnnqmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F53byjIcXKJlNOkrDS9vhfOFcttu06XBqdNYmzZb9h0=; b=Vv0QYoXja7UhzVdolDEmuO6x8Jdglr9rjsk+v1Qxn9u0jMER+neM5IJ/KDh4pnCxbw4fz2MAcsa1vFN+aXQai7850O3MRe8S5dwqUoTiOu+G5SlICEmLia3k7a+gCGWUW7YcgV9fKIv8NZQoFw0uF7f/+m0bDIlJBSIfeBlKF4nCUKsHq8AZAj+Ys9Ym7eQryCRVdOmoajIXtSZvR4RWiLAIGI/4rF+xMFo03DqiWQkSWSRCQdFsi7N4ys/HmiVFn8mIJwjdEmPPIqG15vqc7bW3r6k1uvJTLNRjXyq0vaW3eOmgdTUZr52tsrfotbjrGeNZqr6IQAfReN8wfgAhvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by PR3PR10MB4062.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 08:47:16 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 08:47:16 +0000 Date: Wed, 14 Dec 2022 09:47:07 +0100 From: Henning Schild To: "Roberto A. Foglietta" Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2] If expand last partition fails, unsupervised systems reboot Message-ID: <20221214094707.006cf073@md1za8fc.ad001.siemens.net> In-Reply-To: References: X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR15CA0001.namprd15.prod.outlook.com (2603:10b6:610:51::11) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|PR3PR10MB4062:EE_ X-MS-Office365-Filtering-Correlation-Id: 334ffbce-99aa-4d4b-5dd2-08daddafcd89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xayVjPIZeWdGO405bnT+n95y5Gc6mFWm30IlQgIeRzhZ7d3T9QYIKBOG74YQ1lxhVRKXl4d70koKfb2nPowSE0tNxmnjhboAd6sMs4z3bt/L2RBPuXfJ/tmwyyvr69JJFQTL1mtvwuyDJT70EQ9/ng+ScxglJjAx7q3P3hQroSOVzb8lKRVEzxB3oUyELl07wXunLEH1aLyvZpkVdnCbqypCVMZzONzr8wv0urwZ73f2Itjs7wg1yuMpkXd/WBWA1SvkLxBP5eS/O4M4NsDdA7EpSV5Y6hVZEAwrO4DiJJoyF6H88z/gWxF1rT6tn1sr2OfZClTpai07fe54nETXHj47T53yvqN+NOLxw/7qfBVm37E/P29+gKd6PDmsu4m9DTBzQ4X3/rCO8VadIJhwsaD8jjuHbIo/MazbQ03C/aHUu5HDIgvDJ2vjEb1tMjC34addVI4/utL0on5oOv4f55h3RCXA3xBzkPZX8s+evGm6fLI2baAMwnzTNMqTIYkmAtLcFuslYLpM4qqjqe0eu8Nstrc03mpC8kTQL0gb3lmCVM1y6Ks1Hk3VnIQ1DBy3UQGGmey0cWo87JSKKWTknLOJ6t8dzp2JzPuEI1na0lM7QzL17M6cHDwX57LmlgarQtYfyjfnLKEah0MvSmcR6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199015)(6666004)(478600001)(9686003)(186003)(6512007)(38100700002)(1076003)(6506007)(6486002)(82960400001)(4326008)(316002)(66946007)(5660300002)(66556008)(2906002)(41300700001)(66476007)(6916009)(8676002)(8936002)(66899015)(44832011)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+ElKIIrE3YnQqeNFYvrjP57de2OW3+uVwTHGuKYWALn2/oAhsSMn92N792bE?= =?us-ascii?Q?EE+rv8pICHuHeUBHZ9MMfit38LH9jAA69nFoGtlvN8t/OjEyB5enxQ0qJVLY?= =?us-ascii?Q?CBlKKWOsTkDmxSCn7V6HzKlrd4jdpZ8yQiKB/kHd+66ygr9FAnr4YU2YGyDL?= =?us-ascii?Q?iEczmAajqdM86nJg3v6MeaEDHlXcubomR8mI/qoG6kTDW0tpc6JExtMeNTbJ?= =?us-ascii?Q?Xffyf87K7lcinNbl7guWH2vSsNMKivoHc3DjyBCMg8Hnsk0gtmBtHrmewMuw?= =?us-ascii?Q?9cHjlN/AyIf1xkorxOW0LP9LFtQNTijxZmu3QxzOJ1djfFwhtD/kEVPn/V1p?= =?us-ascii?Q?jcNjQEd1jfrfq5yB9IOmOfDCpNKbHkmXAw/tyFF5XPhJgo+HQrxDyF7hhHlm?= =?us-ascii?Q?SWDkL+sdZ3NrPH6ESGQbiH2j+eIdW5BNoWGY/Z/W7MlqRHuOsQpvfLkNraeY?= =?us-ascii?Q?ihTg6GsD/3fk01rjWemb7YzeriJAl6flVQYbqYAeLOqiEAESFjvn6ZOcOcnn?= =?us-ascii?Q?wkOJ8OpRNGqyMVcxj1FNK0Gf6iQsaIC+awVIuMt0CPm7n7unbnVq1n5S1KGy?= =?us-ascii?Q?PVWGTr99CfOaNs+IXdRS/hoWe+m4veP/n5dxDPb4GwhfFlcFjPhDw7HL2VfL?= =?us-ascii?Q?13kBgB5ahXGI8ZrljjNmAgDykMN+3euIgCxxLrqcrHtj/Abln9FBtjgkxYwa?= =?us-ascii?Q?Z4hQCmJ6f33hyv/zTDCXuXnlRD+gb8QaCUHHg2TVNP7R1D/9xfdN3nZugEwh?= =?us-ascii?Q?VRFgm+yFqHSH90ZFmISds8UhhmHiegSXm8+uoqjmOFutRS/PoZNUqtet59I8?= =?us-ascii?Q?DiguNxyx9fd+UAnpqmF/L96xcppV+TCpH6k+I6zbS1LV6JI2uIO7xTn7uW7Q?= =?us-ascii?Q?FgnKEBde765U2RShRM2X+QU+flORM3EeGIZKoCo5JX6W/+xA5X2kYEa3pLTs?= =?us-ascii?Q?VYixcO/1GXArm/7SaszOZibYih2Cx0ebCKp0BWi6zPdrdjboUoN+0NqnUKl2?= =?us-ascii?Q?0RS7jzcKHX2A5ycLKnFp3TocwjAeI2SE4LE+bB4BGvZcba6HM+jSOCAyJ8y5?= =?us-ascii?Q?pyFGlnu0qOlS0cJPT87NjosIzngJuegdafet3QUNNJrPCUK36+A4ChgC9hCI?= =?us-ascii?Q?IfdJJmp2LPLYCua+BnnT5LjxYwQukg6voAYKGei+vJrZXWzu0Gd7b5+Okn8I?= =?us-ascii?Q?FBgfuwLR/k4D3P5yVaWBP1GSp50Y4jph+f/Cj7b7GwuzGX7gYTosifHxCOXg?= =?us-ascii?Q?oE3kNaK73SiOA5MtmNti+DB+uqxzJ5kRWS0VF3Ba0UuEsqCyKAhGWW0IfrPD?= =?us-ascii?Q?+htY+FVMCirdkDs+R6b+YH0P9RXs8NAMITPZxuz/Ra/US97Lw+xE9ZONrVgH?= =?us-ascii?Q?IneOwitQqe0ymHxPmFhTi/hOYliT2i6a7p+a4l8NvNy9jEBrR43RAf91b3ex?= =?us-ascii?Q?M15QbJdatzF5pXDXHiiy+b/0XZzaVWU1/NLvj8US59oBwxKUMqAw7cdDFH3K?= =?us-ascii?Q?fCYhe4Jpk1QHb6QdZHPf8mYMIGicqAupeFlmlP5oAIKkGa3+qMiN/V+JWSLd?= =?us-ascii?Q?RaAfBz25inhRUHshGlhdUrxgf4GQhOA7HWueA+OhNy3GfUO+xXkCHrQ34aXS?= =?us-ascii?Q?b53Z1lEcAUmbyvZ1/472EzX0RavlAdL+3oQqgvQgAyBcX4NqhYuJSY9SYtq3?= =?us-ascii?Q?CFoOgA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 334ffbce-99aa-4d4b-5dd2-08daddafcd89 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 08:47:16.8223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SBvxLAENnuUlr5CVJJN02QifU1VD/i/Cv7fFR4+cg/msXQhxKQmyMJKdTI5v+MwWMGOlc5aQ/9NjRRXCNVLcEaf+hHDMFr3eUYOCdl6TohQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB4062 X-TUID: 36Q5YI71sK2z Patch can not be reviewed so i can as well top-post. We should maybe separate the discussion with the reboot trap and the unsupervised file from the "aligning the nothing to do exit code to 0" And i think we can only really have the discussion if the patches are inline and not attached. Good catch, please send a patch that just turns that exit 1 into an exit 0. Ideally without elastically stretching git send-email workflow rules. Henning Am Wed, 14 Dec 2022 08:52:00 +0100 schrieb "Roberto A. Foglietta" : > Hi all, > > in the expand last partition script I read this code > > ROOT_DEV="$(findmnt / -o source -n)" > [...] > BOOT_DEV="$(echo "${ROOT_DEV}" | sed 's/p\?[0-9]*$//')" > if [ "${ROOT_DEV}" = "${BOOT_DEV}" ]; then > echo "Boot device equals root device - no partitioning found" > >&2 trap - EXIT > exit 1 > fi > > this means that there are no partitions because the boot partition > /dev/sda is equal to root partition /dev/sda, which happens only when > there is no partition table. > > roberto$ echo /dev/sda2 | sed 's/p\?[0-9]*$//' > /dev/sda (which is different than /dev/sda2) > roberto$ echo /dev/sda | sed 's/p\?[0-9]*$//' > /dev/sda (there is no partition table) > > That's ok but not exit 1 because IMHO, it will retry again the next > time but nothing will change the next time so it will continue to try > and fail at every boot. Because one-time-only in systemd means > one-successful-time-only and exit 1 prevents disabling the operation. > > So, exit 0 would be the correct code to execute and this is the reason > because I removed the trap which would make an unsupervised system > reboot. > > The patch v2 has been sent using the elastic mail SMTP and went in > moderation, here in attachment. > > Best regards, R- >