From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7176514492887465984 X-Received: by 2002:a19:c502:0:b0:4b6:ebd2:6250 with SMTP id w2-20020a19c502000000b004b6ebd26250mr1199120lfe.152.1671008739255; Wed, 14 Dec 2022 01:05:39 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:1208:b0:277:22e9:929f with SMTP id i8-20020a05651c120800b0027722e9929fls3066461lja.5.-pod-prod-gmail; Wed, 14 Dec 2022 01:05:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf548rNpzCwOX2L0VeBIqS1Q7CgXuPAa9Ki1Gnyaw/C3NEpAKoQvbXrJ3IafQ/SzW7iAOmi3 X-Received: by 2002:a2e:8845:0:b0:27b:471e:470 with SMTP id z5-20020a2e8845000000b0027b471e0470mr5254824ljj.15.1671008738056; Wed, 14 Dec 2022 01:05:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671008738; cv=pass; d=google.com; s=arc-20160816; b=Qf5hxsUNFcBLlTpsM4Grt41IVRxidlaKplilXxH1aRcYT5hbGqDrlhAlSLxUD/pFml /E5bnnrrODGDB/nOg6QUp8wwGMtU55F4GukXF8hQ4s65m4mSTHqcLC4Ejq1yVR1HT3Vd pEWQPGSnSJgXvpx+oBBx0X8D+G3vt7OFsCoSQCOxckQV0JqyEjt9OdRem38/uafuA2Jo LF5eRoM46TFmN1MFlbCUHrdFnazLD3t34JWhk+HVJGqiKjgq5FFq40FurAeT8/vHSl6C MAC/m30rwbifGoDoiYyACOG5USSikqtBq9x+GFI++bfm4gUGgqUqBGcSfHDO2fNly/Qj uqLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=jJaaiQocjPWldXtDENNGwjEJH/YVBdbxkapvsD37zVc=; b=FSii/KeM1ul6+RiAfiXxqYHEHK7inepipHjomcg1CG/iF/XsCdSTUmu65H92t2315I IU+eLR7lYwXiOqp1Z4SoYUQGLeDwEA7lGB6RdTc/4GISqMEQpDmrP83MlIyBYbgbxVXe moXgFBZoF5dS/eQf8WJc5waFNUCzsYm2mhb6Rv5uuaK3Oc7FbToHdrv1GsEMEZYC/9bs L8Lo8KP3vlFRTTcTPvI6WKNfXba6yNNJ/2eeeZwGFstmSKOu8CAJHMVfPWP/uL5GOB4X 2sKx0JUD3P+6oiIoCzZI+hdiSipmcgSGini/SzzpM69xlh84wjfnMHP+KauDQ43h1bey aUVQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=nmSOPaH8; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.6.75 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2075.outbound.protection.outlook.com. [40.107.6.75]) by gmr-mx.google.com with ESMTPS id q14-20020a2eb4ae000000b0027a2a767052si247804ljm.3.2022.12.14.01.05.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 01:05:38 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.6.75 as permitted sender) client-ip=40.107.6.75; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=nmSOPaH8; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.6.75 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qh/FGPa85zQCH3cf0tqHCn0PMMcL3E/tRqPvk0n1JEeTQyB5trsOVOomvnA5Ak8Yqmve5xEhvZq2lf9LzRm3Jknhnjm+oFyfELhyysr2hwvep0JnUnJGZKlQcv5HzenOxW8Os0xRdYFr/XvlKzFg4KUsbdcIeVOCdXSDvBvMATWcHdes5w2fNQiRaz9gjlLsUtKwSOywhUij0g1Ky4lePQjUQRlWSRXwg5Kj2Ix2bF5AGNcWCq0S47bLRp19BMh++1n5D1/66Z2/WaynNXRL7My9aDNkeJ3nIFar/rCThbOKFyJ77WtGSYNgg5dSV0oAtD5KTtyj6iy8K4rHfgkVTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jJaaiQocjPWldXtDENNGwjEJH/YVBdbxkapvsD37zVc=; b=Nulw1dLX5EYPX/18nY4NG/S/6StsONJVOAvPb/zk6mgYP2uERAhAiXPJlmbFO0M1TndWH2y2eWV7+dgdzftivfvsHaRQv1ZYRUqclRUnIalv85HUGD8uK5myEGQdnOo1FH0qSJtzVXGaxirAPc6Z4QqJFYQkXqjawW/go7bjmJ+cMMmjEthYeTakQlJb/dZNRxYXN9zxhdGnEmdQEYh1SVGjYRtGzh0g0pbAcdU8x0CrOA0kg2j4PPD8Hrwrtx0R3lP+lSB1Tycv/rsYPjYQ3v4UPwdTH5S7kAjq3b2ZMBCTLkT7UFkCtXe6GNpnEjO+1RM9Y4ROBQymof3wmozrJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jJaaiQocjPWldXtDENNGwjEJH/YVBdbxkapvsD37zVc=; b=nmSOPaH8SWZIv9edIKn99aTAV6+3N2+esL9j4+ZxC73dPzLa+ETD2A9m7SiuJgeV8jdAqKO5cAkLCcLXASAM43MESP6kAkq45ORPh54Fbb4srw3aEmA1LuRl8maeqsT4v4QpQKw2MVo8E0HP6Gc15yb0hmI9QQ0zh63PznyuPyj3QeYjRa7uRiqbkSOmFpym4by4Gx6l9FOE9S3UdPdF1AF2KTLnsdxpYYYjgB88Es+F5n9z6QqhUVgXK5ZcazWRCsj/ZZ9xkKhkm3PN/KHgTFKlEQjyFo9lEDHL9KKef32UxaPNyFVJILPppAqmq8zuLFqrR8FrrL1QfomY5TiO8w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AS4PR10MB5576.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4cf::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 09:05:36 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 09:05:36 +0000 Date: Wed, 14 Dec 2022 10:05:28 +0100 From: Henning Schild To: "Roberto A. Foglietta" Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2] If expand last partition fails, unsupervised systems reboot Message-ID: <20221214100528.0386e83b@md1za8fc.ad001.siemens.net> In-Reply-To: <20221214094707.006cf073@md1za8fc.ad001.siemens.net> References: <20221214094707.006cf073@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0198.namprd03.prod.outlook.com (2603:10b6:610:e4::23) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AS4PR10MB5576:EE_ X-MS-Office365-Filtering-Correlation-Id: 11574f9a-9d26-4596-fb8b-08daddb25d24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qGZ0+hPxMBAqh5T8qmmPGKU4QQhK0pqa6LYbqNY8DQKnoFWASRVDo46qleYQLtS8Mp2khIkxh6+tCaPpOQTcHTHmBEOBZJlZz/CewDNcgDQ940jGsEguspu59fEyh9WPedO/UMoHxzw0h5aLn0zZliMnYVsFLKM4zjeSNWW1vMdtFPIWptkhHjIqjj9ELvgYQ0dKwTL3g+yQb7n8q8ToL3j4bfs/C7hAoTX/rkX2zlXCVXKOJehoFva0U0Cq0vi1exhfptLkw7WTcPtfrmLTHeac6BvTQWEoF1naD9IhyJST6lCeBmq8lnS0l7zsezQXGulEigK91HDc+ni6Bc3L1SkA5uv0DILpIak8df8ohc4kGXS5gIjOr+/nCADd0mhVfHydUH+2cc0BwEk/yMQKRaBUPwNGvUBHxkJt+TnfyjYNmYq5G2StgS0UJ9HijfxldOaTpqB+gxEz9AlldKg+2iJMZi3c65u41gU4iMy9nZkHjMhxWaC1tUUaUo+9H1ocztbS9z7YflDHO4QDTc9HKQj5CKMJMazols3nuxIJ1KnbPD7zGGnobUYWTODaczDaNrU4xWX7Z+5BkWcqcd1bfgxs40BIBuart4XJHu4W+lcTkzqSht/JW87jH7e/LD+4dk0tPYOry//tKmAjdhHqkA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(82960400001)(38100700002)(478600001)(6506007)(44832011)(8936002)(86362001)(41300700001)(66476007)(66946007)(8676002)(66556008)(1076003)(9686003)(6512007)(5660300002)(4326008)(186003)(66899015)(6666004)(6916009)(6486002)(316002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nCxXxUZeEOZTN7p72Jif07VbvM6TTsIk6c7y3iUbzLMM+ZNhI9VCtUlN/FDL?= =?us-ascii?Q?EgFnS/nE8VzOxuyDdvE82DQ1BT+v6NjI7wVH/RnBgMgFMJMDBpYV6LjPm2fS?= =?us-ascii?Q?9bJfRcWOrUW/AiVWCn06z6rVKZwgqwep33tnMzgdwec+CiUWPITtz7k+SyjG?= =?us-ascii?Q?lZFm6a9iR1i2s/O4rpgia6RThcOOtxiPr11g3ZLN/eJ5jHm4JVZ5kSaVCYcW?= =?us-ascii?Q?QMI2YwCPKBdP83zRW7DJGYz/N5Zbv1Ov/qTGJpYzr0oXaxly+Z9BQ/Hv7ecL?= =?us-ascii?Q?ZRSacXrBNvg+BTbOPmKp9YgMx3fmYMGGuIqPoGsu08fzwfPmcm3hg6NthFHW?= =?us-ascii?Q?WZ4ZjSLBc1Slq4t3QFOKeUocn6qmu1Uef50KMaztnAPapkvn1Xd4qurqbXcE?= =?us-ascii?Q?kGQHBKkZPZTJpZjfA1VCfB9/lbyYenOhocFQhORgG2IgUWUWtnirMC47mEPV?= =?us-ascii?Q?V7vzumxrpUqswqVriLOVGPo54DYSY11Y3TjXkLUKI3l4MxJ8Ns79ypY22zg2?= =?us-ascii?Q?oqrHYg2s2xmtbh73et/ix0HRK0dw0aA6226i5FR1gLoP/85dTMwG214fMDJu?= =?us-ascii?Q?X0C0pAlUh5r2HQf4H+5Q1JIJsUtiVmuwVIs01JTzuRR3zuSfOntoH7v+jXI+?= =?us-ascii?Q?N1hySPEGZ22pTrK23rXR00gIp2QoKhIPtLR4yNmCm8NJpxamSESqYomVDK8/?= =?us-ascii?Q?vr0TBqG1OzhPGW3jqnVexUOySEGH4pPWiLs7ZeUdz7BbxCKov1AbDU7RbMYw?= =?us-ascii?Q?7mUNI0D7fP+Yd8hcaq0foL+Y93wDZyP2HvqfzQYZjTLSAJYCHFl/FkN5Txez?= =?us-ascii?Q?y2wyUUskpRYsyQ/MNbq3oPiO/hn54m9Z0eCJkDcWhMhkS1DL4QVBMXipebNa?= =?us-ascii?Q?v0sKSUDtd8Vm4HXnTfhC0QMmZD2GOHepOGgyS6XXJIp/cC2z6RmGIZqaBC/6?= =?us-ascii?Q?Wu/56Cs2tTF0Kfr8/hxyLiiYPTpju1XOVjBlGwDD08geHuOscLrTplbSWuNV?= =?us-ascii?Q?lgGM7XgI5EIw1v3+7mnOv22BuQgSNipx+H6uMpK6jEyahvd+fen+eYPeL3h1?= =?us-ascii?Q?QFAHZUyKpAvQPUFrZmbOZfn0mSCJEm6H79sJWSpPUyPokS6LqHb7YSX22vLh?= =?us-ascii?Q?VlkSEgejohZMIIOgGiq0yai1rmjc/xmCDPX19YVM+9PeZZct77LrReKlLqaa?= =?us-ascii?Q?PQsUnH8DxC9gNxyVekuGaJGVsHSWPtESwxV8oH/nnRmWWLI3Hvj1UObUwS9c?= =?us-ascii?Q?I6JbGnwNod4ii9RDk1cWIcCLuYRQb/K94FhddofZgpFdhrQJdOsf7Ux6VgMr?= =?us-ascii?Q?l7OC4fJSZxBI7rsqFx5/afDBe1C+esL2jJjGR0gXp1zhvLMwd64+Yp1xnOmn?= =?us-ascii?Q?3pKxRDO2a4cg/mVummlr78wh8Xbc+u1yfwZTHtICWjQ3pqHJAXTMeUmjfh4p?= =?us-ascii?Q?WMbbVgkP8P5mgvvHmHb5jgvEJab+VLlyiVDwcpLD5GbrLFh2+CDrV+IIS9aB?= =?us-ascii?Q?X4yKtqL7qc849vXvql3BgYocWHmGf1cVZb8igWvcjGrQ8sI+R23OW7n3R8z6?= =?us-ascii?Q?p4t7fImnGM1UjflqN0AhqFIVLCc7Pan4wAjP2qpizMQssSNbarhgTfUiMJaN?= =?us-ascii?Q?Fyq7sgGAGqr9IXtSRBJoNyE560x5MQGsgKITZxyF7jNyEYOYGDuPJpxS/85g?= =?us-ascii?Q?ndpSOg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11574f9a-9d26-4596-fb8b-08daddb25d24 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 09:05:36.7811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DFk6I94ZVfA2zL58H3H14MYA0F0pnT1G7NIl3u1Iht3l4UU/iLiKAs14bgL+w/fvqgdp1Z5sO59ft+QVfb7Kyud10sryT8WaeNcqrnRbWuI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5576 X-TUID: jAzsfoaDsYyC Am Wed, 14 Dec 2022 09:47:07 +0100 schrieb Henning Schild : > Patch can not be reviewed so i can as well top-post. > > We should maybe separate the discussion with the reboot trap and the > unsupervised file from the "aligning the nothing to do exit code to 0" I think it might also be a good idea to set ExecStopPost=-/bin/systemctl disable expand-on-first-boot.service in addition to ExecStartPost doing the same. So no matter if we succeed or not, we only give it one try. But i did not test that. Henning > And i think we can only really have the discussion if the patches are > inline and not attached. > > Good catch, please send a patch that just turns that exit 1 into an > exit 0. Ideally without elastically stretching git send-email workflow > rules. > > Henning > > Am Wed, 14 Dec 2022 08:52:00 +0100 > schrieb "Roberto A. Foglietta" : > > > Hi all, > > > > in the expand last partition script I read this code > > > > ROOT_DEV="$(findmnt / -o source -n)" > > [...] > > BOOT_DEV="$(echo "${ROOT_DEV}" | sed 's/p\?[0-9]*$//')" > > if [ "${ROOT_DEV}" = "${BOOT_DEV}" ]; then > > echo "Boot device equals root device - no partitioning > > found" > > >&2 trap - EXIT > > exit 1 > > fi > > > > this means that there are no partitions because the boot partition > > /dev/sda is equal to root partition /dev/sda, which happens only > > when there is no partition table. > > > > roberto$ echo /dev/sda2 | sed 's/p\?[0-9]*$//' > > /dev/sda (which is different than /dev/sda2) > > roberto$ echo /dev/sda | sed 's/p\?[0-9]*$//' > > /dev/sda (there is no partition table) > > > > That's ok but not exit 1 because IMHO, it will retry again the next > > time but nothing will change the next time so it will continue to > > try and fail at every boot. Because one-time-only in systemd means > > one-successful-time-only and exit 1 prevents disabling the > > operation. > > > > So, exit 0 would be the correct code to execute and this is the > > reason because I removed the trap which would make an unsupervised > > system reboot. > > > > The patch v2 has been sent using the elastic mail SMTP and went in > > moderation, here in attachment. > > > > Best regards, R- > > >