public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: henning.schild@siemens.com
To: isar-users@googlegroups.com
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH v6 1/6] expand-on-first-boot: really only do that once, especially on failure
Date: Thu, 15 Dec 2022 23:16:01 +0100	[thread overview]
Message-ID: <20221215221606.5623-2-henning.schild@siemens.com> (raw)
In-Reply-To: <20221215221606.5623-1-henning.schild@siemens.com>

From: Henning Schild <henning.schild@siemens.com>

We do hope the expand will work but we also know very well that it can
fail. The script is written in a way that currently only supports one
try. And not a retry if it failed in an earlier boot.
So make sure to disable the service also on failure.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 .../expand-on-first-boot/files/expand-on-first-boot.service      | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
index fda50016e9fe..90c92a396b27 100644
--- a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
+++ b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
@@ -15,6 +15,7 @@ ConditionPathIsReadWrite=/etc
 Type=oneshot
 ExecStart=/usr/share/expand-on-first-boot/expand-last-partition.sh
 ExecStartPost=-/bin/systemctl disable expand-on-first-boot.service
+ExecStopPost=-/bin/systemctl disable expand-on-first-boot.service
 
 [Install]
 WantedBy=sysinit.target
-- 
2.37.4


  reply	other threads:[~2022-12-15 22:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 22:16 [PATCH v6 0/6] expand-on-first-boot btrfs and CI testing henning.schild
2022-12-15 22:16 ` henning.schild [this message]
2022-12-15 22:16 ` [PATCH v6 2/6] expand-on-first-boot: support resizing a btrfs henning.schild
2022-12-15 22:16 ` [PATCH v6 3/6] meta-isar: introduce an example to use btrfs henning.schild
2022-12-15 22:16 ` [PATCH v6 4/6] CI: improve cibuilder readability henning.schild
2022-12-15 22:16 ` [PATCH v6 5/6] meta-isar: install expand-on-first-boot in most images and add space henning.schild
2022-12-15 22:16 ` [PATCH v6 6/6] CI: expect a message about filesystem resize vom expand script henning.schild
2022-12-15 22:37 ` [PATCH v6 0/6] expand-on-first-boot btrfs and CI testing Henning Schild
2022-12-20  9:41 ` Moessbauer, Felix
2022-12-20 19:36 ` Anton Mikanovich
2022-12-21  8:22   ` Henning Schild
2022-12-21 15:28     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221215221606.5623-2-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox