Re: [PATCH v6 0/6] expand-on-first-boot btrfs and CI testing

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 20 Dec 2022 22:36:03 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> 16.12.2022 01:16, henning.schild@siemens.com wrote:
> > From: Henning Schild <henning.schild@siemens.com>
> >
> > changes since v5:
> >   - drop dead code around mktemp subshell
> >   - revert cosmetic mktemp stuff back to v3
> >   - remove "Suggested-by" tag to hopefully improve signal to noise
> > ratio in review process
> >
> > changes since v4:
> >   - cosmetic fix in the way we call mktemp
> >   - add a patch that makes sure the service is run only once, also
> > on error
> >   - bump package version after changes are done
> >
> > changes since v3:
> >   - rebased on "expand-on-first-boot: switch back away from
> > systemd-growfs"
> >   - implement btrfs resizing and CI testing it
> >   - put the padding wks entry into an include
> >
> > changes since v2:
> >   - add python namespace prefix for the bitbake get functions
> >   - install only in images that use WKS_FILEs that have the "gap"
> >
> > changes since v1:
> >   - complete rewrite to not focus only on the tests but rather the
> >     feature for all examples
> >
> > This first was only about testing but meanwhile has a focus on
> > enabling the expand feature in all example images anyhow, and later
> > look for traces of that happening in CI test where we can.
> > We install the application in any image and in the wic images add
> > some scratch space at the end. That will enable improved
> > interactive use of all those wic images, so makes sense apart from
> > any testing. Later use the log reading feature of the qemu tests to
> > look for traces of successful resizing for non ubuntu images. In
> > ubuntu the console_loglevel is not verbose enough to find traces.
> >
> > Henning Schild (6):
> >    expand-on-first-boot: really only do that once, especially on
> > failure expand-on-first-boot: support resizing a btrfs
> >    meta-isar: introduce an example to use btrfs
> >    CI: improve cibuilder readability
> >    meta-isar: install expand-on-first-boot in most images and add
> > space CI: expect a message about filesystem resize vom expand script
> >
> >   meta-isar/conf/machine/qemuamd64.conf         |  6 ++++
> >   meta-isar/conf/machine/virtualbox.conf        |  1 +
> >   meta-isar/conf/machine/vmware.conf            |  1 +
> >   .../conf/multiconfig/qemuarm-bookworm.conf    |  1 +
> >   .../lib/wic/canned-wks/expand-padding.wks.inc |  5 +++
> >   .../lib/wic/canned-wks/sdimage-efi-btrfs.wks  | 11 +++++++
> >   .../lib/wic/canned-wks/sdimage-efi-sd.wks     |  2 ++
> >   .../lib/wic/canned-wks/sdimage-efi.wks        |  2 ++
> >   ...oot_1.3.bb => expand-on-first-boot_1.4.bb} |  0
> >   .../files/expand-last-partition.sh            | 31
> > ++++++++++++++++--- .../files/expand-on-first-boot.service        |
> >  1 + testsuite/cibuilder.py                        | 28
> > ++++++++++++++--- 12 files changed, 80 insertions(+), 9 deletions(-)
> >   create mode 100644
> > meta-isar/scripts/lib/wic/canned-wks/expand-padding.wks.inc create
> > mode 100644
> > meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks rename
> > meta/recipes-support/expand-on-first-boot/{expand-on-first-boot_1.3.bb
> > => expand-on-first-boot_1.4.bb} (100%) 
> Hello Henning,
> 
> This patchset look really good, but still fails on arm-bookworm
> startvm test of
> our fast CI. The issue can be reproduced by just building
> qemuarm-bookworm target with bitbake (even outside testsuite) and
> then execute VmBootTestFast.test_arm_bookworm test case.

I saw that when i ran ilbers CI once. Was hoping it to be unrelated and
maybe a known issue. But if you confirm that these patches introduced
it, i will have a look

> So my proposal is to apply revert expand commit now without waiting
> for this patchset to be ready.

Sure. The "revert" patch is important. This stuff can wait.

Henning