From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7176574728906211328 X-Received: by 2002:a05:600c:296:b0:3cf:8016:880c with SMTP id 22-20020a05600c029600b003cf8016880cmr132388wmk.80.1671636538564; Wed, 21 Dec 2022 07:28:58 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:f706:0:b0:3c6:efd6:9cd8 with SMTP id v6-20020a1cf706000000b003c6efd69cd8ls1285302wmh.0.-pod-control-gmail; Wed, 21 Dec 2022 07:28:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXubeaqoV8tPgnBi122RgacRuw58ZyI6ECgoqHqvSCZ7mjxBlnxpw82Po3dRxJmgNdJUa3CU X-Received: by 2002:a05:600c:1819:b0:3cf:8d51:fae1 with SMTP id n25-20020a05600c181900b003cf8d51fae1mr1939136wmp.0.1671636537449; Wed, 21 Dec 2022 07:28:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671636537; cv=pass; d=google.com; s=arc-20160816; b=ZQGxHFKmYcuo0vnSqHyTfbCiDHwiPIFjYOETmcqSjyxbsXzSH/ZFVNaZ8n6AraKoGl ReHErD5DRFuRSUtVRHZCDy6RhBeoZbwezIpFGjIRJA1qANk3HfupLy5M4W6TUr+CEY1l 5gGWZjvUBh9L/lci4eHZEqVGYWTcacOFtaa849N/M1p2EdDCFo3cU5+jt1se/nsPaGBB DEIeZv9hNW41kHTkThj0vg8bZLqIGT1XoHmG8Z4oQ2LXAHUGq8r7DgY3uVwKFDR49yXO JnKFXFS/G17gjAP/1hjrYWibYuibrfBpM/3L4AXiMiYazqmyXvAavfzWtHMUJkfTN+8X UyFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=/7DGNaG+0zT20pNWQiT8osINEYVa2lq/UkSdleSuEeA=; b=qt8UwuLjpfXyDKAQfayZMby+k/8vXxEIt2HfME47AVr9v5/5Ur0PcMfpREMhmDuVHN iqHOthrLwfS/Va8ICbjdO8k4fH9TDaSfjeM8UXeXHw4bShF+lkZrTl+jsnUiFJ6+CVgD sEgByxdYNqGoRZmlvE3fKjJh13o8wluqjlmsW/IZX9pVtQye46pYRy+BhRYe6qz0mpYo C+TDcPScLvCXWW9U2Ey0tkbhncmKF0Il/16TM3rendy32bMYgy4TOICWaBhtvWmB9pc3 kfNak6igdvnjwbZQHDziCz+EIzZlkx45PD7r+ceqQKcNjDryO0vHkdRmKvC28CZdNZci 6ycA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=UV07d4cb; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.75 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com. [40.107.7.75]) by gmr-mx.google.com with ESMTPS id n7-20020a1c2707000000b003cf567afb1fsi293725wmn.3.2022.12.21.07.28.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Dec 2022 07:28:57 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.75 as permitted sender) client-ip=40.107.7.75; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=UV07d4cb; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.75 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TevT/8pva5SyTRqFJylCdgRTAIxtRQGzQXQwoDDa/jk5DFQmKLVOx/bPkt2R4tWG+b5nj+pkJqPfpjxy+gQ7YZ34EzSILpgmoTnXIRhvKd2RH/21UErRpkjDYg5GNO9UisVYBcdkAqGszDuS9oVIE8z8kOPaJCAs+vFClWS09Jsq5XmspK6VpFzNShwhuMHed0o/uPqeYir69fRgGbW1et2kyYxVk9XT6TikrtT4NjlnUK2dIuo68MHmQAHd5sg/HoiWJ5mXFli0j1Iu6kMGuWh/jqDIfzhvlnqP7fSDUdrLHy6m0rGFRjzNfBtZ/e6KbIRwymfZ6Y8FH1uXRD+HlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7DGNaG+0zT20pNWQiT8osINEYVa2lq/UkSdleSuEeA=; b=NYQNcY4rBpn5FQ6aWMHcfFMbhwczhbOhVodm1RWZ+vaXS1zuJAVKMoXolVgLKdxhCz+PWuCjgHeNz/Bkc1xRDqOOBvnw/mcLRKhiCI+Z3GJ/tVaZtCLrt5z9qfLasSUuuf4cU4gV14OKHzwUN5y0k44PyBr0CQRlY+ipc6DKd+siDaHk8QJvq+GnIaKKA9AMv1pmVg3rk7biZPgF3rFJxX/e6Q6BqXIJBnxk+4royrIpJ7ZCJE8OFNGFSbiprI9tzYTZYKpt+Leqze/yLINNcaVObI3pMAR6WY4l86LFl+Ax5GeWnvjrrMjlVPmg53Odmtex8iBmUQDYwT8E2NFlLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/7DGNaG+0zT20pNWQiT8osINEYVa2lq/UkSdleSuEeA=; b=UV07d4cbjav+teaKyOkvlgKYFkAysyKJLUOyHSXrEwnA4ZwTrR4dBl/LoFlPy8/yX89fqWbFVvj9Y7XARmthdMWeb9aj6pct4iQLIEB2qE73OlcPKwXXyGp0A4pmu1gzcyoB6v8rgPG54s0sr2O5811smYLe9JSNZVY33NqkdN+pvGF7tMrDQKNu0QI8KsKT/oO2XJ3pNct7KnFnrCaQm8c/nDP6aecMafaw8N5bjRocnVgYXaze3ljLrb/9u1YM/q+U3N/XWp1meP46sl10cuiNntM0D+XJLRjV+CTCLqTaMsA3/2rgwCbdsiaPkU0DZK++bcyDyxv4gjiUEnfsMQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DB9PR10MB6313.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:39d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 15:28:56 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 15:28:55 +0000 Date: Wed, 21 Dec 2022 16:28:47 +0100 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH v6 0/6] expand-on-first-boot btrfs and CI testing Message-ID: <20221221162847.0ea89c80@md1za8fc.ad001.siemens.net> In-Reply-To: <20221221092221.3276345a@md1za8fc.ad001.siemens.net> References: <20221215221606.5623-1-henning.schild@siemens.com> <20221221092221.3276345a@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR15CA0005.namprd15.prod.outlook.com (2603:10b6:610:51::15) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DB9PR10MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: eb4323b2-dc18-4649-e7f5-08dae36812b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5F6DUPIUSPp2GScRYq6wJjRXGJQ9c5GQ042exsxTYdg6Kxk0TIF0sflCpy/VAkBnSPwLT213M9ip3mTbQeordtGcZnCI+y7mptbnBpUwXO6Kq76xGlh+BaC9BrsrcIfLlsild0Qu1ZjzGlHaNuju7cpJkpHYpMqpvH2rJzrc5vVMwLvUaNGnrk1jgmqEGu2zdEAtXbfEoM2tjkDiqydKT0PUA6WEQpZESclV/ycjywfS4Ocago2ZmAP5BTLEz/lqAgm6KBIZb6O5NA5GOa7iVg+APJ/HJ7Ggl2JJZodSclGJkhcP1cihkB2ocHt6BgpA48fitPOE0m3AhhT3KgTjFeO3GwLt2GutG1VLYpm9URMX+T+ZDU+A90PIPZB4plqQ8sYfmLsjxJX0s7EBH88E46SkpRC3w7S67LAPhsNqMpk0rvDC+/Zfu6mJGeSmsqAv3LzRQmmX52dCCNRjMoklQJa6jq90MomoitQnAJKClnabNcK4ObHxLvGozDKRMrF3WAVO9udpG5HcC7pV+9u9aOChJdc4s7u06qN9KIyDcSnwE3NeiLtN79M+A00hfmO6H/ngG4j6bKQ2NC5BHv+b0NrLFdu696pmlDcAoQC/yEsk3k1CfGAyZihq2nBHG4R3kJ//LGc7NTZHW3W3nsKDaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(396003)(376002)(39860400002)(451199015)(38100700002)(4326008)(2906002)(86362001)(66476007)(66556008)(8676002)(44832011)(5660300002)(66946007)(82960400001)(83380400001)(478600001)(316002)(6916009)(6486002)(1076003)(41300700001)(9686003)(26005)(8936002)(6666004)(6506007)(6512007)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lkDlMfae2v7KVDTTIBBHhcOCxSpOVDJvOjt+1JtemHgPmd5yCFMeBx3hZ0qx?= =?us-ascii?Q?0BRQt7chIliIi2WhnFzzoQQktG2xh6gpd7q46tedpVXKdJk8mMmsgUvElBKS?= =?us-ascii?Q?tfFDHHsg91IsJlmTGlBnPTm1zZQpjj2XM7gMUAS/aWhOv1+4cZgj73KtWU5f?= =?us-ascii?Q?IR1Pkam8TSoV+BgxaT3v5noEAlVpo/tvxaCOztOOhLV0VWVvrff77IEGsmcW?= =?us-ascii?Q?UlnCR7bwLJiLC6YIe4xGyCFumKYPEaN3hcji77fbSoJoeaf3ScCUSga0jZ+R?= =?us-ascii?Q?WUO98vdR11ok9ck8Ar4JKiRsugSpxOmPi5THBx/7jUWvbYFyl03a4mtjsyI1?= =?us-ascii?Q?nWecFae0qt5DWme7cXf88B8FLwneBI/3axl+h5D7wbu27mlxjuDBmk6nbQSR?= =?us-ascii?Q?QpeiytR+LdBuSqxGeNDed3RW+Ul3YPK+vV5Qz8q2yCKXxAPHWGbxguWZ/113?= =?us-ascii?Q?H+jx22gyfCXIg0vrS7gCubRGLCeCK1UUOT6fgYWVSkYXzH4PkFO41Gboi0qM?= =?us-ascii?Q?G7F+7nidHN/o8CTbMe4T5hfhZ6QSt06JM2LnTtzP2Z5NUdRs4UHoWtOZY9Nr?= =?us-ascii?Q?KIPG6wfoO1Wke9IC7Rp3WJBqvsy9Eg8EzYWScHhmJHtuRLTvtnHmTtUExeNn?= =?us-ascii?Q?T6/Cif7aB3nUken/pW6XTRDAn2sRUcTExc9f2TgwGwqk30E6J4bO8Sx6NejV?= =?us-ascii?Q?HABMZXdFcNEphmA896WiI3AN+dbuELNKTYTD8GHgAP7EfhdURJ3vHVDuUkOI?= =?us-ascii?Q?kbFprO7MvaKq5mBlAWP/rJtRX/v1o4wDmHI+nJWv7RmvnGDLnvdnRiaZC1LB?= =?us-ascii?Q?gKIzGfDiofVUNHOAixLinGA/f35tJZWpGeGVNHQ4QKNtF+Hdi186K16qZmfu?= =?us-ascii?Q?DrSstvyNM861O/SZQLQa7VO7CzEcHAhIiS72ascLToZR8pP4dA03Ley4OVNp?= =?us-ascii?Q?PVie6QY/AdLWPwddG24YZW5UUYoTrVY762uUxA08ZfW5ZQ9W9iToaV2RiTVh?= =?us-ascii?Q?1Fm7NrKawlj02+vJfoAVm84Url8XgapxxD03htaUV2X/yDO8CWsTqo51Fk4Y?= =?us-ascii?Q?nBBDRrdYPys5saxKtAvLxmu2XRmEYMbiF5HwY7KkUM1/BuhWJLGgY489IRiP?= =?us-ascii?Q?rpyVvWdmiKd47DQBttfz/UJDy08EkYerBdT15cZDjnNd//PLuyN+tIRzY1Mb?= =?us-ascii?Q?WQGVDTbQf2kthZ9Md3Si7N7y+86Tk6IMyCw0nnlNyWOQXUZZuVfB5MiPOWCQ?= =?us-ascii?Q?OeaO28PUNUfyhHOo+IAdDanuluAgUkBI/FrCzXL/hNlrr35vK0cOqf6eSh2O?= =?us-ascii?Q?md+0NZxwMyY6xS2NohQh0oTSO5wQ1EEDdaDm+Bciuo5kqHr3InXQD5ok66ls?= =?us-ascii?Q?9K1kG6brcPnyGvDQNmMsy3K3fbpFfDcAjAfIDDa+Rw+A12KjxqJXqo+3fqql?= =?us-ascii?Q?JQKF9GQfSeaF5uzsoyulG5uE1hmkfLj4yrqBOQZvxH19xKCE+cIXk/qNP9AT?= =?us-ascii?Q?Y7JG6H5Uz5+hisxJmC8QC82dH7pMR3yA6rODUYiaiikqICUYYqv4aVW5oyXi?= =?us-ascii?Q?LnPJFb9kXJ51QHuYfVP6d/MheTKDBzPd1ze3pr6d445wl8x8DwvRwYKlon7K?= =?us-ascii?Q?vg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb4323b2-dc18-4649-e7f5-08dae36812b0 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 15:28:55.9328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sb8Pyy3To9wW6jLirzoKrmKJ6ebMZBaXFL2XoqJ2vRP1IPkGsMlSNqzuJnDLaKJZdwcNtS6Z1qN/sSqw2FXFqWZ0bYpgrOHE5c3bC8MfBrg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB6313 X-TUID: tUSSaUFMtrA7 Am Wed, 21 Dec 2022 09:22:21 +0100 schrieb Henning Schild : > Am Tue, 20 Dec 2022 22:36:03 +0300 > schrieb Anton Mikanovich : > > > 16.12.2022 01:16, henning.schild@siemens.com wrote: > > > From: Henning Schild > > > > > > changes since v5: > > > - drop dead code around mktemp subshell > > > - revert cosmetic mktemp stuff back to v3 > > > - remove "Suggested-by" tag to hopefully improve signal to noise > > > ratio in review process > > > > > > changes since v4: > > > - cosmetic fix in the way we call mktemp > > > - add a patch that makes sure the service is run only once, also > > > on error > > > - bump package version after changes are done > > > > > > changes since v3: > > > - rebased on "expand-on-first-boot: switch back away from > > > systemd-growfs" > > > - implement btrfs resizing and CI testing it > > > - put the padding wks entry into an include > > > > > > changes since v2: > > > - add python namespace prefix for the bitbake get functions > > > - install only in images that use WKS_FILEs that have the "gap" > > > > > > changes since v1: > > > - complete rewrite to not focus only on the tests but rather the > > > feature for all examples > > > > > > This first was only about testing but meanwhile has a focus on > > > enabling the expand feature in all example images anyhow, and > > > later look for traces of that happening in CI test where we can. > > > We install the application in any image and in the wic images add > > > some scratch space at the end. That will enable improved > > > interactive use of all those wic images, so makes sense apart from > > > any testing. Later use the log reading feature of the qemu tests > > > to look for traces of successful resizing for non ubuntu images. > > > In ubuntu the console_loglevel is not verbose enough to find > > > traces. > > > > > > Henning Schild (6): > > > expand-on-first-boot: really only do that once, especially on > > > failure expand-on-first-boot: support resizing a btrfs > > > meta-isar: introduce an example to use btrfs > > > CI: improve cibuilder readability > > > meta-isar: install expand-on-first-boot in most images and add > > > space CI: expect a message about filesystem resize vom expand > > > script > > > > > > meta-isar/conf/machine/qemuamd64.conf | 6 ++++ > > > meta-isar/conf/machine/virtualbox.conf | 1 + > > > meta-isar/conf/machine/vmware.conf | 1 + > > > .../conf/multiconfig/qemuarm-bookworm.conf | 1 + > > > .../lib/wic/canned-wks/expand-padding.wks.inc | 5 +++ > > > .../lib/wic/canned-wks/sdimage-efi-btrfs.wks | 11 +++++++ > > > .../lib/wic/canned-wks/sdimage-efi-sd.wks | 2 ++ > > > .../lib/wic/canned-wks/sdimage-efi.wks | 2 ++ > > > ...oot_1.3.bb => expand-on-first-boot_1.4.bb} | 0 > > > .../files/expand-last-partition.sh | 31 > > > ++++++++++++++++--- .../files/expand-on-first-boot.service > > > | 1 + testsuite/cibuilder.py | 28 > > > ++++++++++++++--- 12 files changed, 80 insertions(+), 9 > > > deletions(-) create mode 100644 > > > meta-isar/scripts/lib/wic/canned-wks/expand-padding.wks.inc create > > > mode 100644 > > > meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-btrfs.wks rename > > > meta/recipes-support/expand-on-first-boot/{expand-on-first-boot_1.3.bb > > > => expand-on-first-boot_1.4.bb} (100%) > > Hello Henning, > > > > This patchset look really good, but still fails on arm-bookworm > > startvm test of > > our fast CI. The issue can be reproduced by just building > > qemuarm-bookworm target with bitbake (even outside testsuite) and > > then execute VmBootTestFast.test_arm_bookworm test case. > > I saw that when i ran ilbers CI once. Was hoping it to be unrelated > and maybe a known issue. But if you confirm that these patches > introduced it, i will have a look Found it, reason is that i added test code which expects resize traces in logs when a target used a specific WKS_FILE. Now that qemuarm-bookworm has IMAGE_FSTYPES="ext4 wic" And the CI test does test [0] so it does test ext4 and not wic, in which case we really can not find resize traces. That was all kind of introduced by 8b17d91cc758d173aca9d97961208a17a95f71a2 I will change that last commit to also check IMAGE_FSTYPES and match [0] to be wic Henning > > So my proposal is to apply revert expand commit now without waiting > > for this patchset to be ready. > > Sure. The "revert" patch is important. This stuff can wait. > > Henning > >