From: Henning Schild <henning.schild@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH v7 1/6] expand-on-first-boot: really only do that once, especially on failure
Date: Fri, 23 Dec 2022 09:55:24 +0100 [thread overview]
Message-ID: <20221223085529.8835-2-henning.schild@siemens.com> (raw)
In-Reply-To: <20221223085529.8835-1-henning.schild@siemens.com>
We do hope the expand will work but we also know very well that it can
fail. The script is written in a way that currently only supports one
try. And not a retry if it failed in an earlier boot.
So make sure to disable the service also on failure.
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
.../expand-on-first-boot/files/expand-on-first-boot.service | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
index fda50016e9fe..90c92a396b27 100644
--- a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
+++ b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
@@ -15,6 +15,7 @@ ConditionPathIsReadWrite=/etc
Type=oneshot
ExecStart=/usr/share/expand-on-first-boot/expand-last-partition.sh
ExecStartPost=-/bin/systemctl disable expand-on-first-boot.service
+ExecStopPost=-/bin/systemctl disable expand-on-first-boot.service
[Install]
WantedBy=sysinit.target
--
2.38.2
next prev parent reply other threads:[~2022-12-23 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 8:55 [PATCH v7 0/6] expand-on-first-boot btrfs and CI testing Henning Schild
2022-12-23 8:55 ` Henning Schild [this message]
2022-12-23 8:55 ` [PATCH v7 2/6] expand-on-first-boot: support resizing a btrfs Henning Schild
2022-12-23 8:55 ` [PATCH v7 3/6] meta-isar: introduce an example to use btrfs Henning Schild
2022-12-23 8:55 ` [PATCH v7 4/6] CI: improve cibuilder readability Henning Schild
2022-12-23 8:55 ` [PATCH v7 5/6] meta-isar: install expand-on-first-boot in most images and add space Henning Schild
2022-12-23 15:43 ` Roberto A. Foglietta
2022-12-23 19:11 ` Roberto A. Foglietta
2022-12-23 8:55 ` [PATCH v7 6/6] CI: expect a message about filesystem resize vom expand script Henning Schild
2022-12-23 9:07 ` [PATCH v7 0/6] expand-on-first-boot btrfs and CI testing Henning Schild
2022-12-30 19:18 ` Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221223085529.8835-2-henning.schild@siemens.com \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox