From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184069459095584768 X-Received: by 2002:a05:651c:210a:b0:27f:acc9:feba with SMTP id a10-20020a05651c210a00b0027facc9febamr1748637ljq.105.1672771922683; Tue, 03 Jan 2023 10:52:02 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4e8a:0:b0:4c8:8384:83f3 with SMTP id o10-20020ac24e8a000000b004c8838483f3ls1834565lfr.3.-pod-prod-gmail; Tue, 03 Jan 2023 10:52:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXtW8xRFNTIMO6NViU1hE0HEA7MLYwFIN1xRbsDqObdgpg2OfYi4wEcYMWiJ8SaNZ38gRl/f X-Received: by 2002:a05:6512:3d9f:b0:4a4:68b7:f878 with SMTP id k31-20020a0565123d9f00b004a468b7f878mr18837108lfv.28.1672771921478; Tue, 03 Jan 2023 10:52:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1672771921; cv=pass; d=google.com; s=arc-20160816; b=DtrelwhN9sL3pLL/aLPmvFFUx2OQKRqlJMckocJk1SmGfrdV5uNQhCapex85BRlOLQ cChaipJU7c+8FhjbaQWctabg0mwIXMSqFt8Z2yJYpDyOHppcdBjsQrKgYXQsX0bYyjpW fLsW1XXn5QeFnU8sfbglJezg3BKVA8a87w8jzWGQDsmF/D01eQBnoOnRtMGc9Zk9DvXP vOJCvkG+7jBJm/uAKvQ9Ja0tHGzTfZgqfj2+PWCTFFwQoDKOBOgPn9ix6FByT7dvrusi nenUlJXIymLilkDtAf+7yS/FG+ZEnHgB2EhYoJM97z1jJRptJZbcjFLKAIY3TWkI8diN bOGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=R2cUhzW28P/Pqj/3Oi2ANZUgKY7HkjKvSpbB7bMNX78=; b=dEMXR+jAtdJl4Nd8rsAKUgMjwJI0kSgHySMWufMLoZN9ux7Tg+/oLZz7pach5PE04k xR+yJHTcNbmYhmrIKHssWA47nJb620YM9kHqfms48gt9VwZopE4ydcHNF295SHKGxP8P csM7/hCbbWFNKoEwRT2dQbOBJNJhzVaLhP5gPKONiHH8zlkCsXCgkO/X5docKxbs7dNJ lc8ceYfLLJqJilgQPqSYoDAN5WYa8RWr1HfN18VhGFaU0/tpMopyxQm4kUNxwOnGSKM+ K0cAQ1E+P32ICq0bpOK8M+r6D7k5qRKCfp3TQtpfZPtYL4O9/2VHPEmumI1gUmcikUr4 GtiQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=y7FbdJSu; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.80 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2080.outbound.protection.outlook.com. [40.107.20.80]) by gmr-mx.google.com with ESMTPS id o22-20020a05651205d600b004b5767257ecsi1205492lfo.8.2023.01.03.10.52.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2023 10:52:01 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.80 as permitted sender) client-ip=40.107.20.80; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=y7FbdJSu; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.80 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SLD/D+CY0N6dywQljXqlU8lOjx4PaYuSx7yHBFDmgZVvEEAhbxBIWjiulVz+cGvvZ0Z8WcyodBO2Bzce5q24z9s2E/UW9duADmqCAtUtp4B9he2kY9n6vUZgr2xezAOsRBagbLn1wxDklQmDHXbvqm9iJET5vcclkjQdCUSNVJtLzVW9SuANIPHvAidx/au0p1h7KSOQUZ4fAO4Lpdo/4oCzsAUGvdjKdHPHQ7gGsN9K+qQhMN69uqp2KjO6eJO2x2f+HzPr3JtJLXHSKRKMhPTkBifJFwaqi7dtV9rMc3KMcU5b2J89PIu+0FKVZyE/SmPgsckpoNd8/uLaNcrZiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R2cUhzW28P/Pqj/3Oi2ANZUgKY7HkjKvSpbB7bMNX78=; b=bIdbJuJRz46U84J6Bezk2oy1G9VJg3dstPs0adGSsqxlJqnEm3uFx2Li3ReBzWDnDvIKrTjp+m7qE4T9QfL5U4ZzIrh5tsBogKhh+czC3gvH87cbj9K2aibBC4ZwTPHJxrePD0NqlMLnk9H82cNUCQ6Un7nVQ7gy+6HhaXxUCLxPiXanBfaVhNZZAmUYKtAjIS5nu6HgJkffJ4CUrnUFgQXwx5jlJ6odv8fbdglXJljpT152jBq724lwojOBpV8jRRkYrc6HTPOIGpTSzVj25M5aSx61QYRTBOZBkAd5Z3cmw0WIQu8sRTOU/zWhDpHMcxwZPxq1idbNcaQysS4nPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R2cUhzW28P/Pqj/3Oi2ANZUgKY7HkjKvSpbB7bMNX78=; b=y7FbdJSut2IKoF7CwKnBW6UCsUZRI/JN2+q6wRzOFNtUpMjULMd5CwEl21V3/Pv6Wpvdsnm7pHWjWOn1MyPzcnOYELcaO4fSjOB4g/dEESMbDUayTdhgmt/UXzlysu0Z8+qrpzwA9lyQziQ7IsXP4P9NYslYfRIUDcjccNmctAW8AkNAoJB1i01p8StfRkPA1vYICONeqeqf8q5ddZBSJpdR1E1ueftMthm4A78yyFC/IAx1CromlytECiEaNGByUaRgF7cYciJAvQ+CYUtFA2HHvbopVMos8EC/Aip7sJSouNwRDm/EamVIU0jsIG/PAhWApgxL7bDsLeLfVxGvWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by PAVPR10MB7380.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:31f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 18:51:59 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 18:51:59 +0000 Date: Tue, 3 Jan 2023 19:51:56 +0100 From: Henning Schild To: Jan Kiszka Cc: venkata.pyla@toshiba-tsip.com, isar-users@googlegroups.com, amikan@ilbers.de, kazuhiro3.hayashi@toshiba.co.jp, dinesh.kumar@toshiba-tsip.com Subject: Re: [PATCH] image.bbclass: fix non-reproducible file time-stamps inside rootfs image Message-ID: <20230103195156.4e5d49d5@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20230102145828.32763-1-venkata.pyla@toshiba-tsip.com> <20230102174418.686715cf@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::17) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|PAVPR10MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: 7380d025-84a8-4089-fe36-08daedbb9817 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ess9HKPW7Z+vwgkv+gT2jicgV2VJP0Fti4X8QhvCSlRstlvdwQ3jWgLlqZeVtzqQjIVtErGzvmV7EWftqCppmnOXTWlEoBMbBUV4A6FlFWxneZixq/8cLm1U16oPn5D7SyDLJET0c7ub+Z4ZxSOcVUwg/iqI1/WYsOrTLvi/8uSZQ9l37IVQ4GUgpQdLFOhExkIno3hh+P+nL9nUcwTeuJXnYLpSTV9NmorgeI+vKFJCSPY4H7KwlgcbCRFvZ9QJe9BI2sh95cw9X6Y+D8CnQopSUxtdmyL3qQPpaEo+YtykGJN+9H9CTJPbclK1GteP+VJGZmoPAwIpGX+zudbzdCuDG1tYu0CaB7TzAJ8lFTubBRg+InbX79ULs5c2nDFznmQoELpXSGwgFk6j5ATRatnk9jvxeJkwJXpGEAQyrBswS/jgsWeh9y15MTQabUd8CGXKeen60Z6A1LY+ht+V6g0S1dEo7Vvd/8C11R4ykjJw7tlywHbDCvIT8VKUQKyGb4xCv1h+sUia//6x3lFG1F5S3leHIMb4iCzkH2WO/X5cPumdczLD4IFi7+/TBen1tBMnH56YV/ttGY0sRKo3ykcXSJpS2Pd0rnMDGUr7Ct0hjfpjQdwvqPn77RfMtQGMZmMQRcjOhoEWI5PAgMJHNtG433zPcPMvsx8NVesJqy3UZhXNwHfJ8GCi5zKyhZp3d3Wy3++6zzizc3UUpPgY2sykKJ+UFn1is3HrUcr2kQs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199015)(38100700002)(86362001)(82960400001)(316002)(6636002)(26005)(6512007)(186003)(66946007)(1076003)(6666004)(9686003)(66556008)(966005)(44832011)(6506007)(8676002)(2906002)(478600001)(41300700001)(4326008)(66476007)(6486002)(6862004)(8936002)(83380400001)(5660300002)(53546011)(22166006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ofWKU1Qod5i3kAMYJz0V5R7tAGNfGwvOmVyqgjUjerS9Ym1N8ConTz3Wq6m+?= =?us-ascii?Q?naZ52Tt4pWMRmDGryJ83SlaMzd7aBA43QrixXRBcv5w5ia7yysbr/TDwEjj1?= =?us-ascii?Q?bMoOAm011KT7Jf+jcrsDLcCzdCVUL0izIdr87AMVDIciel2lIFz2h2MxdPwb?= =?us-ascii?Q?vBceXStGe5axGeSHjKheqHhhGyVH7cm8DJ3lWYudJ5To0MWWZixGynCrX+K8?= =?us-ascii?Q?MB0G+IM9WW095em2CgVbmpd/T++r/kuxzI+Z4cedHpIBZv5xYxda/UoAe8z/?= =?us-ascii?Q?jLmqO5NI0ToKer7V60Rzw6ECA8Eca3gLbmKH0rvyzaj4zOrXg4W9qgjXQJod?= =?us-ascii?Q?awXuNAbneBbuU2szeBmPLXbpzeqZhUvfDO+2i17GVxUUskBfMNcR7QZTadHw?= =?us-ascii?Q?bvu/R9r/ZiVFT7b/p7QB+x+LEdJH5oyXkud9qoB+n9Ogj6Fq8FleIpG3uYod?= =?us-ascii?Q?jeVkg4TYND+G/op0prPZXEe/Q2mN/tEiegsirccdy7cWLVErRplvoTgAMfGb?= =?us-ascii?Q?vZEI4alClpw70JT5dhXpqR6lNrSvq4fETVDsUjp/FUq6z+l3eOlK2HLR5Zk6?= =?us-ascii?Q?pjhmpkH8S/4ozP3uThh/57p+9qjoAuO0jq+Osoa7/fu4EPmksBcj0mtbTr7t?= =?us-ascii?Q?BLjTGuxupIiYBSg+dzlf76h29elklPQyNeD7yoTAMH+TnEDsP5mV/GAOSteo?= =?us-ascii?Q?px0y5wlIWuOw+jJSJEBJZiilp14kknM1LjHYOOcKxv/dABth7nw6kvkjmZe5?= =?us-ascii?Q?LM/EGUkcSJ6K/n4+kLuqlC1XxKdF5cYngZlAV0AEvHLl39amnVZJtE5FrCum?= =?us-ascii?Q?IHfwb3HUSWqJxR7f39Nx8CyrYrJ6WAgsj5Vhnv2CoYuNIXO2wYJZqAW1qC/R?= =?us-ascii?Q?UPTz+rV4BPQqeRsEkHJZe1e22Y74V2Evto1A8SgIxuOqmTeSIXZABD1z916w?= =?us-ascii?Q?bUrW+BJjwkPJGwUPnM7OmqFFUhL3zwLwnaXlnrV/FbKngoqMiSnWdCslX0zr?= =?us-ascii?Q?sSB9GCzynNoInCDyaG3sqRDFfGM5BmsfYWwjzZj86SRMHX/1kOVWsuJgGclZ?= =?us-ascii?Q?n6ottRHPHRaK5Rj4I31rcmUFEUHUTcEh7W4Q/SYuGiGU9ulq95I+AXTwyt5y?= =?us-ascii?Q?PoiBUDuq14su3Zq4X2lfa6a33yKk1g/XVK/6J421q4j1AGJTH7VE+d0t6k81?= =?us-ascii?Q?OtSIxmtWde7AkfOUbR9EL8aNPdfD9i2A8fcWfD08iMNx4I9XADBIndJSRnFj?= =?us-ascii?Q?vHkPsQxa6jlVnTPqHTtArg8nmXqQYrOZ6WlXnUaTAD5gd2opRvJCeCiwJn/1?= =?us-ascii?Q?Q1H4O3b3xSPbKp0V49x9u1f0Fm1z+V63jE5DLYQMiUGF9RuuifkFv9iBWd3P?= =?us-ascii?Q?/bkNrCQXUIu7ldJjw8A6psDKk7lMiZ9rwo3qEv6DFuK1u+aYJMaOyq39ItZJ?= =?us-ascii?Q?KPmhNlI3sxl0GAs20uHTnJOjuCNQCt9OUjd7auLfdw0s2310AMqJHn850vNq?= =?us-ascii?Q?+BuwbfYsxsh6HyOt7q/1SMBYPUUseOzo819Hh3W3dwI3tAku74ES0ni8mu53?= =?us-ascii?Q?jeYNFdshvY2ezWJwqI3+16HCPUmL3SgWsKd6CvIcdaoJKkIWS/TXqJzgVh/j?= =?us-ascii?Q?rQ=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7380d025-84a8-4089-fe36-08daedbb9817 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 18:51:59.3972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tRdzlNZnQskiFHXypMuqp5Yah+Afd3s5hM9YdPvq/V/KrhjFzVCpOnrK3mBBfZCB+twWq1HAcDGrIqeUVicr4olbTJ1IPSq8UxsUEFJVMXI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR10MB7380 X-TUID: g8yWxVR1Mzvq Am Tue, 3 Jan 2023 09:05:53 +0100 schrieb Jan Kiszka : > On 02.01.23 17:44, Henning Schild wrote: > > Am Mon, 2 Jan 2023 20:28:28 +0530 > > schrieb venkata.pyla@toshiba-tsip.com: > > > >> From: venkata pyla > >> > >> As part of reproducible-build work, the rootfs images generated on > >> same source should be identical between two builds. > >> > >> In this commit it tries to solve one of the non-reproducible > >> problem i.e. the rootfs file time-stamps generated during build > >> time are not reproducible, it uses one of the solution provided in > >> the debian live-build image project (refer [1]), it fixes by > >> finding all the files/folders that are gernerated newly and set > >> the time-stamp provided by `SOURCE_DATE_EPOCH` environment > >> variable. > >> > >> [1] > >> https://salsa.debian.org/live-team/live-build/-/merge_requests/218 > >> > >> Signed-off-by: venkata pyla > >> --- > >> meta/classes/image.bbclass | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/meta/classes/image.bbclass > >> b/meta/classes/image.bbclass index 813e1f3..f592a12 100644 > >> --- a/meta/classes/image.bbclass > >> +++ b/meta/classes/image.bbclass > >> @@ -430,6 +430,15 @@ do_rootfs_finalize() { > >> "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list" > >> > >> rm -f "${ROOTFSDIR}/etc/apt/sources-list" > >> + > >> + # Set same time-stamps to the newly generated file/folders > >> in the > >> + # rootfs image for the purpose of reproducible builds. > >> + test ! -z "${SOURCE_DATE_EPOCH}" && \ > >> + find ${ROOTFSDIR} -newermt \ > >> + "$(date -d@${SOURCE_DATE_EPOCH} '+%Y-%m-%d > >> %H:%M:%S')" \ > >> + -printf "%y %p\n" \ > >> + -exec touch '{}' -h -d@${SOURCE_DATE_EPOCH} ';' > >> + > > > > This looks like i have seen it before. For me that is _way_ too > > generic and something that is not a package touches files all over > > the place. If some package now wants to intentionally bring a file > > that is from a far away future? > > Then debian-live would have the same problem - I don't think following > that pattern is a bad idea as we are not alone. debian-live is a closed quality thing with likely very little hacks that do not come from packages. So ... kind of ... is isar core. But in the layers we do not really know what people do. Note that this code should somehow be colocated with do_rootfs_quality_check where we already check how people messed around in postproc based on time of files. And i still vote that we bring it as bbwarn only, telling people that a file is causing issues with repro build. And maybe a list of files that people have to append to to have them touched ... not touch everything we find by default. Henning > Jan >