Re: [PATCH] dpkg class sbuild allows extra arguments by vars

[Henning Schild <henning.schild@siemens.com>]

Again can you please send you patches in a way that they can actually
be reviewed in a mail based workflow.

You have conducted reviews yourself already so you should know how
things should work.

Am Tue, 3 Jan 2023 20:58:15 +0100
schrieb "Roberto A. Foglietta" <roberto.foglietta@gmail.com>:

> Hi all,
> 
> Sometimes it is necessary to add some extra commands or arguments to
> sbuild but create a class into an upper layer just for this breaks
> the updates. So, this patch allows setting extra parameters through
> two variables.
> 
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
>  meta/classes/dpkg.bbclass | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> https://github.com/ilbers/isar/commit/7e72921747aedf588af492be95fb0b91ad70f455

I can not reply to that nor to a specific line in the attachment. So
this can not be reviewed ... and therefore not approved.

I would have comments on this one that would likely require you to send
a v2. But i will just say NACK, because you deny the review again after
being asked countless times to send your patches in a proper way.

Henning