From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184517929381134336 X-Received: by 2002:a05:651c:112:b0:27f:bdc0:f0be with SMTP id a18-20020a05651c011200b0027fbdc0f0bemr1621368ljb.395.1672777583262; Tue, 03 Jan 2023 12:26:23 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:10d1:b0:27f:d549:611b with SMTP id l17-20020a05651c10d100b0027fd549611bls1740393ljn.9.-pod-prod-gmail; Tue, 03 Jan 2023 12:26:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXuT6XHd1mQdANTazUivuhu2FuHUgltljsz4VKsWZVdwJzg5AsZjQhhN9ACyQRsvhTCc45FG X-Received: by 2002:a2e:a26d:0:b0:27f:bbaf:2a11 with SMTP id k13-20020a2ea26d000000b0027fbbaf2a11mr8382780ljm.37.1672777581942; Tue, 03 Jan 2023 12:26:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1672777581; cv=pass; d=google.com; s=arc-20160816; b=Zp5qfgUsZgXbgyJw+8NrUFQD0otFHCKTq7TxeG9KaorJKuBzm3J/GL0rmmCGg91jMD qexnazvtCMKLbhb2khlCfim5opsKOLtDpGxJdsQtkufK7pYlhFtrdMbVLeOtNYfQSNZn 0HDavNiYVT/cC9iRxYYsH6f42SrFWb2dPxC8m8wN0qj7uMH+BDjQv1Wjgay1nZfKO970 9fJBeaREyac7R1ASE15UiwcHKrK5cODNCTlWoZUTXMmKyZyLBWH3xcF/qBomc4ASzPgN 0cJZajhnJczXc6n6uT5G0aYbYX1CwuD1Ii9yhZpx943SsnnV99HlJqYJF7IlsHSuUUn8 cuMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=6rod6ajnuCDkQePZPNQ/Pgtf1oKdGwuQwDfDy5m7P3k=; b=YcaybMwGGampcBmwjYgzVwb6CU3JHx9L1MnhUPYtHi7bTnOOvZG5+6nXXUGddkxyJv LX8RHROG8mY8XG1MF6k1Bl9IIFKfilu4E7FPGcz4tk+K4Tni7b0VL1Ngt5AzJO7yWB7C rfx/8TSWrG3iPQ3MUlO0cQT2ygvSIZv7NclFEUgSWnVPHU4tBJbV7Rbd8xjqlvBGVoHt XuSbIiMLIYNVUWDJ/zIsuPW95nSoxtRIvct2l3fLI8vMYw26uJ/Titay0L300fBNMyUE is3GKbEPR9JV1p3GESvCInd7AzFM0t1M4KC83pB+ACuwt2Y3NaqjSy17KMu/WR+UcLG9 IIWA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=GFeEJu++; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.50 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com. [40.107.20.50]) by gmr-mx.google.com with ESMTPS id 17-20020a2eb951000000b0027fbb68e1a8si907827ljs.2.2023.01.03.12.26.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2023 12:26:21 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.50 as permitted sender) client-ip=40.107.20.50; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=GFeEJu++; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.50 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/dK5lWxkSbnoSTyvwevW3oP5CfZjgHQBSkoxAnRx0Akv5RTFq3cw9iXuAF/+Ch3pVPQl5+hK61RRV9KvJGHKpIqz7GoziL4QjiOprzITw6ermCOQAEs1nh4g0LEij8U+tHy0WUdLkxheez5x9455aV8OAO6SHD1ZvqKl3EqWI8qVaxUCgbGN4mAmHTgQfHu5G6N7AJgPbJrz583rwxPN/lkwOgrQ3+RqSv664Og1zeu9hJU2sqO0EAS6TGPRve842Jwa7mSwS+AH5JhVb9s5YZekSWe0WQa6xA3LcDyv84pKpQ31S/MHMhwRK2v8a3faYzb54S1zzy8kRxGlNZWxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6rod6ajnuCDkQePZPNQ/Pgtf1oKdGwuQwDfDy5m7P3k=; b=NMesjWLSWWYDsdcue0y5xWA3HgBBgUBVHnl+YpQlB/7biZz+pui25OoobWyfJ6cFrZLrq8JZC2oUskqKrSxB9dQcSrWefEzn3vFivuRrzLK7ij5Y+wwleLaUxZ0Dsdirwhn4DHMBVU0QEpuu7cwFqgwe8VtXJdvWcHKQxk+cRkUikUyLWqAMdjGIz1x76wacmAC4KXux4EVvtAgjFQZLX2PraoOVW/zRlO9VcioVxcz80m9B53KYIODthQ9Wz2cYnL9GVyZD/Jk5n3XsDGONl74GYZMtJaVw5okg9nZvW9KHftXSKMd5dlGbc8xZ9QQDYybPf693AzrDaqsJDOl0Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6rod6ajnuCDkQePZPNQ/Pgtf1oKdGwuQwDfDy5m7P3k=; b=GFeEJu++F/zJ0X/BNDpC/TSvZ/SNRaKPk4CNjH4wFR9IF2tXGUWc8Hv6DjhbQQkXq52gt62Z4iBj7ecg5O76wxoRsl0Nn+lcyEF68aaOILHvPB9MJ7wWPxz+V1yR1LUSwhndWbW5govYS3GWLbRiC+4zRG8uBvtmfvRaTfYh+93WJywtV6j1HSYP8rPQERLEPZoYrhemrFoLi9mK4hv/eLBvyTfFhq+oR8ereJGZbm0xf5Hup6/8aTtzEjYMEtNGAmlqiYsoQcg6Ux87m0F/DmppnhSpdpca2RhLo4PfS/negD32Pn3S4S/kh5Ga24WM93OdLPgyipMT9KaFfrRU1g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AM7PR10MB3350.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:10c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 20:26:20 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 20:26:20 +0000 Date: Tue, 3 Jan 2023 21:26:15 +0100 From: Henning Schild To: "Roberto A. Foglietta" Cc: isar-users@googlegroups.com Subject: Re: [PATCH] dpkg class sbuild allows extra arguments by vars Message-ID: <20230103212615.66dec94c@md1za8fc.ad001.siemens.net> In-Reply-To: References: X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::11) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AM7PR10MB3350:EE_ X-MS-Office365-Filtering-Correlation-Id: 7206eb26-4f34-4838-5ff1-08daedc8c62b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3l5pz2sOEejPSCIrTo3NxR/NMmugFftjGoTtrKac0LDSuQQe5QvsWKfuJK2nIv1kl+/W1hmHzK5sR0A3o0nR586vdpOC2I7FRz89oq2np9TxlxM+xEfglDGfq4cNHacTHBEIZ0GHkqOgmqO0fxyAoio6PWFbVIshyEce49eO+ndz22gknYAoiJ0+sKedCNc0iRNoN3jlZ3KaAC7Lu6ILkuMHyjJBCUTzAeO80VsbJl5bHS1plioOTZLN9Bk23ev24oxSXKaBgr1sLHVqoGoe1W2T9Q8e0rZgll9AtnJcRQCU3JSFIMcON33i8sz0OgondRfCHV7J23RY1jmeUbjrDdvULn9nTMnejULpVPe05v4KtcpMMmnGurHG6OdPb8s7wgrztQT/ALunS94vmZcubgI/CVGtMxBPW004B/oSC8wk7Yn9noLgt7YwB1qcQ4g2w+Guq4DPPfgwAZue/uoaxjcMFTMfwMWdsmHR4M4zig02Wa7HgVFsY7NzCb7Azh7AAQ7NwrZXw5+EahIvY7cBdzhJhiiP3yeTioUCwlncr/G6LTtvgmKBOWtYUnH+KmBBjqcnLi032/1JRD+ofbaJWUMhCgitiZSgNWPdnTbQB00UFB+4W0eztnoFUBlpwOxxe+LNAv8NDFXARjpCzKSghQiQRHO1gY0+YDmRxAPw1nB+XiYzc+kncGWo9E6k4OyE6HhJbkCTETALJDaON9yWN8bo3B3wbhpo5rTeVVgGP+4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(451199015)(83380400001)(86362001)(82960400001)(5660300002)(8936002)(38100700002)(2906002)(44832011)(41300700001)(6666004)(478600001)(6506007)(4326008)(8676002)(1076003)(6512007)(316002)(186003)(9686003)(66476007)(6916009)(66556008)(6486002)(966005)(66946007)(22166006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lzWQsd7FSlRZMUQnwDrDRl+PBKFzDLdqpW4dvbR2kIjrD1jrlmKzUf4R0rdv?= =?us-ascii?Q?Vz+JTfoAlapqwqVQykRHsua+2yDFpOCfh8xzak7wxM466CEiVbEG1tAM3w8k?= =?us-ascii?Q?xahU27NyrTLrDkogXEQoKaLxjvR6zYujbMYpt45tAd/lsRkei9U4EEECimSf?= =?us-ascii?Q?VNrb91sf2FyzR7HQDwCVtw+MOBm7+OywMlYDb9AzZnghipydsWz8Wn89LQbw?= =?us-ascii?Q?UDrytzLkiwBV14bFnUarBeLIUO1v3PZjH+7kLO3uCcMxZChNX6w/M9j1mfFV?= =?us-ascii?Q?u0uJ59h1zy/LmfgD5oB3ag/b83PcUt3XXtHxwhELt9jRvq8XkcTmGh2i0R74?= =?us-ascii?Q?XeHRyFqXZt5z+7vpm1U8H+pJCCGYLs8BAyPr65HczsVyfa3wWvtAcE1nwtpi?= =?us-ascii?Q?okPg5WhINPCNEAZkQmwObVObRPD7ZGraCu+tqNJFzbihFK//kxQJzzNf1r5L?= =?us-ascii?Q?JEy9YtR/OsIZ8+h/JKSdUkPoq44EiMFVXeoqZRoK/6EvraeBlxCrPAdFyxK9?= =?us-ascii?Q?UtXu4/M9qHVxF/ilTW2iti3lyV24tcTP9Jsq1E+hGfzxrajrrMNPkqD10rdd?= =?us-ascii?Q?hoAwXbwbxE/Wiiy/RYbiMOGv7L4f9XoDNjdwxfv0+AFPI2EfFgvrpqbqCzue?= =?us-ascii?Q?A4H+UEW6zBcdqbYsDF3SGIBwHyX0OFhDP9wyyKCz/1DILYqxxqzGsc0566Aq?= =?us-ascii?Q?8GBEwwBsGF9jPlD4jHscJmRjs6HfKJYFpGuVNAKp7pwjrKsbpNeu6pU4LzWG?= =?us-ascii?Q?wKs1BzvQLiXMgU1ElPt1tpNGnYmWrRzjmwsiWziot3n9BRgy6PN8LyUtt/8U?= =?us-ascii?Q?fy0lwrfGkLhodgJAor7kJoliHyvVJ1W49NfMscg2C0THUcKKsY5RTGJAUOxr?= =?us-ascii?Q?HP6z/o6zEm6m+WMABKcrbshZbs7e2El2J4lpyjq5VWoaqdBKyDEpkQ52sLVu?= =?us-ascii?Q?4QT5LLKqZx/YJRyulyWHmq9/chuO6s7FtTjmufaoyVXJoaQtap+tnvx+xcCc?= =?us-ascii?Q?fExV9YyRoBVTwzgMwJ+aPRBogDEfbomfzfkOBfQp8uT4jsqGMGz897gkQfH+?= =?us-ascii?Q?dvq0YCrxrwPmIUQMO8XH5JHG9XtXAM5KEUoEpbxtBFG59DC9FHrhxKmH2MVr?= =?us-ascii?Q?xs5Jl3Qb/jjoOu7sNjh8yCxedKEec1nIyB5BzT54avnczwouzZ1MPVqIFOEz?= =?us-ascii?Q?B7+dQylzCpwcAGtanzfZ3bSWBlq5ZqDPP0+Q0O2ftQfltcusXaPkSzCzg6Gd?= =?us-ascii?Q?4xaHemPlfWQ+FsiGj8KKaXGaONbV6J+C+Tvlk53bsTSqVlTXZNbJ4tL9Cdev?= =?us-ascii?Q?fxrFkVEFj+glY6HZ9HJ9lpQhHOWil+uDoflsjv0SvrZ9GbPODLkL4ItSt90y?= =?us-ascii?Q?paLjXZOZUosQcgewY0ZiwhNBWnDmCG13ahRVzRgy7/pirD2YDz6LBnCEcVtL?= =?us-ascii?Q?Tl/2oK1+lA/YycfDJ8YfL/Um8D8HLqTnZ85uGefCImq6MQZYiZaNOSzw5s9U?= =?us-ascii?Q?3hAAIDWBos1qJh4vpyQi6gJLPAbGUuckzflY1Icgb00TuqYt2I3JatYeiSUP?= =?us-ascii?Q?f+R2s9sWREscmh1NjzVQ4eh0OIJMwxRz/vocxicKHWwRgQkpblI1JETU5Q8L?= =?us-ascii?Q?GMKq+GXWPk0vnC3xip55IYRGsVfoe3AHmmCjtliaJRLjUUDiFow71B7VzlPu?= =?us-ascii?Q?LTZMEA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7206eb26-4f34-4838-5ff1-08daedc8c62b X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 20:26:20.1413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b3lO/lh036El91EQ7R7FO/YlHbbE9/xCoxiFLH0Axg5VP52QuR38c2Ktqze0lItskXmnUHpHYgS53srQHlDhzBiBNuOodB8mL/lJSxnnxK8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3350 X-TUID: H0fLO+EXmWQb Again can you please send you patches in a way that they can actually be reviewed in a mail based workflow. You have conducted reviews yourself already so you should know how things should work. Am Tue, 3 Jan 2023 20:58:15 +0100 schrieb "Roberto A. Foglietta" : > Hi all, > > Sometimes it is necessary to add some extra commands or arguments to > sbuild but create a class into an upper layer just for this breaks > the updates. So, this patch allows setting extra parameters through > two variables. > > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/dpkg.bbclass | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > https://github.com/ilbers/isar/commit/7e72921747aedf588af492be95fb0b91ad70f455 I can not reply to that nor to a specific line in the attachment. So this can not be reviewed ... and therefore not approved. I would have comments on this one that would likely require you to send a v2. But i will just say NACK, because you deny the review again after being asked countless times to send your patches in a proper way. Henning