Re: [PATCH v2] rootfs class lock undefined in corner cases fix

[Henning Schild <henning.schild@siemens.com>]

Am Wed,  4 Jan 2023 20:46:46 +0100
schrieb roberto.foglietta@gmail.com:

> From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> 
> rootfs class lock undefined in corner cases fix

Could you go into details of what those corner cases are?

We would obviously all assume that your base is Isar next, in case we
are talking about a fork already on bb2 that might all be a reply to
the bb2 series, or a patch based on top.

> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
>  meta/classes/rootfs.bbclass | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index b3faade..63735d4 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -198,11 +198,14 @@ python do_rootfs_install() {
>          if (d.getVarFlag(cmd, 'isar-apt-lock') or "") ==
> "acquire-before": lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR")
> + "/isar.lock", shared=True)
> +        else:
> +            lock = ""

if we fail to grab that lock for any reason ... are you sure we can
keep going and release the lock only when we got it?

There must be some reason for the lock and not getting it likely means
we should not continue ignoring the problem.

Maybe we rather have to keep looping and trying until we get that lock.

Henning

>  
>          bb.build.exec_func(cmd, d)
>  
>          if (d.getVarFlag(cmd, 'isar-apt-lock') or "") ==
> "release-after":
> -            bb.utils.unlockfile(lock)
> +            if (lock != ""):
> +                bb.utils.unlockfile(lock)
>      progress_reporter.finish()
>  }
>  addtask rootfs_install before do_rootfs_postprocess after do_unpack