From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184872845710721024 X-Received: by 2002:a05:651c:1608:b0:27f:b473:f5c3 with SMTP id f8-20020a05651c160800b0027fb473f5c3mr1679627ljq.180.1672864274742; Wed, 04 Jan 2023 12:31:14 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4e8a:0:b0:4c8:8384:83f3 with SMTP id o10-20020ac24e8a000000b004c8838483f3ls908918lfr.3.-pod-prod-gmail; Wed, 04 Jan 2023 12:31:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXuBmAxtGtjYS/IG51jxfqgFv8aMyvA1cO+xwNFd7SMLOaGCLk+WxH1/zrQXT4X4xZj358cm X-Received: by 2002:ac2:5df2:0:b0:4aa:7821:8021 with SMTP id z18-20020ac25df2000000b004aa78218021mr17039409lfq.34.1672864273397; Wed, 04 Jan 2023 12:31:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1672864273; cv=pass; d=google.com; s=arc-20160816; b=Iwl+3SDiiIc1PMk1Dhvk5mLvSt7kDPDM3uUvcId95MUYntKSHR1oRKkyrmrbBYvZxx ZYUvIOywPuTp9onc6dE5HkAczsh7XAlMGAmJJ+0VS6rMns5v2qbVTIoHvsq4NQhXTbmy urHmVwGTYO35zvm0q1cdcHrcLYLe+vLgLtubBTWn2DIG6Hns2wJgSaogdtwKKZLPEUuz ILBFjesvifmok8gEzrwhKep+VoKPUDDLp4PuJc2POJJgko714bm5WrdHvvFznvfsOEh7 tHdTPCh2EUqWhcZi7yR9a1dU+c267vnNNuAf/95QU/qxCgenWwcbH73flzC78QM9X/Xi n2Lg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=e8usvRnrLSX2i9ibK0pCZia0B+EZDWOeQCT86CoWWvU=; b=gxC0VL3zscpFCo7CL00FPYu4ssavcbMKRrbwjeXYMUfFLuC/1d+AT8x2GhhPfj4Cf9 laFhIga9kJe0n4idi2+rI0jVZp65XUFr+NmlXhSRa8lTsrFlRQxehkbTUKMlE/AhuEow AaHLSK7SfKQAzeMQ3zwRBe5cyf+1f9B5vEXcydtlH4t1Kwv1RGrWCAqsZsb7wFJTtVp7 0r1GYHPSIcr5rwCajBbTLsgPf1Mxg3znQi0V9Ypce8eEyyfY9wt3O0wryvv2yYT5WkXu WqcFSZBpETTKWu7fxRATqSckxwz/tvshHeQMrWBvSrtcEzXgbJglVRB5Wwt+8epj/urc 4VkA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=SHd7e2cE; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.44 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2044.outbound.protection.outlook.com. [40.107.8.44]) by gmr-mx.google.com with ESMTPS id w2-20020a05651234c200b004b49cc7bf6asi1179922lfr.9.2023.01.04.12.31.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2023 12:31:13 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.44 as permitted sender) client-ip=40.107.8.44; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=SHd7e2cE; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.44 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIWNz3UFgWINEPXtGvZtlqZ7DPY2JpP1Xr6drVzw75ffgyUqRaloSSAzVy/Lybufy3dT8R3te155QvBCUjH0OjXDdg66G0hw9M1rK6b3tR3gg3cUELr5Y5iJqdfoecEOlBsyzdiQVM+PZlVepoDdbcraGwV6IisUZcUu8Yhh5Nda+yD1lNZXHyWvWZGf07PsdlUDYmT9suSQG4rMhImLAhG9VBiPlZxC9QwxVnSnrAEHAfsHEWAL0yhOQDaZPQRjU7UuJROTWS6azxlfzW9Cs6Cpog2rUljfJ4SITMWNlN6Aet2HLPxI+JV6IDMHH4UH5xng4AxdqFLpDtAQwiEFsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e8usvRnrLSX2i9ibK0pCZia0B+EZDWOeQCT86CoWWvU=; b=Rmi+ZNWy0JbaOB0zwNJihopp5xTe49mCRhnBY+8xhfp6nfOAoJR7TH3AwnmCzaOxsYXUzxthkxXqDCdjjWX48jNKPXm19XiL81N88cLNZGDcHAVXPqwRCrjJD5OKNN5NttvBoV1JqyWy/EF/Xr+Jzw8Uc2EpIAQ7tSzhpMJYiqA6SHyNSnD1d19B1ZguozrvzBheKUduNOUVkLrsuB54Sm0XLP64eAO+h2hoEeeuZ+EIfyaabrRuuYiwSV8J4RGa93XO38EpzOnTux72fJBs3LMBthSqZsQIC/J5eC6swZinUEeUI2LTWjWoprfHKZTtKBRM4omIgHjcw/DRZlRWgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8usvRnrLSX2i9ibK0pCZia0B+EZDWOeQCT86CoWWvU=; b=SHd7e2cEm+NznTLuzKFMPkt2v+DwImumEC42mC04kw9aYjPvghKiUE1Ej4XjQfCgNxPMjjXPiToD2EEaLHfrXmrWncW1WzU6omzSI/vejiNv7bdA8fx2vbNxGAkRaCuD9s3KC2ZROz1WY4Yyj3lz/imC651UF+IE0JuTO6T4rI8c2sez9j1tbV8SH5qJ7cVpUXt7sCnwURZOgDiIbMm9aQjbJv0TPiB6MHM08WLJtPWiXo+61n8vg+ZAA+fv4BBCgLy9JpMcQfaQsdLsQX5el+dR7jfPsJpfwyshKTDtykIaa3T4VHboZsl+Qoaouj6Dr/+sVxwGlz0+YRiR/Y/GsQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by PRAPR10MB5155.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:27b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 20:31:10 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 20:31:10 +0000 Date: Wed, 4 Jan 2023 21:31:03 +0100 From: Henning Schild To: roberto.foglietta@gmail.com Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2] rootfs class lock undefined in corner cases fix Message-ID: <20230104213103.13ec20d5@md1za8fc.ad001.siemens.net> In-Reply-To: <20230104194646.2545099-1-roberto.foglietta@gmail.com> References: <20230104194646.2545099-1-roberto.foglietta@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0193.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::6) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|PRAPR10MB5155:EE_ X-MS-Office365-Filtering-Correlation-Id: 65c576cc-0107-407e-a8d1-08daee929dc4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LhIoTFPsQ5iBSZPvlkd2pGG3ZXer1+N1bxs3xQuz761IHJq7cxe7RCl0xWY1CatZWApyUxOgj+OPODi/8kEQOCv70vGoiv13lRfb3k/6FiE3k6+9ua9W6oGBaypgBPgVevkxZhuDIC+RDJpWVLis1ixLV8TShfQtK987YBm2qPpP0MvKDhA/sJ2x0QJHmzPioLYbBlXAbgjrB5Cwr8XFzKQBRe7hLS6Xm9emQRlK1DIZNEvGxgEJuCBLrBXLfiDJ/zan6UI2VhzkW2uMet5Ia2Xf0AjaiUiSNQJzfDHpFxZoErfJXlKl9DhPQHhArq8HiVO5QNANkeZQYieiiSOxZT1PI4eg3Jyxw5Vvv/rXH4PVXjbHbrjoKEbtuB0z6tc/tsu+ofBC2su/VuarJn3m/7jIursINgUasPywwc0askpg2Oo4qbw6U0WueoCQvdYLk6zp571ivfYF9suOxplOPHYURIUndJNAg0lSWnG6b7PjeKk78cwTeYiHTZ7vCbfOThNJc9L8V0cvLO3M5Sq3KJZzKhXs2c+93p69Y5Ah3iJ2YLV7vzcXzYWKrMOJWXksU0HintxaDMorQPJ72Wknp+sc5wSYukAuqsCb2s1nd6/pYJYnzxI7ggrEUmucZDv9R4MR9VmfSeiq7tyC67aUQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(451199015)(44832011)(8936002)(5660300002)(66476007)(66946007)(4326008)(8676002)(66556008)(316002)(2906002)(6916009)(41300700001)(6486002)(6666004)(6506007)(1076003)(6512007)(186003)(478600001)(9686003)(83380400001)(86362001)(82960400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XdmY2ynvvdkk29iyum6SjTZbTrzNuPhr/Qp1NIFi8A9W3FwFVnSW/LaRjfar?= =?us-ascii?Q?zy1wTkisciEd6BGQN0d1/aJhr1D9Faxdfy9xgZ5pzIO7hdzaU1HIcO4OIlEy?= =?us-ascii?Q?/3hf4OlvqHpzJzQI2rbuDaNasATwrbjeX7/x1xpudXotelQI5875xIEflhoG?= =?us-ascii?Q?k+kbGa/yJMXkER0V6lvrJ1E1VnzQkXxjy9gBu588Txkyz2Yt4G+nVkZzGOgn?= =?us-ascii?Q?dSbZo7fYvMzeUHDWNcHL2xWP/MKovPnZ6Ux5dMHWmulBdntKXfNvo7XyobpM?= =?us-ascii?Q?F0xaM1yr/gONkDAKos1zjrk52Ct7LPGeeQoHZiYsmEdAYbQfduiRpC/Ftxd5?= =?us-ascii?Q?G7VaOeW6evjNE+mO9w+PFg4jF1/M66uo73aFJ2TVP+PA8Xu0+5fsV5+4D7uf?= =?us-ascii?Q?6IdADuBjXkGc2G7D7pHPTH4kjkDDBylhp8reUiuX1YDJf38csr5qCYlEGAhc?= =?us-ascii?Q?cUfrr5ArTSFN04MoookHO7+yR6m6jthyW5I3ZTmPJX82+Nlr2+2RXeW2wrf8?= =?us-ascii?Q?XB/W6kjNFawWWBVzCBOyrvkTaM4zCAFNj3M0fRRkJylp55J9mmSgzqakhBwn?= =?us-ascii?Q?BWNS1M1dqIrpaXr5Gnod2Adf8Ckfy+Ut/MpnlhGDMOMeJ9zdkv7fxJp+QZ7Y?= =?us-ascii?Q?d3yUA8C0/eWYv8wKgs6n8FoOHMe5ArNdUE11NEX2tbILYPbk3NaE/EcRaQH1?= =?us-ascii?Q?onNP14JJ474IrPnuzcqXouT/7HL14G2GcOl4ey8bm6Y00HfxtUOX1acjeqaA?= =?us-ascii?Q?+HTTSiQzQpFC24nZONPBOAFGo+BUpNvv0PCqSXTfVERKy33C1jNIfQdaAAdx?= =?us-ascii?Q?Stld23Oq1riHdYQcQcYqiWKmrVANSg7/zb6brofRgGsPYqUf27DW6YJeBsiw?= =?us-ascii?Q?IG/G9QvtVbhG1Qbd0ELLQTbZK01F7Adzbl5md6cf+XmLKJt7trI+bT/2V0yI?= =?us-ascii?Q?E/0ac+92NjgEyOPd9+yM5L+aiug6fYzo55oZtKKnU17sbOVL/t6oXHgu7X/z?= =?us-ascii?Q?nABsn7E+HquKuU77cJKGNuvRezYS6nIV4pQ6V+kJynOdv71tToOFNjm0JlN8?= =?us-ascii?Q?4+aoh57ym1v9BXtmM132J2mIWL7gikzTP3YzX9Roeq5PYwoGv+YB4hOWoCqI?= =?us-ascii?Q?q7HxezNsD8dMdyiT9ETsH+X2jMGWMI7zz3K87CYvp/CZhTO5R9I2huuKBuAK?= =?us-ascii?Q?ksy9QFwjxUbf+fXzrSXsidImupWJ/rdhI9UW6IKgMzpl7lS7kA4Gq7RcDNxL?= =?us-ascii?Q?yrbpfJd2KB65HTSG3/c7Xe4ggIBJu7O45fsAuhfgTqKHDuKsSzjR/ZIfCy7v?= =?us-ascii?Q?TnT1OCv+/Rt3aC1/JP/dEyO7ASJGznoQWMhKtlMlc/Mh/n4baHDT0qLHMrvw?= =?us-ascii?Q?mIf9EZVpNkf0R0kQDEb9JXvFsV+GorSgLiUmvKHEtiIlCUgHZzoyoZ250RSB?= =?us-ascii?Q?KHLJQ2h2e35v7loQsZkMxozlMvoXjUl0yix6MgnaXnicGx2cvmsfuvv3KXHS?= =?us-ascii?Q?W0okA+v/dfP9x7SbsIFwAO5C1Wg33Y+u7ffnk8giAckHhiMF4LT+itQ0Xnow?= =?us-ascii?Q?l/zaXnP/+JLThoyPfOx2RoswsREqm65Dn701ixPDVTOBgYnMbmffQFrmJD+7?= =?us-ascii?Q?ayZQne0XG0SUCgs6yXgpXAcB+Jw0V0a7dHrnRBSRcrID8n00JqCL8XK4Yu/n?= =?us-ascii?Q?mItW2A=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65c576cc-0107-407e-a8d1-08daee929dc4 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 20:31:10.7611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jAAtKgSlq1Kkf+Qt3gsRAoW86T4+d+336cbUZI9HUxPxSHQK5uMPel0uCHERa6lquVPFrL7M0AIhzKnoo0jfQc7i2OU+w1pHiWDk0hKg460= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAPR10MB5155 X-TUID: 9saucYrTxyoF Am Wed, 4 Jan 2023 20:46:46 +0100 schrieb roberto.foglietta@gmail.com: > From: "Roberto A. Foglietta" > > rootfs class lock undefined in corner cases fix Could you go into details of what those corner cases are? We would obviously all assume that your base is Isar next, in case we are talking about a fork already on bb2 that might all be a reply to the bb2 series, or a patch based on top. > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/rootfs.bbclass | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index b3faade..63735d4 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -198,11 +198,14 @@ python do_rootfs_install() { > if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == > "acquire-before": lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") > + "/isar.lock", shared=True) > + else: > + lock = "" if we fail to grab that lock for any reason ... are you sure we can keep going and release the lock only when we got it? There must be some reason for the lock and not getting it likely means we should not continue ignoring the problem. Maybe we rather have to keep looping and trying until we get that lock. Henning > > bb.build.exec_func(cmd, d) > > if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == > "release-after": > - bb.utils.unlockfile(lock) > + if (lock != ""): > + bb.utils.unlockfile(lock) > progress_reporter.finish() > } > addtask rootfs_install before do_rootfs_postprocess after do_unpack