public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH] Get back to gbp buildpackage command to prepare gbp source
Date: Thu,  5 Jan 2023 07:07:57 +0100	[thread overview]
Message-ID: <20230105060757.2918-1-ubely@ilbers.de> (raw)

With removing stretch support we switched to `gbp export-orig` command
instead of `gbp buildpackage --git-ignore-new --git-builder=/bin/true`
one, since gbp versions in >= buster support this.

Unfortunately, this change makes other downstream layers change their
`GBP_EXTRA_OPTIONS` values in multiple recipes, e.g.:

`--git-(no-)pristine-tar` => `--(no-)pristine-tar`
`--git-upstream-branch=master` => `--upstream-branch=master`.

This creates too much inconvenience - we need to mention it in
RECIPE-API-CHANGELOG, use a different variable for `export-orig`
options, warn user if they still use old variable and, finally,
support both vars in Isar until all downstreams stop using old case.

It is not worth implementing all this stuff just for switching from
long 'buildpackage ...' to shorter 'export-orig ...' gbp subcommand

So, it's better to just revert a piece of "stretch removal" patch.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/classes/dpkg-gbp.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/dpkg-gbp.bbclass b/meta/classes/dpkg-gbp.bbclass
index f765eb9a..b1d7b240 100644
--- a/meta/classes/dpkg-gbp.bbclass
+++ b/meta/classes/dpkg-gbp.bbclass
@@ -9,13 +9,13 @@ S = "${WORKDIR}/git"
 
 PATCHTOOL ?= "git"
 
-GBP_EXTRA_OPTIONS ?= "--pristine-tar"
+GBP_EXTRA_OPTIONS ?= "--git-pristine-tar"
 
 SCHROOT_MOUNTS = "${WORKDIR}:${PP} ${GITDIR}:/home/.git-downloads"
 
 dpkg_runbuild_prepend() {
     sh -c "
         cd ${WORKDIR}/${PPS}
-        gbp export-orig ${GBP_EXTRA_OPTIONS}
+        gbp buildpackage --git-ignore-new --git-builder=/bin/true ${GBP_EXTRA_OPTIONS}
     "
 }
-- 
2.20.1

This replaces `Use GBP_EXPORT_ORIG_OPTIONS for dpg-gbp export command`
by switching to previous `gbp buildpackage` functionality.



             reply	other threads:[~2023-01-05  6:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05  6:07 Uladzimir Bely [this message]
2023-01-05 11:27 ` Henning Schild
2023-01-06 12:20   ` Uladzimir Bely
2023-01-11  5:20 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230105060757.2918-1-ubely@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox