* [PATCH] fix rebuild of rootfs_finalize task
@ 2023-01-06 10:05 Felix Moessbauer
2023-01-06 17:56 ` Roberto A. Foglietta
2023-01-06 18:03 ` Henning Schild
0 siblings, 2 replies; 3+ messages in thread
From: Felix Moessbauer @ 2023-01-06 10:05 UTC (permalink / raw)
To: isar-users
Cc: venkata.pyla, amikan, jan.kiszka, kazuhiro3.hayashi,
dinesh.kumar, henning.schild, Felix Moessbauer
The rootfs_finalize task currently cannot be re-executed, as it moves
the sources-list into bootstrap.list. As this only has to be done once,
it is not required on subsequent executions. To fix the rebuild issue,
we simply ignore the return code of the mv statement.
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
meta/classes/image.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 629a0c1..6f0607e 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -425,7 +425,7 @@ do_rootfs_finalize() {
rm -f "${ROOTFSDIR}/etc/apt/apt.conf.d/50isar"
mv "${ROOTFSDIR}/etc/apt/sources-list" \
- "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list"
+ "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list" || true
rm -f "${ROOTFSDIR}/etc/apt/sources-list"
EOSUDO
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fix rebuild of rootfs_finalize task
2023-01-06 10:05 [PATCH] fix rebuild of rootfs_finalize task Felix Moessbauer
@ 2023-01-06 17:56 ` Roberto A. Foglietta
2023-01-06 18:03 ` Henning Schild
1 sibling, 0 replies; 3+ messages in thread
From: Roberto A. Foglietta @ 2023-01-06 17:56 UTC (permalink / raw)
To: Felix Moessbauer
Cc: isar-users, venkata.pyla, amikan, jan.kiszka, kazuhiro3.hayashi,
dinesh.kumar, henning.schild
On Fri, 6 Jan 2023 at 11:05, Felix Moessbauer
<felix.moessbauer@siemens.com> wrote:
>
> The rootfs_finalize task currently cannot be re-executed, as it moves
> the sources-list into bootstrap.list. As this only has to be done once,
> it is not required on subsequent executions. To fix the rebuild issue,
> we simply ignore the return code of the mv statement.
Please consider the patches (one of the two at maintainers choice):
image: make sure do_rootfs_finalize can run multiple times, v3
image: make sure do_rootfs_finalize can run multiple times, v2
Best Regards, R-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix rebuild of rootfs_finalize task
2023-01-06 10:05 [PATCH] fix rebuild of rootfs_finalize task Felix Moessbauer
2023-01-06 17:56 ` Roberto A. Foglietta
@ 2023-01-06 18:03 ` Henning Schild
1 sibling, 0 replies; 3+ messages in thread
From: Henning Schild @ 2023-01-06 18:03 UTC (permalink / raw)
To: Felix Moessbauer
Cc: isar-users, venkata.pyla, amikan, jan.kiszka, kazuhiro3.hayashi,
dinesh.kumar
ACK, forget why i wrote this is nicer.
Henning
Am Fri, 6 Jan 2023 10:05:25 +0000
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> The rootfs_finalize task currently cannot be re-executed, as it moves
> the sources-list into bootstrap.list. As this only has to be done
> once, it is not required on subsequent executions. To fix the rebuild
> issue, we simply ignore the return code of the mv statement.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> meta/classes/image.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 629a0c1..6f0607e 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -425,7 +425,7 @@ do_rootfs_finalize() {
> rm -f "${ROOTFSDIR}/etc/apt/apt.conf.d/50isar"
>
> mv "${ROOTFSDIR}/etc/apt/sources-list" \
> - "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list"
> + "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list" ||
> true
> rm -f "${ROOTFSDIR}/etc/apt/sources-list"
> EOSUDO
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-06 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 10:05 [PATCH] fix rebuild of rootfs_finalize task Felix Moessbauer
2023-01-06 17:56 ` Roberto A. Foglietta
2023-01-06 18:03 ` Henning Schild
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox