From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7186516587736727552 X-Received: by 2002:a2e:b814:0:b0:27f:ef45:ee14 with SMTP id u20-20020a2eb814000000b0027fef45ee14mr2238907ljo.434.1673256339839; Mon, 09 Jan 2023 01:25:39 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:8785:0:b0:27f:bedd:57d with SMTP id n5-20020a2e8785000000b0027fbedd057dls872802lji.10.-pod-prod-gmail; Mon, 09 Jan 2023 01:25:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXvn+rlB+ZKSLyTVvV7RnnoS/4c9KIp+bVlRHHE2077a623GipcVeQAigj2ifHbs83S9nnqf X-Received: by 2002:a2e:b8c3:0:b0:282:41e6:c500 with SMTP id s3-20020a2eb8c3000000b0028241e6c500mr2922403ljp.52.1673256338587; Mon, 09 Jan 2023 01:25:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673256338; cv=pass; d=google.com; s=arc-20160816; b=IeDecsmrhrONv259QZssY/ZSAURvPnfzJk1fpkgQwBmOsIANuJoYvl9/IDhIFPKKYZ getodXpVbJysw8eReYBBXlyvgNF8+zc/lKdzrkfUZ22e0d4pybjAYTSC7Tez/J7sIj7g 0yWLK1KSR+qy1EKbVNFUYQH7MRLmVbvKrkR0LAXE46U9qDXMp2ZdmCHaLRbSHv2Xz5R4 MmVEM+PxJNNtoSSU9akJs+4bv5i6JUwOzDEFsG2ZP3MaMDsGRgbOxhGTE/kkXdfGTUQ/ LAR5D9FSUifsFLmH0CN5AFjIYpe8ZA7dBeFnZXyDJ1Kqhf4dlWOyui7o8r/vEbhuTlVc PLDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=pUE3+U0Wk9MKHX9HBCvuU4y3VExx10fHLz46VwmrIG4=; b=bkopL3Q1DphpEopgXeZCSFw0IRz9ujwAiwFZrrxl9XjQpCzi1uXjSOteqBjTspK3LU ZslL/mf2YtEZE61e1vF5NgimGcs+ZQfwmI5NA0lrBcb/hjfX36tuheX6oWk89uGANYyA hfUUlfsMXN72tThS/2Ja/T0CcfIA/w4oPpIxyZQvO178x9QEmWpZUme01cLkXL3ZBNS4 LPFZDvayje3ipHscjY/hhhBz2jvWrs4phokuG8rhlq3DVJt4ryx9ugV1745Q4m/QUEGf dtVjk7hydsXDB7mXrx0J8z17itIQezTJYhAzzysOLq5Ohj/WrHte7geGcWvhvsy/t25z lLvw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=B23UpdzS; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.55 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2055.outbound.protection.outlook.com. [40.107.21.55]) by gmr-mx.google.com with ESMTPS id p11-20020a2eb98b000000b002865233e8b5si4644ljp.5.2023.01.09.01.25.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2023 01:25:38 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.55 as permitted sender) client-ip=40.107.21.55; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=B23UpdzS; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.21.55 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akX5Ik1MntdnoWo43hO4EiF4kD2baDUFo2bJ/gMwhaZJ6y3Lc9du5i9lUaMo2SZMpw479zU41etZnDZ5ZZwQ6nbPRLp4RVBZHjNH52S0Ax1DzthTxmKHqEWyw5z4BykqIpC0UpBhHZgaan7TIpnjZQ81N82pxeXKghPUiHUC8VsHpXKXfNJU/mlYc503N7Vv/N8B6G1Kn1eVeaTTi0CzMBsPcVYmzwEGLNzkGepVNzuYxnPmghAcG72OGFNYQYswXT2Pqb0M5NSOW8IvwKRSbRodrTQZDxfK8H/ElDFwomn2xuIALqj0w2I7o3LuqqCvVVSsZmCnkR1ZzWfb4rCeng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pUE3+U0Wk9MKHX9HBCvuU4y3VExx10fHLz46VwmrIG4=; b=YOS8xOongydgBlFxon3v+NWo0PehHDuEqtyB1mXlOUG4KB/2uLEt5VgskxbjCePKZo6bBoaORuIU7rDHKVW3iirA4QJHlhOd77oeXr+paWtkl37PvLiR5cCh4iznPXdOm3rxl4SRipH3bXRqBWj1SrDA0lKX8xXopEeh6AWQWEX6bC4V57NAAm69/XQBYvtwJFJ2NazXc3oxnod2iH3FPnWXsC8dRNvcfo3j6BW62pXGbHS5N7AaPppcjNMX5WAY1En3D46EuYdqRfJr3IJM8d9My0FE0UxTJDV1Ub9fUiwCAnnlDQrYuXWA56q8AaY6ANeBJ+EJg57jv74zKm3pbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pUE3+U0Wk9MKHX9HBCvuU4y3VExx10fHLz46VwmrIG4=; b=B23UpdzS7S7Q78r3DLtCZSSN/kKEAttYQYjD48+UR2ACXSionu8BleWkB7lxBjNdpu8QlrdBniLA8sVeIBymeRtPnC7Ko7KpslqSf9O5GqtUw+vYo+xliKad/UMnZXdoV+czhxPYtO1hpAszvbQSFFNLghacfusMdD6Laiz+vRrIZMF+3kq6XSQ7A0GH2lT5JPjhc3+51NIMzB82wsZVnMCleplK5LzCE5QsQrzH7lhJTKRdtNepQxnXOhDQxJaOufuza+v6HJ8FQCgxj8WoTJeAfdJHmHzC4rI2IgPIeb+91QZuVCPn5CRL/tzKHSlBamDgThGY9QHY2pYBxzijuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by GV1PR10MB6194.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:95::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 09:25:36 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 09:25:36 +0000 Date: Mon, 9 Jan 2023 10:25:26 +0100 From: Henning Schild To: Felix Moessbauer Cc: isar-users@googlegroups.com, jan.kiszka@siemens.com, venkata.pyla@toshiba-tsip.com Subject: Re: [PATCH 3/3] deb_add_changelog: use SOURCE_DATE_EPOCH Message-ID: <20230109102526.313c2082@md1za8fc.ad001.siemens.net> In-Reply-To: <20230109051428.450854-4-felix.moessbauer@siemens.com> References: <20230109051428.450854-1-felix.moessbauer@siemens.com> <20230109051428.450854-4-felix.moessbauer@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR04CA0044.namprd04.prod.outlook.com (2603:10b6:610:77::19) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|GV1PR10MB6194:EE_ X-MS-Office365-Filtering-Correlation-Id: eef1927d-2a29-4fd2-1132-08daf223772d X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y8x9cd5sqYbbENkrUvLYV8BJYBWmsOKNSt7CsqJsxjI76RRUfM5Bb+ksm7HvcDJwaN6gjydF9BU1di+fPlcnmsfiZW5X5yp2R1nUtCp8raIhadYabO4vBj0sKN2RFafXGorstCGjocEpF0T+WDDucL49PQ/rpOJGpMpAMfMP/s+67BtxfKxu1XOerFP6k99P55pREP8FABGUN2deCsoLDpY0dQVruL3tZXGLJsjrdwZqde13zdAecd2BL0lPmDj1TGeaTgA6qH1xvKaewXUogGXgxWOMYDoj3nyElSpBRbvT6Jl9JHA8irTiK1Crm76T8K3tCzyGIgveDSQ80pQVLDJka8gR8qNoH2Emckp+45+RNlTWEPmFaC4bN3ZKsEIN6A+V5ZanRhsi8wUWzGDa7ejj/LebfRppQUNN5RgIParQ13HX2QQKzhUbuBM+HhRKFEnYTk5p1uCbIbH8ip/Tw4rFfn6pRSlzvnoqcZG/hh/bBNxXD81lagYGcg9bD/4ZnSuSshwsdRodrYmNpUlpXFk9zHEtkJp4YwWNuIyY7kg7aStbYnFwi3sxVRujO5vI42yHauzW+gwNYVMEuykJDDo/MOjFhFYotkOHOOQRmVrG4rl1MKpriENoWNE5J1kPifTijBCMTJMpjE0QtDMvPlCOgrtogx+/CMSjMmI4AvNvVv0DMf17zg0EyfGkU4TMU37s6wJmqGCoey/XiwK82g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199015)(2906002)(6506007)(6486002)(478600001)(186003)(6666004)(9686003)(6512007)(26005)(6636002)(316002)(66476007)(8676002)(66556008)(66946007)(1076003)(4326008)(41300700001)(83380400001)(6862004)(5660300002)(38100700002)(82960400001)(44832011)(8936002)(86362001)(207903002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JTfQ6dMb3VD0wGnmuYSE0bjZCUBRyqlLbt6lFaZlE/zzd0hyVXszvwidm1oz?= =?us-ascii?Q?0rH9yFaWYHT/VXBmmMx6jWv/hmYXtKDRoHvaR/ZWtch0wsq9P/v0zcZPdUlZ?= =?us-ascii?Q?rTa7WofVGJL03ba2i0akwLuxITtx71q21SfVOShxbdD3ugcvzanVli7f2Opm?= =?us-ascii?Q?Wrpzfb18TIqAD6F6mQEmeLrLnPwxfDDTjVpyRBZzLw73WhvfMeVO1X7Xffct?= =?us-ascii?Q?Qq1JT3buo2Q8cWQ15TxLGvTTk2xjE8dmxxmfIZTT/JjuMjxm/ce+s01s0eJ5?= =?us-ascii?Q?uNfV3ZeNzXS6MbS/3YyUikCAv66mCh6S7Q9d1z+wBhiTkT05qYCi7sXaXapr?= =?us-ascii?Q?E3vXdAJUD7xE9CMPkEWhOeDSPKO6/rBXVkecsiRmCOkmTGDm3D5xndB2JB+3?= =?us-ascii?Q?9miH/Riy/XMef0Ku2T47COyPXtgR8d9PFTDGDanIH4j3wILFB6eFK82viTTG?= =?us-ascii?Q?sk7+fa2L6B6x52JpkaYLvIB90Jmxs9lzuViT0P0cMFlQw3dkJ32EOiKGJ3k1?= =?us-ascii?Q?YXrxP/YRPF9ZAN2DYsxzSFcmCsvfqNW6kT+ZnSiFiOF+1X3bOtklNmH8M+ca?= =?us-ascii?Q?CB5+e9wx7QjSCLT/s8A0lvB2VFdtIegr96ixnZWWa/qQX5z4iY64eB9sQ754?= =?us-ascii?Q?djEiaSOCCJSqm9W8Cob86QL2V/MNz7pdbCW3rflGIcxO4IZkfzPLfAXEtA6n?= =?us-ascii?Q?ed7lgbzO8WQITtfPt3jVNQAEt4W0pgHCLvdti6LMb6zE3YIdJoQiiH/eGH8N?= =?us-ascii?Q?C59uPH6kyDhwHw39hJALANhM+cU4erCEVhD81uNLTN+gMjvon4CeUzjAfVtY?= =?us-ascii?Q?OOEjFQD4l1LVHKyiR50FT05zc0de1BococOxax6Hc7QUgqwXYEn42mFCBmba?= =?us-ascii?Q?KdG1lmkKmsSuncL28zPz20uhxqPfBIosvt32REsgALoyXPod3WlbqfpCoDYi?= =?us-ascii?Q?cgsjI2bNN0wnBsW0rAt9cDIa8OFU9NlGPdAsCYtCEWE6G+PXjqBeWG9cyXoD?= =?us-ascii?Q?RCU2jjt3wi8BU8JhLQOe7MMYYBXIkodO1sqRRcLGJpEmCfULxWKVnNo+R/Zw?= =?us-ascii?Q?S+yiAFK4cT5OtC//udZeOBmJJtkwPGDcuErSLOumOuS1JRBUi5EFFN0O0WwQ?= =?us-ascii?Q?iWEnnPwwTzSCrX5g+zv0lExx5xhKXCE24YxCDLqlfHkw37Shrbz1bOaaSU6K?= =?us-ascii?Q?Q9P0O2pFLCUj4/VxspZrSF7REmmflo5qaTBDXUNz+GGUpHlMttByvL8ZIAOo?= =?us-ascii?Q?IKEW9i7uS/eCkR1GAgMSag2mi0NX+hjKuyHMGelZ1adUv6wTmSYzal/SxOPu?= =?us-ascii?Q?b8N377ddgRU/W00nikwSf8JEKPqGB0VS+edPAZP9FrZ/SuxBKu+0QEotJz2t?= =?us-ascii?Q?1hFZC+peUt1oarJUC+86/w8UXFE2Sf37EFoTuh4xSNNleBJlEgl66QjfYUNa?= =?us-ascii?Q?nta2joCfzWbQNuZov6MArG0yrOv+M9JwR8qLtI5DO/CvUibipB0TyYjfsk/0?= =?us-ascii?Q?+rZhnyYjY2s/w6p4T7Bo2VWT4YiPG31EIYqEg7GyaP/Zs6TWO2bBGIsYcIGT?= =?us-ascii?Q?So15BTqnnH594SohRWrGarC0tOLvsx5TFrF56YqiBrYDZcoYCb/sjZio9v5c?= =?us-ascii?Q?RQ=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: eef1927d-2a29-4fd2-1132-08daf223772d X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 09:25:36.5440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h/YdhbCEmjs02S0wNcplLzoaUMXuIJuBxbVSv9ho9ZV0C0OasS2VU1d7GDCQ7UQuuEb8ht8MoaqdWLaRzvs/rAAaudQ3FHtgSDtMFPv18qg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB6194 X-TUID: nEm/zoAXnq+u Am Mon, 9 Jan 2023 05:14:28 +0000 schrieb Felix Moessbauer : > In case the SOURCE_DATE_EPOCH bb variable is set, use that value > both for the auto-generated changelog as well as when appending to > an existing changelog. The variable SOURCE_DATE_EPOCH does not make it into the build environment and it very likely should not because the overall value for a single image must not be used for all packages. So we can not and should not use it. For a package the sane value would likely be the newest changelog entry ... like we try and do already. Henning > Signed-off-by: Felix Moessbauer > --- > meta/classes/debianize.bbclass | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/meta/classes/debianize.bbclass > b/meta/classes/debianize.bbclass index 3531421..49ae0dd 100644 > --- a/meta/classes/debianize.bbclass > +++ b/meta/classes/debianize.bbclass > @@ -14,7 +14,7 @@ MAINTAINER ??= "Unknown maintainer > " > deb_add_changelog() { > changelog_v="${CHANGELOG_V}" > - timestamp=3600 > + timestamp=${@ d.getVar('SOURCE_DATE_EPOCH', True) or '3600' } > # we have a changelog and that is not autogenerated > # (when autogenerated, changelog.orig is empty) > if [ -f ${S}/debian/changelog ] && [ -s > ${WORKDIR}/changelog.orig ]; then @@ -23,9 +23,11 @@ > deb_add_changelog() { fi > orig_version=$(dpkg-parsechangelog -l > ${WORKDIR}/changelog.orig -S Version) changelog_v=$(echo > "${changelog_v}" | sed 's//'${orig_version}'/') > - orig_date=$(dpkg-parsechangelog -l > ${WORKDIR}/changelog.orig -S Date) > - orig_seconds=$(date --date="${orig_date}" +'%s') > - timestamp=$(expr ${orig_seconds} + 42) > + if [ -z "${SOURCE_DATE_EPOCH}" ]; then > + orig_date=$(dpkg-parsechangelog -l > ${WORKDIR}/changelog.orig -S Date) > + orig_seconds=$(date --date="${orig_date}" > +'%s') > + timestamp=$(expr ${orig_seconds} + 42) > + fi > fi > > date=$(LANG=C date -R -d @${timestamp}) > @@ -42,7 +44,6 @@ EOF > # prepend our entry to the original changelog > echo >> ${S}/debian/changelog > cat ${WORKDIR}/changelog.orig >> ${S}/debian/changelog > - fi > > if [ -f ${WORKDIR}/changelog ]; then > latest_version=$(dpkg-parsechangelog -l > ${WORKDIR}/changelog -S Version)