From: Henning Schild <henning.schild@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: isar-users@googlegroups.com, jan.kiszka@siemens.com,
venkata.pyla@toshiba-tsip.com
Subject: Re: [PATCH 0/3] Fix reproducability issues in deb_add_changelog
Date: Mon, 9 Jan 2023 10:28:31 +0100 [thread overview]
Message-ID: <20230109102831.49a9b39b@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20230109051428.450854-1-felix.moessbauer@siemens.com>
Maybe you explain what exactly can go wrong. All i see is the 0 for
when we create the changelog ... move the +=42 a few lines down to
cover create and prepend ... done?
partial rebuilds and reproducible builds is a tricky topic. Is it done
because we value the cache ... or because someone changed the code in
the meantime? Cache being valid, any sort of code change of cause
invalid.
Henning
Am Mon, 9 Jan 2023 05:14:25 +0000
schrieb Felix Moessbauer <felix.moessbauer@siemens.com>:
> This series fixes both reproducability and rebuild issues when using
> the deb_add_changelog function.
>
> p1, p2: fix the reproducability issue
> p3: add support for SOURCE_DATE_EPOCH
>
> Best regards,
> Felix
>
> Felix Moessbauer (3):
> make deb_add_changelog idempotent
> deb_add_changelog: set timestamp to valid epoch
> deb_add_changelog: use SOURCE_DATE_EPOCH
>
> meta/classes/debianize.bbclass | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
next prev parent reply other threads:[~2023-01-09 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 5:14 Felix Moessbauer
2023-01-09 5:14 ` [PATCH 1/3] make deb_add_changelog idempotent Felix Moessbauer
2023-01-09 9:19 ` Henning Schild
2023-01-09 10:42 ` Moessbauer, Felix
2023-01-09 5:14 ` [PATCH 2/3] deb_add_changelog: set timestamp to valid epoch Felix Moessbauer
2023-01-09 5:14 ` [PATCH 3/3] deb_add_changelog: use SOURCE_DATE_EPOCH Felix Moessbauer
2023-01-09 5:34 ` Jan Kiszka
2023-01-09 9:25 ` Henning Schild
2023-01-09 10:24 ` Moessbauer, Felix
2023-01-09 10:30 ` Jan Kiszka
2023-01-09 9:28 ` Henning Schild [this message]
2023-01-09 10:33 ` [PATCH 0/3] Fix reproducability issues in deb_add_changelog Moessbauer, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109102831.49a9b39b@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=venkata.pyla@toshiba-tsip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox