From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7187242631035879424 X-Received: by 2002:aa7:df92:0:b0:48a:1b2c:fe06 with SMTP id b18-20020aa7df92000000b0048a1b2cfe06mr5813061edy.412.1673424396051; Wed, 11 Jan 2023 00:06:36 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:5213:b0:43d:b3c4:cd21 with SMTP id s19-20020a056402521300b0043db3c4cd21ls6380034edd.2.-pod-prod-gmail; Wed, 11 Jan 2023 00:06:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXvf2Yim9a13XBEmlv1lJCsuKVMcILYEz4NP+rvPDRoRoirbFXToKA0MUYMtYOwASY1HWhJy X-Received: by 2002:aa7:c6c2:0:b0:46b:aedf:f328 with SMTP id b2-20020aa7c6c2000000b0046baedff328mr60134740eds.20.1673424394973; Wed, 11 Jan 2023 00:06:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673424394; cv=pass; d=google.com; s=arc-20160816; b=OFQ3v6ruY/o0IvLXnIDK4RgqWmoPFVsWEIb4u+KkMn7nJwTWnf0O4Dx0W7vkvaSEfI sTHPv2ilfw3gIIFJ89ItM7Q8OefecxMrsDMSsh+6oHwmTxit1udz+wDVaCk8FcNCsqsk +pzsfNHI1G+avzoCO2r0hI4DgAYsF7M3MkPBXlis30lV9e9ew/7RxL0Op7Y8tb+mfYE5 30vHuW2cZpE2yaXBrlZdDuWWco0jU1YMRX0u3DSefhMdYAulSxWM2iTrUhftfpbix7sT px8V5iyes8u8LysQX6X5pzExFKKas7wS7tD6/exqel4jHpFIsPtcnEK4x1ln6J/Pmb+O 1mdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=WnMUIUfI54iLNkuPI44kUqvA3BCTE6qFLgHZZkyBkeU=; b=Rr9w6LBXh0lHKJx1+meY6NSON337a4aCOECJ6JwsCW8RGpar1o8I1+kmiby6DOJ6sV gQMm/X5y3hJSn85GXb3nN8Rl2hxo6c4aqXPOnMJxB4Eonp+e3b+d9zaY/m4lf7H1y/9Y t9LJ2HBxu5iGUitrkOmewff7hfEG3D7BgMSj5IfgnF9uSxb5jd7zBRUJtjlruN14s0X2 qi6glmmtK8J1qV2OQDmoQwrPw/efNT7u8KJ1BwuqH7gyRAh8J6kbcrEMMko423lf0zbF C6WqazBS0ioPQ5i6aQrXIyoGXdR/sPNFwFUzTz3RZPPbj7nqZd87NhVOorNnbLCluoTf reDg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=zk2hMUfS; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.44 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2044.outbound.protection.outlook.com. [40.107.14.44]) by gmr-mx.google.com with ESMTPS id l25-20020aa7c319000000b0048ecd372fccsi607473edq.5.2023.01.11.00.06.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2023 00:06:34 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.44 as permitted sender) client-ip=40.107.14.44; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=zk2hMUfS; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.14.44 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W8s2aaUyPbNuBTCh8Icq319Wvn6MGG774wYGsrItsFGameCXLByJ0OZJry44tTFMGXoggcZNfurgSgkReMxoNRkX3znk3DzUCV9SEhVPR2EqOQhs5+AW9IHi66ns1AjRnUXxiCBWMdKk452BLSens9i4AL4Ldm+ZhZwzWVRzWkJ0T7F4NWYSxCI3nhPf1tFV19mHA4uhNuQJyuPeV7jTRY4dglJbu2LyNQJ/DW2YnR+sQSK467v2pv1CQdOTEf6QoY9GYxuTH6TMPmGLjtsc8Vu0FQ+TJQyfu+Vo5XioJxMlQNjPiEza3xLxRG8aQnvedlfYBPYsKk7fx1POTqYM7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WnMUIUfI54iLNkuPI44kUqvA3BCTE6qFLgHZZkyBkeU=; b=YSzEuBK89ZDDtQ+QfLbpKqOpaPnviggsL6YI+uZe8LcUVHJhIHam3c1mX4FTZ7NwMsib4R0cpWlrsL26/0CHgxnQ9TG6HmIlI2g7Pl16ynyRSexlxPMqP39pZSg++3D+VV5N7WgwWbsOpDQEpYxNIJQ6l/SHRfkPjxlR72m+cSTlwhHiQsOBYQaVO/B/lObaNtX9wGtzp0xcOyJkhJjo6FexM3mwbo2VWdIbUNiR0bEnEtUJsI079YOlPRTD6EvIaCl1PhgrMgHuk9a6p6/RPavsqZ/2PajRpjIGGA+ccCkXt6TB823E+lSC1S+39g5CxQTk5jgz8KUcrPC0QfbtEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WnMUIUfI54iLNkuPI44kUqvA3BCTE6qFLgHZZkyBkeU=; b=zk2hMUfSZDTV6x2mDYod+FVSVZSES4sIHZ0kLFJd6PiSuF4RJvcJxDOcPDRCcNIosWbJsbkNJbtIxfYl1uKQwq/SssF+oB+mDJiHbKeCmsXag9NLPTh9Q51UC9BrlJPd8Awo6AIFLx8ER5w1yK084hPdazZWjpqD+PES4QlHYRjVwJoWwpCW4/o1Yw9iBVacyjZ058Bx1XIzKg2+lDwvln3hRDgJUwkM+UJnUUdr1G29a2lTSZmGIRNHz/ezAkp9jA1SMWm0Dt3kHFAfVv7VpdInhsv1BLDxClE3ySyaNzYkRs9ut37FBfV57ciMs8HRfC5GYfmzJ93DHYjE1G6Ojw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DU0PR10MB5535.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:31f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 08:06:33 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%4]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 08:06:33 +0000 Date: Wed, 11 Jan 2023 09:06:26 +0100 From: Henning Schild To: Felix Moessbauer Cc: isar-users@googlegroups.com, jan.kiszka@siemens.com, daniel.bovensiepen@siemens.com, venkata.pyla@toshiba-tsip.com Subject: Re: [PATCH 03/11] rootfs postprocess: clean python cache Message-ID: <20230111090626.7f2bc56c@md1za8fc.ad001.siemens.net> In-Reply-To: <20230111041140.3460393-4-felix.moessbauer@siemens.com> References: <20230111041140.3460393-1-felix.moessbauer@siemens.com> <20230111041140.3460393-4-felix.moessbauer@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0023.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::7) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DU0PR10MB5535:EE_ X-MS-Office365-Filtering-Correlation-Id: 202b9a1a-bce0-44f9-e627-08daf3aac0b1 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ROHDbY59hzePpVf0Z/v5mKY9XzPvZpNPAuFKMN4ODCOtr1doDb6OGqhdEUKhmJNULo1U9WOPTe4v1rAwPxECvN+Han2mANYLZg2l4X6duoIdKz11/m1OGlCtadARtJhJ9YGOlBCffDsbt/1ApsmXaGw7CsTb23qWs0smpdA6iHhQo+P6ZKLvwod/GgnrvqWtksU0E2oUTc/+ri+bbDBnh1CRuLrJdO/DOeDwSSgJBZXpo+suvG82nB+IMpXShpzSqy5+1RLEpXTHLdF5rXS4TJhgnwDVsB2vMn8KTLullIhQVJP88X4TGSbDABVQ8T7bOcFVvlpoHsLQb+gbegxMb3nNCBbHo5sPg61YcgGaCpJh/GoeSyJQdw46RyRq5901MdGmxQUfyuoUfNyVjMfCa+iytg7ednWdbEab/ySP4CeJiQZcVZxgb0Sfl1NdmvHz5srxw0YeRh1QoL1UOwDgdJztheTcAlfW/8z28/aikNAeuI0Jn6VVGUWCiFGDvINMoMSUcHTBihxqMB1hFxGQvC/4cBEw/tXvRQuTT6CA2rZnX5xnBVokkazwHYr+zVp3DFE6caeGg6OsoipAvGrk0kIPtV0RfGp1jilsl4prY5xHrgsf2cO/oGE7Anc1oGaMhXU7uVnb1vFOnVjeXRmlQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(366004)(451199015)(6506007)(82960400001)(38100700002)(6666004)(2906002)(6486002)(1076003)(186003)(44832011)(6512007)(9686003)(316002)(5660300002)(478600001)(86362001)(6862004)(8936002)(83380400001)(41300700001)(8676002)(66946007)(66556008)(66476007)(4326008)(6636002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gs27wIm/QlmjA07ZGmaU6CGzRbMK3KacnBQOkxi9Qnh/39UZCxMBhN/vDw5X?= =?us-ascii?Q?VV3bFjwhepb8tZgME61bs2IhRZG/L5/w7Ifpr2Ub/Z88zWCRGdD1a87EAA0w?= =?us-ascii?Q?MllL+JR7Yrz0MHee2GUOTAJsEeLhBFFvcky9mGXKxN+Ek5m7ne3pQtm8iO40?= =?us-ascii?Q?RRGQdUYkD5JmoPwU6A7tvm+7qf3OqPfRkNQmc3LBOMb/ZIcYX5jH9DCOC+Dh?= =?us-ascii?Q?okKRojSK72LYJlbMrX0pgJ0gq+Gbn4keZxo8yjuPWcQvIf8HeLAHiCIeFkVQ?= =?us-ascii?Q?7WBCnUmm0zWjnajDfqlQSB3XrM8jV3smuwChtyjCwsBEIVCjlP8ZwUyfs3+U?= =?us-ascii?Q?ppTM3PbkSyLHxHQFXPBwvB8//9DO4+jLKt0nSVRmFodO7kaY4/i3a0K7DvHQ?= =?us-ascii?Q?VljPnpEaKe5s3z1kTBVwC9I9H2LEb8+AtdUO6KGok3V+Yn7YxfsYKyna9aJl?= =?us-ascii?Q?+6sQvhhaqGI5AuyAouKC5RxHWEy1CH79lG6ksdvawnHysz4RmumvTgFKoQf3?= =?us-ascii?Q?w7urmHHAI1rBqe3S6I0uTfVrweV1szn9jKPgUIf34a9uzrv2s3FW1TympQHZ?= =?us-ascii?Q?IyAvENqdD/hdRMEOB8vzE/lBL+WAmMc4Vfkch3VmEp3PtjZTDAZHqllayAWM?= =?us-ascii?Q?neI1rImB1jyy/cn3tURXhu3C+tGuDGWAXEP63JGINkSnUxagLG6V+dZ468LY?= =?us-ascii?Q?yJBoZc76taXGtiiUB2c3NI7kN724H0jGaOZl3Im0H0l/+1Tls9NykbLn2FVG?= =?us-ascii?Q?A4jyUimWwDg4JMWJ1W/ILy3HehFGrE53f+NHNgopmWAm3EW+9zXGMO6dYQ4B?= =?us-ascii?Q?jA+UwcmSL8/mZtExiKF+6AKvMHbUp8DlaCOjc0CRvLy8At9n+6tJ2OTkkqkb?= =?us-ascii?Q?S9fYQgaUF7mGceB+OG+L1uzA5AvY0LsGnbtxWc5Rw8444dPeqfgkkkqMm5aG?= =?us-ascii?Q?FMVKx9XP1VscsDSRxJtWRDOKawYZw0q6dpMBsRewu81+h8raYJNgmSVHpqVj?= =?us-ascii?Q?M/p/ivbz5/Fr9+mbwVhglbXYLWkYZO5eWESdtn1oixIk15XocC6CiDbjZgeg?= =?us-ascii?Q?hwTzF0BUDK9cXIHRhFnuW1r2f3buhZpdJcDqAwj1rLciTjjyFRCpfwgi/oXC?= =?us-ascii?Q?vi5ICCEbi3o5Gzt+F1Z7lGBUyzXmzhEuvi+yzMmF5zEjkzQefnTR/MI5KRWQ?= =?us-ascii?Q?XgxTgMeAykr7eM0BDc2CqFKl0XUxE2Li0FLDwJp/YUD7O+83zEqbQ82csVVA?= =?us-ascii?Q?hpFA/lWQ+Dymx7OiJyP8XlCyh9VdR+3JxgCsr8HQA36T5PVWsBE54p+Mr7Bk?= =?us-ascii?Q?QSMIHaNwjXDzyV61yZ/XtU/jlJtKxGFpIsC8/CYH6/LuC8m81hhsohPhhIj5?= =?us-ascii?Q?NNtXTsOLJroW1n8cyzbmtecEmOajefPijtGEGdxDK3xgKePoD09uWwa9+2g8?= =?us-ascii?Q?zwASGDJyik2/CpEMNvRz1Tei53ECzDzAfvAoiH7kpwWB9nWCLeZiij/TpcW0?= =?us-ascii?Q?Tl7N+W1UExh1JM7eTR/xcfQMD0R3c1f86W+fMGPdavBDxF63z5SCyeGDq4ux?= =?us-ascii?Q?MBvts5qpQmKw8z8JHkl2Ine4PkaOMCLxM7E/LIvY+US4NU4nJguPCdZcQasg?= =?us-ascii?Q?9EUG2NDFjQG9Mix98Ey22H8MpYAueoqlD4+sKQg6N+xqEVg9AzV9tidn74d8?= =?us-ascii?Q?sAs9gg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 202b9a1a-bce0-44f9-e627-08daf3aac0b1 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 08:06:33.3608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wYkE4mG/yEDs8f/H/5zHBspcR0COUNTCW/UQNtn0NFuYYtBL7rWzvt/crpaj0JVNBTFcbzHVBuPMc37dFd2n2mWRhkOaXS86gkXt8Z47Qdk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5535 X-TUID: 2ZbV6N9Hacxz Am Wed, 11 Jan 2023 04:11:32 +0000 schrieb Felix Moessbauer : > When calling python scripts, python automatically creates cache files > to speedup future invocations of the same sources. This often happens > in postinst scripts, that directly run in the image chroot. The > created debian packages do not ship these files, as the debheper > scripts remove them before installing. > > For the rootfs part, we manually have to do it to also not > include these in the final image. This patch implements this logic in > a custom cleanup postprocess step. As there might be situations where > shipping of a subset of the caches is desireable (e.g. readonly rootfs > images), we add support to control this logic using ROOTFS_FEATURES. > > Signed-off-by: Felix Moessbauer > --- > meta/classes/image.bbclass | 2 +- > meta/classes/rootfs.bbclass | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 519a2e5..b86a428 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -80,7 +80,7 @@ image_do_mounts() { > } > > ROOTFSDIR = "${IMAGE_ROOTFS}" > -ROOTFS_FEATURES += "clean-package-cache generate-manifest > export-dpkg-status clean-log-files clean-debconf-cache" > +ROOTFS_FEATURES += "clean-package-cache clean-pycache > generate-manifest export-dpkg-status clean-log-files > clean-debconf-cache" ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} > ${IMAGE_INSTALL}" ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" diff --git > a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass index > 786682d..325e7ae 100644 --- a/meta/classes/rootfs.bbclass +++ > b/meta/classes/rootfs.bbclass @@ -252,6 +252,12 @@ > rootfs_postprocess_clean_debconf_cache() { sudo rm -rf > "${ROOTFSDIR}/var/cache/debconf/"* } > > +ROOTFS_POSTPROCESS_COMMAND += > "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-pycache', > 'rootfs_postprocess_clean_pycache', '', d)}" > +rootfs_postprocess_clean_pycache() { > + sudo find ${ROOTFSDIR}/usr -type f -name '*.pyc' -delete > -print > + sudo find ${ROOTFSDIR}/usr -type d -name '__pycache__' -delete > -print +} Are we sure that this can never be valid content of any package? I suggest we double check with dpkg. Henning > ROOTFS_POSTPROCESS_COMMAND += > "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', > 'rootfs_generate_manifest', '', d)}" rootfs_generate_manifest () { > mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}