From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7187242631035879424 X-Received: by 2002:a05:6512:4da:b0:4b5:9182:9344 with SMTP id w26-20020a05651204da00b004b591829344mr3570239lfq.408.1673426971693; Wed, 11 Jan 2023 00:49:31 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:58f3:0:b0:49a:b814:856d with SMTP id v19-20020ac258f3000000b0049ab814856dls5495399lfo.1.-pod-prod-gmail; Wed, 11 Jan 2023 00:49:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXuqAJLJZ4eq+NDTt7Whus6BSQ/BtXAcKeLxpZ7o2DTRiVy4lC9gaDh3+Yx5p2rqqzXHq2as X-Received: by 2002:a05:6512:3e21:b0:4a4:68b7:deb7 with SMTP id i33-20020a0565123e2100b004a468b7deb7mr2561998lfv.19.1673426970461; Wed, 11 Jan 2023 00:49:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673426970; cv=pass; d=google.com; s=arc-20160816; b=VcUJuL6/wEseIkldzye9Lxxrny8dY/TtzyYqvOi/RVFkQMJmkKmwKqk5mGz+hASM49 fPsW2cfNZ+tzUgGk+lx1nEKEjcH4pLyPeSnoG98cP39dEkM66oScsS40SdgCLlt5Uvan YhwH3R7z2a1OIGNPpj07x8LmmYSHI68Wn9W1Ohq3LnPPWmB0x58+6E2RSaJ1xaekLDjY yArljnS4LkbRsK7a+XpvyYlaa8tinDu+oanAmJzcNN8WC6DCKvlHcSUKmNPrOp+h2YC4 wCDY6Eec3MoXbXMkiT6U+DZdKYosypfSJ9hDBY20gWkdxFAIhV14OSMybE84XE4Fl5x5 h4Sw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=CIPuZc50sjtdz56prmhEmhfVfgWU7nLflm4zRr/6TpI=; b=DkE/arLR+kOEO0UfFa4icoB8Hb5JcCjdoWaRLrKfkwnSEMWbKJuQKiISvTeBdKaTuM VMuOfhmEdluJx1faHV5cAQkYE/r6jgop+Wdg0O+cRD4NxoJOs9rbVA77MloI6zn61tPw yd6NZ/E6VD3sDEs+NEiapdFpst4cWpXZFgW7QL5iL2MGUhrTG+iN3zRKPlJmCTCmRL/I AZw+V8Rl4JdkiaEBVjdKzEU5QeUed00onglyvOm00AGmYOWgYfbStPExKu+nURuSnVYo bdmuOYdCTHDI7wkdAP4PdNKHW47zAmn8Qpt4uFyiyYYpb8ZJSLB6Oa1KRC6hRRWZoJlD HLTQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=DbKbjA7c; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.82 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2082.outbound.protection.outlook.com. [40.107.8.82]) by gmr-mx.google.com with ESMTPS id j11-20020a056512344b00b004b49cc7bf6asi631767lfr.9.2023.01.11.00.49.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2023 00:49:30 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.82 as permitted sender) client-ip=40.107.8.82; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=DbKbjA7c; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.8.82 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nSLmEd5QpGFG8ZKK72ZoQ1oR8DLjBt1s0smyY91t0hDdb9VHKxeASt/YI9Zys0RoIOFaB3oNZqp4wNq0XD+sHaMmWop1jD+Fj1dXdEu7QKJJ626eNv6ixTjBVv074hMEUREMHju0pvUx+kHg6sXGWCDgkeBLqm9pkxgjtiYsue4gU8m4Dkkg0A2rmDrL/NnFFC2d10pruJq37Z8OsZNPOKDVu1h8TwYOjQmnD+khWhHdXT71hR+EhEs6KPQq++NcWy9tbn081CKQzk5epqkf3A1nSYddcOrdGv7VFqB84sTjZ9JgyDHX1W7+IUHJX44jC61AVi5ZluSjKShzlSoeLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CIPuZc50sjtdz56prmhEmhfVfgWU7nLflm4zRr/6TpI=; b=EwovaRkrUInnvb37KR83tlHJT8qKJ7idLdADqbqu9ELdYCJyk/+Qv49BUMBG1DrFZqWM0ZkjKS+NhaIDWG35dhKkVXf0MPOZivSxrsHCgQNB4hZG5TTXm98yitRqk6Oh7MdsmWPCQurA1jxmv2M74B3YLBWuwOtxp1Mg07CRBLg50N8vHO4UwcfnQHSonFCKbLoWKKwWGlvY3mN86GD/qhiTSZFGIkam2xz+lGhtQ4zpt00GMLgQ0g7yG4bypTfS1VessoSHOcDN+rvd60v1+1PHrkjYHnT3MkwNowd48BXrEzfTeDtPgFzTWHml+QEVTuVsARgtKnLfFZK9AwiAIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CIPuZc50sjtdz56prmhEmhfVfgWU7nLflm4zRr/6TpI=; b=DbKbjA7clU7Nutuzdfa/mPyK6kThRbHygx7b1NcCyQ9WLWr4MITtEYj0s0f04/7Btfyhw7sA4vFP8WWQOwahI+q2g52Z/P8TV2O/xFQqvyfCqB+/Kbanco/CpF/xozJnAuQMGZJdyYQ878oqMjq8hMefa1CUd30QeytghDl/JDQ6GOZdha+P6VDpA+IeMwbIUvjiO+fvtOXFY92YIy1T60D46vgOvyl3khKAjQ8+kWXSsNdKN2sQ6DSQAhCdf3YVyh/7t8vdT3wmXIY2SSSz18PkfiYjyEbPoPHuXSfonQY8kwiEU2+z9avW7DGhO+h8h5Mt+2GCnm9CdbBBsQ2Z0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DU0PR10MB7924.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:314::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 08:49:28 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%4]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 08:49:28 +0000 Date: Wed, 11 Jan 2023 09:49:19 +0100 From: Henning Schild To: Felix Moessbauer Cc: isar-users@googlegroups.com, jan.kiszka@siemens.com, daniel.bovensiepen@siemens.com, venkata.pyla@toshiba-tsip.com Subject: Re: [PATCH 10/11] deb_add_changelog: use SOURCE_DATE_EPOCH Message-ID: <20230111094919.29be3fbf@md1za8fc.ad001.siemens.net> In-Reply-To: <20230111041140.3460393-11-felix.moessbauer@siemens.com> References: <20230111041140.3460393-1-felix.moessbauer@siemens.com> <20230111041140.3460393-11-felix.moessbauer@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:ef::15) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DU0PR10MB7924:EE_ X-MS-Office365-Filtering-Correlation-Id: 193a8f94-9a2c-4d80-7ddb-08daf3b0bfd7 X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: plU12CQMeAWgeWFdBdPhsork5lAJNkeP1l3gh25TDuk31Ox7hoCdmVRndV038T6hdHSRw/8H/W80G1Jscp55WViXy+p3sDtKA6XT51GCJylmROEMpMkSqpfTtQter1F4SUWWCaft9a+ksRAb3NzcAzMVzhWH+Vr321zhuI2Lym0v0jhXsuY7YBvsy1KeUoOGl8x8FgBbCG+FJlOVdAVYR60sXkouZEHtQplVl1Fh85MSdZCcOcxHeWszZwxOGo102sWHoO3i7Qo0lTGUgErLHhdAPGEfwGzzBCjtsEqbMfG5DgOWIgQy+TU5oyqrQGxie1wtCLj4P1BfL8CXnFqMwiVDrsppPTcz4acWrZ9hTAJa9m6Ggx132CDxgEGWECSLQ/9WOHRMNCvOTfks96k2XK8iLKchvSF9PJczCIvf7RSldTf5fWLC1och8QHz5ZfiQObZv6xBP5IzWvIcsVepPRKofWWcNTk+Ux5qhi/I5zWuI3Y2aSpOshBSd2OyCnbdmQmqr4qA4VG82L7dVthylY9kCPQpKVBlXf7ouVWzwjbN+26MnT3jwSaIIOHtKWEoNoJn+NtL26LmvYIG+tPQwiBazGznxHkdcsPIWVTOQi/EDl8IWs/ZvtiU/zCKdHUjgt6VKwQu28VQI7YUZ8Y4A2X20IKAvHqTfZaCxFDkdDHrZ9yFRqJM1wI1QoX+ucXKVX8LZO/j22GZr3XwF1gD4A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199015)(66946007)(41300700001)(2906002)(6862004)(44832011)(8936002)(5660300002)(8676002)(66476007)(6512007)(66556008)(316002)(6636002)(478600001)(6666004)(6486002)(6506007)(4326008)(9686003)(186003)(1076003)(83380400001)(86362001)(82960400001)(38100700002)(207903002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PCAlF27ZLq3rYluEfOXO+NKSK4FSI83G4NI2dgDREjVKvYMcV5og9LCCjzCe?= =?us-ascii?Q?J40slnsG6/DOsIkCUdQ0leLg7W8BgJh7ogCKd1189i2kMCxH3oXivoXS3grN?= =?us-ascii?Q?VsJtMZ2sR+nadQ5ws337I/mm4G4uIgPkmmead5zN6c0kfqaAw7CxDPCwiswI?= =?us-ascii?Q?1OfM6wOur77jo6X8jFUNRT9LCOxmIUmlGi144WRAGEP3mODrO8zzatDsyxkg?= =?us-ascii?Q?QblLw17oguttzCNH4bpY9lPKmlpiqTXpfevcYE9vzjVQ0p9A/lFCou/bL5ut?= =?us-ascii?Q?deajpYKm5TJQDar0l1rRANNvq+BYrmSXGTWsf9tnZZseGR9mwiyWv8iRGBvo?= =?us-ascii?Q?imLeYBMUKcBb9x7mVP9MPBRU6aqigCZLkQp+xTh+auVOaqA7Ah9cI/oylxcR?= =?us-ascii?Q?+aErq0SgS7TnenL6oDO8aZviHJPbtVu9D25pjj9Y8/AhrhERtP9g5HIx1O7o?= =?us-ascii?Q?w55gk39fphEcytq74XqgxTJznQad70lhid6biqyvRmxZWeu47pWXNv2m0mHi?= =?us-ascii?Q?Y+7EvXgcBrRSBQUOMw1oFwAdVqtcoFAO0XI5dunWf/Dvamj6Maa2NoG8OlKP?= =?us-ascii?Q?jNYbeayiI9Eu68uIX9l3VcxUQYy+EwITexoIUfy64tkHeLkWypReNEAvFhf8?= =?us-ascii?Q?pD8W4P7dvftFDumti3NwgTz0T2aUeSZ8JQYKvNo7vOD/bMyiTgf9gW3JgsQ3?= =?us-ascii?Q?sqZ4KnCrf3xJ/CD4vgde2Tp4JTHzjhn+T1/qIyU+htlSeaSx1yJZz5Zligz5?= =?us-ascii?Q?WdJRwmX+Y8YaljatfiaNit5pV2syPo2F1VBojuDY/qxepAXH6bgaoSNpnhXU?= =?us-ascii?Q?gCjUIrSbIBAxrti4K0IzrA4Mevnq3kwCJQrYMFge88DVl/oAT/aRdKXAaBfm?= =?us-ascii?Q?gZWSfKBD75Sq0BVzl+uZB2EVFJdRvzi1lJYs5FurmjjMTmeY1EsJyFN7deBe?= =?us-ascii?Q?PHxDfMh/O+8Uu+r1h5TYmP6nVENo/rDznuwUrP/2ezMcB2O6egS+h+XvDJTK?= =?us-ascii?Q?RSrGqQQYWoM+/aT3xZ1OFlArz+8UJg+jFhntFduaczMcUGfa7RR1oS5aa1Ga?= =?us-ascii?Q?pR9RnJTWGie/44UirtEEFhv/dWl9DNmDJaqDIY01BSZp77CDWkldiru+kNG2?= =?us-ascii?Q?rttbwG4XTZUG7yb1vbbTx4ZUY2PJCABsprY1ccoHGnfJwWevABaxd83WP8oj?= =?us-ascii?Q?EkgOEYUvwIkjMI+e9er0WkNr5PaaHBWl5rT1s+Je5To5Otomcpa0XNkV/FZL?= =?us-ascii?Q?MikBhh+wKjGW/NDjG36l+iHAbJerUAdcpkFIPMKkOEE40qIt1M4dlp+IL6JN?= =?us-ascii?Q?Frxxrkgrwfc9DIcvxK+to/e9UAQa1yqDb5JdXufzx/xSCtqdo4ujLtTUY1/w?= =?us-ascii?Q?W+RFVa+mCxPInrowXk0MkOnRPk6vmn3REBfkFyalAjMQSEklqa1VayCw3xII?= =?us-ascii?Q?CcH5ciS8I3EIKbvDVmRPS/ZGQb7urqn+a+Hjxta9XaNvQAsihOWMSv437upZ?= =?us-ascii?Q?G3i9KoaX6Ek9TWeCGW1e7wVmFP3vaNf0S33IroQAkcEOYyptMfZsv3i/JZM5?= =?us-ascii?Q?F4VkcNYtLBcM7xVSxh3eNvJR94L1zX+bSydFYBofIp6jn/pY5dQ+nAiRApPI?= =?us-ascii?Q?2rPw7ukTcZm9LO5f11U5s8WYDFhxlBgRbJlHcv65uX45+PptzEVxx0FkF+sR?= =?us-ascii?Q?yqIjgA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 193a8f94-9a2c-4d80-7ddb-08daf3b0bfd7 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 08:49:28.7366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rK7tBEf22zcBfypJaPdH1obo1641R4gnpJMMYWLE4Jwp/qar+wpln+X6XKC0gXhyqNaFOLTOJkbc6tGmIjiQomAJwI5AEy5WI0WDc0fzX7w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB7924 X-TUID: nQCvvaxmB1EI Am Wed, 11 Jan 2023 04:11:39 +0000 schrieb Felix Moessbauer : > In case the SOURCE_DATE_EPOCH bb variable is set, use that value > both for the auto-generated changelog as well as when appending to > an existing changelog. > > Signed-off-by: Felix Moessbauer > --- > meta/classes/debianize.bbclass | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/meta/classes/debianize.bbclass > b/meta/classes/debianize.bbclass index a6694a0..3d5d934 100644 > --- a/meta/classes/debianize.bbclass > +++ b/meta/classes/debianize.bbclass > @@ -14,7 +14,7 @@ MAINTAINER ??= "Unknown maintainer > " > deb_add_changelog() { > changelog_v="${CHANGELOG_V}" > - timestamp=3600 > + timestamp=${@ d.getVar('SOURCE_DATE_EPOCH', True) or '3600' } > if [ -f ${S}/debian/changelog ]; then > if [ ! -f ${WORKDIR}/changelog.orig ]; then > cp ${S}/debian/changelog > ${WORKDIR}/changelog.orig @@ -23,9 +23,11 @@ deb_add_changelog() { > if [ -s ${WORKDIR}/changelog.orig ]; then > orig_version=$(dpkg-parsechangelog -l > ${WORKDIR}/changelog.orig -S Version) changelog_v=$(echo > "${changelog_v}" | sed 's//'${orig_version}'/') > - orig_date=$(dpkg-parsechangelog -l > ${WORKDIR}/changelog.orig -S Date) > - orig_seconds=$(date --date="${orig_date}" > +'%s') > - timestamp=$(expr ${orig_seconds} + 42) > + if [ -z "${SOURCE_DATE_EPOCH}" ]; then > + orig_date=$(dpkg-parsechangelog -l > ${WORKDIR}/changelog.orig -S Date) > + orig_seconds=$(date > --date="${orig_date}" +'%s') > + timestamp=$(expr ${orig_seconds} + > 42) What would happen if we prepended an entry older than orig-date? I hope this would trigger some sort of warning or maybe even package build failure. I still think the images SOURCE_DATE_EPOCH should not be used for individual components. The value of doing so remains unclear, while it is very risky to use global scope variables to construct package content. Correct me if i am wrong, but without this patch everything will be reproducible just fine. Henning > + fi > fi > fi >