From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7188033154287927296 X-Received: by 2002:a05:600c:35c6:b0:3d1:e710:9905 with SMTP id r6-20020a05600c35c600b003d1e7109905mr1211814wmq.81.1674543566970; Mon, 23 Jan 2023 22:59:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:4f93:b0:3cf:9be3:73dd with SMTP id n19-20020a05600c4f9300b003cf9be373ddls9422405wmq.3.-pod-canary-gmail; Mon, 23 Jan 2023 22:59:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXuFxvq7dV9YX3U88qucOUjo3Ke3SpzwjI5mJxo9Ox7tE4WJcFSJO9kdwO06w+xRbFtyVdcx X-Received: by 2002:a05:600c:a4c:b0:3dc:d5b:5f73 with SMTP id c12-20020a05600c0a4c00b003dc0d5b5f73mr1677978wmq.19.1674543565946; Mon, 23 Jan 2023 22:59:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674543565; cv=pass; d=google.com; s=arc-20160816; b=YkLSASUoLdXV7GJ47ffdrlQjqgNiCb1BvDFaODf9o0YDE49QL0qTwnXLJ+y6o4qIxu FUqj7TjyypJxGE/HFsT/K3TvVr9Zg7KOamnVrTlY6SsUituT8v+LLTS2VaLGT61CfQ1r EUTcD9zD8jv3p8ChGEExFdxlUV6wWv36K68V221hk1a4N9Q2iaLWfe3w7kzZ9wz3jHzQ pHQzjnPzAkIpP3jm1qQeLzZUrx1mVcLB0mYXobbw9Vwqn335IhBIA6FUAx4eKlShGcyd ePVGhVHzdDTJhrZAz/rSs1WL0DRZQUXODIq9+PJpj2fBIqw4xOcPkOJjGTnDMX31rVZx 970Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=xnDBYQIBA5I0cfrBfYlS4gp4pzKw3/gKygITqbom85A=; b=xuEaB6JfRGorNaF/9c/UZUNadMfW8d7Xoclq6zR0mWRE4enFNHiymIyXkW3Ntxbg5n 6Ep/oZTfSIy7l6xlWB08vmJfi8Q5PmUbBeGNgq1ueG5/0kVN3v+JEK8g0D1w0ujXN0h3 TvHcHLQnnAt6xljybpX8lmb0qPb8YEF6vQIc4SgCz4mTOMO3SCDWGmmVGp9V+R2bNWZo 4AquPvaFqJTJyu3PBtkDWnzSbNo1SGeLCXa2Vbo05EV/kfzzu7EoY0cbLKxJf4+M/YmQ rdiqtkMtDgsjLGYHgS1EwT3EwdaU6vEKXYiVq/vy8zvQvmXaKQyUlDQLVI3WyM1tpXuK +jSQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=m8s9o+D0; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.13.58 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2058.outbound.protection.outlook.com. [40.107.13.58]) by gmr-mx.google.com with ESMTPS id o41-20020a05600c512900b003d9dfe01039si55758wms.4.2023.01.23.22.59.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jan 2023 22:59:25 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.13.58 as permitted sender) client-ip=40.107.13.58; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=m8s9o+D0; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.13.58 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNhBT3Qqbh29ip7qz+0PqpJbtlRhl94pgwIvtn5iZJZP5EVdQWzCpSR9MYYduc83AH11ibej3z0AuXdwcT8oU8uu2rkJK7TAMvMePxhpUEi0eZ8U0ITvXdUDm5Ssg3bZyLJi6RGxgTXeWeBUmdXSmBgc2AEnKOugo30bqqQj7u61TlECPPIAiWIAeSn1fITR3pxohmJPDsSHWTB+uonkHLhW2aTGkb4BtGIaPBl+b9O60ZhCCiHydRh36N+NHj99JSlJgYZkoVZJ6yRWo2vwN4eHHDfoGzGNS0Ud9JvbaOYO+SlOvr2Uv5bHdcsrIfjIs2xJq1NeTm654pwDgLKzEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xnDBYQIBA5I0cfrBfYlS4gp4pzKw3/gKygITqbom85A=; b=mlTNZ5IoZ43qAU28drusjIpJB+FFgMW/btsvTb7lLOmI+dED8nsyX2i4xEjiVMj6ZrEx62khoOwp7LFAYNnl3XqdzF3rRenBDJiWs4rX1yNmRJORMSLEuSEaqtQS9+vYZwn306aYlLiE8xryUQv9vTlYttiB+EcTka6XZrF5iCo+QP4xBC7kUvSPngaJMLuUd9ndtXdmW1bDyH/JlXsM83R1Ordjjy28TWJY4F5fsMlFAC6eehOfIzU18+sOP7vvrCdfQcZgSsHDC5msPXUiL3EYXQqWRMjDx56qKJckyKJqciV1Y1R9ehJtl8OZPgq4qag9Vah4m+CYsWSUJ++5OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xnDBYQIBA5I0cfrBfYlS4gp4pzKw3/gKygITqbom85A=; b=m8s9o+D0Bw9i2SFPGbXdYrR7ryCRgIF5f8t1iIrVfPEji9JIRHbWMxnDvZXw+ck8PYcSVDhyHhWg+XGwCrr+DVQOfg5BUofWYbn4GrTCJp/x92Z8P3FlB97iHFSKaddq3tevnIhhbDjeZgrhCdijQKhx9HMOMJvszQpxgot1w4jcKxzkJlpifEd7NZtwBaT/t+iiw3PtGnlrCnWn3ANLQmbkiFYjPYOeFoEZvoPmt1nEjdFhvtcO82zeMidhW6jYd3ihMtV99h+plSaWNeK9nOdM52U5RLPk4/w5r0bzDhbZhEIL9Gg4U/XPy8FjdNccpWKB93gXba2W/hlynldGPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DU0PR10MB7921.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:322::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 06:59:23 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%4]) with mapi id 15.20.6002.033; Tue, 24 Jan 2023 06:59:23 +0000 Date: Tue, 24 Jan 2023 07:59:18 +0100 From: Henning Schild To: Uladzimir Bely Cc: isar-users@googlegroups.com Subject: Re: [PATCH 02/11] testsuite: Allow custom image names in start_vm.py Message-ID: <20230124075918.0f68283a@md1za8fc.ad001.siemens.net> In-Reply-To: <20230113071942.22506-3-ubely@ilbers.de> References: <20230113071942.22506-1-ubely@ilbers.de> <20230113071942.22506-3-ubely@ilbers.de> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::11) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DU0PR10MB7921:EE_ X-MS-Office365-Filtering-Correlation-Id: 71c146c7-d2f1-4433-eb18-08dafdd88664 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7feSxeOrpG9ZIaZcVBi9YUCK4Z2BtESeiwup2hKbkUzVXlRN1Djl8eLonupdopbx18ftCCMugyiqKUJICsy6r8+iXW30oldC0Vk29TU6aZhw31FtFExT6YklAcFYJUswdZBOM6/pzxToBoWlAbIGZiIrFkMMnllla25DwZMTCICVWjQoLpm9r3L0qiX7vSIXg09kA8CgSbSaTH5xS/m84r3c9bEPFoSgPXYXeucW0nNsWgvWOVoc2c8OGJluEBdc+ma2Qzc+Zp8UNH8T/kxtav6wP4egrICTM8FwJTXLkjy4ScH7nU7PeWsmeDbXvrgaNvSeAicpPoD6RVwkQu8dRQOt3cY3yLpp6dMeENAzDM/wBc5scQ7jzFusJY6j6QFIPMshfHbMywzBpKbdvbnErMwO95d3pDUjIq8rRVht216O7Bm8xE+wWKojs9vWdWpQrO3ISvVFTppvSafsdiPYCREyWocGO+YEfvn6VnCuo2h/FiH1BDmwkOgBs2EF6JNLqQbT/De+NLL87Heet0B/J4egpKi47Dme/gB45+0Wh1l1o+MVWVTr30UJGMMQDf3aIvSohy7OHhUA+V3k79DJ7NL9kQGhV0b0RiG6njFKtThLQfafA0dYc2XkiwHEBKMqAa8tYlm2Ul8Vk5Hwc57jkg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199015)(86362001)(5660300002)(82960400001)(8936002)(2906002)(44832011)(4326008)(41300700001)(83380400001)(38100700002)(6486002)(478600001)(6916009)(186003)(8676002)(6506007)(6512007)(9686003)(66556008)(316002)(66946007)(1076003)(66476007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DKBHof1ehz9pvi5EU1a8H9xxkfn7ARpjwHZ88XajXE0BzfGFeDYvASrBTHy1?= =?us-ascii?Q?3TR5B5bVHM9YcDLz53t5PwEJGqjFkeZFKpUwPWel9gnHd40jut2Q5+Dqn9HJ?= =?us-ascii?Q?9f4tbYgDNXMI6QHeLDZ4cNlP+Pnye7EC0BAQvx1JHQ8oMQKandz7U6/MQSvD?= =?us-ascii?Q?1J34T/Pk/voWYhmP0LVPqFf4kHG19cyCn+06rpW+vfbkbz+0beTvRKEErWD8?= =?us-ascii?Q?jgu7hefP2HwF//6hWUVukkKa7VpAfMhZbB5ej8j5o1wRrGJCu+HZlrjkYSKb?= =?us-ascii?Q?t5E0vmRJfP93O/jJfBjFuzYj/eRSRwfL55OBv6MOVTm4tA50M9DwQhDSUXST?= =?us-ascii?Q?LTIR18+L3YIrstxMBX/QhBJDFoy56p6ujmvolnAqWVy56Otc4FrBCsWJLv6G?= =?us-ascii?Q?/TQ1R4cOXvn5dXb6ci6Fuh4K3sMwLB/fB5SOwWIgedlGCCY2ccutEGwXaJ9U?= =?us-ascii?Q?aHBBoJj0P7xZkwt1kJYty6fs9vYUvU+924rfUhs993QzwUSwMRZ36njANVQ/?= =?us-ascii?Q?LbwEmYYzDROknemZGc1wPDjdzW2hmTIx52lvwEvAWSQsY9m5QaREx8jWTyAb?= =?us-ascii?Q?czCJI3RCty7AIl1eexKAVmAWRp4Dzt3QTh1vADlTfesIDgNiwhAe3bh5vArx?= =?us-ascii?Q?ZXe+gVbndaaww06OLxCHPitNDSRz8p/h0pe9aINWMNIGME9KgfXg9dHWAqhU?= =?us-ascii?Q?PuurSPDFJL/oeTe5C0bj1M150GKSAU1S5iw/3u1I26KSBS5N48PqZDiSBoBn?= =?us-ascii?Q?Q4IH+nesr2OKNbFPjzJ68HoydA9Qw7deyty2kI716XYfTpGEERigJcApXc9e?= =?us-ascii?Q?mlOHP4oMWI1S9kUL6Wp7rntAuPcSjMQ6nCAfau4fImnwsjpRXC/5sRCcaM+x?= =?us-ascii?Q?eWkKeLoU9db20tUwsGKiYKusFzxvehKiY7iapPdV4vkE3VaLNHjnJLLbq8Sa?= =?us-ascii?Q?FZGDucq6oNDSeQGKTB3UqKB2DtjUor0u6W0HhtZJ2HQ6ciQVDYlTPam9nlMN?= =?us-ascii?Q?xm4G+BuYO6j087lBAhCS8KGLUYB0yNupe2tjnbBEBTaUa7gmbmC6u3xtb6bf?= =?us-ascii?Q?z9qfGBrKS6O+FNvWB1l5cwb3E5Fisdi0x32+KlHtxzNMpMRXRtBbRZ5oyOyP?= =?us-ascii?Q?5w9N0MeuR7fmdc/i1Qh1BXJjsBlDftZTJ6aa7jiO5aTMdBgvYEP/AnnlrCmV?= =?us-ascii?Q?+r5YlxRq4Upba9rVOlZJVUdlQ7izvM3wKm/V1aGa3Pe38lodvIPxXnczdZQh?= =?us-ascii?Q?3nuZ5BdhKJC53Wg97fjU5xjDwLX3/rIhtOLLB3MFjzv2lce9soG+J+4i6pbC?= =?us-ascii?Q?EC1YA5ku/mPge8rOGs7DBPiS5bJb6Ap/NykBvJCBrBET4vxAglgDoGGpxcch?= =?us-ascii?Q?OCdtN7e2qL+N8rmpQpCsfhy3iNuGxl3CpL+edByk6rqjbAMcsaL4GhSDgYh2?= =?us-ascii?Q?XCKTr4HGsyhZ4jASd3ICBVxIuSF4C3l1d/YxgyUHPIKN7ok1H8vLZeTNzOJI?= =?us-ascii?Q?U6Glr7uaJnJMCUJ87FroBrrvDkXEt17l2Qhzvo6bnb+Iq6GuNWBr2L2RZmBK?= =?us-ascii?Q?6GvUeO8iq2GVM1EWMBEdfg+MrNF/4nIYrIr9iNmEMN5eiXVl2lSVtT9kbJKZ?= =?us-ascii?Q?GkbeotPIDsH0XrDEsp0E4MdLN5zONWmGITXn4ULN+Y8uKPcSiVBV4iE3TofB?= =?us-ascii?Q?D1+7uQ=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71c146c7-d2f1-4433-eb18-08dafdd88664 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 06:59:23.7411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lzRFKXmf9EGwaOOo1jxBbKFs/vP9gkE2H1RJOnPqfBbI345+/GBwH7lYekzyv1ewAFoSsnaQbFB5CWPKKVjL/sDe/aDtvLnmmG5A80yWS8g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB7921 X-TUID: qc8Bf2J9JV3L Am Fri, 13 Jan 2023 08:19:33 +0100 schrieb Uladzimir Bely : > This removes hardcoded `isar-image-base` image name used in > `testsuite/start_vm.py`. > > Now, user can pass custom value with `-i` or `--image` option > (e.g. `isar-image-debug` or any other value used in their downstream. > > Signed-off-by: Uladzimir Bely > --- > testsuite/cibuilder.py | 6 +++--- > testsuite/citest.py | 2 +- > testsuite/start_vm.py | 21 +++++++++++---------- > 3 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index 6a3cf052..9139cd7b 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -201,7 +201,7 @@ class CIBuilder(Test): > > return env['LAYERDIR_' + layer].strip('"') > > - def vm_start(self, arch='amd64', distro='buster', > enforce_pcbios=False): > + def vm_start(self, arch='amd64', distro='buster', > image='isar-image-base', enforce_pcbios=False): time_to_wait = > self.params.get('time_to_wait', default=60) > self.log.info('===================================================') > @@ -224,7 +224,7 @@ class CIBuilder(Test): > os.unlink(latest_link) > os.symlink(os.path.basename(output_file), latest_link) > > - cmdline = start_vm.format_qemu_cmdline(arch, self.build_dir, > distro, > + cmdline = start_vm.format_qemu_cmdline(arch, self.build_dir, > distro, image, output_file, None, enforce_pcbios) > cmdline.insert(1, '-nographic') > > @@ -235,7 +235,7 @@ class CIBuilder(Test): > module_output = b'Just an example' > resize_output = None > > - bb_output = start_vm.get_bitbake_env(arch, distro).decode() > + bb_output = start_vm.get_bitbake_env(arch, distro, > image).decode() image_fstypes = start_vm.get_bitbake_var(bb_output, > 'IMAGE_FSTYPES') wks_file = start_vm.get_bitbake_var(bb_output, > 'WKS_FILE') # only the first type will be tested in start_vm.py > diff --git a/testsuite/citest.py b/testsuite/citest.py > index 7aa1e6b5..08a2a00e 100755 > --- a/testsuite/citest.py > +++ b/testsuite/citest.py > @@ -351,7 +351,7 @@ class VmBootTestFull(CIBaseTest): > # test efi boot > self.vm_start('amd64','buster') > # test pcbios boot > - self.vm_start('amd64', 'buster', True) > + self.vm_start('amd64', 'buster', enforce_pcbios=True) i would move that to "all names", not a mix of names and positional Henning > def test_amd64_focal(self): > self.init() > diff --git a/testsuite/start_vm.py b/testsuite/start_vm.py > index 82fe489e..d6c47dcd 100755 > --- a/testsuite/start_vm.py > +++ b/testsuite/start_vm.py > @@ -9,8 +9,8 @@ import subprocess > import sys > import time > > -def get_bitbake_env(arch, distro): > - multiconfig = 'mc:qemu' + arch + '-' + distro + > ':isar-image-base' +def get_bitbake_env(arch, distro, image): > + multiconfig = 'mc:qemu' + arch + '-' + distro + ':' + image > output = subprocess.check_output(['bitbake', '-e', > str(multiconfig)]) return output > > @@ -21,18 +21,19 @@ def get_bitbake_var(output, var): > ret = line.split('"')[1] > return ret > > -def format_qemu_cmdline(arch, build, distro, out, pid, > enforce_pcbios=False): > - bb_output = get_bitbake_env(arch, distro).decode() > +def format_qemu_cmdline(arch, build, distro, image, out, pid, > enforce_pcbios=False): > + bb_output = get_bitbake_env(arch, distro, image).decode() > > - rootfs_image = '' > extra_args = '' > cpu = [''] > > image_type = get_bitbake_var(bb_output, > 'IMAGE_FSTYPES').split()[0] deploy_dir_image = > get_bitbake_var(bb_output, 'DEPLOY_DIR_IMAGE') base = 'ubuntu' if > distro in ['focal', 'bionic'] else 'debian' + > + rootfs_image = image + '-' + base + '-' + distro + '-qemu' + > arch + '.' + image_type + > if image_type == 'ext4': > - rootfs_image = 'isar-image-base-' + base + '-' + distro + > '-qemu' + arch + '.ext4' kernel_image = deploy_dir_image + '/' + > get_bitbake_var(bb_output, 'KERNEL_IMAGE') initrd_image = > get_bitbake_var(bb_output, 'INITRD_IMAGE') > @@ -48,7 +49,6 @@ def format_qemu_cmdline(arch, build, distro, out, > pid, enforce_pcbios=False): extra_args = ['-kernel', kernel_image, > '-initrd', initrd_image] extra_args.extend(kargs) > elif image_type == 'wic': > - rootfs_image = 'isar-image-base-' + base + '-' + distro + > '-qemu' + arch + '.wic' extra_args = ['-snapshot'] > else: > raise ValueError('Invalid image type: ' + str(image_type)) > @@ -87,8 +87,8 @@ def format_qemu_cmdline(arch, build, distro, out, > pid, enforce_pcbios=False): > return cmd > > -def start_qemu(arch, build, distro, out, pid, enforce_pcbios): > - cmdline = format_qemu_cmdline(arch, build, distro, out, pid, > enforce_pcbios) +def start_qemu(arch, build, distro, image, out, pid, > enforce_pcbios): > + cmdline = format_qemu_cmdline(arch, build, distro, image, out, > pid, enforce_pcbios) cmdline.insert(1, '-nographic') > > print(cmdline) > @@ -99,9 +99,10 @@ if __name__ == "__main__": > parser.add_argument('-a', '--arch', choices=['arm', 'arm64', > 'amd64', 'i386', 'mipsel'], help='set isar machine architecture.', > default='arm') parser.add_argument('-b', '--build', help='set path to > build directory.', default=os.getcwd()) parser.add_argument('-d', > '--distro', choices=['buster', 'bullseye', 'bookworm'], help='set > isar Debian distribution.', default='bookworm') > + parser.add_argument('-i', '--image', help='set image name.', > default='isar-image-base') parser.add_argument('-o', '--out', > help='Route QEMU console output to specified file.') > parser.add_argument('-p', '--pid', help='Store QEMU pid to specified > file.') parser.add_argument('--pcbios', action="store_true", > help='remove any bios options to enforce use of pc bios') args = > parser.parse_args() > - start_qemu(args.arch, args.build, args.distro, args.out, > args.pid, args.pcbios) > + start_qemu(args.arch, args.build, args.distro, args.image, > args.out, args.pid, args.pcbios)