Re: [PATCH 10/11] isar-image-ci: Make ethernet inerface auto bring up in ubuntu-focal

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 24 Jan 2023 08:24:50 +0100
schrieb Henning Schild <henning.schild@siemens.com>:

> Am Fri, 13 Jan 2023 08:19:41 +0100
> schrieb Uladzimir Bely <ubely@ilbers.de>:
> 
> > NetworkManager in Ubuntu doesn't manage ethernet interfaces by
> > default (see
> > /usr/lib/NetworkManager/conf.d/10-globally-managed-devices.conf).
> > 
> > Change this behaviour by overlaying this with a empty config so that
> > ethernet iface is managed by NM so that it's automatically brought
> > up in virtual machine and qemu host-to-guest port forwarding works.
> > 
> > Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> > ---
> >  meta-isar/recipes-core/images/isar-image-ci.bb | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/meta-isar/recipes-core/images/isar-image-ci.bb
> > b/meta-isar/recipes-core/images/isar-image-ci.bb index
> > 74b841ba..a8dd3e40 100644 ---
> > a/meta-isar/recipes-core/images/isar-image-ci.bb +++
> > b/meta-isar/recipes-core/images/isar-image-ci.bb @@ -28,3 +28,11 @@
> > USER_ci[flags] += "copy-ci-key" 
> >  # Don't QA check files added by 'copy-ci-key' flag when
> > postprocessing ROOTFS_QA_FIND_ARGS = "! -path
> > ${ROOTFSDIR}/home/ci/.ssh" +
> > +# Manage ethernet in ubuntu-focal by network-manager
> > +ROOTFS_CONFIGURE_COMMAND_append_ubuntu-focal = " manage_ethernet"
> > +
> > +manage_ethernet() {
> > +    sudo -E install -D -m 644 /dev/null \
> > +
> > ${ROOTFSDIR}/etc/NetworkManager/conf.d/10-globally-managed-devices.conf
> > +}  
> 
> Files should come from packages where ever possible. Maybe just add
> some 11-isar.conf in the package that we could call
> "isar-ci-ssh-setup", that file can be shipped to debian as well ...
> should not hurt.
> 
> And you would DEBIAN_DEPENDS on NM instead of installing it manually.
> In the end the image would be
> 
> inherit isar-image-base
> IMAGE_INSTALL += "isar-ci-ssh-setup"
> 
> Or we even just put that into the sample local conf and do not even
> need another image. Maybe as a comment where only the testsuite
> uncomments it, so users who build our examples do not get such "open
> images"

Maybe we can bbwarn when building that package. Or it could also
adjust /etc/issue and/or /etc/motd to make it clear that this image is
insecure.

Henning

> Henning