public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH v2 09/15] CI: Get rid of setting cross from outside
Date: Tue, 24 Jan 2023 22:45:52 +0200	[thread overview]
Message-ID: <20230124204558.31025-10-amikan@ilbers.de> (raw)
In-Reply-To: <20230124204558.31025-1-amikan@ilbers.de>

There is no need in setting cross compilation mode from outside
because it was already done inside test cases.
This also makes test cases more unified.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 .gitlab-ci.yml         | 2 +-
 scripts/ci_build.sh    | 9 +--------
 testsuite/cibuilder.py | 4 +---
 3 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6a49ce4..d1d22a6 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -37,7 +37,7 @@ full-ci:
     - PREVIOUS_SHA="$(cat .CI_COMMIT_SHA || true)"
     - if [ "$CI_COMMIT_SHA" != "$PREVIOUS_SHA" ]; then
           echo "$CI_COMMIT_SHA" > .CI_COMMIT_SHA;
-          scripts/ci_build.sh -q -c -r;
+          scripts/ci_build.sh -q -r;
       fi
   cache:
     key: "$CI_COMMIT_REF_SLUG"
diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
index 960ee94..02aeba5 100755
--- a/scripts/ci_build.sh
+++ b/scripts/ci_build.sh
@@ -48,7 +48,6 @@ show_help() {
     echo "Parameters:"
     echo "    -b, --base BASE_DIR      set path to base directory. If not set,"
     echo "                             the tests will be started in current path."
-    echo "    -c, --cross              enable cross-compilation."
     echo "    -d, --debug              enable debug bitbake output."
     echo "    -f, --fast               cross build reduced set of configurations."
     echo "    -q, --quiet              suppress verbose bitbake output."
@@ -64,7 +63,6 @@ show_help() {
 }
 
 TAGS="full"
-CROSS_BUILD="0"
 QUIET="0"
 TIMEOUT=300
 
@@ -82,17 +80,12 @@ do
         BASE_DIR="$2"
         shift
         ;;
-    -c|--cross)
-        CROSS_BUILD="1"
-        ;;
     -d|--debug)
         VERBOSE="--show=app,test"
         ;;
     -f|--fast)
         # Start build for the reduced set of configurations
-        # Enforce cross-compilation to speed up the build
         TAGS="fast"
-        CROSS_BUILD="1"
         ;;
     -q|--quiet)
         QUIET="1"
@@ -150,4 +143,4 @@ set -x
 
 avocado ${VERBOSE} run "${TESTSUITE_DIR}/citest.py" \
     -t "${TAGS}" --nrunner-max-parallel-tasks=1 --disable-sysinfo \
-    -p quiet="${QUIET}" -p cross="${CROSS_BUILD}" -p time_to_wait="${TIMEOUT}"
+    -p quiet="${QUIET}" -p time_to_wait="${TIMEOUT}"
diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py
index 4e55121..830918d 100755
--- a/testsuite/cibuilder.py
+++ b/testsuite/cibuilder.py
@@ -52,7 +52,7 @@ class CIBuilder(Test):
         if not hasattr(self, 'build_dir'):
             self.error("Broken test implementation: need to call init().")
 
-    def configure(self, compat_arch=True, cross=None, debsrc_cache=False,
+    def configure(self, compat_arch=True, cross=False, debsrc_cache=False,
                   container=False, ccache=False, sstate=False, offline=False,
                   gpg_pub_key=None, wic_deploy_parts=False, dl_dir=None,
                   source_date_epoch=None, image_install=None, **kwargs):
@@ -62,8 +62,6 @@ class CIBuilder(Test):
 
         # get parameters from avocado cmdline
         quiet = bool(int(self.params.get('quiet', default=0)))
-        if cross is None:
-            cross = bool(int(self.params.get('cross', default=0)))
 
         if dl_dir is None:
             dl_dir = os.path.join(isar_root, 'downloads')
-- 
2.34.1


  parent reply	other threads:[~2023-01-24 20:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 20:45 [PATCH v2 00/15] Add developers test Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 01/15] CI: Enable downloads dir sharing Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 02/15] CI: Add IMAGE_INSTALL override Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 03/15] CI: Add developers test Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 04/15] CI: Remove duplicated targets Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 05/15] CI: move to avocado to 99.0 Anton Mikanovich
2023-01-25  7:10   ` Henning Schild
2023-01-25  7:42     ` Anton Mikanovich
2023-01-25 11:39       ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 06/15] CI: fix shell coding style Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 07/15] CI: install qemu-system when qemu testing is requested Anton Mikanovich
2023-01-25  8:18   ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 08/15] testsuite: remove tests from "fast" set Anton Mikanovich
2023-01-24 20:45 ` Anton Mikanovich [this message]
2023-01-25  8:22   ` [PATCH v2 09/15] CI: Get rid of setting cross from outside Henning Schild
2023-01-24 20:45 ` [PATCH v2 10/15] CI: Make cross compile to be default Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 11/15] CI: Get rid of setting repro from outside Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 12/15] CI: Allow example module checking disabling Anton Mikanovich
2023-01-25  8:29   ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 13/15] testsuite: Fix terminal broken after run test executed Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 14/15] CI: Update testsuite documentation Anton Mikanovich
2023-01-25  8:31   ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 15/15] CI: Add single target test case Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124204558.31025-10-amikan@ilbers.de \
    --to=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox