From: Henning Schild <henning.schild@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH v2 07/15] CI: install qemu-system when qemu testing is requested
Date: Wed, 25 Jan 2023 09:18:45 +0100 [thread overview]
Message-ID: <20230125091845.3a230401@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <20230124204558.31025-8-amikan@ilbers.de>
Am Tue, 24 Jan 2023 22:45:50 +0200
schrieb Anton Mikanovich <amikan@ilbers.de>:
> From: Henning Schild <henning.schild@siemens.com>
>
> And also change gitlab ci config to request qemu testing.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> .gitlab-ci.yml | 4 ++--
> scripts/ci_build.sh | 5 +++++
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index fcdefa8..6a49ce4 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -27,7 +27,7 @@ fast-ci:
> except:
> - schedules
> script:
> - - scripts/ci_build.sh -q -f -n
> + - scripts/ci_build.sh -q -f
>
> full-ci:
> <<: *common-build
> @@ -37,7 +37,7 @@ full-ci:
> - PREVIOUS_SHA="$(cat .CI_COMMIT_SHA || true)"
> - if [ "$CI_COMMIT_SHA" != "$PREVIOUS_SHA" ]; then
> echo "$CI_COMMIT_SHA" > .CI_COMMIT_SHA;
> - scripts/ci_build.sh -q -c -r -n;
> + scripts/ci_build.sh -q -c -r;
> fi
> cache:
> key: "$CI_COMMIT_REF_SLUG"
> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> index e5f20d4..960ee94 100755
> --- a/scripts/ci_build.sh
> +++ b/scripts/ci_build.sh
> @@ -127,6 +127,11 @@ fi
>
> if [ -n "$NORUN" ]; then
> TAGS="$TAGS,-startvm"
> +else
> + if ! command -v qemu-system-x86_64 > /dev/null; then
I think i would have done
if [ ! -f /usr/share/doc/qemu-system/copyright ]
after the last review. That way we check what we install and will not
miss the arm qemu should the amd64 be the only one installed.
Henning
> + sudo apt-get update -qq
> + sudo apt-get install -y qemu-system
> + fi
> fi
>
> # Provide working path
next prev parent reply other threads:[~2023-01-25 8:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 20:45 [PATCH v2 00/15] Add developers test Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 01/15] CI: Enable downloads dir sharing Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 02/15] CI: Add IMAGE_INSTALL override Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 03/15] CI: Add developers test Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 04/15] CI: Remove duplicated targets Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 05/15] CI: move to avocado to 99.0 Anton Mikanovich
2023-01-25 7:10 ` Henning Schild
2023-01-25 7:42 ` Anton Mikanovich
2023-01-25 11:39 ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 06/15] CI: fix shell coding style Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 07/15] CI: install qemu-system when qemu testing is requested Anton Mikanovich
2023-01-25 8:18 ` Henning Schild [this message]
2023-01-24 20:45 ` [PATCH v2 08/15] testsuite: remove tests from "fast" set Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 09/15] CI: Get rid of setting cross from outside Anton Mikanovich
2023-01-25 8:22 ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 10/15] CI: Make cross compile to be default Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 11/15] CI: Get rid of setting repro from outside Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 12/15] CI: Allow example module checking disabling Anton Mikanovich
2023-01-25 8:29 ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 13/15] testsuite: Fix terminal broken after run test executed Anton Mikanovich
2023-01-24 20:45 ` [PATCH v2 14/15] CI: Update testsuite documentation Anton Mikanovich
2023-01-25 8:31 ` Henning Schild
2023-01-24 20:45 ` [PATCH v2 15/15] CI: Add single target test case Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125091845.3a230401@md1za8fc.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox