From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7192322883099557888 X-Received: by 2002:a05:6512:2821:b0:4d5:6e31:cc03 with SMTP id cf33-20020a056512282100b004d56e31cc03mr2941874lfb.558.1674634944036; Wed, 25 Jan 2023 00:22:24 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:2082:b0:4d1:8575:2d31 with SMTP id t2-20020a056512208200b004d185752d31ls8926426lfr.0.-pod-prod-gmail; Wed, 25 Jan 2023 00:22:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXsxSKxiStz+CoVNW2BWvis93NKGYAzoyRiE/9JesKCh+ybuBfML6cQzZ6l6m0AoG5j3pz5n X-Received: by 2002:ac2:5606:0:b0:4b7:1cc:ed56 with SMTP id v6-20020ac25606000000b004b701cced56mr11608302lfd.35.1674634942598; Wed, 25 Jan 2023 00:22:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674634942; cv=pass; d=google.com; s=arc-20160816; b=BrRCJF+FgVViOFp+RDuO+zrN9iL3KlBrzZApKTGqxR3fgqpomQSFGshpTAbpvGqf+i E7IAX9JLbtZ2kv6JaDLtWJp4r07CKukffWbntMqDKFyeoQIqp9h8ejwu2a0AuOTDCTDg lZFlddzgvPzvyFyrAMzw5lZN5JlPpGPyrSbTdFEIyJ0N9oq9cJTFDGdg/g3rZRaFjEHZ c1tgNHz8U+A4HPFjcekIpB6WycC5E4DBmfpHuMX3TCsDOBoZn6mtCLpSx8Zi4ys/U2Au dK8/7oSQ5uxlbIm14c1oXklkQtVI4LzPZnM4k0f0yokz4TX+Ecm2J91Gup/siBV9CcHQ c3TQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=5KjEGQC0v+1XSlv9q1ZkSDDHjz6zYxYz36+scAlSE6g=; b=eDd6OvEyeI5M+Kbsx+MUseHnxtaRibEHfhlBaNeeUTG1qdW3msxZQTR9xJTF7Qq2Uh jQ8tzDE0NPZ56hWfEu18q7t+dF3l7y9luWDCVEQuRO2Koyfd+NyHU+Sw/ZS7YpArps80 DVewvBhAwZw+TPpZbS4JmhKelW3gyTTHZOiZW62d2OiDxSIgljP8Ihra+kp5JinPByG5 4686O+6tsipq8NZB/F3q8Pl/RkPgUKimcq8JXyRK7ZXrP2hlvBQEq0f2Sfe77/n9QJ18 RYZT8elX9GhKL3fts7Sh48TPM0y+mFyDWWCCuqs1Y/3tY11aepPVQHa+YXMmIuqXghB7 9xEw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=cLAO3g+N; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.76 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com ([40.107.20.76]) by gmr-mx.google.com with ESMTPS id w41-20020a0565120b2900b004b58f5274c1si211044lfu.1.2023.01.25.00.22.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2023 00:22:22 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.76 as permitted sender) client-ip=40.107.20.76; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=cLAO3g+N; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.20.76 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glfZr7cinCt/fTJaUeFg1pr/2rCwSoS7gt6M+aao7OBVJpjYuhWTjVdwQRUbEhm/mtfUqu/ghWdiO2no9pDwBU/HSpCQG9QTVJfvooKaWhivo6KDYt7JhNgwjUSDhRjzq263VvnzlCmTMgvZd1BIEkVXU0wFZGdsb73aJOO8PWcUrsLusJngzqvkjvJxMalnFM3bA5zvsYnaycwSV9nEGfNcdDqFXikN8jx7PpfrG/IsdmttVnBn6GUeiyTzs9nc+GlifKIvd0ezuNuDcZkniGEx8417RS/u0UR2oON9ooTn/0YeZRziV1OSt5Ad0+RUuuvaV0J4v5HWaFlUnfSM4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5KjEGQC0v+1XSlv9q1ZkSDDHjz6zYxYz36+scAlSE6g=; b=Expe+axI7Hzd/MdkvOwV+BCZgVVyU5QhCxRHDIb4k233qf6SN9U1hIsWnpN9666e2BXxnHglCIgKMF4nSXeKSVNoQNTDjp2HZZdeazNAcRa9qbYBO9y1oIoARmwe8oiiSL8DuH4Hql5y0YrV7Rr4y9blhLRMHn901639sRJg5XTz1HVOTUDRho/i3em3vPIvSBo4Zi79ibFZ33zFF40YQ0wVfU6qPDF2t0sTgv1EyWv7CmXdVGQwDoVEKceAKuJ6gxFAz8MczIXktM15Hpe0l1bVwZkAH4mTw55zwUNhlVpoy71Qw8Hp4xD2mS3OWYkZ+QhYAC8reQqvHmYvAixFqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5KjEGQC0v+1XSlv9q1ZkSDDHjz6zYxYz36+scAlSE6g=; b=cLAO3g+NYi5mzk8JUcX6gbSVdNb6pdKZzY+3L7m7V1STT6xDuyDFJM+FGvdLDYthqcYE8uL8bPRQ1TWq2QkqYv9wPKYrOlN6fTXPyo2vNfyKgZfexN4xSeb5AZ9fzFVBM3Ah5UuhYdcaa7F5c4AHQNRiDd3Fy3OhO7yuOxMkbpiO2SNBsKRMTRfx3ruOC82ePxGJDAsSK6OzPrQaNDuIzdhmlzv0dhVLtx3Po0+OdDiMYFiZc0UTrWiAgYV2djt+3S1kOnghV2VTPNB8t+6oN99Qgs727rpvuTDoOMYcndxeXljjxoXuLKoEtbJ5wrSwzx8HTsQWA/p0Azm+/+2CiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DU0PR10MB6107.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3e3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 08:22:17 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%4]) with mapi id 15.20.6002.033; Wed, 25 Jan 2023 08:22:17 +0000 Date: Wed, 25 Jan 2023 09:22:09 +0100 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 09/15] CI: Get rid of setting cross from outside Message-ID: <20230125092209.3a6c512e@md1za8fc.ad001.siemens.net> In-Reply-To: <20230124204558.31025-10-amikan@ilbers.de> References: <20230124204558.31025-1-amikan@ilbers.de> <20230124204558.31025-10-amikan@ilbers.de> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0502CA0030.eurprd05.prod.outlook.com (2603:10a6:803:1::43) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DU0PR10MB6107:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e2fba50-f8df-490f-c5f2-08dafead4542 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +hLgSjJaz1APgTQVxw2Pv/Sq/c7gjQKhPg9FFIT3oABzRk2GKMmJ3mMVAFWtJDDOe2W7hL/fwPF0uDrKuBiMaNPHIIqJRPMzJ08PGczKMXbuez0ZWe6wclpeIZ80KKlMJtedtzO1XI+n84ZmO8EAtOrCuQLZfU02/KZf3dlkxPHiyipbTHMG2TJB2F8NeK+JU6LbN8AbfnJcOTLU1srKIax0k7d1rNF3MtR/418i0OHTn2ovEQg4l1E/iDIsyRsFwpypl6sQTDIW9UJ2V2AJWemgjQRVN0OBGLZTGqWiUGP04et7D6v9lBFpbRmHwTdJp1R451zxB8NzMz/hlOzQ4cS3fFkn+K3faZtdfYFmv8ac6BDs7QRKtNsFoA1YMnfuV2jgJtlmTB3dbpabRht63ZfPa0/S4m73ma72USE+hepX8zMTCtz+YvOX00DVHcwjgVyn1JkVA08rJF8Y9EnEzinAAfXQLM6kYuHyXf37rJ2rwfHwrypumtUswJGzk1CFXsk4vQ0jyUk0QNXc8yjS+7L/lA8Vonvlgr65H3Q+E/gE/bpqkam/q10LDyO6eNKqaC6sXpfTMaqG9tTZ4sYZd7vuPc8XcNurZu7dvsiwEvBj5hezaXk/3ilgBMVuFnA83HrmxQkxOrTeHbaj9EmLmChBECVhxiMmWEeVuc3V3t4udppD+4/lbwAbSn3Jr3ND X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199018)(38100700002)(83380400001)(6916009)(66556008)(478600001)(8676002)(186003)(66476007)(9686003)(6486002)(1076003)(66946007)(2906002)(86362001)(41300700001)(82960400001)(5660300002)(316002)(6506007)(6666004)(6512007)(44832011)(4326008)(8936002)(26583001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ckDAAfuOoYeZp05geBRxWw7L0LyrUy71ca3hJaExUJVZXMRPwEbwHNu8Fe5R?= =?us-ascii?Q?/iwCPmy18XEpGbzy5IdpUR5FUCQ9NBjL4idrPXF/M8olVzDPSNAGJOOgL2ks?= =?us-ascii?Q?pFLaXpsBA46fbniovonuKLaABBDJ0K/oCbf6raTOrjp3XflIfssTqLlqcSc1?= =?us-ascii?Q?2WRXsdIeWAQCg//ReuQAO94qj47MYQAOu5cWAxCSpy2ocqh3/tLF6uSlU0Sd?= =?us-ascii?Q?9KsFS4osut4yDWHYIY1hNPaclSz84yRYh5ekVFCywgv51DQku2r09NcW+Smc?= =?us-ascii?Q?0mZdQb/kg17Wh0D0fixCMov5BCSTGfC+FpLnCnJhISoBFC7qBlICkp2dBtzL?= =?us-ascii?Q?Qaaq6pCz73V+9Z7KrWHZszK2UMS8//9YcG//vYJPYZQz9mgC5ijF4VfFGVKv?= =?us-ascii?Q?7v3maFylUDtIYit+SeFzLSu6cAFceovR9/3eZNMVTxB+SMrLLrpthfn2bPgz?= =?us-ascii?Q?+PSpoxDn72/6FZyM9qKGLdmYQQtI3hVryxE5fYqayRXqjNsmNZQKi/gh+e2T?= =?us-ascii?Q?i2xOJVASGVYSuMs/6VugxU+1IhBp0yTkS4FtMmY4YLRoI4KUMUw9GVXGiq/F?= =?us-ascii?Q?QnWDz5rSCa64Scv1F5Q7esDugFR+e5PA+B7TgoML/ifn28mhtuuyPhkW/HYm?= =?us-ascii?Q?bpOEBZcEy5ow+9TVgczZiVT197r18RyaA97pfJtIN93n8V96BksMH6GOFJoY?= =?us-ascii?Q?9ax0dWDzuJss7bH+BhbUtsIo1dD846fEItneyHId3p/oQ8CCJnxvQ7tqUhGI?= =?us-ascii?Q?ahdxq+PLNBdqKofOOAmz7Nnjvmv/PDawtcR3vpzT+KBwq+9tfQyFjh/UhLJO?= =?us-ascii?Q?LGRzIOXD32fdbkpkT09eCrKA4YV1qui4YXcs+/OR9zkI5BEoJLED7QjoB26c?= =?us-ascii?Q?tirKu9acAIRYt5VjIqX68201A6Vx/iTlIWl4S1lu/4Bd+7vf478leyOJX1AD?= =?us-ascii?Q?fA2XqdBU6wQoevjrst5en/j5LCVsoTJbq36AWjStim3XH+A3qF2H3hVCTkhS?= =?us-ascii?Q?UjE8Xc/XFo5V95SvjzHoByEduV/r6bHjm0VV1Q+S81+CXX114D9nYD3ORZE4?= =?us-ascii?Q?oHYP/siLeWE+q3OCNsOuwdJPfxp1Tpd98ZuPE0W8dxtJ5RUUxvm9r8pShYVK?= =?us-ascii?Q?wwPc/8IO4ti1rzv/9fYlX1IYej2BEhh1EHFmB5y64L+xQAd1rKUdlr9GICMC?= =?us-ascii?Q?WUhppQbShc+7GnKdmqKWmTuwDazr3SiJn+F8yDcrT45gC1SP3xb0/L50g1Z9?= =?us-ascii?Q?UPTYy1dKZXMUvQuPwFSmnuQCRkW+XSFRICkB5GGZ3QJHZ52z7SPwnU4DZKlT?= =?us-ascii?Q?W7oENZ6FtBlZ3KZmo+QwUBrC+sGxZaon90EGrTBPFsbVHyG9Zk/hDPPQ8VQ7?= =?us-ascii?Q?RfsEdGNsNnWNT1uf0O9gkK3TjcjUg4Y34KhyvdTwq9YSIPpi0AIzX6aKDPSe?= =?us-ascii?Q?eP4fdn+n9et9GEIwAci4FyAEVZKT1Duw6ru2YxKAsj0d1z0wWAH4ZUoZPZ75?= =?us-ascii?Q?GWn8l8DfcewV85ZjqUi+VezysvOph4r6HkfWznzknNxZb8qxCuJ0iNTae2Bi?= =?us-ascii?Q?ETL6y8GrvY8qVz3xDLrXjHWEhRN7QLh6u21+1YhYnhf+K3fy01k4IrN5DDaJ?= =?us-ascii?Q?RUq4HDYHNuojaDOwJAICfMSi0AxibHRoeIr+03IgHXZFx1ZSzNQzilZCt1ec?= =?us-ascii?Q?RZmC8A=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e2fba50-f8df-490f-c5f2-08dafead4542 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 08:22:17.1928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JUEx/qKBLagd1dQVMH8Sn5HTMtuc16pI4/h2NOwzZKy9TLa50MMHOOMtN52s/A17cyPKQvUdhTCsL5g+0DomY5B0d864utiJawbXtJZCXRs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6107 X-TUID: 5ogbL+ttVT13 Am Tue, 24 Jan 2023 22:45:52 +0200 schrieb Anton Mikanovich : > There is no need in setting cross compilation mode from outside > because it was already done inside test cases. > This also makes test cases more unified. > > Signed-off-by: Anton Mikanovich > --- > .gitlab-ci.yml | 2 +- > scripts/ci_build.sh | 9 +-------- > testsuite/cibuilder.py | 4 +--- > 3 files changed, 3 insertions(+), 12 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 6a49ce4..d1d22a6 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -37,7 +37,7 @@ full-ci: > - PREVIOUS_SHA="$(cat .CI_COMMIT_SHA || true)" > - if [ "$CI_COMMIT_SHA" != "$PREVIOUS_SHA" ]; then > echo "$CI_COMMIT_SHA" > .CI_COMMIT_SHA; > - scripts/ci_build.sh -q -c -r; > + scripts/ci_build.sh -q -r; > fi > cache: > key: "$CI_COMMIT_REF_SLUG" > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh > index 960ee94..02aeba5 100755 > --- a/scripts/ci_build.sh > +++ b/scripts/ci_build.sh > @@ -48,7 +48,6 @@ show_help() { > echo "Parameters:" > echo " -b, --base BASE_DIR set path to base directory. > If not set," echo " the tests will be > started in current path." > - echo " -c, --cross enable cross-compilation." This is a user-interface change and people calling it the old way will get an error. Not sure we want to do anything about that, i do not care because gitlab never used that and i hardly ever called that manually. Henning > echo " -d, --debug enable debug bitbake output." > echo " -f, --fast cross build reduced set of > configurations." echo " -q, --quiet suppress verbose > bitbake output." @@ -64,7 +63,6 @@ show_help() { > } > > TAGS="full" > -CROSS_BUILD="0" > QUIET="0" > TIMEOUT=300 > > @@ -82,17 +80,12 @@ do > BASE_DIR="$2" > shift > ;; > - -c|--cross) > - CROSS_BUILD="1" > - ;; > -d|--debug) > VERBOSE="--show=app,test" > ;; > -f|--fast) > # Start build for the reduced set of configurations > - # Enforce cross-compilation to speed up the build > TAGS="fast" > - CROSS_BUILD="1" > ;; > -q|--quiet) > QUIET="1" > @@ -150,4 +143,4 @@ set -x > > avocado ${VERBOSE} run "${TESTSUITE_DIR}/citest.py" \ > -t "${TAGS}" --nrunner-max-parallel-tasks=1 --disable-sysinfo \ > - -p quiet="${QUIET}" -p cross="${CROSS_BUILD}" -p > time_to_wait="${TIMEOUT}" > + -p quiet="${QUIET}" -p time_to_wait="${TIMEOUT}" > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index 4e55121..830918d 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -52,7 +52,7 @@ class CIBuilder(Test): > if not hasattr(self, 'build_dir'): > self.error("Broken test implementation: need to call > init().") > - def configure(self, compat_arch=True, cross=None, > debsrc_cache=False, > + def configure(self, compat_arch=True, cross=False, > debsrc_cache=False, container=False, ccache=False, sstate=False, > offline=False, gpg_pub_key=None, wic_deploy_parts=False, dl_dir=None, > source_date_epoch=None, image_install=None, > **kwargs): @@ -62,8 +62,6 @@ class CIBuilder(Test): > > # get parameters from avocado cmdline > quiet = bool(int(self.params.get('quiet', default=0))) > - if cross is None: > - cross = bool(int(self.params.get('cross', default=0))) > > if dl_dir is None: > dl_dir = os.path.join(isar_root, 'downloads')