From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7192322883099557888 X-Received: by 2002:a5d:595d:0:b0:2be:5347:8365 with SMTP id e29-20020a5d595d000000b002be53478365mr885375wri.153.1674635364302; Wed, 25 Jan 2023 00:29:24 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:5124:b0:3c6:c1ff:1fd with SMTP id o36-20020a05600c512400b003c6c1ff01fdls647153wms.2.-pod-canary-gmail; Wed, 25 Jan 2023 00:29:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXuWIMQFJCE7NCd+Ur0aWlRuqUoTUWGlB+VgDlG4OcGRbji2MXooziSssCZ7h7ejLw8b+vrz X-Received: by 2002:a05:600c:3596:b0:3da:1357:4ca2 with SMTP id p22-20020a05600c359600b003da13574ca2mr32267086wmq.11.1674635363252; Wed, 25 Jan 2023 00:29:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674635363; cv=pass; d=google.com; s=arc-20160816; b=acs3XBNV1Ko2ot2bt4G2ULX03HGETG6ifL9XH0Jy7VNg12JlxI24Z0LSySujka7bJb w5khN6KP+1PR0UuOaPE80Y24GCrEB9DKI7tANdzU8F4sTi/VLhXLfVhcAOIS7LUTG7Hz wUOb8+OzWGTTj7k89Je497luFEyXkg8Hms0+ciLtAGjFyfXrlBCQtAskEJPc38x086OG XciZHxLM6VLtqXF3I+c80y6MUV8ZxuQRLsZQCrFFPrepuBCWUcOVSWofsJ1EFQIyOOvG 8zVlvFbjbpvNEfqXAV7QaqLL6dr2bSgTnCN4LEMPjivp7fr7hD+kEU5mqXLN8clE7bRn OYbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=w/HgR6JMN0QqiVMjPTgVhyUW5R9gwSQsFRj9il8hk2w=; b=ZcqWjQel2dH6w2AJV1joVs5iFgQ7EmhRU46wl49ZZ8tIWk3ODkBXk/P8nF3jjooCfH u+b6aUDHpLe9pO1DvNf3Jl+r6BNzhL69G28yrTy3d6rxM+6VN6t7zFbKNk74OtvjaBS2 jcY2E0Zj/STaG1dC7mY9sLBnQxKqoUmT3MPOiWXPW5qwWNnpNf+iUQral5Zy6bv4oyds WXO5NzCCiG3gmIgsPiBGTn/DsmH0K1tLGelODlQEpAh68+1nlXSwe2Y4CF/ofyOh4b1T +papiW+w5ciSCCW/UZWPziCUBynzaycvFvXSa1NzRKmCg2YcG0LVQDT7mdrRDjCY+BIS O+Sw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=i0iSPFly; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.81 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2081.outbound.protection.outlook.com. [40.107.7.81]) by gmr-mx.google.com with ESMTPS id o41-20020a05600c512900b003d9dfe01039si268570wms.4.2023.01.25.00.29.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2023 00:29:23 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.81 as permitted sender) client-ip=40.107.7.81; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=i0iSPFly; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.7.81 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OgWhkAClTAnbIdC4Q1cEDVCO8LNSEQ1zlUGdJ2BLfg5WQlyLYVL/eys3Y+K+KrU5rPNWiFofmYzYAgDZA5P2sPnMkPVsPpSqKPwspTr2WNtXQv+taRpkH2dyGhNRkY8800qo2CQ87FtlIgrPjpPhVyBOeHL7SSa9hjGxyMqE+5aTXNeM7e5HTQJQMmTAjBmE2q+/GxDMYyEFaJecHXEZBycKsGqXYLEar9MhNPQgXyDnFThoaMBfJT/ssTa1h1Jv4Vfy+Ha5PoB6OYend1NYGzlVwxGYTPzoRZFBLIz2UxK66BLNh3HYV/1FjBrDOdFMIHPMJve2owXoV+P4w8zqDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/HgR6JMN0QqiVMjPTgVhyUW5R9gwSQsFRj9il8hk2w=; b=dD7/dH/VAtP1MsYstMDf+aJTCP7EhGwz8LWiJlIo/G3Rqxtmud5YBk96QKCOcP/GpwB3M3VFH922y+spljDBB3qMPgHswlo2I9ayVxWXlz5Vz1A98GcqHSZuXbK8rw7lHG/fM2yWblQucSNqay1mgzatemaxBK0p4SUeCqF0yid4MPw5ZQqlRkUlszydsXxIwW8h/CkTTFI9vbVEtB9y802apfpep9nhEnQ5zmzieG3OrDutGUXOJDZ5veZ8YoAH8XvAdMLbyZ3wgCgd5zNLElqhHogBNBxJty7/q2sZzeiAfYr2szYPjxETDTE2L2whHXn1rTnTxbGJROUeOi5YtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/HgR6JMN0QqiVMjPTgVhyUW5R9gwSQsFRj9il8hk2w=; b=i0iSPFly0ksa5+Jm9mv1bma6ebqHKYvbhSjXUt0sVr/XCdazzd/cw+LGG70AwLjQ3cTT4zjmdMqs0LFKZexZazj/KHi4CaSzfotLu0cRpGOCNxfOrTitxd22h+p5PNDdX8RwX5ZgWSuQ01DMrRpj/d4gbpesViJ6AYo+AgWSWw3FyA+eOgULPBkZCW650fzGUaAhGuLx22JcXpvxhNKrOpKofq7hrf1It7ExW4dexXOYwV+O1g0n9vuT1N8siJnjM3ACUTmfJzZ4uUKkRw2ARgyI2rQAKlvVGYraFHFtt1OsFPF02QQ+XXwcZ2pTVrjC6wWJjzgMyiv9j1syMGIRww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by GV1PR10MB6705.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:82::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 08:29:16 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%4]) with mapi id 15.20.6002.033; Wed, 25 Jan 2023 08:29:15 +0000 Date: Wed, 25 Jan 2023 09:29:09 +0100 From: Henning Schild To: Anton Mikanovich Cc: isar-users@googlegroups.com Subject: Re: [PATCH v2 12/15] CI: Allow example module checking disabling Message-ID: <20230125092909.14390494@md1za8fc.ad001.siemens.net> In-Reply-To: <20230124204558.31025-13-amikan@ilbers.de> References: <20230124204558.31025-1-amikan@ilbers.de> <20230124204558.31025-13-amikan@ilbers.de> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VE1PR08CA0031.eurprd08.prod.outlook.com (2603:10a6:803:104::44) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|GV1PR10MB6705:EE_ X-MS-Office365-Filtering-Correlation-Id: 373f89c8-ed4a-4cd6-a7bf-08dafeae3e3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tTyrLnTVaZKOAxy8kJfS7JiLKHynecPbFabcYDo+1C1RGYkPCwH4GeYUgArV1MAWqP8IZcA0C9JGevY7aS5PoIVmQujEdqZHoV01GB4EMSj8EzOp4Bpc6Az8HVEPcr2soLpHw8xC979PMs4YG3wVh773aUOibNEoBvMe7/TuncpI4vlxKdRIx6zSXViND7jrPmFVZtWKRhysLYzw4sJQKatwVdej/i/7KjhDEkfB6krrWOr/8nGt1BJxpzecefRc5R/FRmvtsHdLJ026ZnePYRhWT9g7tQ40KMr1DqN4tXLPwNLDU/mMGg1JJVSyefi9t/Ofp1UYSzEbYSlRe4yXxI5JLsA8gfmw3eudDcMGxgUDAuwYgyl2nU1asBFHGeeWCddMxpLIOY275ejn6Lm41cizcYETgAwlF+6ca3f3tByQ0Py0tsxnxqn/pg6xDCOXsIg6qvUhdMMoMRF/Etvs4KnMoCZCcIfZfyFvRVREAvFYEwQab7P19IZhyZxrR2Vz6lzpSvf0TM3VuD0OWZ9FprXpB2EpoUcHAoiYZYMh9XupcNSEdI0fHL11Fonv/Gz2IqsMkvnDR3jkcZlfudcFVNskZ7qY77x+8yqut7vTKMUgV/JtiatZ86iZfHg/wApRw7dc5GUK9ai7tL8TzzM18w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199018)(4326008)(316002)(66476007)(86362001)(66946007)(6916009)(1076003)(44832011)(5660300002)(9686003)(2906002)(41300700001)(38100700002)(8936002)(6666004)(186003)(6506007)(6512007)(8676002)(66556008)(82960400001)(6486002)(478600001)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FnAf/FhoB1VHweckByyPu+INnYBspIgK7kfnY5yudqs2rGX+4WxK9DhU51m9?= =?us-ascii?Q?HtO9Fdvm4V4m0oWyyofqSMkTBD4wFmMveU/Q9N/9JrJuVyHoYwdbjFUIDsoK?= =?us-ascii?Q?5/CohZdz8ojmHuWpmOlFUXCy5EXdOpPcJRHcHYq/939I0uZLxDVTnSm+dfGb?= =?us-ascii?Q?zoyKQrFZ4X7fXSHpbY/Z3XSqiDTbKBL5H7uyjPTCg/JgRtvjJl235XDvBV1H?= =?us-ascii?Q?beUl8gV3ZiTa0BA5W0+9JpDQvYCziU5Mke4JdwQC0LBK2x2XxxVFd3QdFteH?= =?us-ascii?Q?3y4cQLZ/+KzceurN5EZzgA6zqU53tMf149zzgAmZHhmNKQsDcG50sXrYx9BC?= =?us-ascii?Q?vO3vthomHOMJ09I+7dW8+ACF3FCz4X0KCOFwTh2hXSFoT6bOIoDxw3uaberb?= =?us-ascii?Q?8snXnJw/pOGAqms/STFwEAnVzuM1GlZhCOkQw+VpdZJGuBkdesc/MKDX3mzg?= =?us-ascii?Q?3/vNSzYodQAqPdqBfhsTVYa/eEAyS+CAKQ1p02gocETwGNarE1gCNuFIJjEc?= =?us-ascii?Q?e4NnMXWD+SKD6KgwV6WyFxLWsrqVY6kdZ8+iifyLsyak1aat7pachJ1ryB3Y?= =?us-ascii?Q?0e3Cof7qw5g6hiQxoHJOCZ/E1yiGJwmXlFrXsdSIKdDYQA5ynA8oMtvNxqOC?= =?us-ascii?Q?MbUEWRQCN4pFliv4HfANQnHk6igVFRMi72MZZmKKQEdTaAaPW6FgQrp1m1mn?= =?us-ascii?Q?B3t7nvVCeF0D/JLr1sttjcOfMkR7SpiKBTWpo4j9lHjHp9FOMawj1c7sSAGa?= =?us-ascii?Q?J1+kUX11gDNySLiNoikWVj6RFlikQcFoLn5WOOceQR5z+bRbq+k1LTnhWq8P?= =?us-ascii?Q?IMGlav+8IG/URaaYdMQln2IwpO1InKSjn60jQOfA79y3uKMj+Tk5kvP7azSh?= =?us-ascii?Q?BCQsy2f5llA5W1/S58Mx0OKB65TvJi2/pf8nYXnTm+etw+84ZSjxBryrMwRt?= =?us-ascii?Q?E/4KVzrL41hFnclnqyiloHQtAk6YvT3rJWAyAA02pz5JUp6rS/ytvxW13O9b?= =?us-ascii?Q?Orot6Oxx0ROhz20HyegK9QU/+0kz1zFY8wxfoSoPhkRToFxdGh32BZm1yK7z?= =?us-ascii?Q?/+sSBtkYw9gsothRWqNZTePu0H0RL0DH5+ui/88VuAjG7/cVqBWtNjWzlCtU?= =?us-ascii?Q?gZIL5I7IeYQ27+kvUlWnRG0b9fYDSx4xdAExtRqHVpXr7yW9GMFC+MWt701H?= =?us-ascii?Q?OAaL4BAfR2hVcdg2PbzEEZD5d+TSeHjkDLkmrq3duUcHtXu9xunQ+ecJIYGH?= =?us-ascii?Q?95kRdGBuQonApbu4VE8Ri9AA6QdgPtrJXmXmif/svoZsYfC0apOz5Gl2muKA?= =?us-ascii?Q?I1GSbaXzgIme+YTaO6l/gFi5g9m70j65nPYeenX+6CZoUfqZnAZuy2KID14t?= =?us-ascii?Q?PI2uP4foJCDqOk6iL/YLWQ+fZ+E9QmGpH5dpdpFvpVXqZze6+HhHQrU9rOCw?= =?us-ascii?Q?6asIecSGLkLxnoho7XsJ6rsvjr6WFWYMGHqpI49XStfBUhx06WeAEzdce5e7?= =?us-ascii?Q?8CrCZXsBcCZkweFIAm59x9fmnuHNHZCmirF/PRmej5ohWV6jUvHZ8u6MFKw5?= =?us-ascii?Q?oudzofLPRVaG1dm8BMhkQgV4bHe5WjIDODxllrv7XnOFNTJFC/lo51HJpJhj?= =?us-ascii?Q?jx9wiQ9fiwhZUHj6dv1+nSWLMPnJw7tphO4D1wOVVPckuGfWdYk+F32DHq60?= =?us-ascii?Q?Qj7UeQ=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 373f89c8-ed4a-4cd6-a7bf-08dafeae3e3a X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 08:29:15.4547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /YOC46y7MTir5kHjgvDFuPTZju46gWTmxofytx9z8DmmYSQLARqUY/YdQbCTV4z88Ycw36+J1gMvJw2dnFCuowupNqPL/rwVvS+r+qFRsoE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB6705 X-TUID: 4pJFvOOEudvz Am Tue, 24 Jan 2023 22:45:55 +0200 schrieb Anton Mikanovich : > If the target do not have example-module package compiled it can fail > on startvm test currently. Provide internal testsuite API for skipping > this test. > > Signed-off-by: Anton Mikanovich > --- > testsuite/cibuilder.py | 6 ++++-- > testsuite/citest.py | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index d229ecb..f373829 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -209,7 +209,8 @@ class CIBuilder(Test): > > return env['LAYERDIR_' + layer].strip('"') > > - def vm_start(self, arch='amd64', distro='buster', > enforce_pcbios=False): > + def vm_start(self, arch='amd64', distro='buster', > enforce_pcbios=False, > + skip_modulecheck=False): > time_to_wait = self.params.get('time_to_wait', default=60) > > self.log.info('===================================================') > @@ -291,7 +292,8 @@ class CIBuilder(Test): > if os.path.exists(output_file) and > os.path.getsize(output_file) > 0: with open(output_file, "rb") as f1: > data = f1.read() > - if module_output in data and login_prompt in data: > + if (module_output in data or skip_modulecheck) \ > + and login_prompt in data: This all looks a little weird to be honest. And will likely be replaced once we ssh in and "lsmod" anyhow. Maybe we need this in the meantime. > if resize_output: > if resize_output in data: > return > diff --git a/testsuite/citest.py b/testsuite/citest.py > index 2c17361..1b4336c 100755 > --- a/testsuite/citest.py > +++ b/testsuite/citest.py > @@ -69,7 +69,7 @@ class DevTest(CIBaseTest): > > def test_dev_run_arm_bullseye(self): > self.init() > - self.vm_start('arm', 'bullseye') > + self.vm_start('arm', 'bullseye', skip_modulecheck=True) Not sure why this one does not have or support the module, maybe adding the module if possible would be better. Henning > class ReproTest(CIBaseTest): >