From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7192512605249863680 X-Received: by 2002:a2e:2e07:0:b0:28b:a99b:e52f with SMTP id u7-20020a2e2e07000000b0028ba99be52fmr1332813lju.24.1674653347619; Wed, 25 Jan 2023 05:29:07 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:214f:b0:4c8:8384:83f3 with SMTP id s15-20020a056512214f00b004c8838483f3ls9479262lfr.3.-pod-prod-gmail; Wed, 25 Jan 2023 05:29:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXtXOUTf7gjj6kIHpHvrd3maxT1KID3iUgCc7xA3BKAYhvcAGo3Ls8clqpi6AHtvDqYb93Z8 X-Received: by 2002:a05:6512:a88:b0:4a4:7be4:9baf with SMTP id m8-20020a0565120a8800b004a47be49bafmr10428246lfu.59.1674653346315; Wed, 25 Jan 2023 05:29:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1674653346; cv=pass; d=google.com; s=arc-20160816; b=yFEC8u/DGLiN0RLj6Oun30slSq4J6BJvjIDnwl0ZiMI7E7pmFvqn7rWv61ub3YXITe S4VWtBmmIlZfIXMTdJJjMPpwhfU1MzHcJlU22Sr0AJc2grhrzrqu84qmKa9H87b4f9AB MYzsjEpA4WpJEXxLLP2/fEHCGiSPP1slBgWxwPiQHmP9PNWnARf1dZRVDdJvpUmVkW0Y KnoGAcE4O1jY0zgerawNKEBfqz4zj5S+BWbPN2uBJbl7DohBZ9fCc6NWrpXrcs5+5167 mMIffUBnUrTqUlyaNmeYVFG/4A6cyRehOK1zKxcPKMnoZdrii4uAECbGYmnOdddIf6if T4FQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=jUloUAnqd7eNEyLIfqxZ9l1TTW5JBdqNGZkbZkgY2pg=; b=HhP1HkjUONx0fzcJrnFuLdGGJJgW27m5I+yMUp7sgRsZhetYzpYxA8eewdqa955y56 IQCHQYMQsTxqS/y+1flLbKaNzAB1BGgZanKV/mwDy8xBhef13QITbX6lh0Lgor3mdJDb jT0kuguYEXumfz7oKIkIFS0oX4o+hpnLU++00MAahYeuV66+cAFOJt3sr8t9AUIclUDK qPGUxVmmegujCtYXehfjACgAye4/3j/C3W91gQEATv063G15i+OomLR2wV7lHUOPfBfV 8/y4Tfi8nD94Lbw4M7okRgqfQmk867eUqArjF9GcFO2JmYYJRvIhW6f/K9ro/SxYIW8U 99Eg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=uJmw9F+N; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.77 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com. [40.107.22.77]) by gmr-mx.google.com with ESMTPS id br3-20020a056512400300b004d5786b729esi245699lfb.9.2023.01.25.05.29.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2023 05:29:06 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.77 as permitted sender) client-ip=40.107.22.77; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=uJmw9F+N; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 40.107.22.77 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QiwdtI3WorPFc6aLmRJa9wr55x493EPPQi2iTWEoSz9svNyG3dZNTUSXEZBv+yrsV97Ktmlyt+joFxt7ZUyW75qOkR6C7FlT/s1+PbPN7MxHRajtm/ssgdlw1ch+QyyNViQtkxlKvPtWod2KKRrsTHT7zeC6h5avlW8YrxEvjZypzAez1isEEItybVc+s65iJDZhSpBbJLoFrr0MP+y0jPcrYr5Ama5IH8fWZmIfeC0VxSavjowcs34SgV3NIRlWBKm3URJyIPqfrKx1Thtx0NxDJ42AwA0RpkEQh+WS/PLazrVHDAUBiGyJYETAKJacZ/S5K/sSzVgqlWv1jwdPPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jUloUAnqd7eNEyLIfqxZ9l1TTW5JBdqNGZkbZkgY2pg=; b=XUTHry3ebSWhacq2YucuOUquGH8CWqmCP/sPmu9FF1fTr6WmcsDbi3hFMPFmBeAPMgyT2qcr0l/Xg1ZIZ/cfLNZufvbsb6c2GSHdxggCZ95u9lNBmJOrrk7+l1vpUoso6gBmkX8TA4g60HOZLAQJWdcmlILv6mP96IKuN6own+HOqqES0pKXrAJb8+X7OZtEao/UMMhEQe5Ymqq0SD44Iceu+zMQVsEmYCigxk+Di8OIJRsAIR0oGh0qSfx2FMNtX1ehm5DdFi+Kk+jlDonqjixDY7xVKHFaSsQtwoi1w5Mctn1qOucX4D2Q9YtVw9kfIAHpoC5F11Az9+FdH5LSaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jUloUAnqd7eNEyLIfqxZ9l1TTW5JBdqNGZkbZkgY2pg=; b=uJmw9F+NQrWjtYmI4XVVSggeTjDZ6lEvhhqr6vbg1wikIvlvqPkMLgimh6X9JwauxcGbLvFUS/L4mFj8CBi9jrS6AJL8wUTdCUABpQ0d7Aw5pLDusHowv8eZCKrj/sdjYxceR+nEp1i5UzKzkaPhVGYipo6LjRrYBdr9rlF24bTi0DOB8EnfRchROWJJLHlXruyIrif1vhcAqwfbabGSgqSIuomrJv8qrFw4tbIA6/FTAsBzpJWkHc7HXiis6g70VkNELtS4yXFAN+inJYcEdTYdRRQmVXAXMhb4JHni36UOoVpiib2MtbBY5d4XYlE3H/CBOCySoufzRMgNPWBw1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by PAXPR10MB5758.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:248::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 13:29:05 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%4]) with mapi id 15.20.6002.033; Wed, 25 Jan 2023 13:29:05 +0000 Date: Wed, 25 Jan 2023 14:29:01 +0100 From: Henning Schild To: "T. Schaffner" Cc: , , Subject: Re: [PATCH 0/5] allow creation of users/groups before rootfs creation Message-ID: <20230125142901.597613d7@md1za8fc.ad001.siemens.net> In-Reply-To: <20230125090156.284309-1-tobias.schaffner@siemens.com> References: <20230125090156.284309-1-tobias.schaffner@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0337.eurprd06.prod.outlook.com (2603:10a6:20b:466::13) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|PAXPR10MB5758:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c5502f5-801c-4471-482f-08dafed82125 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mjgTZ1SZ6vFfdMEvrLDrc3STwYbVHZ1Qdx0/LyYHMet/cYI2t7wDWCGP5IhbPGPY389ULzqtW6TKxo1sazzV6jpzme/DYgx07epihp887pNgJGXSSjC3QpHbypLxguIWfDxciwIJwk65GV7M9BhiT6pvQsisdLBrTp0yqaO5Gw1B5EogaxQu+vr9hPkh0OF6iuyDGyOC8efHd6Ypjn9pv36UXVTfUiEUbfr6r/UnVVdYQyyQ/9ee2+ANh5OSOG0QviOEdcuSB3yXQ6KqGX0E8IR9amvz1VX+K/NIVQWY7hgarGCbzYpEbbbea63N6XWZF7Zkk6PCl/XIbEwKY564BOSCjEHy+sJ/vPW2uzCsaRaR/F86TG9Y9Js0aSy0FwDnW9/PCtxVcwQhn2+CdHPG0BTIXankc3Gnbb7FAQA3DLoOOIn+k86YtJd8p+atptPPCCg4ln1xMgP8FaV3BtpRfOJiXt2zcPE4ZD3S2Lm/LkTHKobjsuyv0enQ9tHn1WNXF0OwdyZhkZ0ObBarSdFfyLBlFTOcz3VbT4nBFIBOsb9tKSKP/Y8hhGBeBkMh/m2Efp/1TXru5qmasKAVwYogmdSWGXZ9ByKgBksPPC4DLK162+bidt9xCN+5IvXKzfd/y6+VwCprun8ZHQpnAvL0QQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199018)(38100700002)(83380400001)(82960400001)(5660300002)(2906002)(41300700001)(86362001)(4326008)(44832011)(8936002)(6862004)(6666004)(6512007)(316002)(6506007)(8676002)(186003)(107886003)(66476007)(54906003)(66556008)(478600001)(6636002)(66946007)(6486002)(9686003)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0UbX4YA9L4TDlOedKvabP0b6XK8DQpf4jE3ejTwU8kMTp2kixa1Aju9ZwNHw?= =?us-ascii?Q?WpX9fXXmmUYgoPeFdhNKVfdwpbTlMuDxG/XH5THTjv6SIbZ2QGhpKWnNuIPt?= =?us-ascii?Q?5EyH4Cgb0jKhvqgQucjxRosN0515727BJB1hJJwZNnLT+qO4tA39EJBhpTNJ?= =?us-ascii?Q?TMLHcpB4KCzKDMkMLvs2sfmOWmhtW3mTTk1zhcY2orxqTiqTQKlDYWeUtN+v?= =?us-ascii?Q?PdjIHpwX/s1SWdT6xmQxQLOVjyWtJjTGY5yAE1tHMaffjBZhGoyX4xKtt4vj?= =?us-ascii?Q?AryVQGZ/u3EYJicxxK+3TlCZxMcm+AR2lpnO+cvV9uHRqYNKPMHziM5iAY+O?= =?us-ascii?Q?ZYGyUuHAgb861nWTND15XIWaiJc6VxcEoHf3Ij+c8epsfv/VMvNXdvSRsQib?= =?us-ascii?Q?V4FBO4mKbuzxqwxvqxbUUzm1VzUMKfvw4M9YLj0p4QOgtDJB0DGTNNaUME1i?= =?us-ascii?Q?DgGSDPH6/CEyUjQo7kWu0aUDOHzStbc5YReHmUCnaQ4Pl74vpYOyfcg4apCo?= =?us-ascii?Q?0Mt6qtZpvKtkgOETUAjUAvemo1qlx2JPhySUO3oDpaR2Huc7tSr6s5eEjBaf?= =?us-ascii?Q?DYB/lb4HtlxLD+V4v36fB3zM8/7XPVxMb21X5t1Z6Hj3yFmettTX8JwWSZ03?= =?us-ascii?Q?jsGLeeKKuo6wAoGZk28l4jlsPCAHIK+zMexjifNjQyuxRmdyGIKbAmYPxJS7?= =?us-ascii?Q?rznX25y7KCHQQTDJQ5LnWQVOCDfH1Yjunj3BRQxdqD3ghYtgoKyAvqi0f/Mj?= =?us-ascii?Q?o0cNqaFRINucGEuunV+Z0/MruDeCPVPcNznd1aYAlrJ7Q56S7a2SHRNycPE9?= =?us-ascii?Q?x4XzKFbZVRYWwZVoqNw2LwYvWE+JSWhBUfNxQKSTKa+IpmEw8/yh3FKuctgg?= =?us-ascii?Q?pNrbdpODSTYl2xrLkDwUAP74RbYgY+mBvjDoOyXKbB3xGDZ/1pSoHE84miz9?= =?us-ascii?Q?H3iKiupqsWxuAgISxwbvYw2sszYNvj8JYEnx4C/cOaHEtT4TMqWhM6SgbGYZ?= =?us-ascii?Q?QIIa4VpBEg9AXeygC/zJgPVXos0ANVgBQT0w3VQBSVjmHQ4gekDRqmvrS8Pc?= =?us-ascii?Q?fC2fh70vUU8z1xgFLMYnUew091tsYiX3gPkix5LGHp7GsXu+Xi/mHbb6KScy?= =?us-ascii?Q?tALB/SMDfAkqF7ZIa63X/n80KiBkI7I+n06TqOdBDAOTWMUqYxf3OFq1nFxE?= =?us-ascii?Q?+iwQdhXSc4170kqiUsfw8CCRrol94ABGsB/rOZW2mNE5q3AIxQdUA220+nfp?= =?us-ascii?Q?lVMlcAFvj+IzgM0Bq9ly1UpHJiDeyBfO0AGtZ0KV2C+D1r7kzPZ3reBaTwKS?= =?us-ascii?Q?rmF7wXJW3f1/ecGqX5+7r7DubEy5jVgwUl10D2J80Kd23WyV6+V9z1fBJMuo?= =?us-ascii?Q?0ToGghuBmHGfhKfYLJEpfsSt/6Uo2Bm40H5yZETgdEBRDbqG8YpkZPRw+pUb?= =?us-ascii?Q?Ue5HiCGkFP9Wm3WPmkno7uNzVccR9/cbuPnh9TbRhzepJBLYFK4L4vUZgLsW?= =?us-ascii?Q?+rzwgEJ0e/anm6RUtaiCfN/tbMNwRl8IBNp8+230mnevK0Mxfo9tqJbnkDDc?= =?us-ascii?Q?JS9bMxIe7hEuGIr71w/ell786bYTb0YURUgqDEVN5GcWz7ffNUKdGT3J1s7a?= =?us-ascii?Q?mx2B++EZFkUlQSyyImIA/DnniZ+45meh454Gwe7qzFy+b2P/mdhEgMw9Estq?= =?us-ascii?Q?YoFDZw=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c5502f5-801c-4471-482f-08dafed82125 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 13:29:05.0859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WhackCiGppmbkcCS1m4BsYCW8Wz45Qc2/2cPwUaUPWnKNTDWmUTTZCeJOdD2AGHj9wL7lHx3Gf9h6p28V9MSsSm8UrMm7P9lHVrR0XcbP6M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5758 X-TUID: 61zuOfMsiXwm Am Wed, 25 Jan 2023 10:01:51 +0100 schrieb "T. Schaffner" : > From: Tobias Schaffner > > This patch series will allow to specify a `pre` flag for the USER_ and > GROUP_ bitbake variables. If this flag is set to `true` the given user > or group will be created in the rootfs configuration step instead of > on rootfs postprocessing. This is helpful when a specific id should > be used which would otherwise be picked by a user or group created by > one of the installed packages. While i do understand the reason i am not sure how relevant that is. Why would anything only function with a fixed ID? Whoever provided that thing should maybe fix it. So i am willing to say that this is super-niche! And it deserves a niche-solution in its layer, not a feature in Isar. You could hook in a task between bootstrap and image_install. Or you could rebuild a bootstrap package to have reserved ids. You could run "the thing" in namespaces ... So is that really relevant? Please go into detail. Whatever happens i think the python rewrite is cool. But the code may have been coming/inspired from OE ... in which case it would not be cool, because it would fork away further. Henning > A rewrite of the image-account-extension in python was done on the > way. This allows us to drop a lot of encoding and parsing code that > was used to transition to shell and therefore made it easier to read > and maintain. > > Using python functions for more complex tasks allows us the usage of > unittests. A very basic infrastructure for unittesting using the build > in python unittest and the bb.parse module was added. This was used to > test the re-implementation of the image-account-extension as a first > showcase. > > Tobias Schaffner (5): > simplify image-account-extension > allow creation of users/groups before rootfs creation > create a minimal python unittest infrastructure > add unittests for the image-account-extension > set minimal python version in user_manual to 3.5 > > doc/user_manual.md | 4 +- > meta/classes/image-account-extension.bbclass | 391 > +++++++----------- testsuite/unittests/README.md | > 28 ++ testsuite/unittests/bitbake.py | 37 ++ > testsuite/unittests/rootfs.py | 45 ++ > .../unittests/test_image_account_extension.py | 175 ++++++++ > 6 files changed, 434 insertions(+), 246 deletions(-) > create mode 100644 testsuite/unittests/README.md > create mode 100644 testsuite/unittests/bitbake.py > create mode 100644 testsuite/unittests/rootfs.py > create mode 100644 > testsuite/unittests/test_image_account_extension.py >