From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7192601440996556800 X-Received: by 2002:a5d:6d41:0:b0:2bc:390:4cfc with SMTP id k1-20020a5d6d41000000b002bc03904cfcmr1238232wri.298.1674658041437; Wed, 25 Jan 2023 06:47:21 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:3d06:b0:3cf:9be3:73dd with SMTP id bh6-20020a05600c3d0600b003cf9be373ddls1247933wmb.3.-pod-canary-gmail; Wed, 25 Jan 2023 06:47:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXuIx2DeZk9hSTSESs75hXW0ynfRpdanVS6c9rCr8h4k40zDxW8FLahqDrqUj73lVGncbhrz X-Received: by 2002:a05:600c:a4e:b0:3db:14d0:65be with SMTP id c14-20020a05600c0a4e00b003db14d065bemr27477968wmq.34.1674658040213; Wed, 25 Jan 2023 06:47:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674658040; cv=none; d=google.com; s=arc-20160816; b=M8M6dK75D+y8KNblR36rd+Jf6iR5p1Tc6ImZGJ1UGfC0lI1trs14NHE+DYjhbGQ6/U hyag/1P0x2bwuZXcd1APJKHofQZqCikDPIWT82vpaensM75ZSwuvtJhH8P1y7RRwOJtY CFuaybyndhP16IaAKfNqSh2ZlK/iymlyWBxiBd/kpxsR/yV9eiO0NqSaOW5ojSlzp+Sl H9kGyPFAaDVyFQ7LPFZlcScYhMEhyWfkRuaeld+ot2G7OoKRrneEjRzvaziB1GGBKu+J Q6bxcibDLFcuVIwokP/ikOWMf0cc69KKEc06g3kXF82iw6ncHzoe01xfyCWzuVq0xS1h QkJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=QaV+SR0XMv60NB+Ovrx9wbP/gxOYEAWxPFTWEG5+/5s=; b=URc0ZbLBZdPpPd7HdW7jQocxIDjUs1oVw4SCmxlsz01wFDTdbWPOKjx9CX2KR6Gc5/ OGtYmRSIhSBtFHdbZnwG9P70AxLYetuPe/QCN+Uueu7Y4PreAqFGv33X2ah+Urio4oNx qhODaSEgbtRfFpbDLCNqdyTL2vyE1Ah8ct/l0fcvdFqGkrBI5UC+j6k2CpDBCXMmZ28J tqPk/1ZXNSDvOPwCVuGDQtLpxGHcqB8eqh7ln4XkcY9Rd+N16PYkvCmHgNMg2Ig2+OqD org+waPyFU1doS184z+ZhneiFn6RJ+L8IJT70TCemdcxbcqiy86L057ZdMAY0BmVpTiD to0g== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=CeC7lKp8; spf=pass (google.com: domain of fm-72506-202301251447197702bf3006a3a1b40d-yji_uc@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-72506-202301251447197702bf3006a3a1b40d-yjI_Uc@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-65-227.siemens.flowmailer.net (mta-65-227.siemens.flowmailer.net. [185.136.65.227]) by gmr-mx.google.com with ESMTPS id p33-20020a05600c1da100b003d9ae6cfd2esi132308wms.2.2023.01.25.06.47.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2023 06:47:20 -0800 (PST) Received-SPF: pass (google.com: domain of fm-72506-202301251447197702bf3006a3a1b40d-yji_uc@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) client-ip=185.136.65.227; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=CeC7lKp8; spf=pass (google.com: domain of fm-72506-202301251447197702bf3006a3a1b40d-yji_uc@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-72506-202301251447197702bf3006a3a1b40d-yjI_Uc@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-65-227.siemens.flowmailer.net with ESMTPSA id 202301251447197702bf3006a3a1b40d for ; Wed, 25 Jan 2023 15:47:19 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=felix.moessbauer@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=QaV+SR0XMv60NB+Ovrx9wbP/gxOYEAWxPFTWEG5+/5s=; b=CeC7lKp8J/37CTS8ru5R8j+hWUZmYhNJ0xDXGLLTm8q7m3AvWdm69CkA3pz9vNy/6sQGDa LIEjRaM4tmJAFsVKpEtdTQgf05DZzaX5KV+i/uQU2QRDL6ymAGGlzNbTUstotVR5oB6EM6ti O+CIrIqQn5JCPq2bq57XKYMxG+zKM=; From: Felix Moessbauer To: isar-users@googlegroups.com Cc: Felix Moessbauer , "Roberto A . Foglietta" Subject: [PATCH 4/4] warn only once in case file timestamps are updated Date: Wed, 25 Jan 2023 14:46:32 +0000 Message-Id: <20230125144632.2099908-4-felix.moessbauer@siemens.com> In-Reply-To: <20230125144632.2099908-1-felix.moessbauer@siemens.com> References: <20230125144632.2099908-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-72506:519-21489:flowmailer X-TUID: hTtfGeYBKkBc When creating a reproducible image, file timestamps of too-new files are updated in a postprocess step. This includes potentially many files. Previously, a bitbake warning was filed per single file, which overflooded the terminal. The new implementation simply prints a summary and gives a hint where the full list can be found. Suggested-by: Roberto A. Foglietta Signed-off-by: Felix Moessbauer --- meta/classes/image.bbclass | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index e59767e7..eb546084 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -447,11 +447,14 @@ EOSUDO # Set same time-stamps to the newly generated file/folders in the # rootfs image for the purpose of reproducible builds. if [ -n "${SOURCE_DATE_EPOCH}" ]; then - sudo find ${ROOTFSDIR} -newermt \ - "$(date -d@${SOURCE_DATE_EPOCH} '+%Y-%m-%d %H:%M:%S')" \ - -printf "%y %p\n" \ - -exec touch '{}' -h -d@${SOURCE_DATE_EPOCH} ';' > ${DEPLOY_DIR_IMAGE}/files.modified_timestamps && \ - bbwarn "$(grep ^f ${DEPLOY_DIR_IMAGE}/files.modified_timestamps) \nModified above file timestamps to build image reproducibly" + fn="${DEPLOY_DIR_IMAGE}/files.modified_timestamps" + if sudo find ${ROOTFSDIR} -newermt "$(date -d@${SOURCE_DATE_EPOCH} '+%Y-%m-%d %H:%M:%S')" \ + -printf "%y %p\n" -exec touch '{}' -h -d@${SOURCE_DATE_EPOCH} ';' | egrep ^f >"$fn"; then + if [ -e "$fn" ]; then + bbwarn "modified timestamp (${SOURCE_DATE_EPOCH}) of $(cat "$fn" | wc -l) files for image reproducibly." \ + "List of files modified can be found in: .${DEPLOY_DIR_IMAGE}/files.modified_timestamps" + fi + fi fi } -- 2.34.1