From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7182796543154454528 X-Received: by 2002:a05:600c:4215:b0:3dc:eaef:c1b6 with SMTP id x21-20020a05600c421500b003dceaefc1b6mr58811wmh.0.1675075511336; Mon, 30 Jan 2023 02:45:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:42:b0:2bf:ccef:53a6 with SMTP id k2-20020a056000004200b002bfccef53a6ls939909wrx.0.-pod-prod-gmail; Mon, 30 Jan 2023 02:45:10 -0800 (PST) X-Google-Smtp-Source: AK7set9jpghve+Ctk52mpxeswRgTnFGcBhgLx1XG21/xQXCtrfw2HCt5Xm2jZpM8y8daBJfv3Iyk X-Received: by 2002:adf:db81:0:b0:2bf:be7c:c40c with SMTP id u1-20020adfdb81000000b002bfbe7cc40cmr15675066wri.19.1675075510019; Mon, 30 Jan 2023 02:45:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1675075510; cv=pass; d=google.com; s=arc-20160816; b=rAw0PqVQ9jZHafL7NDDHHJ+QppzurhX2TgSt9Fzce7eQNdrF2316VgwwbIFMc3hdUm c5LYPCCmGga7kKNiV5Vu4hMWfIBYw9ql1gwimTM7YvSCu4NnRtWOhBGqqmujSxeEyO8F 37xL9W+lArlFVx3HNl+XXuId+mCi30vm2sJjYLjGx6xD2hMohPNaRSbEnIxwp0uvjZUf CmMd60kR3Nqw6pFRMH2saQoro13Tl0imo3td6MoSTF3Wb0OP1UpW8OwhLAhG1pT/ZvbJ GaKXVn0TbTfQeZgoU4Cr462QjwqHcCPlj7NqwOmoO/ouuknoKix5zLQs6MUJm0JDmSjx MZhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=/boq0JsC1wKSYIe7NuFzBnCP/NJjGQjQQA/ELc3aA6E=; b=XGXOr1/VhaNvQPcph3rwAodm8Cwh+5O0lZqf4Hqe8q3w7RVpbo1tBA7mZwS8uV7LJT AzcLFeRFrSNHL6cw0fCOd48+JO0l8HiB6IwWZ4WpDE7IdIdCR3nXzqM53bsAJ0E3cZfI ahfVaFUOUh9q6AVzIsEjTkzZx5DlvZ7LcTLJDa8LLz3x+c2fCq6COpjc6lsh3i8zAWJ9 0wNJWsKGHvk1WhnrZCvUPnSIFDbaa9+LUhixB4AccEfesXOouBwVCGTqK+4oOF28savw ZQcwXE5/FswP0Nonk4rhpFn5l9kiS2oN/+IqpqTU/jUpLen1gm5u15bHxujv4Sd5uC/T jWfw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=EchFJGYO; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe1a::60f as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060f.outbound.protection.outlook.com. [2a01:111:f400:fe1a::60f]) by gmr-mx.google.com with ESMTPS id cc15-20020a5d5c0f000000b002be29f05cdfsi597055wrb.0.2023.01.30.02.45.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2023 02:45:09 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe1a::60f as permitted sender) client-ip=2a01:111:f400:fe1a::60f; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=EchFJGYO; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe1a::60f as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlXfNgMuVrxijB0Rb3RXs4fKIpIjlyiQjLOROr6sbWsaCdKl9XM7CCXE71XgJGgo79zu4/FNH/E7loIVlDofyCLes7zBv648cjOwNpRiPdKac+xgz2fVAzl18Mf/EPchVdpZzl/RoqO1sRHG+44oPzfvj6+FCE2kHdjAWnhYQsnzPxD/iOIt3Dp8zz/J5yShCAWZTyygRML64pGWCo8xqJojl+clU8aT6EQrpF7OOVzSW2l0mactGXT+EhdLKXQEsaDud6Cm0ArYEQNQlLIHqCoRsRI7wZXs/N7VszPRYVAOCC+OpKX5FxhPpqzOglxUusuMtqu5Kn0IU+5D6f4jbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/boq0JsC1wKSYIe7NuFzBnCP/NJjGQjQQA/ELc3aA6E=; b=HjwH+oFqtoQAlMRzehM/bO/jsGtVzhBjQLpVReocU4Mh0ucgYwDbi/EFuxhOnaBy5WKM/RGRNDEfEcoi8ceiQb27HqJ65v94JenXxzvBWCZdFF7Fe4WAo9cbGG+RUyAI7pre8YzW9zCc8wheWaJHXOrNcE2hFNDOMml2hni2FmXQa0dqpqMDKHre8QVuD3k7njlMfKj+JN7LhRQaBvCOai5RiyFgE7bCrf85RfD9yWRLmZzAW/tkbBqfrvinrWkofKJouhiSxisOvwuXoffrg0JYQn8xzXe3rIOn8d4rG9x6Ni+FFKytT4FzgCYUb+B8uMatx8GgfpTUMH9WQkHcfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/boq0JsC1wKSYIe7NuFzBnCP/NJjGQjQQA/ELc3aA6E=; b=EchFJGYOkNrmcz39nYh+phMFEjCH0hEI8zKz6SyQYKYyqDUyOs7gZnV7IkGXqzKuQxkD3OQkoFiArOM/wDxQnlF4iinODCqy46UURgnInTUeSWqGcDe035dzBYaqM7UsYe5Ra4A1C5auIsQeG5mP4jbaTrqjOMjxLQit19lCwicqILkdOM015nUeoFogdiZ65y1tqJUp6Nk3zgqw66N7U4LVlqU3TF9OrDn9zwVllzYbWcGp7vgtAiWzBaYunbFLleZRH1/zDrGe7pUqeZIM8IJ4dn0SDgKv12QsR3FPRDyGK1ai3YoXMV05k4VYfbCQ7vdEFLwgUI22iope1jw6FQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DU2PR10MB7786.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:46e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Mon, 30 Jan 2023 10:45:08 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::bdf0:fdeb:f955:bc79%3]) with mapi id 15.20.6043.033; Mon, 30 Jan 2023 10:45:08 +0000 Date: Mon, 30 Jan 2023 11:45:04 +0100 From: Henning Schild To: "Moessbauer, Felix (T CED INW-CN)" Cc: "ubely@ilbers.de" , "isar-users@googlegroups.com" , "Kiszka, Jan (T CED)" Subject: Re: [PATCH v3 0/5] Improving apt cache Message-ID: <20230130114504.51e78b03@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20230120073106.5453-1-ubely@ilbers.de> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::11) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DU2PR10MB7786:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f5d9b07-296c-45e6-16bb-08db02af0e4a X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zhU6y0+DeQ0g5EPnXj31SzyVoISaXuxufy/XkNohzd18DV4fomqJlL0bYxLL+uL+Dvsazie7Tmk2x2IPvxsQaOnqxXc2Z7i1//9WAB1FPUviIMmGNVlxvbKyV8c3t1kwB+NBF+dp88FRCFeRhq6EjGsnxlhvmacBcIpUPy6ammXtMwiJ4bWiNNEwDVynEI1VZl3VzABmOY/1sIvUomgb5ZymZ6sOgnqaEhntOajPszYmgdaluoEUjgZ1Avmtr17zeQ0CvnS7GNKwmkQWFHpUJkPr2Dq7006p+deFMroK3I7XH8HaSrQwhGbl1Ff4eZNeoQ7WbXrKp8d2XdSTv25UwaqeRUu3R/oM69nXl7aRVnW4nDE8URz2TFALGnPxQsSysNNngruOM0DL442outRcRmZaH9GoNRKpjWxtxfHOtgmXQErBdAlO18YvXJFvBkLvOkp0+qmunOFFJKfvo/X8B0gSPbgpstNZ+HO94SNAEBbmNScH15wP7Jgxhw5fV/5NI4HeTkaXLvMHZDEICd7tLPLd6YTiThuoIb5Kp9rorYSjtEPDqR+RDzLFgk02T49SETWheJU4YFDLchLR2uVbPa1Rtk1Wlvm6EGUvlLKRKpDWuuA9HUdtGbGcbNdWLzoQ/0PNg8W1LypTv0XHPhNUlQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199018)(6636002)(54906003)(316002)(4326008)(6862004)(66946007)(41300700001)(8936002)(8676002)(66476007)(66556008)(86362001)(38100700002)(82960400001)(107886003)(6506007)(1076003)(6666004)(186003)(9686003)(6512007)(44832011)(2906002)(5660300002)(83380400001)(478600001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1SIzP3NkwOm0p88JrhUrB59ssEs6LtXwF1TnEmQyOfTj9/kSKJg4puWRxhY4?= =?us-ascii?Q?EGQinpX9+eEwrJ8/44U8fOihtZeY/RJPmRKYs5n98WVC7FuTO0ebEK1a4YsB?= =?us-ascii?Q?5hkeJD++Mh3b0+cw1iFATG0niqrgTCa0SwGOz+hKhFdp+dFGh9Zsgb6AjU32?= =?us-ascii?Q?pyO8WYWE7qoWdsE3jjqVCS/3ekB1aiqgnYrkbfO1rXyjRgQZras5OJFPFf21?= =?us-ascii?Q?MNWlKyICeTDf9mNzMxkToHlcRMyGQGfy56fv3RBx5Nm85SnWcZRd8JnmskgY?= =?us-ascii?Q?0h1ZMW4nS/8RvJNZ1u6SCBv+79ci48KN/6N0119I1r8iNSnZT/hSOHY9mJKT?= =?us-ascii?Q?vMua1TbQRNjf1pwa1Byd/YW50ChNxu2kKL0eqjK2km+klo50DPMecoScHHD1?= =?us-ascii?Q?Lw/EG63l4l4gaBTRg4gtd18bW275/ru5Msa7MAT93UmY/oW0HVqnEMvMMYwT?= =?us-ascii?Q?rx5x4CpbM6RIQxgsnWN1ZP8UMYxhK/fmDzsp73ysY83QSlmhPba/EesO+Isx?= =?us-ascii?Q?n0GlUwXqhFXrXvfSWHNdbTyvKnd/G050j2lmDIzNk42zy87iVp6aEiHAzP+B?= =?us-ascii?Q?BmMSdX3p4z1s/V7W4j0BLRgnkH7UtpuIiYRdasDeB4cSyVcNXkZEnDlxA0n0?= =?us-ascii?Q?LtK/vV9mrNhGX5JHbNqhJURnstktXLnOOIkBGDdbA2dcHSU1fkF9xqO2d+Jl?= =?us-ascii?Q?1e4mn33rPCuoGE9TDNb4ncEbpmsEQJg5xDI5I0bRZziY7l2p70ZsJoegsCsO?= =?us-ascii?Q?XVjavX6AeA/WlTvwVyUaQiL8ANsQNNf0+f0pdcF0EOdK+ao+6se9q91OYvu9?= =?us-ascii?Q?PWxcxt+qBB6C5V0quNICXhUnaYVPfuN4LGQuyoopAQ1eyw1kdQX8eT2GA19D?= =?us-ascii?Q?QBOrbbEULDHMH+jNGgIESUAaWv1KOJP+9hd6RTHB1pInUnvzSKN8rJjSgIgY?= =?us-ascii?Q?nUCBwC4TO0txXoqybCjbmolTNc2hQE341o3YU2JphFqRxU72xZto5c1NXUFU?= =?us-ascii?Q?WrUdVfp//Ocf+19qm9uv4Nq42uVXUc05vkckRi6wXQQkT6Xq+RGQAw4DTpCg?= =?us-ascii?Q?mE1haNyLZw0ZrQF3zKs0pXUjWEgkC0zzIJ+m+9dqIM8GUEuDznIZmBklW7Gb?= =?us-ascii?Q?cPY1wExaq2R9vMK4dBzqrr4uQqYbtkJztxbyteqzYwGIBtKlXmrkYBRLuptI?= =?us-ascii?Q?dq0wmLylP4gfX2V3smioAzn3Nyle90pQdtiS2a1R71DegVWxghWjst9mdQUS?= =?us-ascii?Q?B8K508XP3c98VOHGLTJnfiOdGKQDbARC4Du8FrwibMCd9qRnf8T72DJPOX5/?= =?us-ascii?Q?uqNL0F7EoarNW2szTlOLJ/cZF/v9Ik1iESBEDpE2wci9Muq5DCxgv74pkmRV?= =?us-ascii?Q?/AjvlmqCNSWDDz7eoMVV2G7wzeDI7ZEkF58DpPEHkv8NnHMSw06s5VlYwATR?= =?us-ascii?Q?volX+KqYBSeCVjqCZFZrtEcASszbBfRE3SkRHaGUfvAQiSlPKHgOdGDuQ/jO?= =?us-ascii?Q?XRN0QEDY0JGUR58G6S/IgfFQ9FO5WhpxBsIHQju+UsMLwT8zi/vm+EurE5gP?= =?us-ascii?Q?Q6p8UMDKjzuJr7tdA5W2z3KfQmXgo9V1rg3pxkxHYXz86sO7tvFWT54a7OYn?= =?us-ascii?Q?Jo7FuEEOLV8iJA3y2I408WY7udVXrpS73jIlKmoHFBcF9h0JY/MqlKL+vSiw?= =?us-ascii?Q?Y3F2XA=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5d9b07-296c-45e6-16bb-08db02af0e4a X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 10:45:08.7669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: evdAoJQlO3WY576RH7IHSs8IO89s/4A8lEh2GtjlMqpvDZYLZAHmPYnvpyrynyMi9EvjDmtzRkz4nVrO7S11pQe8ffNZ8XPc8cIHgDS6qTY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR10MB7786 X-TUID: k19i0nru6/mX Am Mon, 30 Jan 2023 09:45:45 +0100 schrieb "Moessbauer, Felix (T CED INW-CN)" : > On Fri, 2023-01-20 at 08:31 +0100, Uladzimir Bely wrote: > > Currently, apt cache (e.g. `var/cache/apt/archives`) import and > > export > > functions are not optimal. Multiple files are copied from global > > DL_DIR to package WORKDIR, increasing disk IO and space needed. > > > > Also, various chroots (bootstrap, buildchroot, sbuild chroot) > > include their apt caches to sstate cache files. > > > > This patchset switches to hardlinks instead of copies and removes > > apt cache from bootstrapped images ans sstate caches. > > I just saw that this pattern does NOT work in case the cache is on a > different filesystem. This unfortunately is the case for all CI > systems with locally mounted caches, as well as for kas-container > builds with DL_DIR outside the KAS_WORK_DIR. I remember discussing that issue with someone because that is always what happens when you implement hard linking. Not sure it was on the list because i kept away from this lively discussion. It is like when someone adds overlayfs and then finds that it can not be nested a few weeks later ;). One way to go is to try hardlinking and fall back to copying or mounting or whatever the slow/expensive case is. I once wrote patches for wic doing a "if not hardlink, copy" that were needed for Isar and its chroots. But if the cases we care most about would always take the "slow path" we better not have two paths. Henning > In short: This breaks a LOT of use-cases. > I'm really sorry that we only found that by know. > But we definitely need a different solution. > > Example output: > 2023-01-30 08:38:51 - INFO - | ln: failed to create hard link > '/builds/iiot-edge-device/foo/meta-iot2050-pg2- > foo/build/tmp/work/debian-bullseye-amd64/isar-bootstrap-target/1.0- > r0/rootfs/var/cache/apt/archives/gcc-arm-linux-gnueabihf_4%3a10.2.1- > 1_arm64.deb' => '/local-cache/meta-iot2050-pg2- > foo/downloads/deb/debian-bullseye/gcc-arm-linux-gnueabihf_4%3a10.2.1- > 1_arm64.deb': Invalid cross-device link > > Best regards, > Felix > > > > > Changes since v2: > > - Don't use CACHEDIR.TAG, simply exclude var/cache/apt directory > > when creating rootfs tarball for sstate-cache. > > - Use symlinks when exchanging deb files between WORKDIR/rootfs > > and /var/cache/apt/archives inside sbuild chroot > > > > Changes since v1: > > - Simplified cleanup of apt cache in debootstrap rootfs. > > - Now "ln" instead of "cp -l" used. > > - Removed apt cache contents from sstate cache. The idea is > > proposed in patch 3, but it was reworked and fixed. Firstly, > > CACHEDIR.TAG can't > > be just a file (e.g. created by 'touch'), it should include some > > specific signature [1]. Secondly, it's easier to just create this > > tag in bootstrapped rootfs and it will be automatically used in all > > derivatives (sbuild-chroot/buildchroot/image). So, the original > > patch from Roberto A. Foglietta was simplified. > > > > This patchset includes (or absorbs) the logic from p1..p3 patches of > > the series Roberto prosposed. What concerns additional patches, they > > don't let us benefit much, but require quite significant changes > > in Isar, so we should check twice if they are worth including. > > > > Uladzimir Bely (5): > > Clean apt cache from debootstrapped rootfs dirs > > Use hardlinks in deb-dl-dir import/export > > Exclude apt cache from sstate caches > > Use symlinks when importing debian packages to sbuild chroot > > Lightweight copy of rootfs directories if possible > > > > meta/classes/deb-dl-dir.bbclass | 4 ++-- > > meta/classes/dpkg.bbclass | 4 ++-- > > meta/classes/imagetypes_container.bbclass | 2 +- > > meta/classes/rootfs.bbclass | 7 ++++--- > > meta/classes/sdk.bbclass | 2 +- > > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 6 +++++- > > 6 files changed, 15 insertions(+), 10 deletions(-) > > > > -- > > 2.20.1 > > >