Re: [PATCH] Reinstall imager deps if package in IMAGER_INSTALL has changed.

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 30 Jan 2023 10:07:41 +0100
schrieb Uladzimir Bely <ubely@ilbers.de>:

> When debugging packages in `isar-apt` that are in IMAGER_INSTALL
> list, they happen not to be updated in the resulting image.
> 
> For example, in case of u-boot IMAGE_BOOT_FILES is used to generate
> files for `/boot` partition. Buildchroot is currently used for
> extracting required files from `u-boot`, `optee-os`, etc. These
> packages are installed in buildchroot via IMAGER_INSTALL list.
> 
> Since modifications of the packages don't change their versions,
> updated packages don't go to buildchroot, so previously used versions
> are wrongly used. The following can be seen in log:
> 
> "<package> is already the newest version"
> 
> This patch forces reinstalling all the packages from IMAGER_INSTALL
> list if some of them has changed.


That makes some sense anyhow. But we should really watch out for such
issues and demand version bumping when contents change. Maybe not for
every recipe. Or we should include all recipes for IMAGER_INSTALL into
the sstate input so the cache gets invalidated and the chroot gets
rebuild from scratch.

Henning

> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/classes/image-tools-extension.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/image-tools-extension.bbclass
> b/meta/classes/image-tools-extension.bbclass index 101704d0..640e1958
> 100644 --- a/meta/classes/image-tools-extension.bbclass
> +++ b/meta/classes/image-tools-extension.bbclass
> @@ -35,12 +35,12 @@ do_install_imager_deps() {
>              -o APT::Get::List-Cleanup="0"
>          apt-get -o Debug::pkgProblemResolver=yes
> --no-install-recommends -y \ --allow-unauthenticated
> --allow-downgrades --download-only install \
> -            ${IMAGER_INSTALL}'
> +            --reinstall ${IMAGER_INSTALL}'
>  
>      deb_dl_dir_export ${BUILDCHROOT_DIR} ${distro}
>      sudo -E chroot ${BUILDCHROOT_DIR} sh -c ' \
>          apt-get -o Debug::pkgProblemResolver=yes
> --no-install-recommends -y \ --allow-unauthenticated
> --allow-downgrades install \
> -            ${IMAGER_INSTALL}'
> +            --reinstall ${IMAGER_INSTALL}'
>  }
>  addtask install_imager_deps before do_image_tools