Re: [PATCH] expand-on-first-boot: really only do that once - reverted back

[Henning Schild <henning.schild@siemens.com>]

NACK

Am Wed,  1 Feb 2023 16:53:35 +0100
schrieb roberto.foglietta@linuxteam.org:

> From: "Roberto A. Foglietta" <roberto.foglietta@gmail.com>
> 
> The proper solution is to wait that udev settle ends and then try to
> access to the disk that in some architectures are down to a bus not
> initialised at boot time because the boot happens from a separate
> partition usually internal to the PCB/SoC.
> 
> After all, this script is supposed to run just one single time at the
> first boot and thus the time spent on it has no impact on the
> every-day performances. Moreover, in case of failure - which is more
> probable in small embedded systems - the system goes in production
> without the full disk capacity for which has been designed for. Small
> embedded systems those usually unsupervised or remotely supervised,
> thus introducing a potential source of nasty failures which could
> hard to detect expecially if the disk becames overloaded or complete
> full.
> 
> To avoid all these risks the only reasonable approach is to set these
> systems in such a way that they will reboot continously until they are
> not provided with the full disk capacity. In such a way they will fail
> at the day zero and this will be easily catch by the deployment tests.
> 
> This patch affects also this setting and definetely should be reverted
> 
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>
> ---
>  .../expand-on-first-boot/files/expand-on-first-boot.service      | 1
> - 1 file changed, 1 deletion(-)
> 
> diff --git
> a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> index 90c92a39..fda50016 100644 ---
> a/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> +++
> b/meta/recipes-support/expand-on-first-boot/files/expand-on-first-boot.service
> @@ -15,7 +15,6 @@ ConditionPathIsReadWrite=/etc Type=oneshot
> ExecStart=/usr/share/expand-on-first-boot/expand-last-partition.sh
> ExecStartPost=-/bin/systemctl disable expand-on-first-boot.service
> -ExecStopPost=-/bin/systemctl disable expand-on-first-boot.service
> [Install] WantedBy=sysinit.target