Re: [PATCH v3 07/15] CI: install qemu-system when qemu testing is requested

[Henning Schild <henning.schild@siemens.com>]

Am Fri, 03 Feb 2023 11:33:38 +0300
schrieb Uladzimir Bely <ubely@ilbers.de>:

> In mail from Friday, 3 February 2023 07:44:18 +03 user Uladzimir Bely
> wrote:
> > From: Henning Schild <henning.schild@siemens.com>
> > 
> > And also change gitlab ci config to request qemu testing.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> > ---
> >  .gitlab-ci.yml      | 4 ++--
> >  scripts/ci_build.sh | 5 +++++
> >  2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index fcdefa87..6a49ce43 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -27,7 +27,7 @@ fast-ci:
> >    except:
> >      - schedules
> >    script:
> > -    - scripts/ci_build.sh -q -f -n
> > +    - scripts/ci_build.sh -q -f
> > 
> >  full-ci:
> >    <<: *common-build
> > @@ -37,7 +37,7 @@ full-ci:
> >      - PREVIOUS_SHA="$(cat .CI_COMMIT_SHA || true)"
> >      - if [ "$CI_COMMIT_SHA" != "$PREVIOUS_SHA" ]; then
> >            echo "$CI_COMMIT_SHA" > .CI_COMMIT_SHA;
> > -          scripts/ci_build.sh -q -c -r -n;
> > +          scripts/ci_build.sh -q -c -r;
> >        fi
> >    cache:
> >      key: "$CI_COMMIT_REF_SLUG"
> > diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> > index e5f20d4f..960ee94e 100755
> > --- a/scripts/ci_build.sh
> > +++ b/scripts/ci_build.sh
> > @@ -127,6 +127,11 @@ fi
> > 
> >  if [ -n "$NORUN" ]; then
> >      TAGS="$TAGS,-startvm"
> > +else
> > +    if ! command -v qemu-system-x86_64 > /dev/null; then  
> 
> For now, this check is not changed to testing
> '/usr/share/doc/qemu-system/ copyright' or something more general.
> 
> Additionally, it might be good to use "--no-install-recommends" to
> install less dependencies. For example, under kas docker image:
> 
> ```
> sudo apt-get install qemu-system
> ...
> 2 upgraded, 232 newly installed, 0 to remove and 78 not upgraded.
> Need to get 228 MB of archives.
> After this operation, 1,084 MB of additional disk space will be used.
> ```
> vs
> 
> ```
> sudo apt-get install --no-install-recommends qemu-system ipxe-qemu
> ...
> 0 upgraded, 56 newly installed, 0 to remove and 80 not upgraded.
> Need to get 92.1 MB of archives.
> After this operation, 423 MB of additional disk space will be used.
> ```
> 
> Package `ipxe-qemu` is definitely required for network working. But
> for now I'm not sure if we don't need any more packages here, this is
> to be checked under Gitlab CI.

Thanks for the update. I propose you apply those changes, since you
took those patches into your series. And i will try it on gitlab and
see which packages might end up missing.

For a super quick test it would be handy to have a branch to pull,
instead of an mbox workflow. But i can do both, especially not with
patchwork it is actually as quick as branch.

Henning

> > +        sudo apt-get update -qq
> > +        sudo apt-get install -y qemu-system
> > +    fi
> >  fi
> > 
> >  # Provide working path  
> 
> 
> 
>