public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: [PATCH v4 13/15] testsuite: Fix terminal broken after run test executed
Date: Mon,  6 Feb 2023 13:34:00 +0100	[thread overview]
Message-ID: <20230206123402.2727-14-ubely@ilbers.de> (raw)
In-Reply-To: <20230206123402.2727-1-ubely@ilbers.de>

If some of run tests executed from interactive terminal by hand,
user input goes broken after VM powered off. Commands user enters
become invisible and terminal can be fixed only by executing
either 'reset' or 'stty echo' commands.

Fix this by specifying 'stdin' value for qemu subprocess.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 testsuite/cibuilder.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py
index c6a1eb67..72522f4d 100755
--- a/testsuite/cibuilder.py
+++ b/testsuite/cibuilder.py
@@ -262,8 +262,9 @@ class CIBuilder(Test):
 
         timeout = time.time() + int(time_to_wait)
 
-        p1 = subprocess.Popen(cmdline, stdout=subprocess.PIPE,
-                              stderr=subprocess.PIPE, universal_newlines=True)
+        p1 = subprocess.Popen(cmdline,
+                              stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+                              universal_newlines=True)
         try:
             poller = select.poll()
             poller.register(p1.stdout, select.POLLIN)
-- 
2.20.1


  parent reply	other threads:[~2023-02-06 12:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 12:33 [PATCH v4 00/15] Add developers test Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 01/15] CI: Enable downloads dir sharing Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 02/15] CI: Add IMAGE_INSTALL override Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 03/15] CI: Add developers test Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 04/15] CI: Remove duplicated targets Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 05/15] CI: move to avocado to 99.0 Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 06/15] CI: fix shell coding style Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 07/15] CI: install qemu-system when qemu testing is requested Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 08/15] testsuite: remove tests from "fast" set Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 09/15] CI: Get rid of setting cross from outside Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 10/15] CI: Make cross compile to be default Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 11/15] CI: Get rid of setting repro from outside Uladzimir Bely
2023-02-06 12:33 ` [PATCH v4 12/15] CI: Allow example module checking disabling Uladzimir Bely
2023-02-06 12:34 ` Uladzimir Bely [this message]
2023-02-06 12:34 ` [PATCH v4 14/15] CI: Update testsuite documentation Uladzimir Bely
2023-02-06 12:34 ` [PATCH v4 15/15] CI: Add single target test case Uladzimir Bely
2023-02-09  8:39 ` [PATCH v4 00/15] Add developers test Uladzimir Bely
2023-02-09 15:46   ` Henning Schild
2023-02-10  2:42     ` Uladzimir Bely
2023-02-10  9:44       ` Henning Schild
2023-02-10  9:51         ` Uladzimir Bely
2023-02-10 10:19           ` Henning Schild
2023-02-10 17:13             ` Baurzhan Ismagulov
2023-02-10 19:54               ` Henning Schild
2023-02-10 20:04                 ` Henning Schild
2023-02-12 17:16                 ` Baurzhan Ismagulov
2023-02-10 17:36             ` Henning Schild
2023-02-14  5:43 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206123402.2727-14-ubely@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox