Re: [PATCH] imagetypes XZ_OPTIONS replaced by XZ_DEFAULTS defined in bitbake.comf

[Henning Schild <henning.schild@siemens.com>]

Am Thu,  9 Feb 2023 23:41:48 +0100
schrieb roberto.foglietta@linuxteam.org:

> From: Anton Mikanovich <amikan@ilbers.de>
> 
> imagetypes, bugfix
> 
> A previous patch moved XZ_ variables declarations into bitbake.conf
> from the imagetypes class. In such patch the XZ_OPTIONS has been
> renamed in XZ_DEFAULTS but the XZ_ command in imagetype class has not
> been updated. This patch fixed this bug which decreases performance
> and alters the expected behaviour.
> 
> Requires:
> 
>  * bitbake.conf: declare default XZ and ZSTD options

Fixes: 924aa382ca26 ("bitbake.conf: declare default XZ and ZSTD options")
> Signed-off-by: Roberto A. Foglietta <roberto.foglietta@gmail.com>

Good catch. ACK, thanks!

Henning

> ---
>  meta/classes/imagetypes.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/imagetypes.bbclass
> b/meta/classes/imagetypes.bbclass index 0cff440f..7d193d2e 100644
> --- a/meta/classes/imagetypes.bbclass
> +++ b/meta/classes/imagetypes.bbclass
> @@ -98,5 +98,5 @@ IMAGE_CONVERSIONS = "gz xz"
>  CONVERSION_CMD:gz = "${SUDO_CHROOT} sh -c 'gzip -f -9 -n -c
> --rsyncable ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.gz'"
> CONVERSION_DEPS:gz = "gzip" 
> -CONVERSION_CMD:xz = "${SUDO_CHROOT} sh -c 'xz -c ${XZ_OPTIONS}
> ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.xz'" +CONVERSION_CMD:xz =
> "${SUDO_CHROOT} sh -c 'xz -c ${XZ_DEFAULTS} ${IMAGE_FILE_CHROOT} >
> ${IMAGE_FILE_CHROOT}.xz'" CONVERSION_DEPS:xz = "xz-utils"