From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7198290085259771904 X-Received: by 2002:a17:906:b081:b0:886:2823:423e with SMTP id x1-20020a170906b08100b008862823423emr3144571ejy.284.1676025129661; Fri, 10 Feb 2023 02:32:09 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:4026:b0:4ab:4b0e:590c with SMTP id d38-20020a056402402600b004ab4b0e590cls1222639eda.0.-pod-prod-gmail; Fri, 10 Feb 2023 02:32:08 -0800 (PST) X-Google-Smtp-Source: AK7set8OCUfSNsfSW3X9Oy65ekpvanP8e0KeKAUbH4DM3So3FkQLlu7JZBSWa4GWjVmr8arCTbcl X-Received: by 2002:a50:9e23:0:b0:4ac:8359:10c with SMTP id z32-20020a509e23000000b004ac8359010cmr13857ede.19.1676025128442; Fri, 10 Feb 2023 02:32:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1676025128; cv=pass; d=google.com; s=arc-20160816; b=lPoCDCBbKyB4ScA4iTiba/Z/yuMoE1Cn/peuA4D9XS1vO3yhNn0HUTljEVbEdREkOf IxXIKw2+0ne9CX3tfYDK0/QTvyYH0y0htVCu2ODmgS/8Yrwzs7hflaOnxjTw4x4LOVbc fh/ftjrAVvjJ7oThSfF3h0hCc+lhmqVeikmn2HWDhDi7HK1TGb/TaB6uYMuivoRJyrxh T4oDUIrZUOigsgfJccKHjnwchjx45K1Wx7xDrYBMKNHUqW8iDoB1DLUljL3isFQ5t9ZP i4z0T+B5Kqon++uzMjQLdVL9+vWrRNhLfEjzph7F12ZkLEUSPLa8kC1LX0clivJBJrBb nCNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=BWt+q0ut2EZ+SZkIxCVzgUwMYxTmjczpjqik/fpaEkg=; b=K3PQWB/RbN2FbwEbLDpVAI+l48Q6yfLAv350XmMm0lPwZl3mpHr0ileshv+QQw/D6c jkWYyBaUiqPvHHUhMuEIunl0Pw83Z2Utqj5nkiNjgN6SqLiPRes9DehG6k91olS5Gyyc d3YCtUEp8qC/xYhJjIuS8lgdSDAt2qvQPhAwZMKhcF/3U1mERaQQq1BoOI7WO6Eqp8ag zjntJHpZgSwC3kzhFLpVqJzN8tyJBNPCvkKLUsNkuxiVHovVIfPgksAUttdAipnkcx/x OJiKb6+NXwwOqYT+GwaYSGIOQ8xIMOy8yI3WFhQO5lLxHYBk2N3G1QwkcthNyutd6FXD VkWA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=AwWVaHgp; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::602 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20602.outbound.protection.outlook.com. [2a01:111:f400:7e1a::602]) by gmr-mx.google.com with ESMTPS id g35-20020a056402322300b004ab3a681994si99476eda.4.2023.02.10.02.32.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Feb 2023 02:32:08 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::602 as permitted sender) client-ip=2a01:111:f400:7e1a::602; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=AwWVaHgp; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:7e1a::602 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R+Zz2ml2iTj+OuQw+qO+mJZBuZB7sTaIg6C5JHsWjV47iT7TEncxwP5snXjfN10VbUUF2cnKV+XGhO+f47FZG1vcbMEuRxBtK9f0NwJhSaedJu0+r3vXg9fDADECtsQkHL1+aRA9dsBvUCpIciFB8jx9hCCLuyWNlMH+ehXuERTv+HhIoWkaO6kUjZSV9RizozzSqasgtuOiP+gm87PsVfvzrf0QJ6uR5XFHS5EwVQRHCvu/9huF1XHw+jZJwYxC4fcM6KPzYZfifBX/aULlWY3JfZIyJyOwPyckj608Gj9mgXot79kpFx2lRjKnxbfbDpwN7BKNHkWB5er+5WmXQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWt+q0ut2EZ+SZkIxCVzgUwMYxTmjczpjqik/fpaEkg=; b=CoDrzhb0RaQyzNKc6Wc+N9odLmr975zOVB6eeY9x6Ymdfv+QfpQ/SdI15FvQWGMGTm+72Vo7XQejWEz/eHqLgrvqxQlNQZs3eJ5+1FHzcHUnlaKxIxNp6QgzXwt4klqArzLFjiqi3vjxpI73OFH+wx5B48Jl1rRTuGo21HC5PKp5+XDrLj/FGdZQgIMzc4+BumxVydW/KIEOR9+6OJukVtAov6fSnIYb0COcJKsh5JYrSjTPS2AVXWpXz3Mv04aXX4c1vNtdyoHnmRbp+s1GSLZXTbHr52Lk/NqFRPUdwzKjah9XTlVDDQyIeIqYkejHZsBN5obti6caxFek+QxSbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWt+q0ut2EZ+SZkIxCVzgUwMYxTmjczpjqik/fpaEkg=; b=AwWVaHgp9OCvOmWdKP9XcwCRbSEy54amdHMW+MrCK4eO3PtlTkFFXJFIZuURZnJjVvBBSZET0WyikvFchskOxbr2wPZ4Es7RJogD15beFZPl0zfD21+Z3j7jcmSvRwvHvnsHCXrOWCLdGluVF4RjhuXRFmfY7rJugzcnkuuKo5Gegm8tQvf5MHGod95xM7QdkYQFeNcvPyrua+IFLg6oPDnu2eGd77vuhPTC/xBz6hsvNuaolN7IC/77/gWzTjLSPshzOlBnpzq0ZqoxdfQc4ZxafHggZd46TfdRVdhbcyxQPZ5+5l8VG8YFdrSydkVAWwnxkG88oShKGvc1gtOc6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DB8PR10MB3163.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:118::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 10:32:07 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::ee44:171b:4c40:d42c]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::ee44:171b:4c40:d42c%6]) with mapi id 15.20.6086.020; Fri, 10 Feb 2023 10:32:07 +0000 Date: Fri, 10 Feb 2023 11:31:59 +0100 From: Henning Schild To: roberto.foglietta@linuxteam.org Cc: isar-users@googlegroups.com, roberto.foglietta@gmail.com, Anton Mikanovich Subject: Re: [PATCH] imagetypes XZ_OPTIONS replaced by XZ_DEFAULTS defined in bitbake.comf Message-ID: <20230210113159.76dfe260@md1za8fc.ad001.siemens.net> In-Reply-To: <20230210112714.513d3264@md1za8fc.ad001.siemens.net> References: <20230209224148.60152-1-roberto.foglietta@linuxteam.org> <20230210112714.513d3264@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR05CA0061.namprd05.prod.outlook.com (2603:10b6:610:38::38) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DB8PR10MB3163:EE_ X-MS-Office365-Filtering-Correlation-Id: 602639dc-1a8d-4c3f-4e20-08db0b520f0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BE6saSk4MCXvRxn9DzD8xj3Rhfb530wPHarF/8mPFdrdyAF+3HVRG8aCahNZxhghthOPj2aRwID2czvrsePxtCLnnOpf/l2ooAJt97Y5n1S/Bny6pOoBPb0/utsS5Nd7YsWytsFte5xsyEQttTdHexWy3U80Gsdm3Teo+2Mdl1ZUQv4dW14qyhtqQ85XOJvvMvOLtaeZmO9HerZ46jF2B8b+kwTqrC6eaGREFy2FvEyZumn0yTBxLFTRJsW7UOjUFBXx+nr/LC+nrNNEwdVgUrw3KAynkKj4YToUfwfHMR1SEYnAswyaowliNDCpCNX4cwe1Xt5er4QhpGk68wnhn54c4NtTo7L5dh6y/Uxfd5Hh52B0ICl4w0lf+A2T7jEUYf//BbL3zSGMgLirBHsw53ZmmGHVa6sze/NHrTZt3x7PhLlZJkQheZQPFqGIYOp7EwYL9Ft+T22/vANTBShvajEvYwUA0tYRpIzQiTha+zxjQHpVr9bTmgmSqlH2ySG7Keqn/BNobm/GUrbKhPtPSyMSHx89C4AUFZ6qqzUdK8glpaFB7nyOEzuvBMeeSN7eyMFpuh+xRtntxeBSNK8sYoJJdUNAKtVblgVQeO2sfEW+9clrVKqRlCZ5yh5Njhsg6Ea7eRSr8946x26aEmkIZxJgKG4N268u0BB1IOihN14= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(39860400002)(136003)(376002)(396003)(451199018)(186003)(478600001)(26005)(6486002)(966005)(5660300002)(8936002)(6666004)(1076003)(6512007)(9686003)(6506007)(41300700001)(316002)(6916009)(8676002)(4326008)(66556008)(66476007)(66946007)(83380400001)(82960400001)(86362001)(44832011)(38100700002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L3Y0PpA18zCtVafGxERBaFB2/NYaoWpsl8vVY/JKlcfNonLhdq562HetGfhb?= =?us-ascii?Q?Sp/4k24Qu6XnnBsuyHZ4ZzOlmprNE8p1sAxh+MSpmEICqsZS/tkpOavlfPGu?= =?us-ascii?Q?esB80wpL/kRoCzpmPPlsT+gfRGwxDxUjw8Q1FTl7sD9CiuW2XGSmiJTl87vu?= =?us-ascii?Q?RzTqvQsrFYdIVIKpsLVisGKttEMLowXNZItB3LhJnv3+vFl+mv5izvaS3x4i?= =?us-ascii?Q?RsvOFOJ9h0ZBJajBTIxI+T9loNsBPrMYDNxTrIsPWfu8fS0NEaXy9GBF8OLU?= =?us-ascii?Q?JzwnxyVh7pyH3TDdm5P7LxIQ4j6CWoiJc0lPrYpwiwjOhWn/COhUarIavCtk?= =?us-ascii?Q?1MLo1fsnfAyzJmIESRrRd1UcvRRztc2Pfk59ykeb51m4s0CCsvnGA7CwTGk6?= =?us-ascii?Q?NGgl4iFtREji/JFrw5iXu6omiCsEvz6tkuRd9AmoDnxwDYtxSlQ/0KTUss44?= =?us-ascii?Q?enSDQWknW8Qkc6Sh9jeGj1zfg4i+f6kXliCUB6um6teziwuRJlkspwPK7uD8?= =?us-ascii?Q?g3l3m66BHYEROhwyrMV8ucrTlg/BGl69WBpa3TMeznuynQzGh1lsQvk2/Hf9?= =?us-ascii?Q?0dV0qDHKP79Dx2lyCjK1BmQBLYNTaoR69S9lNKejCB11DarYDqkOfvNB7+Br?= =?us-ascii?Q?dfvlaFQTD/ILgH6IYHFShkcK2gxFxLFyOUXyVdClRPuIki7F0VR8bYqswGaQ?= =?us-ascii?Q?9YVUBSVzy3X5rEZGeoUe3b8Qm7KntaM6TRcxg1jDXoGRUVbwn6S0MIbFrP9n?= =?us-ascii?Q?JSyr/FH+cexA5IW11j3qMj4VIFeDYrYsnRhwrAZbr3i7bmoy7Cff4KlVKvlw?= =?us-ascii?Q?rfYUuAWbuK6OHDHlf5x4HwFJA/Y2+YyeO74A5SsbAv8uinUuMr4ENzJjw6Fe?= =?us-ascii?Q?aI8tKMsv6akgbwrtD0Vgke7S1Mn4b0kDy8Y9WfvSBdmbZeMSWUDBYQLRJW5S?= =?us-ascii?Q?sf9Pf87o6TMwhgXeMTQSXVSE+PslFYVZJpNCGOMwcxjQ1OA8M1ROI/OsqSGy?= =?us-ascii?Q?zWp54ivAaYeh35IBr+mpcqjFB9tX2NENbBylLITBPHQaVf+UbZwSq7qAzBZX?= =?us-ascii?Q?TRTQZp/dKCdJCz6t+QnDbZpLkxSgRWZpA0vSlGy7yR9Rd8SOGQ4amyDE+9SM?= =?us-ascii?Q?unMQG7bDoYnFUYQDctprHCUwi1b8bHvxXQ/X+ld3hLtugjDx4JGeFw41DPrN?= =?us-ascii?Q?+5V/nmb6kk78TO+h5GkD5vlIKtqjo1M7HX79kNCRd1T5izzfhxLY2z/oC1f+?= =?us-ascii?Q?xqDUijutiu4YVS2erofrXLN52NDSMpUbUR6HzalueFr6i8HMpDgKKBHb0zQ8?= =?us-ascii?Q?HxnipY3Y4mX+lZ6MnaLlt5gO6N+mmKtjtutkjjbuoBpHc2N5kfZz15y9BXIS?= =?us-ascii?Q?iDXSr+W6lJokeKi8azQjp1nhoBekM7qqsn0Z2vAM4++QXdDb2ET+alrzrclj?= =?us-ascii?Q?ObNtABHdVbYnxVe6eb42+9itaIV8IqyGmku+HfQLRIIdOA+uSWaMe4RM81yg?= =?us-ascii?Q?18TTJ8eUuwEDvH3Q9JOUNk4nm+RbvQCx3XiXtDc47hFTXYiZOhgm3t0QX0rQ?= =?us-ascii?Q?ntjZgU/VejzQCbspU9uPQabrNg0mwUu/jiQm4LXcZS4/lrt21CLqJuUriIAD?= =?us-ascii?Q?Hg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 602639dc-1a8d-4c3f-4e20-08db0b520f0b X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 10:32:07.1773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HUnGa2tOR6ven2EljkM4omsjrx99Ck+3crpytguFvugHeDdet88JFc03dk/xYO6nVTJQHpQ2iQX/y4ZOWWKxErPvBg2oaLoBzfXm9hPusa4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3163 X-TUID: wzeUB3+U6q9g Am Fri, 10 Feb 2023 11:27:14 +0100 schrieb Henning Schild : > Am Thu, 9 Feb 2023 23:41:48 +0100 > schrieb roberto.foglietta@linuxteam.org: > > > From: Anton Mikanovich > > > > imagetypes, bugfix > > > > A previous patch moved XZ_ variables declarations into bitbake.conf > > from the imagetypes class. In such patch the XZ_OPTIONS has been > > renamed in XZ_DEFAULTS but the XZ_ command in imagetype class has > > not been updated. This patch fixed this bug which decreases > > performance and alters the expected behaviour. > > > > Requires: > > > > * bitbake.conf: declare default XZ and ZSTD options > > Fixes: 924aa382ca26 ("bitbake.conf: declare default XZ and ZSTD > options") Not something isar uses, but it is nice to know and does not do harm. taken from https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-your-changes last bits of the paragraph Henning > > Signed-off-by: Roberto A. Foglietta > > Good catch. ACK, thanks! > > Henning > > > --- > > meta/classes/imagetypes.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/imagetypes.bbclass > > b/meta/classes/imagetypes.bbclass index 0cff440f..7d193d2e 100644 > > --- a/meta/classes/imagetypes.bbclass > > +++ b/meta/classes/imagetypes.bbclass > > @@ -98,5 +98,5 @@ IMAGE_CONVERSIONS = "gz xz" > > CONVERSION_CMD:gz = "${SUDO_CHROOT} sh -c 'gzip -f -9 -n -c > > --rsyncable ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.gz'" > > CONVERSION_DEPS:gz = "gzip" > > -CONVERSION_CMD:xz = "${SUDO_CHROOT} sh -c 'xz -c ${XZ_OPTIONS} > > ${IMAGE_FILE_CHROOT} > ${IMAGE_FILE_CHROOT}.xz'" +CONVERSION_CMD:xz > > = "${SUDO_CHROOT} sh -c 'xz -c ${XZ_DEFAULTS} ${IMAGE_FILE_CHROOT} > > > ${IMAGE_FILE_CHROOT}.xz'" CONVERSION_DEPS:xz = "xz-utils" >