public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Michael Adler <michael.adler@siemens.com>
To: "Moessbauer, Felix (T CED INW-CN)" <felix.moessbauer@siemens.com>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"roberto.foglietta@gmail.com" <roberto.foglietta@gmail.com>
Subject: Re: [PATCH v2] feat: add zstd support to image conversions
Date: Fri, 10 Feb 2023 15:18:04 +0100	[thread overview]
Message-ID: <20230210141804.hvzpi35ldzlgh6y3@backstein> (raw)
In-Reply-To: <fc1e781825de8d7abcfec4a791574b725715785f.camel@siemens.com>

Hi Felix,

> This probably also needs to be renamed to ZSTD_DEFAULTS to be
> consistent with XZ_DEFAULTS.

I agree that it probably makes sense to use the same naming scheme
(<algo>_DEFAULTS) for both xz and zstd. Thanks for the heads up, I will send
v3 in a moment.

> The details have been discussed in "imagetypes XZ_OPTIONS replaced by
> XZ_DEFAULTS defined in bitbake.comf".

well, but in my case it's correct because I use the same variable name
(ZSTD_OPTIONS) in both files :)

Kind Regards,
  Michael

-- 
Michael Adler

Siemens AG
T CED SES-DE
Otto-Hahn-Ring 6
81739 M�nchen, Deutschland

Siemens Aktiengesellschaft: Vorsitzender des Aufsichtsrats: Jim Hagemann
Snabe; Vorstand: Roland Busch, Vorsitzender; Klaus Helmrich, Cedrik Neike,
Matthias Rebellius, Ralf P. Thomas, Judith Wiese; Sitz der Gesellschaft:
Berlin und M�nchen, Deutschland; Registergericht: Berlin-Charlottenburg, HRB
12300, M�nchen, HRB 6684; WEEE-Reg.-Nr. DE 23691322 

      reply	other threads:[~2023-02-10 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10 13:45 Michael Adler
2023-02-10 13:57 ` Moessbauer, Felix
2023-02-10 14:18   ` Michael Adler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210141804.hvzpi35ldzlgh6y3@backstein \
    --to=michael.adler@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=roberto.foglietta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox