Re: [PATCH] images: Complete account related exceptions in do_rootfs_quality_check

[Henning Schild <henning.schild@siemens.com>]

Kind of hard to read what was changed and the commit message is also
not too verbose. I think i get it so ACK.

But i would suggest to sort that list in a p1 alphabetically ... no
change just sort.

And later do the real change in a p2.

You sort and add in one patch, which makes it hard to review.

Henning

Am Fri, 10 Feb 2023 20:19:03 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/classes/image.bbclass | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 539ec51d..ef7d5a2a 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -482,10 +482,12 @@ do_rootfs_quality_check() {
>  	        args="${args} ! -path ${ROOTFSDIR}/etc/passwd \
>                            ! -path ${ROOTFSDIR}/etc/subgid \
>                            ! -path ${ROOTFSDIR}/etc/subuid \
> -                          ! -path ${ROOTFSDIR}/etc/shadow- \
>                            ! -path ${ROOTFSDIR}/etc/gshadow \
> +                          ! -path ${ROOTFSDIR}/etc/gshadow- \
>                            ! -path ${ROOTFSDIR}/etc/shadow \
> -                          ! -path ${ROOTFSDIR}/etc/group"
> +                          ! -path ${ROOTFSDIR}/etc/shadow- \
> +                          ! -path ${ROOTFSDIR}/etc/group \
> +                          ! -path ${ROOTFSDIR}/etc/group-"
>              ;;
>  	esac
>      done