From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7198608925382410240 X-Received: by 2002:a17:906:9381:b0:878:8061:e114 with SMTP id l1-20020a170906938100b008788061e114mr1423175ejx.0.1676058322899; Fri, 10 Feb 2023 11:45:22 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:f22:b0:4aa:d8d1:5599 with SMTP id i34-20020a0564020f2200b004aad8d15599ls6221538eda.3.-pod-prod-gmail; Fri, 10 Feb 2023 11:45:21 -0800 (PST) X-Google-Smtp-Source: AK7set+xvTeFdDwn4FMMybJn3uJE5u1dHXPkooSvG7DRomV/E2lpx1Lu3WkjoZBWBytf076Tqu4c X-Received: by 2002:a50:d58c:0:b0:4ab:2555:408a with SMTP id v12-20020a50d58c000000b004ab2555408amr5501667edi.22.1676058321676; Fri, 10 Feb 2023 11:45:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1676058321; cv=pass; d=google.com; s=arc-20160816; b=on20mAnboh5tjKzFoH8Vqz7+6fdiWa16Lja3n1JysjxN7Mnv9spKzlS0xcmE/S+qCI m0yjp2Q3xXMFGivKE+XzBrA+7miSgW1s3pcM9U7G3s9heVOzdVIiY9zNrOEArSCYNw6h I8dpP1yS2iSjobTHIZraMQyZsiixCZzDV26u8OIVZGwg2Tb5IsIqPEkgIiJRhVXf5odq leOoPsYa6X6q8v6oeHyii5SqH08FQl0ohkhxXM8nD2J6ZuxJ5Os/zdT1sTkEhtQbel9p BIjDxeJqEdPXEuG11RTQ4PgXQN5aj+07aGwtdpZXcdIuudVNEz1n/Tlu528hOFE1JVEN 2MkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=iw6QKK+QRBD2AkKTVzI06qTfAYDvXN1VXVULES9IUPo=; b=ZPisop/c1zXjUuInBo95AxMcByhqcpC8tPPJt2o/4jBcj5/TtEY88hPOULqDhQ4oL2 HgTRkDuTPQ3kiBtWYHBxtBpqnRIf8pYB3ZsWnv4G3jGiYkAgUILkKVct4EJy7nNDChmm a2v1OlOSC6UhMyhLad9ZhPfz1ww7MLHN5hcaegwZZxBPVVqg11jQx7Tnwt+a312gzo0v JfEV4MLV3+YcL0EHE7pCVaIFBWQ319oSalNyAHp4Lez4RmrWrFQRmnqzSLQxdxtL0903 jyTmOZTRM6+ITOtuNSiI6lA7F3GfdepKeyeO/N7Sg0q1FPFOSgYDY7xqF+t70GNLy5+1 hcDg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=MKokrUDr; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0c::607 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0607.outbound.protection.outlook.com. [2a01:111:f400:fe0c::607]) by gmr-mx.google.com with ESMTPS id d5-20020a056402400500b004ab260791f7si193058eda.5.2023.02.10.11.45.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Feb 2023 11:45:21 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0c::607 as permitted sender) client-ip=2a01:111:f400:fe0c::607; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=MKokrUDr; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0c::607 as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gumNU7WWaW9yR//DCnxpUXAvLsUVKpvu3npIxUuoPxloqtdaQxYSmodDFhArTIAdJlXneSDgthR9H+hlo34tfjFf4V6MalesIVI70cxegbpiSzq6zHiGX6XKr3F1+/PsJZwpCorOrCM0mY75B3nFCDOriQ9HROszSyjJ4O+lv4phEPi5KM2LVVx9qNT4uKAep1+l6AscYZCpskjsEKJxg46kvG4adpamMQiDdev+5thz2dEOX06MvWzT+yadJ9TCaamhUJQVWpt41YEmym2Szznv2TmW9vjvKboNJgbdYlnAWrMMyNej0ga63W4OBlANyQssL79eM4VjFNREiD/yzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iw6QKK+QRBD2AkKTVzI06qTfAYDvXN1VXVULES9IUPo=; b=SzLGTeeIdlCc7+MQC0MThsGfnvefxnLt/XsbfW0Ztdkqbarl1zurSNUHAV6T+3Hw4F6FH9mv3FcLjKsLSs5Kx5/kpywTcX6mykyvD77P+VhWr621iY4O/F7Kh2zrwwmctSsg6LO3LEDaTkohq55gKrz2OszsjMuZwAm0DtRrp4e0uMZllpGye6OoQU85K5oL99qG9XUnlPQtnAm8oH30+QiiG2QF+5dpooTmvbWypbNhbWdiUUFqn9TbpNEMAuO2wSDkXi/S6aS9uS8yB4N+JfmSxkOihpiCHUbKg5CQMFhfyusg0DkSIJlOLO1Jsuem6p+Fw5yRqRhgIOXayUGNhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iw6QKK+QRBD2AkKTVzI06qTfAYDvXN1VXVULES9IUPo=; b=MKokrUDrQqx36N04FH86Hzu9+pvPRqgCz+VCNF90K67VgbKqf3g8hLAeMDfdlvgZA6E6cKGKn8cmA2TdGi/TuLfhCxXi60f0mfLlVHJBfkCS30RZS4k+AavsqzAVvwFOPt+5KI95BisoTg+GKanVs2UlT1kuypcl6bUW4JNVPIS0ZddG14OdrOnF/bybuAJRM+eZWvJr7A3HNJsRAOAD64uK1XTZJKlAe3VtV/La25pqxurtJ2NDG5NC9zGF6p1HXcX0zzTprM2retSF5bls4BUgi8GOPOrAuNljAdxG2KisrukPcTmzS+srZ5C80xAA+jv7j9Swd4QKWQW6DggTLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AS4PR10MB5741.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 19:45:12 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::ee44:171b:4c40:d42c]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::ee44:171b:4c40:d42c%6]) with mapi id 15.20.6086.020; Fri, 10 Feb 2023 19:45:12 +0000 Date: Fri, 10 Feb 2023 20:45:01 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users , Quirin Gylstorff Subject: Re: [PATCH] images: Complete account related exceptions in do_rootfs_quality_check Message-ID: <20230210204501.1efeebe5@md1za8fc.ad001.siemens.net> In-Reply-To: <4fe96d1a-0e9f-ac8b-7f65-582ef6b33bd3@siemens.com> References: <4fe96d1a-0e9f-ac8b-7f65-582ef6b33bd3@siemens.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR04CA0004.namprd04.prod.outlook.com (2603:10b6:610:52::14) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AS4PR10MB5741:EE_ X-MS-Office365-Filtering-Correlation-Id: 47b419e3-591e-49da-7282-08db0b9f52ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M5a83fVGZsKh1pZgc9P2mfGhtRgop3wSVt4jGmCif9HUN1C3D/58DX02Lc/KXErECCdydl6bt/AQ7d9QJVytj30c+0DY2SQ7kz/yi+XnSgmy+HmdevTFKgZ4DJgt+KNyH3XdsjhogM0vKdSjcUpq1PILcrCUWT5CeKxAwd/zTuEy13sfRIP2TnvkFzZkMRcvwKc7FUanKoNMBHK9/CfAnNWoHqdVijZtvCPBD/ZOpb5aRgK0FPC4eQh+otKIYmjeaysuUyOjF+nCIzdZ61sAoLtb22yNh059cGXs69pFas2Tjvz1A5IdYIKLhvQ9tYADyfN6THNj330oFC/A2uOfXkx6uZI4OMVRTthwI43SAt0U5MfBRYsBsJxr4ivdQLK/GRAuDbK5BvGW+XzMXhyfOoOuoM7JKdQuAffHwtVkwUw93pkXxBxUzMp1O+j6iFLRWlqXDn2fh8UtVFETrHSpFN4vMkZ02OvGYSJcv8kAd2qmhHCgY1AdEe0dtph1buu4eqflww9nQWSyGPoRwWlSoslrco5NKlEMAE1rVhfHZbdEQL3EE/9tBrTc4FHN93U8CRkv/YDedl2OlXi1b8aBdxRNZo4t0Sppwgp1Lp1O6DQ4EbYHNZJcG6csVgD0BOyS9UNATUUY7Z/GXJeB+1LqZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199018)(6512007)(9686003)(1076003)(107886003)(6666004)(6636002)(478600001)(186003)(6486002)(66556008)(4326008)(66476007)(66946007)(8676002)(41300700001)(8936002)(86362001)(83380400001)(38100700002)(6506007)(316002)(54906003)(82960400001)(2906002)(44832011)(5660300002)(15650500001)(6862004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3Cx8o+BJLSjT376NtwrlTlaGfXLqJXJWm0nQEUQ6p9vXGZ+apnb2I28033bD?= =?us-ascii?Q?gyPIFDP9wj7mUnMXs4PIHdILkPBQNvaqUog6PVU29FnRAeaYlwNCJk7cnv0O?= =?us-ascii?Q?LjeQIkAezI/wyjyRt+T0lLZD5Fb1d2gx/0F3b/8/7CyKlY8EtEjFm2yqmXQT?= =?us-ascii?Q?SlimFaWbVd1cAlJKeP9hgBs6YmeBBQyNaFHTAcU3jvWBfb9HSYA8w3cj+Tjz?= =?us-ascii?Q?3coA0XLca3a1E4pe0ASCW0rAw6ez6SWv1CbCny9c7A9Qb8imMaxqNfvx03C1?= =?us-ascii?Q?NoCFlgX/qZ87W5GNiOZorDBqDihnl/OkSEw1u7d6sLi1jUIebhPC4bhyb/wW?= =?us-ascii?Q?+M1VBNDFBQk9Wjb/DPQQgiqhvfYBPNL9I2Zyt7oQPutDsoiAjo6zIf21RksE?= =?us-ascii?Q?JlJvm1pLzYj3ia+MPYDVIsih6xiSeLn5sptm+7G+vYEfBytPf2hZaAYI9NvH?= =?us-ascii?Q?RwYfQ5szzsjd6OUgSfT5bX5jm2dwXs5dHYKNKdDVAQaALFrzVxRPW9VOxzz/?= =?us-ascii?Q?0SYFi0UbuzfCRZSd7/+EGZn2yW2pk7Zh/GcpZWrER0IYjDHyJg2tGt8IjC4J?= =?us-ascii?Q?DhiolrX3xmCqFlJdG1wwAHooPKc8M1KBaWgTumcS5EwRKpPgf27hBxHdzlDn?= =?us-ascii?Q?yw2kdt4t4ehk6g4b3AvzghUpczlzbCO2XASrgIcabvBW47ZJdf+manlnyoEx?= =?us-ascii?Q?ZIXe4PE1a7ChGSZ1R5WrLuNsQz5tbeZRPPEfCMo6MKC2i+mtG0BnPSs3rvWw?= =?us-ascii?Q?z/iGB280mL2hJU+JddMzWA0dAEJu+UnLh3uIlcnQDtEmbXEWl3kOdNPStNUV?= =?us-ascii?Q?5WQxxABtO2CFmT7MPFw4k86EgFxJf6IYWXxHut9v3oT+QrXYJsj5piUr1qmE?= =?us-ascii?Q?S3LZzMd07PZLEwbsoVgXk9TVOnFFMeTVbP8UQdvlHfbnKD6N5qh0SibRZneE?= =?us-ascii?Q?02JOdJlUCrcVLlcUhcjgX+bC1H4TGl7KvB5WCba80lSmX+0Kv66lczwDbXPW?= =?us-ascii?Q?bZAC2baNPH9RGxK4u91h+VnnL+v4Ka1fFy2itFLegtDhLc+gEmkNqEqUqdjX?= =?us-ascii?Q?BURuDEu5kTRvDFzYw3r+lnbhbKk5GdFHWvebdeqceUQIwJ3yUpjMXFXp3dXJ?= =?us-ascii?Q?P1qqfT4Zzh+i9PX7fR/Pb9t3sX1xRe/5vxUYvLS5N5YeDWUCkYiZYyGAX7zI?= =?us-ascii?Q?XC5/v4RDK1zEDpkUq9y9TYmFEwigEikUg8AOgNlvpemY6iH0tIxTfTybg58G?= =?us-ascii?Q?NtlGIBqqYDizRCsa0k0wlDZnrTDRHEEV4HY37AeX1sQ/fbOLZdvJ2xSP1K2I?= =?us-ascii?Q?wTWF++CIgiWYCQSiStGpTkG/1ZQATgGfdVWwuDMmc4dfZBfprlO50u5WguYU?= =?us-ascii?Q?roEc0YT+2qYnkJJEUxIAbmRbPcSlF0XoyIE8Y7M8YEWg8XkrdeGg2SOwOrrn?= =?us-ascii?Q?odyUsVgxW1m5Q2tjk9KBwF5EfcBvv9o/uFxGAVFpjOtbcRYR9zZWh4R8hTeX?= =?us-ascii?Q?4KRauteZc3hIUuSVviYKknnPIIxN578+Rrz+SR+eUi6yVcf7eclV8HXGI0DM?= =?us-ascii?Q?6Ub2qRoqM+KkKrhgyARsxnTImwMxBleP0tCQ+K1hYLiTOVBwaY7nRze3kxGm?= =?us-ascii?Q?3JVbJg7XTKbLJvOdecvR8P0KUKUBQpmILyIJpqqWOfuVHr1Ab0NrADTE/RyZ?= =?us-ascii?Q?4G281Q=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47b419e3-591e-49da-7282-08db0b9f52ab X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 19:45:12.0230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J02vhY4BZw7GO9udYyu5kWljhrHzl3WiZsGHCom1Flg5ki0q6IpPEWLsyPPBt9pXHPXJRURepoeD6DhEAzfBwTziwX8n3BrLwtSy1rl/hqQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5741 X-TUID: P63Wus/IWO0d Kind of hard to read what was changed and the commit message is also not too verbose. I think i get it so ACK. But i would suggest to sort that list in a p1 alphabetically ... no change just sort. And later do the real change in a p2. You sort and add in one patch, which makes it hard to review. Henning Am Fri, 10 Feb 2023 20:19:03 +0100 schrieb Jan Kiszka : > From: Jan Kiszka > > Signed-off-by: Jan Kiszka > --- > meta/classes/image.bbclass | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 539ec51d..ef7d5a2a 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -482,10 +482,12 @@ do_rootfs_quality_check() { > args="${args} ! -path ${ROOTFSDIR}/etc/passwd \ > ! -path ${ROOTFSDIR}/etc/subgid \ > ! -path ${ROOTFSDIR}/etc/subuid \ > - ! -path ${ROOTFSDIR}/etc/shadow- \ > ! -path ${ROOTFSDIR}/etc/gshadow \ > + ! -path ${ROOTFSDIR}/etc/gshadow- \ > ! -path ${ROOTFSDIR}/etc/shadow \ > - ! -path ${ROOTFSDIR}/etc/group" > + ! -path ${ROOTFSDIR}/etc/shadow- \ > + ! -path ${ROOTFSDIR}/etc/group \ > + ! -path ${ROOTFSDIR}/etc/group-" > ;; > esac > done