From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH 05/11] CI: Set default QEMU timeout to 10 minutes
Date: Thu, 23 Feb 2023 17:41:25 +0200 [thread overview]
Message-ID: <20230223154131.132362-6-amikan@ilbers.de> (raw)
In-Reply-To: <20230223154131.132362-1-amikan@ilbers.de>
Also remove default value inside bash script.
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
scripts/ci_build.sh | 7 ++-----
testsuite/README.md | 4 ++--
testsuite/cibuilder.py | 4 +++-
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
index 7382862..9f62db5 100755
--- a/scripts/ci_build.sh
+++ b/scripts/ci_build.sh
@@ -52,8 +52,6 @@ show_help() {
echo " -T, --tags specify basic avocado tags."
echo " -q, --quiet suppress verbose bitbake output."
echo " -n, --norun do not execute QEMU run tests."
- echo " -t, --timeout SEC specify time in seconds to wait before stop QEMU."
- echo " The default is: 300"
echo " --help display this message and exit."
echo
echo "Exit status:"
@@ -62,7 +60,6 @@ show_help() {
}
QUIET="0"
-TIMEOUT=300
# Parse command line to get user configuration
while [ $# -gt 0 ]
@@ -97,7 +94,7 @@ do
NORUN="1"
;;
-t|--timeout)
- TIMEOUT=$2
+ TIMEOUT="-p time_to_wait=$2"
shift
;;
-c|--cross|-r|--repro|-s|--sign)
@@ -154,4 +151,4 @@ set -x
avocado ${VERBOSE} run "${TESTSUITE_DIR}/citest.py" \
-t "${TAGS}" ${PARALLEL} --disable-sysinfo \
- -p quiet="${QUIET}" -p time_to_wait="${TIMEOUT}"
+ -p quiet="${QUIET}" ${TIMEOUT}
diff --git a/testsuite/README.md b/testsuite/README.md
index d8adc7f..10fbd79 100644
--- a/testsuite/README.md
+++ b/testsuite/README.md
@@ -39,13 +39,13 @@ $ avocado run ../testsuite/citest.py -t full --max-parallel-tasks=1 -p quiet=1
## Fast boot test
```
-$ avocado run ../testsuite/citest.py -t startvm,fast -p time_to_wait=300
+$ avocado run ../testsuite/citest.py -t startvm,fast
```
## Full boot test
```
-$ avocado run ../testsuite/citest.py -t startvm,full -p time_to_wait=300
+$ avocado run ../testsuite/citest.py -t startvm,full
```
# Running qemu images
diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py
index 5eebd5a..65eeb4b 100755
--- a/testsuite/cibuilder.py
+++ b/testsuite/cibuilder.py
@@ -15,6 +15,8 @@ from avocado import Test
from avocado.utils import path
from avocado.utils import process
+DEF_VM_TO_SEC = 600
+
isar_root = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
backup_prefix = '.ci-backup'
@@ -262,7 +264,7 @@ class CIBuilder(Test):
def vm_start(self, arch='amd64', distro='buster',
enforce_pcbios=False, skip_modulecheck=False,
image='isar-image-base', cmd=None, script=None):
- time_to_wait = self.params.get('time_to_wait', default=60)
+ time_to_wait = self.params.get('time_to_wait', default=DEF_VM_TO_SEC)
self.log.info('===================================================')
self.log.info('Running Isar VM boot test for (' + distro + '-' + arch + ')')
--
2.34.1
next prev parent reply other threads:[~2023-02-23 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:41 [PATCH 00/11] Next avocado improvements Anton Mikanovich
2023-02-23 15:41 ` [PATCH 01/11] CI: Update Avocado version Anton Mikanovich
2023-02-23 15:41 ` [PATCH 02/11] CI: Add avocado version checking Anton Mikanovich
2023-02-23 15:45 ` Anton Mikanovich
2023-02-23 15:41 ` [PATCH 03/11] scripts: Add option to directly specify avocado tags Anton Mikanovich
2023-02-23 15:41 ` [PATCH 04/11] gitlab-ci.yml: Run dev tests set on push Anton Mikanovich
2023-02-23 15:41 ` Anton Mikanovich [this message]
2023-02-23 15:41 ` [PATCH 06/11] CI: Make quite option to be set by default Anton Mikanovich
2023-02-28 6:40 ` Cedric Hombourger
2023-02-28 7:18 ` Anton Mikanovich
2023-02-23 15:41 ` [PATCH 07/11] CI: Remove norun option Anton Mikanovich
2023-02-23 15:41 ` [PATCH 08/11] CI: Enable sstate dir sharing Anton Mikanovich
2023-02-23 15:41 ` [PATCH 09/11] CI: Enable ccache " Anton Mikanovich
2023-02-23 15:41 ` [PATCH 10/11] CI: Update avocado install documentation Anton Mikanovich
2023-02-23 15:41 ` [PATCH 11/11] CI: Add documentation for test case creation Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223154131.132362-6-amikan@ilbers.de \
--to=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox