From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7211363025731715072 X-Received: by 2002:ac2:5deb:0:b0:4db:3ab2:896e with SMTP id z11-20020ac25deb000000b004db3ab2896emr4222018lfq.6.1679041075278; Fri, 17 Mar 2023 01:17:55 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:bd14:0:b0:293:12a9:1ca5 with SMTP id n20-20020a2ebd14000000b0029312a91ca5ls852556ljq.6.-pod-prod-gmail; Fri, 17 Mar 2023 01:17:52 -0700 (PDT) X-Google-Smtp-Source: AK7set/r8o917tHVQoNdvtlv2yb2cIPDj51nDOykZoy1+1IQ591rKeQJ1yX8IJUlMFypF3DA3fIM X-Received: by 2002:a2e:9e13:0:b0:299:3ea1:e4c9 with SMTP id e19-20020a2e9e13000000b002993ea1e4c9mr2043544ljk.20.1679041071967; Fri, 17 Mar 2023 01:17:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1679041071; cv=pass; d=google.com; s=arc-20160816; b=RBYu7sUhvy1mNN98CZZEhc3RbMDNmtt2BAC7z1JemiUMxP74yBNd3LsWbIdtXG9/d9 7hR7HcDJ5JQnssVi66lO4jbFB7abinOChvt2Th/tsajY9AwuHIW0ApcsLn426e4au7B2 kMx9dKNyc7gZAW+9II9boIpm6fkMAuWkaJwrT6hiAozjjGIZ0QeXuVpjWXsPAuKYaCTO tcYTBIr0YvEy6wf5rHlPAOBcxEqFv686Fu6WdFcd3VanepqzttIL1ynNjgxfKL14EcmP D+yGkH3P09BAnIrbh21mJmsymhKtU4deRnVDEJDCEURxyUQ9CT2FEsqKnGZBEqIBFfkq Gnjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=S9S9j3FOqy1oprWH5M85JgS79QPPw6R1oRh/gq+UPKA=; b=sFhEcbHWSpVGHqAGVXhPF0XUpaXENFtKa+cfnbgUqwYuwsxN0p0mRNnUny4mqDUUgj YPQ1sP4IVaI8bJRImyCmwS1vSfPqv7LrtvInTH70VX4nMgR9mgEYjzIJsTyOY+htBIz7 UQUCGX75nBd3uZ/InsZIxy4osOuiRc3fCsmt8dFhRm06WZFKkF7PFTFnn/03A8jK3yqN kPuyBDAzk/1ir3VQ+7sZtvWtev8ycB55QZBWCvp/E1kVlvG4F/V1qVctfASOPIt2/1pb WMZqWTguAqy9Nh6W41DtcHvpIhJjO5H7z1WKli3gb34ECUFINleMJ9F/Omu0HgH/WQrA l9Pw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=CeMPdl40; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0d::62b as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on062b.outbound.protection.outlook.com. [2a01:111:f400:fe0d::62b]) by gmr-mx.google.com with ESMTPS id 5-20020a05651c12c500b002959f20a2afsi72697lje.8.2023.03.17.01.17.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Mar 2023 01:17:51 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0d::62b as permitted sender) client-ip=2a01:111:f400:fe0d::62b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=CeMPdl40; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe0d::62b as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YD7ZiqNf2Z1TNyeq+id9wcNI9IbEMve87nOYtpggiiDB2bPjOFm0+P9lp0OPbHcipvpM2YOFQLI0Fex7bq13CKBEO30YPADM4cjUx+7vr90mG01Z2N8PPr7kKwbPupJOeOWopAXP+RlGEyJuK4uTZutgqg85x17fbtIobhUl0StCB0Xll+ty9AvmLdcekggPkK0LLJ5a+hROqDRfnMRkmH1ZKs43iugshH4k0vIWKr/IFnr7A/xGXienaIQK2ixgb/lyxfbgnQ6fE+8iDQSXZl5BT3ymw74aG3s9hVxDpK5H3zBmV+XbKzxuqfKHMYQCE/ti4392MijS1BWT4bhg6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S9S9j3FOqy1oprWH5M85JgS79QPPw6R1oRh/gq+UPKA=; b=jfFPkPj2N8rBVbgOtT1SlkCwh7FK5IQfIRNbewOnlbMy1N6Vtub3vNCeRziPEZad5QiZ/iKxdlEZQrMsyfonQhVxWS0H27HWqigwk9V6cabwVRVGDaWPmX+SPoU4V1nu8ySYMWCITyUJJiav4ySz//SFFJYLUiEclSrm5gQDI3z94m+aIYd30IftNvI56QYgP6zV7hR9aUXYvb3TL01Nu0/vqG5HZ2n0GbpSGvR177q2E1mI38jRCNtF1ct+l2eUjG/4wRf4nHv6JnV6WKuccUwAtRQluKOsrtyG9ICmdsm9YAFS+hAnw/QrXcKsbuKqmtSRPACjO/wZR2+a9hjwkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S9S9j3FOqy1oprWH5M85JgS79QPPw6R1oRh/gq+UPKA=; b=CeMPdl40Kfa9U96uWcLyrqOiA/5WJoTR3fIqasNvApfWi1ycEFeUt5Xp0YXpBP4Zopbivl8Kft4gVpDHRM1ibX66sQeHjt9QhtXG7eCx+ov1Rx8wJmRaHYamAV4o9o4IVvVeSiIBpV2aatjjwXaS9br4IJaoiKIFYoonSw9R/EXhvJI0czK3o9/+Hf9nxc0Khy1C97eBU9/XHmkkWBn/e8fxdAnCFU8DUcKeKA1m7I45tiXL9FtoASybtJaEJ1CStgX56QDt49cKrJduiYOM6ZIAahLtf04eUxEPjUoeDA8nEGEtZR+NgxRyUIaL+P0GxH9b2vewJpJUeXNX8+DP7w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by AS8PR10MB5879.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:527::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.8; Fri, 17 Mar 2023 08:17:50 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::f777:d35e:83f2:6148]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::f777:d35e:83f2:6148%4]) with mapi id 15.20.6222.010; Fri, 17 Mar 2023 08:17:50 +0000 Date: Fri, 17 Mar 2023 09:17:40 +0100 From: Henning Schild To: Uladzimir Bely Cc: isar-users@googlegroups.com Subject: Re: [PATCH] testsuite: Improve SSH ping Message-ID: <20230317091740.7e8bee9c@md1za8fc.ad001.siemens.net> In-Reply-To: <20230317041130.7987-1-ubely@ilbers.de> References: <20230317041130.7987-1-ubely@ilbers.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0411.namprd03.prod.outlook.com (2603:10b6:610:11b::27) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|AS8PR10MB5879:EE_ X-MS-Office365-Filtering-Correlation-Id: 535c7a00-b2ce-490e-4784-08db26c01906 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MIf+7tBbWOiDrMXPwy32/PIykvkQLaQR5pIDuuSsVFsnDymjnof+MguOwMaabL7Z04D4FGqbUQ6+nP8qM+BTL68Bj0WuUNJ+Aj8a/RY40EF7TzPM2akXIyUTRDGfhUv8Q3fWP1g1eIH8UGIQtzOCiTx/bjYnO2hjjOaXmCZgZijPUtNoHDOzkaX+hBC+iohbR4BCOIfW+oF+gvDsHVZQfcJxSn1CLR597GyewBnpYDWnk4yZLROjh093bo76ksIK3D1QZeuKMa8zV5FlxstX2IxV1bBioaFpjtb8VIupaijwBvVfVN7Jl0qO1M7Bf21hDV5/LOKhGF4J7QNMOPTd2qfQB9tBTXiDwrKt7SaT3ciKu5S65tRTW+inHTv4GPVYQ6kibcNUGufF/y9tLVD5QwymLoOR8Kf/3uF+o0zEBQa4hAAHPDDaawJX/FPdDoSPsZLV8Fpkv50orKuR+to6jmw3ZD2tbEQPe+M7tGiAa8Bj9Mq6xni3537/nQWzpTEXVcYvd0k/H5R9W7F7/7jMYXhFDv3xLWLU/6VlbAcSzDnPDIJQXpEuVsBiS6DOujlKOUGgEjUqALP+BH0PddReiPlX4B+3fA+jyAT9lYM21UssKfIgQLvtKhSePPr0OAdKZQ1pyzBa+lihdKDGpclatw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199018)(86362001)(82960400001)(38100700002)(44832011)(2906002)(8936002)(41300700001)(5660300002)(186003)(1076003)(4326008)(6512007)(9686003)(83380400001)(6666004)(6506007)(316002)(66556008)(8676002)(66946007)(66476007)(478600001)(6486002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FVMp1zC7i+tCRgXWA+jWRMnAzGoYSYj3zP5RUV3VoUBSf84wtJmfo0sBYWFl?= =?us-ascii?Q?C8ULFGH5P+qcllRUmSXrewn4XkpztlQlDxDGbW5I5XzToPCAcugxvPJXDSBq?= =?us-ascii?Q?m2pUzyu/qxNNXd65lB5SWzygLAqOyuQjs5YwMFKNomWEgFOOUF52m853VVy1?= =?us-ascii?Q?7d5O8GLlxw/ZdH4xMD339VVcyP48DOcHCx80jReIodFWCOup8U4Swm0e8JeK?= =?us-ascii?Q?6Zn2VjtNRcPy6jOFH8p6xmop50n1Py6uwoUvKzG/XkJsUaz/+iXQ3xxwgBkm?= =?us-ascii?Q?Uf7S0bj/lRDH1B9V5Dqk0cvaVrP8/aMWXiBjapN692rSoR7lEYoyNGcMVz26?= =?us-ascii?Q?bjNDbkuyuFFA+kC9btZpiyL3V9FygZ/caeQMn9pYeoW213C4Y01tdQxKeSnX?= =?us-ascii?Q?DNq8ZObmq+0cEMF7qcYQAugQwBj+HoFAomBl+3MdRVS99NT6/cyCQsA56ylP?= =?us-ascii?Q?oKxtWGX6c5rkZwOPFB1V0ZCRfGG8x54WL3TO3j7vWxjuKbrZ1LdGkPpJ6T/G?= =?us-ascii?Q?H5eiTtjY6pXFrpAqnuBqoe7DqCMqM4+oNJTSemYKq3BXAjHBC8PYyNerwYIi?= =?us-ascii?Q?zAkSTTZybeClYmUVjPkgjp9JgrAEh497fP4ZDF6W7J/EhIEdQCGYDKsKS6YW?= =?us-ascii?Q?bQL522yYfycSy3Q2v9wUTitIeRy0cZ0MUok4HOEw2sasrxtPFhFVLAurCoYC?= =?us-ascii?Q?bCLYjkYUUwK+g7DiFEoz7hWR2hEPxCFfZm18bE2y5AriZrTY9ctK1RRNIzoJ?= =?us-ascii?Q?nNOmWKFHHMmZ1NkHf5B5Vxwaf/JZvRWqNsaDG9mnVC17jTz+f317/4trtwCZ?= =?us-ascii?Q?o92+LiuXwrrAT6o0VjzcuogSIur7iWIImqFK0fiBznj30FNwsnME6SMM1mpw?= =?us-ascii?Q?NDGL+tQLriBxw1GplFX/Q2WDMoluZq+mOLCZzWFrn2uf9eggvkEsGuBhaJIk?= =?us-ascii?Q?oG9PO5ItCBX4o6l7g8g1jHXq3JF/0Mc5J7xpqiHtbRkRqOz2jXc2Y3k6+0/X?= =?us-ascii?Q?XfUWX170UipTVyzVU0Plx/kr5qyzkzPaJ+x1cOf0yf5Qa5K18xXPJRS9pskX?= =?us-ascii?Q?1w62TwMamk7i2Bfv8cNH2XmPaDmCHxhF2DFjHvyoADW66LGPuxnCidhWxym+?= =?us-ascii?Q?ZK2f4OJemkGj0QjJ4x9LQfcjgC93YXh3fk5wsdULRJsp4oC1p6J4p+z8zX8j?= =?us-ascii?Q?Y8CSkj+WTH56yJOyagKypBE3mPLe78Np7qIetuqcVfsQOeD3Uu1BrGtteDO/?= =?us-ascii?Q?KTpP32FGREiPMegCzgLpe3fSM+eKIyGmZrHJzxCaK4WuYZzZNBcGfsQCSMxU?= =?us-ascii?Q?yZTQZCM2dKEZyyCKt9Sl7Xv4rMqDG/FHVI95J5KvvQaryTY9O6ENA3NisDKW?= =?us-ascii?Q?4ApXEJsvNCO85JEd1YPRrCDdb7KjL5ubIdOHwbYUWcv4uWOGRoszq2JjFHgo?= =?us-ascii?Q?wwzF/kjrI2CTYD2YFcIfUQr68rCtsS9N3xV2Geoes0A9tDPdvqBOpYZyD4we?= =?us-ascii?Q?4vzfVbo8XhwnWbbYYr2f3uAYD8w0ZtXlxbzjd6oEc3sg5fnLP8OC/TWBl5V3?= =?us-ascii?Q?cUJm6oC/yPiJsUdsOya5vUL9yZkCfXjHvrxAw2KQuAA6BvJ1S3vrneocxmMV?= =?us-ascii?Q?DBjYC6OcCE/u7ID8EcBuJ/PvlfQXTgBk4pHderDX4VBcxBEy6OflyQJV/+1X?= =?us-ascii?Q?sQ7FWg=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 535c7a00-b2ce-490e-4784-08db26c01906 X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 08:17:49.9784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2/qskOtxnfxwmOd6mb4UsAUvr4x3Mgj63sowubY2cAVPyxOrIseshWWzwcD5nvL9C2Jk0oVykV4VcBIu+0UIN1YjvVSo6sfnCWIvgP6WHSk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB5879 X-TUID: 6RQDmVAGvruL Am Fri, 17 Mar 2023 05:11:30 +0100 schrieb Uladzimir Bely : > When qemu machine boots, it may happen that consecutive SSH connection > fails right after the previous good one. So, we get a situation when > the command/script fails after we consider SSH is ready. > > This patch improves detection of SSH server ready status by making at > least three good consecutive SSH pings. > > Example of debug output that shows the case: > > ``` > | Waiting for SSH server ready... > | SSH ping result: 255, left: 300s # <== machine is booting > | SSH ping result: 255, left: 294s > | SSH ping result: 255, left: 288s > | SSH ping result: 255, left: 282s > | SSH ping result: 255, left: 276s > | SSH ping result: 255, left: 270s > | SSH ping result: 255, left: 264s > | SSH ping result: 255, left: 258s > | SSH ping result: 0, left: 253s # <== SSH server is up... > | SSH ping result: 0, left: 251s > | SSH ping result: 255, left: 250s # <== but one ping failed again > | SSH ping result: 0, left: 248s > | SSH ping result: 0, left: 245s > | SSH ping result: 0, left: 243s > | SSH server is ready > | `lsmod | grep example_module` returned 0 > ``` > > Signed-off-by: Uladzimir Bely > --- > testsuite/cibuilder.py | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index 9e84c3a3..4e568b8e 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -257,17 +257,25 @@ class CIBuilder(Test): > self.log.debug('Waiting for SSH server ready...') > > rc = None > + goodcnt = 0 > while time.time() < timeout: > if proc.poll() is not None: > self.log.error('Machine is not running') > return rc > > rc = self.exec_cmd('/bin/true', cmd_prefix) > + time_left = timeout - time.time() > + self.log.debug('SSH ping result: %d, left: %.fs' % (rc, > time_left)) time.sleep(1) > > if rc == 0: > - self.log.debug('SSH server is ready') > - break > + goodcnt += 1 I find all that code kind of hard to read. With the multiple indirections to find the command that actually gets executed in the end. A quick look makes one think it is "/bin/true". and for a counting loop python has "for i in range(3)" The idea to wait a bit longer is good, and if that works it can be merged. But the code could likely by written in a way that it would be easier to read and maintain. Henning > + # Let 3 good SSH pings to make sure SSH connection > is stable > + if goodcnt >= 3: > + self.log.debug('SSH server is ready') > + break > + else: > + goodcnt = 0 > > if rc != 0: > self.log.error('SSH server is not ready')