From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7211363025731715072 X-Received: by 2002:a05:6000:1363:b0:2cb:c072:cf56 with SMTP id q3-20020a056000136300b002cbc072cf56mr1590670wrz.7.1679043246126; Fri, 17 Mar 2023 01:54:06 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:6023:b0:3cf:9be3:73dd with SMTP id az35-20020a05600c602300b003cf9be373ddls4429452wmb.3.-pod-canary-gmail; Fri, 17 Mar 2023 01:54:04 -0700 (PDT) X-Google-Smtp-Source: AK7set+Uv2IRa4RcaGR4HkKIKbInNxai4rsMeGKjPyVtqYzVGyHgd6dUwAMRueE2AA3fP/BSJsf1 X-Received: by 2002:a7b:c7c9:0:b0:3ed:5fe9:bead with SMTP id z9-20020a7bc7c9000000b003ed5fe9beadmr4345796wmk.36.1679043244807; Fri, 17 Mar 2023 01:54:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1679043244; cv=pass; d=google.com; s=arc-20160816; b=IUW9yPdN/D95+IHEArfcC+ChVwlWeLcXslVer3ccJQm+YTNQSp3qrqLGp2nO9bKDhM DD7LaLvq7z0P+s+gb0EymcP81mwvOxHYf+T4oJSA9yFFvynGgzUOCLy85AE+FZu1Ac/m AADNpax05xbR1NIU6B7dRqe9OyJTujIDIbWzFMkxNQ2c0xZA/uQfJi40ld65nSav+UE+ k+Uoabz4JcjWUYjXkzQ9NlmClLK53ik7lxuOJfQx1jBkcO0zViTObEJ/ljGqCjw6sgw1 KjTtNAdrXIae7xi04GOKxxn7CRKXMJ6KiwbV6DZoYbS/tb3DsNj1TS9wwixgqJG+t6qw GWhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=pQdi0WMsDZD8ZxNWWveeUHy9v2OJfjrFvNTif7T5ulM=; b=hzCWcZpjbiilhlzGD0n1qZ8TVCZ0LsDNFUErf40WggUaTqjewSdASwTT+lyMKn290n ClRW3smQL1FMdrG/EZf4UpWVS9E7YNqNv9wd8BiTSfBf8FWpnJaJBdRYqnHi/apNMqqz SEu/4fo82D0fwkjZuZWPEw4m43FG9858bHd7paDDVntFeDttUW6k+V914RYjRL5eN6vi OLvY0nnrVeA9y2C89TZ9Dh8BeYVxeP0MmnGbHCl0ofX/FEGYJtR0xOnCQlql2jqpI4Eb 1olXB6E0KulZr74iqsJFHuOiKRvj1Q7UqDfYtm4ooGBcLRa63L3nyghyJzj6PVNJuN2G jYEw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=FmSvfQTR; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe1f::60e as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on060e.outbound.protection.outlook.com. [2a01:111:f400:fe1f::60e]) by gmr-mx.google.com with ESMTPS id fm5-20020a05600c0c0500b003ed1fe9bec2si92121wmb.0.2023.03.17.01.54.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Mar 2023 01:54:04 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe1f::60e as permitted sender) client-ip=2a01:111:f400:fe1f::60e; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=FmSvfQTR; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of henning.schild@siemens.com designates 2a01:111:f400:fe1f::60e as permitted sender) smtp.mailfrom=henning.schild@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWkTZ9TXQWu1no56/kmzkrseXj//8uhTAprpgu9JzZZW9ACVXHEiyAMmc9dy2jbeNzdid72OYV2gcEyS0BUK/lU7tMnReO6U10gAkUwTjkJw2ybS+RKoRaC13rsNq7PK/+HnCsekXbsowgbbETdiOxEh1WsaSY+/vjyxuFnaq1w1O4l9ARMouAd7LgQQCbEEOj0+9TvlaungghKcjvtdxSKuu8iaW/CBzLx4gTnfjXyrcdXf5bUP5XAexN04ejD9PoOmN3GQlyjn5tcF+MXjydTBB1DFl4TUSTCepWeo4bY9afEgGtBZ7aeFilvvcLgCXRan+Xsk8otkYvige2iWhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pQdi0WMsDZD8ZxNWWveeUHy9v2OJfjrFvNTif7T5ulM=; b=IA3SMk8V6iCzZOFfvU29U6zkRrQfXiTH56YilpE9YIlKP4mG1x4DceFDcC04yCn+kBTY+KVLj2ef30l/WhcJQe8i9aMyNZgHrLrdDqz/wstaF0k6Wk7ER+KpVYim6/zhWxljyBX7+1312KTx7LFJ6RbdYyp1VEDUyPmgo2SOGL72Ojun+1Odiqyr21YSCXj88CW6LURGVJmxzqAt8o8G12mhOGLtjwUZFmmG1ftFnm7yKyAQQMjwfmOcwALm4xFmYyhE2HbsUrXWdSHEeJMIaWv5VAZi4VqQeD8lKSpBSTcoJxCB+U80HAalJp6gzg2MdnZarrMZehU6s5vZ0WPM1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pQdi0WMsDZD8ZxNWWveeUHy9v2OJfjrFvNTif7T5ulM=; b=FmSvfQTRBont3P1TKzHYcafbwXbFqa8ej6ChjHaKIGz+DBx1ggsP4N/ydBwJm0acXj8hURt4hAPIkgk9ge3TgKmXJOnICxXr7E6pcxRJhD6wwBfwHe393hRY9lySsCa9uw+9hMMZLtgMUn09b8TnP+E7+/SelEA/QLok3eiDGN/TynzjAKX9Ml7N6O1BsO9s+HmYcxgTyMuSm0T6w1VGF55m83pk5x62qyqd0TKbaEp6pa1mSxmjoLH07MTTww+dfEsuwxoxFl/ck1QM4h1Uu5HKt4wwfiBck/cq/LtQo6TPGOqZFiCJ22EH7QVihe86HqfkjcBb3N8EGG3PX+S8YA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) by DB9PR10MB5788.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:37f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.10; Fri, 17 Mar 2023 08:54:03 +0000 Received: from PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::f777:d35e:83f2:6148]) by PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM ([fe80::f777:d35e:83f2:6148%4]) with mapi id 15.20.6222.010; Fri, 17 Mar 2023 08:54:03 +0000 Date: Fri, 17 Mar 2023 09:53:58 +0100 From: Henning Schild To: Uladzimir Bely Cc: isar-users@googlegroups.com Subject: Re: [PATCH] testsuite: Improve SSH ping Message-ID: <20230317095358.6a73547f@md1za8fc.ad001.siemens.net> In-Reply-To: <20230317041130.7987-1-ubely@ilbers.de> References: <20230317041130.7987-1-ubely@ilbers.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-pc-linux-gnu) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0096.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::8) To PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:269::8) Return-Path: henning.schild@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR10MB5780:EE_|DB9PR10MB5788:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d832c0a-2a27-4245-cf4a-08db26c5283c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bfzwDP1vf8hNpsJP78aHE2xLbY/kijWG6kqCDivqU7+U2vxbLcZgtflilqAs6+IiS9Hoepg5rU13Vla5Qp3z8z2OaN7grcCtNjmy42iqoKe9f89x5QD8dU1/MXx74+wl3BRwgg0f5N8QVk8FlkvAJtm8DAT8IGsg0sxjav3qhyofwGOiRzhKKp5CzrpEOijyTN9e0CfJLU4t2ZKlPI0wiOnZ2pv/LE+8Ug0422a8AkpdCGqv+1aKXwiIs0pylVYqpPv3HICvoSxpBq8C1o/y3vtWsvFp6XIM9IRCkqsYHo3Iv6LwExt9xu6yDq06uirLIKZuISPfcBV4d76/B33ZMOP2HwNudH/VSR+hHBgoWwdmxzFGY3pfPxB3gshog/imv34zDVA1Ut0z+YLV8+j9/+l11eI8MdQBRMbtLB78R0zgKo1ywOMAr0JX6hGtxY7OBVXOTngHIY5QccxjxEWhPc46WLqqrY+Vx16iqiB4M1cv/FozFDRI0p/4jdSb1jgOwWIOKHIvnD/RXnaUxiaB2q5I144cntU2qJuFcf643MK0f7x+4lxft/XJ8PSDeTLiGQ4Fcb2FmmLQCNhSkeyCoDHzAp7H0Iw3QkV7khO5A1KGvjGvggCGHVH+ZGJmxQKRqPqtCaUPuJeHa6q8ANBIqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199018)(2906002)(44832011)(5660300002)(82960400001)(8936002)(41300700001)(8676002)(316002)(478600001)(38100700002)(86362001)(83380400001)(9686003)(186003)(6512007)(6916009)(26005)(6506007)(1076003)(66946007)(66556008)(4326008)(66476007)(6486002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mzsnS4t+8rIjbm3YPgaRxfDwyBP7Eca3D0HXQx2bdjkTJL9tXLlsX5d55uXh?= =?us-ascii?Q?IaCwU2a7ZS4n2eIK1fAZM0FMiPQNKEjh0t5EA8AoT6YwcfAFDhMGGAyHf+s7?= =?us-ascii?Q?v4leYCWOqbhQLcs3uBaYXukgsTBvDbac1soT9hzN1MClMIEcdVJKwexx+VMD?= =?us-ascii?Q?9dcxp4we4zFvQNI4QmJRJbHKVTZR+L+GX7GJZcNIEhnCp5/XkoTU6MhFDOaI?= =?us-ascii?Q?G/7opHUXBLEDSCz1oult9wP+RFyKN/UQVF6ArJSUe/6TN1kJ349iAwttBrWH?= =?us-ascii?Q?i+2F8dTcJH7+zcH9HD7pEh5Ckywa0AW68R4VEazh4elCimBkpUdX232O06ti?= =?us-ascii?Q?OfZSNjkSXCaNiujTwlAdAQpxOUsD4BE+0KQd0ufGbDZxdyYq8iEbsMq9otqz?= =?us-ascii?Q?ecINQInw7ImPZcpWak5qcK31pMcj5pQGIVhlOkKpxTVAdVFfz90Jwi4pVuOi?= =?us-ascii?Q?pJI4xuZeLJAhp+tppiK4CuSPVGUXZ4wlnkCwV0Ou0zpRHxTjrCKVc1u5izW8?= =?us-ascii?Q?P+NqPIv6hZbbRsItpv3c2MY+iGH79foYeiRnTqvF/84+f3B1AeZPIGZkWoKs?= =?us-ascii?Q?lH31NqKXM4BLygQDWQuiwPg7ZRsnTETn04F9+de1huH1Czkjq493bNWaGbs0?= =?us-ascii?Q?lYbCQXGe6e/+qLfuh+28ds7lmkN4qWfSI8fz+m0xy3RMfzHLpC5TBbC09cIx?= =?us-ascii?Q?1x6oM5RhHP78nNqv/tMhkz5uciBtZ7Pc+tU7VpoNqcqW2fCLHLj6CQE3DFcH?= =?us-ascii?Q?HRs7C76IYcwAYkKs2b3g6Yo6TQc03rh4+CSj6+ElTvqReafsihHZzKfBk3th?= =?us-ascii?Q?8mu1mU2i5s+Nn26Zi0MGmU0FuY7JkpadF8SUi9d32UE85JBYkW0yrqJ3rsq/?= =?us-ascii?Q?7S8fyT9rwLuOYHMJRTEQAbaUYZFs2nH5Q/ZXu98K/TyIhmz0u/CfLBiwOLLr?= =?us-ascii?Q?B5S51fxi3q9uIL5Q6YS5D2KevZVJPX0X/yjA0d1SB+Y2DzwNdYiDpcGzblJ5?= =?us-ascii?Q?zAwKKwlIPLtjYcG2ecAT4iB2fOOaiouvZqrsegI7o0N4fRYHvl6w3h2zepLL?= =?us-ascii?Q?lDIbofLRc5qAOsmKEPACtbPZJ4BPIgw8jFxmh2uW3Lo1ufNoq+NldwHlcQZV?= =?us-ascii?Q?qJHbnDUt5MRGX4kncT9eLIAu51tIZ6vqhUoP0mH/wkyerd7v601sYnYGErOG?= =?us-ascii?Q?1zdrpLb/H2vhoBq9+cpBCRM3MJ5+9jcyRkdumREcJwPuerNhMvQWZsjTrxQ7?= =?us-ascii?Q?qvUkWLC4wmVKdbynj2AOwhO/flNkAbwqma9ShKSsTGFtNF62cuUehtv1CEBy?= =?us-ascii?Q?N4+8So3AcAzeRrVvUQHYL+eaM1+xMIiK8pAcao7F0oWNfxOcqGUOCme0xQGi?= =?us-ascii?Q?Qf4owS3QY+MylUE4qeH2fjuVJ6LAhQ6AVolEs9T0Wk0xWiP0xuZi9S7LhBDw?= =?us-ascii?Q?YOSo/1Y68FZ/8lcmzQ5Lp/PQglf9f0zFJz0cuA7K++s7VF2eOgbN8RUSRFYu?= =?us-ascii?Q?qeGHxJ3jRp4jRBqvDGGQucxueSA/uPJ/HZG+FjtOxcHHFYwV2Gcf1hGgt5Ru?= =?us-ascii?Q?Vx0rHnltzGLQV2Imk9aeSKVQ2eILPhG7BtTrvgoahioHcGS6Ey5170aHSJly?= =?us-ascii?Q?MQ=3D=3D?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d832c0a-2a27-4245-cf4a-08db26c5283c X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 08:54:02.9854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BrXsUZkK2h/2FT9ZKgfdxQ+l9j3OwOg7OAPHsZlqzN/rCZwTZYQQ04LC8kzlDTbq/gpjQo+x0z70VpGEQV3z42TRQjmTpcA4EjxkbB5SPxU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB5788 X-TUID: 9bimLpWHi4LQ Am Fri, 17 Mar 2023 05:11:30 +0100 schrieb Uladzimir Bely : > When qemu machine boots, it may happen that consecutive SSH connection > fails right after the previous good one. So, we get a situation when > the command/script fails after we consider SSH is ready. > > This patch improves detection of SSH server ready status by making at > least three good consecutive SSH pings. > > Example of debug output that shows the case: > > ``` > | Waiting for SSH server ready... > | SSH ping result: 255, left: 300s # <== machine is booting > | SSH ping result: 255, left: 294s > | SSH ping result: 255, left: 288s > | SSH ping result: 255, left: 282s > | SSH ping result: 255, left: 276s > | SSH ping result: 255, left: 270s > | SSH ping result: 255, left: 264s > | SSH ping result: 255, left: 258s > | SSH ping result: 0, left: 253s # <== SSH server is up... > | SSH ping result: 0, left: 251s > | SSH ping result: 255, left: 250s # <== but one ping failed again > | SSH ping result: 0, left: 248s > | SSH ping result: 0, left: 245s > | SSH ping result: 0, left: 243s > | SSH server is ready > | `lsmod | grep example_module` returned 0 > ``` > > Signed-off-by: Uladzimir Bely > --- > testsuite/cibuilder.py | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/testsuite/cibuilder.py b/testsuite/cibuilder.py > index 9e84c3a3..4e568b8e 100755 > --- a/testsuite/cibuilder.py > +++ b/testsuite/cibuilder.py > @@ -257,17 +257,25 @@ class CIBuilder(Test): > self.log.debug('Waiting for SSH server ready...') > > rc = None > + goodcnt = 0 > while time.time() < timeout: > if proc.poll() is not None: > self.log.error('Machine is not running') > return rc > > rc = self.exec_cmd('/bin/true', cmd_prefix) > + time_left = timeout - time.time() > + self.log.debug('SSH ping result: %d, left: %.fs' % (rc, > time_left)) time.sleep(1) > > if rc == 0: > - self.log.debug('SSH server is ready') > - break > + goodcnt += 1 > + # Let 3 good SSH pings to make sure SSH connection > is stable > + if goodcnt >= 3: > + self.log.debug('SSH server is ready') > + break > + else: > + goodcnt = 0 This looks like an endless loop should ssh never come up. Not sure what would break that loop. In the worst case a test-timeout and everything being stuck because we might not execute these things in parallel. Henning > > if rc != 0: > self.log.error('SSH server is not ready')