public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Srinuvasan Arjunan <srinuvasan_a@mentor.com>
To: <isar-users@googlegroups.com>
Cc: <jan.kiszka@siemens.com>, Srinuvasan A <srinuvasan_a@mentor.com>
Subject: [PATCH] meta/conf/bitbake.conf: enable SRCPV support for AUTOREV
Date: Fri, 14 Apr 2023 14:27:42 +0530	[thread overview]
Message-ID: <20230414085742.844733-1-srinuvasan_a@mentor.com> (raw)
In-Reply-To: <CAB2Z2nM3yyd9VjU1mWsVB4gZDhqPazttOmS+i7A-xmp8kjchXQ@mail.gmail.com>

From: Srinuvasan A <srinuvasan_a@mentor.com>

One of our downstream project recipe uses `SRCREV = "${AUTOREV}"` to get
the latest changes always, but this not works after bitbake 2 migration,
it throws the below error.

do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV for OE).

Till now we don't have support for SRCPV in ISAR, hence add this support
as like OE.

Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
---
 meta/classes/base.bbclass | 4 ++++
 meta/conf/bitbake.conf    | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 53550ae..819f8a2 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -120,6 +120,10 @@ root_cleandirs() {
 python() {
     import re
 
+    srcuri = d.getVar('SRC_URI')
+    if srcuri:
+        d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}")
+
     for e in d.keys():
         flags = d.getVarFlags(e)
         if flags and flags.get('task'):
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index f421050..124bf49 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -36,6 +36,10 @@ PR = "${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[2] or 'r0'}"
 PROVIDES = ""
 S = "${WORKDIR}/${P}"
 AUTOREV = "${@bb.fetch2.get_autorev(d)}"
+AUTOREV[vardepvalue] = "${SRCPV}"
+# Set Dynamically in base.bbclass
+# SRCPV = "${@bb.fetch2.get_srcrev(d)}"
+SRCPV[vardepvalue] = "${SRCPV}"
 SRC_URI = ""
 STAMPS_DIR ?= "${TMPDIR}/stamps"
 STAMP = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}/${PV}-${PR}"
-- 
2.34.1


  reply	other threads:[~2023-04-14  8:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 10:17 Srinuvasan Arjunan
2023-04-13  7:02 ` Jan Kiszka
2023-04-13  7:09   ` Srinuvasan Arjunan
2023-04-14  8:57     ` Srinuvasan Arjunan [this message]
2023-04-14  9:00       ` Jan Kiszka
2023-04-14  9:12         ` Srinuvasan Arjunan
2023-04-14  9:16           ` Jan Kiszka
2023-04-17 13:27             ` Srinuvasan Arjunan
2023-04-17 14:10               ` Jan Kiszka
2023-04-18  6:25                 ` Srinuvasan Arjunan
2023-04-18  7:06                 ` Uladzimir Bely
2023-04-19  2:40                   ` [PATCH v2] " Srinuvasan Arjunan
2023-04-19 13:43                     ` Jan Kiszka
2023-05-08 17:57                     ` Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414085742.844733-1-srinuvasan_a@mentor.com \
    --to=srinuvasan_a@mentor.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox