public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Srinuvasan Arjunan <srinuvasan_a@mentor.com>
To: <isar-users@googlegroups.com>
Cc: <jan.kiszka@siemens.com>, <amikan@ilbers.de>,
	Srinuvasan A <srinuvasan.a@siemens.com>
Subject: [PATCH] crossvars.bbclass: use d.appendVar instead of d.setVar for SDK_TOOLCHAIN variable
Date: Mon, 22 May 2023 10:11:17 +0530	[thread overview]
Message-ID: <20230522044117.1698718-1-srinuvasan_a@mentor.com> (raw)

From: Srinuvasan A <srinuvasan.a@siemens.com>

In downstream layer we may override the sdk_toolchain, but this not works as
expected in latest ISAR, the reason behind this as they moved toolchain
selection into python Anonymous function.

Anonymous Python functions always run at the end of parsing, regardless of where they are defined
even when we do override in our recipe, always wins the Anonymous Python
functions variable settings, hence change to d.appendVar instead of
d.setVar in sdk toolchain selection, so downstream layer they can modify the
SDK_TOOLCHAIN list if needed (append/remove).

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta/classes/crossvars.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass
index 201d460..5a3edc4 100644
--- a/meta/classes/crossvars.bbclass
+++ b/meta/classes/crossvars.bbclass
@@ -17,7 +17,7 @@ python __anonymous() {
         sbuild_dep = "sbuild-chroot-target:do_build"
         buildchroot_dir = d.getVar('BUILDCHROOT_TARGET_DIR', False)
         buildchroot_dep = "buildchroot-target:do_build"
-        sdk_toolchain = "build-essential"
+        sdk_toolchain = " build-essential"
     else:
         d.setVar('BUILD_HOST_ARCH', d.getVar('HOST_ARCH'))
         schroot_dir = d.getVar('SCHROOT_HOST_DIR', False)
@@ -31,5 +31,5 @@ python __anonymous() {
     d.setVar('BUILDCHROOT_DEP', buildchroot_dep)
     if isar_can_build_compat(d):
         sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH')
-    d.setVar('SDK_TOOLCHAIN', sdk_toolchain)
+    d.appendVar('SDK_TOOLCHAIN', sdk_toolchain)
 }
-- 
2.34.1


             reply	other threads:[~2023-05-22  4:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  4:41 Srinuvasan Arjunan [this message]
2023-05-22  5:16 ` Jan Kiszka
2023-05-22  5:54   ` Jan Kiszka
2023-05-25  4:53     ` Srinuvasan Arjunan
2023-05-25 10:20       ` Jan Kiszka
2023-05-26  9:03         ` Srinuvasan Arjunan
2023-06-04  9:32     ` [PATCH] meta/classes/crossvars: move sdk toolchain selection from python block Srinuvasan Arjunan
2023-06-05  7:00       ` Jan Kiszka
2023-06-05  7:07         ` Srinuvasan Arjunan
2023-06-05  7:18           ` Jan Kiszka
2023-06-05  7:43             ` Srinuvasan Arjunan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522044117.1698718-1-srinuvasan_a@mentor.com \
    --to=srinuvasan_a@mentor.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    --cc=srinuvasan.a@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox