From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7235862407233404928 X-Received: by 2002:a19:ee01:0:b0:4f1:4724:bb6a with SMTP id g1-20020a19ee01000000b004f14724bb6amr2160878lfb.1.1684730501919; Sun, 21 May 2023 21:41:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:1597:b0:2ad:a1ce:ff1b with SMTP id h23-20020a05651c159700b002ada1ceff1bls938239ljq.0.-pod-prod-02-eu; Sun, 21 May 2023 21:41:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5m3t0FbKfIrLuv5IMGN7gPIGEYm881bSkilvctIa1REqW6RHSecfBkSsfB6JW+mImmssoA X-Received: by 2002:a05:651c:1035:b0:2b0:297c:cbdf with SMTP id w21-20020a05651c103500b002b0297ccbdfmr222688ljm.1.1684730500365; Sun, 21 May 2023 21:41:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684730500; cv=none; d=google.com; s=arc-20160816; b=vzyxqRZEbtnImfGi5FxMOV7zC5r3WWMGBXgshot7G6fb95LhLiiinCnOSRieAuVD1V frduTcj3Jy/MEPp3BMlwPqg3pEZ5m9VvD0dG+qDpfRSt5JaW6re17stHreuiHCXbl73O OgluSofWnbZ5MBhd+GFJrsB/Aa5phB2p2/mRiG2+uiexJwaF9BnCbZzyf1dhI/QWAIO4 5h6twkPa85OB8lM6t6jU+Bmik3amLtZYUEGjJ2io7UQIwXagZ49TEwTfdk8pojCxsSA3 Wgr8qdaE1fknjQP5D0XdNFZoBtU1A/Gskp55rWHiEq7g+COLf6NAsHB0TIV7zyJC/B/g k40Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:ironport-sdr; bh=7GQo3t/Atuyt3rreA4hkEHsABtLjMDOBz3xAHKc/PuY=; b=twkrItbaPSp///f8osGktYNkyIk0d6ZqB0yv0L+UXX5cEPsjnw0xkR/hLkAqJm9ZB2 jmHNIWK0ZsxV6ZGwiEY8sLnvlIpRxULSObx4WSBp37Tka3bi7GOY1p5jajjE9W6meFCV 7VT77aTvm5f8M/I1JSUpmo0Kc5jD5c7cS+2v0gzYKrgMkKiBCvuSPgA8ldYEuxm13eZD PGLRSM3HyfgRpZp2eIpqHB4Pbg+wif3NthNQvw2+nccMcCv4l6vx3CKPUYIxvflblKTy aVjmk5R0x2WYC6c6R2/PTAEe/enUkKL0asDF7tMVqTaXX+kiBPmJ0ApAznDx+g5kvKyw yuLg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com. [68.232.137.252]) by gmr-mx.google.com with ESMTPS id bx35-20020a05651c19a300b002af15d1ad3asi295253ljb.8.2023.05.21.21.41.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2023 21:41:40 -0700 (PDT) Received-SPF: pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) client-ip=68.232.137.252; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com X-IronPort-AV: E=Sophos;i="6.00,183,1681200000"; d="scan'208";a="6089003" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 21 May 2023 20:41:37 -0800 IronPort-SDR: xRzsiocXguuHR6NE+2zmZo4BiXqojF+YicInSNgQ89RKljiF8ZSjxPN+vDxo8Jm/oepOJ8B13Y y3LxkMggAg6akhbzNi8N03iMrvJc4G/0l4ksL1sUaw0c+pgAOQmvanSkWIkNyaCXpGmtsCnIzn h5qW+lSQhZxeF6Xzm88kMNlUUmL3wtiMdWd30GDcz8NJIQghhc5oaA8rB/zCgfpLTDSO+P1IIN CLgEgEO27YMWLudpnYpYiBAzGGiEDyK1xSNVCmHFIgp4Lguy101OEa562/+Ht+pVv9QroEvGh+ Mi4= From: Srinuvasan Arjunan To: CC: , , Srinuvasan A Subject: [PATCH] crossvars.bbclass: use d.appendVar instead of d.setVar for SDK_TOOLCHAIN variable Date: Mon, 22 May 2023 10:11:17 +0530 Message-ID: <20230522044117.1698718-1-srinuvasan_a@mentor.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Return-Path: srinuvasan_a@mentor.com X-ClientProxiedBy: svr-orw-mbx-11.mgc.mentorg.com (147.34.90.211) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-TUID: aPXFDVXirVKt From: Srinuvasan A In downstream layer we may override the sdk_toolchain, but this not works as expected in latest ISAR, the reason behind this as they moved toolchain selection into python Anonymous function. Anonymous Python functions always run at the end of parsing, regardless of where they are defined even when we do override in our recipe, always wins the Anonymous Python functions variable settings, hence change to d.appendVar instead of d.setVar in sdk toolchain selection, so downstream layer they can modify the SDK_TOOLCHAIN list if needed (append/remove). Signed-off-by: Srinuvasan A --- meta/classes/crossvars.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass index 201d460..5a3edc4 100644 --- a/meta/classes/crossvars.bbclass +++ b/meta/classes/crossvars.bbclass @@ -17,7 +17,7 @@ python __anonymous() { sbuild_dep = "sbuild-chroot-target:do_build" buildchroot_dir = d.getVar('BUILDCHROOT_TARGET_DIR', False) buildchroot_dep = "buildchroot-target:do_build" - sdk_toolchain = "build-essential" + sdk_toolchain = " build-essential" else: d.setVar('BUILD_HOST_ARCH', d.getVar('HOST_ARCH')) schroot_dir = d.getVar('SCHROOT_HOST_DIR', False) @@ -31,5 +31,5 @@ python __anonymous() { d.setVar('BUILDCHROOT_DEP', buildchroot_dep) if isar_can_build_compat(d): sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH') - d.setVar('SDK_TOOLCHAIN', sdk_toolchain) + d.appendVar('SDK_TOOLCHAIN', sdk_toolchain) } -- 2.34.1