From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7235862407233404928 X-Received: by 2002:a17:907:3188:b0:94a:9f9a:b3c4 with SMTP id xe8-20020a170907318800b0094a9f9ab3c4mr3728975ejb.49.1685871160205; Sun, 04 Jun 2023 02:32:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1c26:b0:3f6:971:c0a6 with SMTP id j38-20020a05600c1c2600b003f60971c0a6ls97986wms.0.-pod-prod-02-eu; Sun, 04 Jun 2023 02:32:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5fRPsVmPnzrQ1PEOFBDGSTiYS5izOvksUL6PiCrcStGQkseQMabjgICR2kVwGHndPNIImv X-Received: by 2002:a7b:cc05:0:b0:3f4:1cd8:3e99 with SMTP id f5-20020a7bcc05000000b003f41cd83e99mr5381411wmh.28.1685871158917; Sun, 04 Jun 2023 02:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685871158; cv=none; d=google.com; s=arc-20160816; b=JWheztk8Q12xOyhG46vSAbJ7W/kA5HxaTDQ9tVkhS3lxpmDcoEOxXor/Q5wc7yAlqX m+GiWkPvVyNTvRCA0sBpzAa1wt37tX88F9vK2Sj53FsHIDOLHd0giNS3gR1HztFxnd2l 4ploEtqwEprq/swhyvJnO+quy+YwjMtyPGzhdMS3mZkVSl2UYOUkrdEjVP70gDDLhF17 D1Miy6qNc1zki2qaXJ7wed2qJkMOZKctF/ALOt7Q8qT47uAmfsaMuPxvQQPtYK6hkE91 QXTxDOyRVr7E1XlRqvt3gfWFN8OvAWSDQ4aipce4xYgzz3ku0/sRzr3uBn3F1iRVsFzy Sr7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr; bh=O4E14Zr7MvBjvM/puVDTrlZ5ttOivpUqKFI3Oy3hBG8=; b=CH+p3QwFlbB91TcMsqUsWxnHZh+5Eb9V0HrqjlNH3IIwrsjXTtHzQA/S/EZLJlELmG aBa5q6WdxISNED2L+kMUxAgC47RL0FZCIjKZQOijBLnJzxCBTWyM4pexbxZompzDUUYU ND6QA7yu7omjPbfVymSWkvvMjYdwNdSm4SYeRS5h0CJ3MQFjKT6aSuEG3EAr57stkX9U d8Gh1dM9stutmIrw/vlv4GbszOfAxfjpW8TBeowedqT2Ny/wNMVEQIOwVSKEL3GO8vR6 GAfxDwgIUZV1MN4BEU/U+8JD0yMnpKNf+kNXeRfpRZNltWtqtKtC1jON7RqknRzojZGd rv/g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com. [68.232.137.252]) by gmr-mx.google.com with ESMTPS id az16-20020a05600c601000b003f42786c7b4si760180wmb.0.2023.06.04.02.32.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2023 02:32:38 -0700 (PDT) Received-SPF: pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) client-ip=68.232.137.252; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com X-IronPort-AV: E=Sophos;i="6.00,217,1681200000"; d="scan'208";a="7607770" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 04 Jun 2023 01:32:36 -0800 IronPort-SDR: o4Z7As75mmrPMHqSOv4Jej9h+CyomaVzNwp5/7V0ButWVYB2oYj7nAhAtrarXz5W6f/z+JvKKy 46/KvQtp4IEudTMHM/+Zwd7lf4W454uL4FNR8+wrtpTJOceEJqsBMxaydcIcgYixi6Kr4fzoVT boLSYtHo7ry/ZmGW9HH9+N0jfihWsUg2sG1UW6zooZE1N3nZtdIkOHUc5ebLtvPvDGTE4QSp9y OSsmpFiW/tJEQOZRVWxW8bc2R1KGyaiCmOQG8SnFDWYvLRwLXyerKFjNMFcl1Qgu4Quh9ZkJnz d6M= From: Srinuvasan Arjunan To: CC: , , Srinuvasan A Subject: [PATCH] meta/classes/crossvars: move sdk toolchain selection from python block Date: Sun, 4 Jun 2023 15:02:16 +0530 Message-ID: <20230604093216.1094289-1-srinuvasan_a@mentor.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <46a03938-0343-4221-a57c-efba80b27c83@siemens.com> References: <46a03938-0343-4221-a57c-efba80b27c83@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Return-Path: srinuvasan_a@mentor.com X-ClientProxiedBy: svr-orw-mbx-10.mgc.mentorg.com (147.34.90.210) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-TUID: 5nSKdUxFPtOA From: Srinuvasan A In the present implementation we are not able to override the SDK toolchain from downstream layer, this is due to the SDK toolchain selection part in anonymous python function. Anonymous python functions always run at the end of parsing, regardless of where they are defined even when we do override in our recipe, always wins the Anonymous Python functions variable settings, hence we are not able to override our downstream toolchain. Move the SDK toolchian selection from python block, now we can able to override from downstream layer. Signed-off-by: Srinuvasan A --- meta/classes/crossvars.bbclass | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass index 201d460..120e6d1 100644 --- a/meta/classes/crossvars.bbclass +++ b/meta/classes/crossvars.bbclass @@ -5,6 +5,10 @@ ISAR_CROSS_COMPILE ??= "0" inherit compat +SDK_TOOLCHAIN = "${@'build-essential' if d.getVar('ISAR_CROSS_COMPILE') == '0' or d.getVar('HOST_ARCH') == d.getVar('DISTRO_ARCH') or d.getVar('DISTRO_ARCH') == None else 'crossbuild-essential-${DISTRO_ARCH}'}" + +SDK_TOOLCHAIN:append = "${@' crossbuild-essential-${COMPAT_DISTRO_ARCH}' if isar_can_build_compat(d) else ''}" + python __anonymous() { import pwd d.setVar('SCHROOT_USER', pwd.getpwuid(os.geteuid()).pw_name) @@ -17,19 +21,14 @@ python __anonymous() { sbuild_dep = "sbuild-chroot-target:do_build" buildchroot_dir = d.getVar('BUILDCHROOT_TARGET_DIR', False) buildchroot_dep = "buildchroot-target:do_build" - sdk_toolchain = "build-essential" else: d.setVar('BUILD_HOST_ARCH', d.getVar('HOST_ARCH')) schroot_dir = d.getVar('SCHROOT_HOST_DIR', False) sbuild_dep = "sbuild-chroot-host:do_build" buildchroot_dir = d.getVar('BUILDCHROOT_HOST_DIR', False) buildchroot_dep = "buildchroot-host:do_build" - sdk_toolchain = "crossbuild-essential-" + distro_arch d.setVar('SCHROOT_DIR', schroot_dir) d.setVar('SCHROOT_DEP', sbuild_dep) d.setVar('BUILDCHROOT_DIR', buildchroot_dir) d.setVar('BUILDCHROOT_DEP', buildchroot_dep) - if isar_can_build_compat(d): - sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH') - d.setVar('SDK_TOOLCHAIN', sdk_toolchain) } -- 2.34.1