From: Claudius Heine <ch@denx.de>
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: [RFC PATCH 1/1] linux-module: append local files path to FILSPATH
Date: Thu, 29 Jun 2023 15:21:08 +0200 [thread overview]
Message-ID: <20230629132107.2202204-2-ch@denx.de> (raw)
In-Reply-To: <20230629132107.2202204-1-ch@denx.de>
FILESEXTRAPATHS is meant to allow bbappend files to overwrite files from
their recipe. For this reason the 'normal' patter in bbappend files is
to prepend the local file path to FILESEXTRAPATHS, which results in
files from the local file path to be preferred over files from the
original recipe, or other, lower prioritized bbappend files.
The `module.inc` file is meant to be included by other recipes (`.bb`)
files. So it should still allow the recipe to overwrite files its files
that where added via the normal recipes `FILESPATH` search path.
If `module.inc` uses `FILESEXTRAPATHS:prepend` to add its local file
path to `FILESPATH`, then the recipe, that includes the `module.inc`
would have to use `FILESEXTRAPATHS:prepend` as well, after including the
`module.inc` file in order to overwrite the files from the `module.inc`
file. However this is a workaround of the issue.
`module.inc` should append its local file search path to `FILESPATH`, so
that it allows other recipes to overwrite any file from it, without
requiring an additional workaround.
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta/recipes-kernel/linux-module/module.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
index 76ad860..333c66b 100644
--- a/meta/recipes-kernel/linux-module/module.inc
+++ b/meta/recipes-kernel/linux-module/module.inc
@@ -5,7 +5,7 @@
#
# SPDX-License-Identifier: MIT
-FILESEXTRAPATHS:prepend := "${FILE_DIRNAME}/files:"
+FILESPATH:append := ":${FILE_DIRNAME}/files"
DESCRIPTION ?= "Custom kernel module ${PN}"
--
2.40.1
next prev parent reply other threads:[~2023-06-29 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 13:21 [RFC PATCH 0/1] FILESEXTRAPATHS in .inc files Claudius Heine
2023-06-29 13:21 ` Claudius Heine [this message]
2023-06-29 13:43 ` [RFC PATCH 1/1] linux-module: append local files path to FILSPATH Claudius Heine
2023-06-30 11:36 ` Kanagarajan, Vijaikumar
2023-07-04 7:51 ` Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629132107.2202204-2-ch@denx.de \
--to=ch@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox