* [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line
@ 2023-07-05 13:31 Claudius Heine
2023-07-05 14:03 ` Anton Mikanovich
2023-08-02 21:37 ` Uladzimir Bely
0 siblings, 2 replies; 5+ messages in thread
From: Claudius Heine @ 2023-07-05 13:31 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
Use new override syntax: "_" -> ":"
And fix `THISDIR` expansion: "$THISDIR" -> "${THISDIR}"
Signed-off-by: Claudius Heine <ch@denx.de>
---
RECIPE-API-CHANGELOG.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
index 7a16b5c..8517eb2 100644
--- a/RECIPE-API-CHANGELOG.md
+++ b/RECIPE-API-CHANGELOG.md
@@ -192,7 +192,7 @@ files and patches using bbappend a lot easier.
For example:
```
-FILESEXTRAPATHS_prepend := "$THISDIR/files:"
+FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
```
### multiconfig build targets were renamed
--
2.40.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line
2023-07-05 13:31 [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line Claudius Heine
@ 2023-07-05 14:03 ` Anton Mikanovich
2023-07-06 6:52 ` Claudius Heine
2023-08-02 21:37 ` Uladzimir Bely
1 sibling, 1 reply; 5+ messages in thread
From: Anton Mikanovich @ 2023-07-05 14:03 UTC (permalink / raw)
To: Claudius Heine, isar-users
05/07/2023 16:31, Claudius Heine wrote:
> Use new override syntax: "_" -> ":"
>
> And fix `THISDIR` expansion: "$THISDIR" -> "${THISDIR}"
>
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> RECIPE-API-CHANGELOG.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index 7a16b5c..8517eb2 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -192,7 +192,7 @@ files and patches using bbappend a lot easier.
>
> For example:
> ```
> -FILESEXTRAPATHS_prepend := "$THISDIR/files:"
> +FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
> ```
>
> ### multiconfig build targets were renamed
Hello Claudius,
You've changed changelog of v0.8 which was using old override syntax.
This patch is incorrect, so rejected.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line
2023-07-05 14:03 ` Anton Mikanovich
@ 2023-07-06 6:52 ` Claudius Heine
2023-07-12 13:47 ` Anton Mikanovich
0 siblings, 1 reply; 5+ messages in thread
From: Claudius Heine @ 2023-07-06 6:52 UTC (permalink / raw)
To: Anton Mikanovich, isar-users
Hi Anton,
On 2023-07-05 16:03, Anton Mikanovich wrote:
> 05/07/2023 16:31, Claudius Heine wrote:
>> Use new override syntax: "_" -> ":"
>>
>> And fix `THISDIR` expansion: "$THISDIR" -> "${THISDIR}"
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> ---
>> RECIPE-API-CHANGELOG.md | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
>> index 7a16b5c..8517eb2 100644
>> --- a/RECIPE-API-CHANGELOG.md
>> +++ b/RECIPE-API-CHANGELOG.md
>> @@ -192,7 +192,7 @@ files and patches using bbappend a lot easier.
>> For example:
>> ```
>> -FILESEXTRAPATHS_prepend := "$THISDIR/files:"
>> +FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
>> ```
>> ### multiconfig build targets were renamed
>
> Hello Claudius,
>
> You've changed changelog of v0.8 which was using old override syntax.
> This patch is incorrect, so rejected.
Both kind of changes here? I sort of understand not changing the
override syntax, but "$THISDIR" -> "${THISDIR}" is more or less a typo
fix. Would a patch that just fixes that be acceptable?
regards,
Claudius
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line
2023-07-06 6:52 ` Claudius Heine
@ 2023-07-12 13:47 ` Anton Mikanovich
0 siblings, 0 replies; 5+ messages in thread
From: Anton Mikanovich @ 2023-07-12 13:47 UTC (permalink / raw)
To: Claudius Heine, isar-users, Uladzimir Bely
06/07/2023 09:52, Claudius Heine wrote:
> Hi Anton,
>
> Both kind of changes here? I sort of understand not changing the
> override syntax, but "$THISDIR" -> "${THISDIR}" is more or less a typo
> fix. Would a patch that just fixes that be acceptable?
>
> regards,
> Claudius
Hello Claudius,
Please resend only THISDIR part, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line
2023-07-05 13:31 [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line Claudius Heine
2023-07-05 14:03 ` Anton Mikanovich
@ 2023-08-02 21:37 ` Uladzimir Bely
1 sibling, 0 replies; 5+ messages in thread
From: Uladzimir Bely @ 2023-08-02 21:37 UTC (permalink / raw)
To: Claudius Heine, isar-users
On Wed, 2023-07-05 at 15:31 +0200, Claudius Heine wrote:
> Use new override syntax: "_" -> ":"
>
> And fix `THISDIR` expansion: "$THISDIR" -> "${THISDIR}"
>
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> RECIPE-API-CHANGELOG.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index 7a16b5c..8517eb2 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -192,7 +192,7 @@ files and patches using bbappend a lot easier.
>
> For example:
> ```
> -FILESEXTRAPATHS_prepend := "$THISDIR/files:"
> +FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
> ```
>
> ### multiconfig build targets were renamed
> --
> 2.40.1
>
Applied to next (only "$THISDIR => ${THISDIR}" part, not "_prepend =>
:prepend" one, according to the discussion in maillist).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-02 21:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-05 13:31 [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line Claudius Heine
2023-07-05 14:03 ` Anton Mikanovich
2023-07-06 6:52 ` Claudius Heine
2023-07-12 13:47 ` Anton Mikanovich
2023-08-02 21:37 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox