public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] CI: Remove KFAIL for Bookworm
@ 2023-07-18 11:36 Anton Mikanovich
  2023-07-18 12:55 ` Henning Schild
  2023-08-02  4:07 ` Uladzimir Bely
  0 siblings, 2 replies; 3+ messages in thread
From: Anton Mikanovich @ 2023-07-18 11:36 UTC (permalink / raw)
  To: isar-users; +Cc: Anton Mikanovich

Debian Bookworm is stable now, so it should always pass all the tests.
Remove all the KFAIL protection from Bookworm targets.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 testsuite/citest.py | 38 +++++++++-----------------------------
 1 file changed, 9 insertions(+), 29 deletions(-)

diff --git a/testsuite/citest.py b/testsuite/citest.py
index 34258452..0d30b883 100755
--- a/testsuite/citest.py
+++ b/testsuite/citest.py
@@ -127,7 +127,9 @@ class CrossTest(CIBaseTest):
             'mc:qemuarm-buster:isar-image-ci',
             'mc:qemuarm-bullseye:isar-image-ci',
             'mc:de0-nano-soc-bullseye:isar-image-base',
-            'mc:stm32mp15x-bullseye:isar-image-base'
+            'mc:stm32mp15x-bullseye:isar-image-base',
+            'mc:qemuarm-bookworm:isar-image-ci',
+            'mc:qemuarm64-bookworm:isar-image-ci'
                   ]
 
         self.init()
@@ -155,18 +157,6 @@ class CrossTest(CIBaseTest):
         except:
             self.cancel('KFAIL')
 
-    def test_cross_bookworm(self):
-        targets = [
-            'mc:qemuarm-bookworm:isar-image-ci',
-            'mc:qemuarm64-bookworm:isar-image-ci'
-                  ]
-
-        self.init()
-        try:
-            self.perform_build_test(targets)
-        except:
-            self.cancel('KFAIL')
-
 class WicTest(CIBaseTest):
 
     """
@@ -216,7 +206,12 @@ class NoCrossTest(CIBaseTest):
             'mc:nanopi-neo-bullseye:isar-image-base',
             'mc:stm32mp15x-bullseye:isar-image-base',
             'mc:stm32mp15x-bullseye:stm32mp15x-initramfs',
-            'mc:qemuamd64-focal:isar-image-ci'
+            'mc:qemuamd64-focal:isar-image-ci',
+            'mc:qemuamd64-bookworm:isar-image-ci',
+            'mc:qemuarm-bookworm:isar-image-ci',
+            'mc:qemui386-bookworm:isar-image-base',
+            'mc:qemumipsel-bookworm:isar-image-ci',
+            'mc:hikey-bookworm:isar-image-base'
                   ]
 
         self.init()
@@ -238,21 +233,6 @@ class NoCrossTest(CIBaseTest):
         except:
             self.cancel('KFAIL')
 
-    def test_nocross_bookworm(self):
-        targets = [
-            'mc:qemuamd64-bookworm:isar-image-ci',
-            'mc:qemuarm-bookworm:isar-image-ci',
-            'mc:qemui386-bookworm:isar-image-base',
-            'mc:qemumipsel-bookworm:isar-image-ci',
-            'mc:hikey-bookworm:isar-image-base'
-                  ]
-
-        self.init()
-        try:
-            self.perform_build_test(targets, cross=False)
-        except:
-            self.cancel('KFAIL')
-
     def test_nocross_trixie(self):
         targets = [
             'mc:qemuamd64-trixie:isar-image-ci',
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] CI: Remove KFAIL for Bookworm
  2023-07-18 11:36 [PATCH] CI: Remove KFAIL for Bookworm Anton Mikanovich
@ 2023-07-18 12:55 ` Henning Schild
  2023-08-02  4:07 ` Uladzimir Bely
  1 sibling, 0 replies; 3+ messages in thread
From: Henning Schild @ 2023-07-18 12:55 UTC (permalink / raw)
  To: Anton Mikanovich; +Cc: isar-users

Am Tue, 18 Jul 2023 14:36:15 +0300
schrieb Anton Mikanovich <amikan@ilbers.de>:

> Debian Bookworm is stable now, so it should always pass all the tests.
> Remove all the KFAIL protection from Bookworm targets.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  testsuite/citest.py | 38 +++++++++-----------------------------
>  1 file changed, 9 insertions(+), 29 deletions(-)
> 
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index 34258452..0d30b883 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -127,7 +127,9 @@ class CrossTest(CIBaseTest):
>              'mc:qemuarm-buster:isar-image-ci',
>              'mc:qemuarm-bullseye:isar-image-ci',
>              'mc:de0-nano-soc-bullseye:isar-image-base',
> -            'mc:stm32mp15x-bullseye:isar-image-base'
> +            'mc:stm32mp15x-bullseye:isar-image-base',
> +            'mc:qemuarm-bookworm:isar-image-ci',
> +            'mc:qemuarm64-bookworm:isar-image-ci'
>                    ]
>  
>          self.init()
> @@ -155,18 +157,6 @@ class CrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_cross_bookworm(self):
> -        targets = [
> -            'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemuarm64-bookworm:isar-image-ci'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets)
> -        except:
> -            self.cancel('KFAIL')
> -
>  class WicTest(CIBaseTest):
>  
>      """
> @@ -216,7 +206,12 @@ class NoCrossTest(CIBaseTest):
>              'mc:nanopi-neo-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:stm32mp15x-initramfs',
> -            'mc:qemuamd64-focal:isar-image-ci'
> +            'mc:qemuamd64-focal:isar-image-ci',
> +            'mc:qemuamd64-bookworm:isar-image-ci',
> +            'mc:qemuarm-bookworm:isar-image-ci',
> +            'mc:qemui386-bookworm:isar-image-base',
> +            'mc:qemumipsel-bookworm:isar-image-ci',
> +            'mc:hikey-bookworm:isar-image-base'

i would suggest to end that last line with a , so it never matters
which one is the last and adding more does not have to touch this again

Henning

>                    ]
>  
>          self.init()
> @@ -238,21 +233,6 @@ class NoCrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_nocross_bookworm(self):
> -        targets = [
> -            'mc:qemuamd64-bookworm:isar-image-ci',
> -            'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemui386-bookworm:isar-image-base',
> -            'mc:qemumipsel-bookworm:isar-image-ci',
> -            'mc:hikey-bookworm:isar-image-base'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets, cross=False)
> -        except:
> -            self.cancel('KFAIL')
> -
>      def test_nocross_trixie(self):
>          targets = [
>              'mc:qemuamd64-trixie:isar-image-ci',


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] CI: Remove KFAIL for Bookworm
  2023-07-18 11:36 [PATCH] CI: Remove KFAIL for Bookworm Anton Mikanovich
  2023-07-18 12:55 ` Henning Schild
@ 2023-08-02  4:07 ` Uladzimir Bely
  1 sibling, 0 replies; 3+ messages in thread
From: Uladzimir Bely @ 2023-08-02  4:07 UTC (permalink / raw)
  To: Anton Mikanovich, isar-users

On Tue, 2023-07-18 at 14:36 +0300, Anton Mikanovich wrote:
> Debian Bookworm is stable now, so it should always pass all the
> tests.
> Remove all the KFAIL protection from Bookworm targets.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  testsuite/citest.py | 38 +++++++++-----------------------------
>  1 file changed, 9 insertions(+), 29 deletions(-)
> 
> diff --git a/testsuite/citest.py b/testsuite/citest.py
> index 34258452..0d30b883 100755
> --- a/testsuite/citest.py
> +++ b/testsuite/citest.py
> @@ -127,7 +127,9 @@ class CrossTest(CIBaseTest):
>              'mc:qemuarm-buster:isar-image-ci',
>              'mc:qemuarm-bullseye:isar-image-ci',
>              'mc:de0-nano-soc-bullseye:isar-image-base',
> -            'mc:stm32mp15x-bullseye:isar-image-base'
> +            'mc:stm32mp15x-bullseye:isar-image-base',
> +            'mc:qemuarm-bookworm:isar-image-ci',
> +            'mc:qemuarm64-bookworm:isar-image-ci'
>                    ]
>  
>          self.init()
> @@ -155,18 +157,6 @@ class CrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_cross_bookworm(self):
> -        targets = [
> -            'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemuarm64-bookworm:isar-image-ci'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets)
> -        except:
> -            self.cancel('KFAIL')
> -
>  class WicTest(CIBaseTest):
>  
>      """
> @@ -216,7 +206,12 @@ class NoCrossTest(CIBaseTest):
>              'mc:nanopi-neo-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:isar-image-base',
>              'mc:stm32mp15x-bullseye:stm32mp15x-initramfs',
> -            'mc:qemuamd64-focal:isar-image-ci'
> +            'mc:qemuamd64-focal:isar-image-ci',
> +            'mc:qemuamd64-bookworm:isar-image-ci',
> +            'mc:qemuarm-bookworm:isar-image-ci',
> +            'mc:qemui386-bookworm:isar-image-base',
> +            'mc:qemumipsel-bookworm:isar-image-ci',
> +            'mc:hikey-bookworm:isar-image-base'
>                    ]
>  
>          self.init()
> @@ -238,21 +233,6 @@ class NoCrossTest(CIBaseTest):
>          except:
>              self.cancel('KFAIL')
>  
> -    def test_nocross_bookworm(self):
> -        targets = [
> -            'mc:qemuamd64-bookworm:isar-image-ci',
> -            'mc:qemuarm-bookworm:isar-image-ci',
> -            'mc:qemui386-bookworm:isar-image-base',
> -            'mc:qemumipsel-bookworm:isar-image-ci',
> -            'mc:hikey-bookworm:isar-image-base'
> -                  ]
> -
> -        self.init()
> -        try:
> -            self.perform_build_test(targets, cross=False)
> -        except:
> -            self.cancel('KFAIL')
> -
>      def test_nocross_trixie(self):
>          targets = [
>              'mc:qemuamd64-trixie:isar-image-ci',
> -- 
> 2.34.1
> 

Applied to next.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-02  4:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 11:36 [PATCH] CI: Remove KFAIL for Bookworm Anton Mikanovich
2023-07-18 12:55 ` Henning Schild
2023-08-02  4:07 ` Uladzimir Bely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox